Re: Review Request 19431: Add instance specifier syntax to clientv2
INSTANCES_OPTION
src/main/python/apache/aurora/client/cli/*.py
src/main/python/apache/aurora/client/cli/options.py:INSTANCES_OPTION =
CommandOption('--instances', type=parse_instances, dest='instances',
src/main/python/apache/aurora/client/cli/task.py:INSTANCES_OPTION,
[sun-wukong incubator-aurora (instance-syntax)]$ ./pants
src/test/python/apache/aurora/client/cli:all
Build operating on targets:
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py
=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_help.py .
=== 5 passed in 0.47 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...
== 27 passed in 1.65 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_plugins.py ..
=== 2 passed in 0.51 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items
src/test/python/apache/aurora/client/cli/test_quota.py ...
=== 3 passed in 0.49 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_sla.py .
=== 5 passed in 0.53 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_task_run.py ..
=== 2 passed in 0.53 seconds ===
src.test.python.apache.aurora.client.cli.bridge
. SUCCESS
src.test.python.apache.aurora.client.cli.help
. SUCCESS
src.test.python.apache.aurora.client.cli.job
. SUCCESS
src.test.python.apache.aurora.client.cli.plugins
. SUCCESS
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19431: Add instance specifier syntax to clientv2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38338 --- src/main/python/apache/aurora/client/cli/jobs.py <https://reviews.apache.org/r/19431/#comment70404> I think that the code is clearer when it's explicit that instances is a required parameter, and that we're deliberately passing "None" as a signal. src/main/python/apache/aurora/client/cli/options.py <https://reviews.apache.org/r/19431/#comment70406> "all" was never revealed to users, and we've decided to get rid of it. It will never show up in a user-visible way; mentioning it here will just be confusing. - Mark Chu-Carroll On March 22, 2014, 10:14 a.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19431/ > --- > > (Updated March 22, 2014, 10:14 a.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Bugs: aurora-268 > https://issues.apache.org/jira/browse/aurora-268 > > > Repository: aurora > > > Description > --- > > Add instance specifier syntax to commands that can specify instances for > clientv2. > > Also, while I was at it, I added the kill/killall distinction to clientv2. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe > src/main/python/apache/aurora/client/cli/jobs.py > 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4 > src/main/python/apache/aurora/client/cli/options.py > 1f33ea293969326c4e8cbd39e54b173f659e61bf > src/main/python/apache/aurora/client/cli/task.py > 8d4d38efbd126911f46bc3f8944e81bc9d149e32 > src/main/python/apache/aurora/client/config.py > 1fe5db429007850911f19517565d49b0518e8196 > src/test/python/apache/aurora/client/cli/test_kill.py > 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa > src/test/python/apache/aurora/client/cli/test_restart.py > 7547bd79f059c9d535db926d882abc0b46f9d046 > src/test/python/apache/aurora/client/cli/util.py > db65eee3aeba651f3dedc76233f589a7b22020e8 > > Diff: https://reviews.apache.org/r/19431/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (instance-syntax)]$ !./p > ./pants src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 passed in 0.02 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > === 5 passed in 0.48 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 27 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py . > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ... > src/test/python/apache/aurora/client/cli/test_update.py ... > > == 27 passed in 1.63 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py .. > > === 2 passed in 0.49 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 3 items > > src/test/python/apache/aurora/client/cli/test_quota.py ... > > === 3 passed in 0.50 seconds > ===
Re: Review Request 19466: Add batching to the kill and killall commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38379 --- ping? - Mark Chu-Carroll On March 21, 2014, 2:58 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19466/ > --- > > (Updated March 21, 2014, 2:58 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Brian Wickman. > > > Bugs: aurora-283 > https://issues.apache.org/jira/browse/aurora-283 > > > Repository: aurora > > > Description > --- > > Add batching to the kill and killall commands. > > (Note that this is currently a diff relative to > https://reviews.apache.org/r/19431/) > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe > src/main/python/apache/aurora/client/cli/jobs.py > 2e62519a0531b2c910bc2c0227fd835baee644f1 > src/main/python/apache/aurora/client/cli/options.py > 0e0bd45f9506e5dc729a24cd68b04b49650605b6 > src/main/python/apache/aurora/client/cli/task.py > 8d4d38efbd126911f46bc3f8944e81bc9d149e32 > src/main/python/apache/aurora/client/config.py > 1fe5db429007850911f19517565d49b0518e8196 > src/test/python/apache/aurora/client/cli/test_kill.py > 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa > src/test/python/apache/aurora/client/cli/test_restart.py > aa23d5bfe81361243d82aadf9dc574608e28d953 > src/test/python/apache/aurora/client/cli/test_update.py > 51858b9e4ca02c2ae2151275fff9936460936bb4 > src/test/python/apache/aurora/client/cli/util.py > db65eee3aeba651f3dedc76233f589a7b22020e8 > > Diff: https://reviews.apache.org/r/19466/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (batchsize)]$ ./pants > src/test/python/apache/aurora/client:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/test_binding_helper.py .. > > === 2 passed in 0.37 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/test_config.py .. > > === 6 passed in 0.47 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_disambiguator.py .. > > === 6 passed in 0.43 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/api/test_job_monitor.py . > > === 1 passed in 0.40 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > === 6 passed in 0.35 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 47 items / 1 skipped > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > ... > > = 47 passed, 1 skipped in 3.57 seconds > = > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 20 items > > src/test/python/apache/aurora/client/api/test_instance_watcher.py > src/test/python/apache/aurora/client/api/test_health_check.py > > == 20 passed in 0.25 seconds > === >
Re: Review Request 19396: Implement client command logging with a unique token.
> On March 21, 2014, 5:06 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 283 > > <https://reviews.apache.org/r/19396/diff/2/?file=531742#file531742line283> > > > > No, it shouldn't. It's a call to the global function declared towards > > the top of the file. > > > > My intension is that in most client logging, they'll use > > context.print_log, but if someone like the API code, which doesn't have > > access to a context object, still wants to log something, they'll use that > > global - and in that case, the clarity that they're using an aurora client > > logging function rather than normal system logging is worth the extra > > characters. ping? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38202 --- On March 21, 2014, 3:06 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19396/ > --- > > (Updated March 21, 2014, 3:06 p.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Bugs: aurora-276 > https://issues.apache.org/jira/browse/aurora-276 > > > Repository: aurora > > > Description > --- > > Adding a centralized logger interface for clientv2. > > For the aurora analytics work, we need some hooks for logging. We'd like all > client logging to go through a common interface, and for client logs that > might be sent to the centralized logging service to be tagged with > identifiers and userids. > > This change implements a simple minimal logging function that's used by > clientv2 logging calls, and which attaches a universally unique client > identifier to each log message. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/__init__.py > 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 > src/main/python/apache/aurora/client/cli/context.py > dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe > src/main/python/apache/aurora/client/cli/jobs.py > 2e62519a0531b2c910bc2c0227fd835baee644f1 > src/test/python/apache/aurora/client/cli/BUILD > a48284c8cffa64b56760f8e0c587506caf1289a6 > src/test/python/apache/aurora/client/cli/test_logging.py PRE-CREATION > > Diff: https://reviews.apache.org/r/19396/diff/ > > > Testing > --- > > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/test_binding_helper.py .. > > === 2 passed in 0.37 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/test_config.py .. > > === 6 passed in 0.46 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_disambiguator.py .. > > === 6 passed in 0.45 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/api/test_job_monitor.py . > > === 1 passed in 0.39 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > === 6 passed in 0.36 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 47 items / 1 skipped > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > ... > > = 47 p
Re: Review Request 19466: Add batching to the kill and killall commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38387 --- src/main/python/apache/aurora/client/cli/jobs.py <https://reviews.apache.org/r/19466/#comment70485> I did. I screwed up again, uploaded the change to the wrong review. Stupid. I get completely screwed up when I try to juggle too many open reviews at once. Sorry. - Mark Chu-Carroll On March 21, 2014, 2:58 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19466/ > --- > > (Updated March 21, 2014, 2:58 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Brian Wickman. > > > Bugs: aurora-283 > https://issues.apache.org/jira/browse/aurora-283 > > > Repository: aurora > > > Description > --- > > Add batching to the kill and killall commands. > > (Note that this is currently a diff relative to > https://reviews.apache.org/r/19431/) > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe > src/main/python/apache/aurora/client/cli/jobs.py > 2e62519a0531b2c910bc2c0227fd835baee644f1 > src/main/python/apache/aurora/client/cli/options.py > 0e0bd45f9506e5dc729a24cd68b04b49650605b6 > src/main/python/apache/aurora/client/cli/task.py > 8d4d38efbd126911f46bc3f8944e81bc9d149e32 > src/main/python/apache/aurora/client/config.py > 1fe5db429007850911f19517565d49b0518e8196 > src/test/python/apache/aurora/client/cli/test_kill.py > 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa > src/test/python/apache/aurora/client/cli/test_restart.py > aa23d5bfe81361243d82aadf9dc574608e28d953 > src/test/python/apache/aurora/client/cli/test_update.py > 51858b9e4ca02c2ae2151275fff9936460936bb4 > src/test/python/apache/aurora/client/cli/util.py > db65eee3aeba651f3dedc76233f589a7b22020e8 > > Diff: https://reviews.apache.org/r/19466/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (batchsize)]$ ./pants > src/test/python/apache/aurora/client:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/test_binding_helper.py .. > > === 2 passed in 0.37 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/test_config.py .. > > === 6 passed in 0.47 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_disambiguator.py .. > > === 6 passed in 0.43 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/api/test_job_monitor.py . > > === 1 passed in 0.40 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > === 6 passed in 0.35 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 47 items / 1 skipped > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > ... > > = 47 passed, 1 skipped in 3.57 seconds > = > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 20 items > > src/
Re: Review Request 19466: Add batching to the kill and killall commands.
=== 4 passed in 0.40 seconds === src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19431: Add instance specifier syntax to clientv2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38480 --- Ping? - Mark Chu-Carroll On March 24, 2014, 2:58 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19431/ > --- > > (Updated March 24, 2014, 2:58 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Bugs: aurora-268 > https://issues.apache.org/jira/browse/aurora-268 > > > Repository: aurora > > > Description > --- > > Add instance specifier syntax to commands that can specify instances for > clientv2. > > Also, while I was at it, I added the kill/killall distinction to clientv2. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe > src/main/python/apache/aurora/client/cli/jobs.py > 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4 > src/main/python/apache/aurora/client/cli/options.py > 1f33ea293969326c4e8cbd39e54b173f659e61bf > src/main/python/apache/aurora/client/cli/task.py > 8d4d38efbd126911f46bc3f8944e81bc9d149e32 > src/main/python/apache/aurora/client/config.py > 1fe5db429007850911f19517565d49b0518e8196 > src/test/python/apache/aurora/client/cli/test_kill.py > 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa > src/test/python/apache/aurora/client/cli/test_restart.py > 7547bd79f059c9d535db926d882abc0b46f9d046 > src/test/python/apache/aurora/client/cli/util.py > db65eee3aeba651f3dedc76233f589a7b22020e8 > > Diff: https://reviews.apache.org/r/19431/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (instance-syntax)]$ !./p > ./pants src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 passed in 0.02 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > === 5 passed in 0.48 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 27 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py . > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ... > src/test/python/apache/aurora/client/cli/test_update.py ... > > == 27 passed in 1.63 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py .. > > === 2 passed in 0.49 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 3 items > > src/test/python/apache/aurora/client/cli/test_quota.py ... > > === 3 passed in 0.50 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_sla.py . > > === 5 passed in 0.53 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aur
Re: Review Request 19396: Implement client command logging with a unique token.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38481 --- kevin, ping? - Mark Chu-Carroll On March 21, 2014, 3:06 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19396/ > --- > > (Updated March 21, 2014, 3:06 p.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Bugs: aurora-276 > https://issues.apache.org/jira/browse/aurora-276 > > > Repository: aurora > > > Description > --- > > Adding a centralized logger interface for clientv2. > > For the aurora analytics work, we need some hooks for logging. We'd like all > client logging to go through a common interface, and for client logs that > might be sent to the centralized logging service to be tagged with > identifiers and userids. > > This change implements a simple minimal logging function that's used by > clientv2 logging calls, and which attaches a universally unique client > identifier to each log message. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/__init__.py > 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 > src/main/python/apache/aurora/client/cli/context.py > dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe > src/main/python/apache/aurora/client/cli/jobs.py > 2e62519a0531b2c910bc2c0227fd835baee644f1 > src/test/python/apache/aurora/client/cli/BUILD > a48284c8cffa64b56760f8e0c587506caf1289a6 > src/test/python/apache/aurora/client/cli/test_logging.py PRE-CREATION > > Diff: https://reviews.apache.org/r/19396/diff/ > > > Testing > --- > > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/test_binding_helper.py .. > > === 2 passed in 0.37 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/test_config.py .. > > === 6 passed in 0.46 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_disambiguator.py .. > > === 6 passed in 0.45 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/api/test_job_monitor.py . > > === 1 passed in 0.39 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > === 6 passed in 0.36 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 47 items / 1 skipped > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > ... > > = 47 passed, 1 skipped in 3.59 seconds > = > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 20 items > > src/test/python/apache/aurora/client/api/test_instance_watcher.py > src/test/python/apache/aurora/client/api/test_health_check.py > > == 20 passed in 0.25 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 27 items > > src/test/python/apache/aurora/client/api/test_updater.py > ... >
Re: Review Request 19466: Add batching to the kill and killall commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38484 --- Brian, ping? - Mark Chu-Carroll On March 24, 2014, 7:21 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19466/ > --- > > (Updated March 24, 2014, 7:21 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Brian Wickman. > > > Bugs: aurora-283 > https://issues.apache.org/jira/browse/aurora-283 > > > Repository: aurora > > > Description > --- > > Add batching to the kill and killall commands. > > (Note that this is currently a diff relative to > https://reviews.apache.org/r/19431/) > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe > src/main/python/apache/aurora/client/cli/jobs.py > 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4 > src/main/python/apache/aurora/client/cli/options.py > 1f33ea293969326c4e8cbd39e54b173f659e61bf > src/main/python/apache/aurora/client/cli/task.py > 8d4d38efbd126911f46bc3f8944e81bc9d149e32 > src/main/python/apache/aurora/client/config.py > 1fe5db429007850911f19517565d49b0518e8196 > src/test/python/apache/aurora/client/cli/test_kill.py > 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa > src/test/python/apache/aurora/client/cli/test_restart.py > 7547bd79f059c9d535db926d882abc0b46f9d046 > src/test/python/apache/aurora/client/cli/util.py > db65eee3aeba651f3dedc76233f589a7b22020e8 > > Diff: https://reviews.apache.org/r/19466/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (batchsize)]$ ./pants > src/test/python/apache/aurora/client:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/test_binding_helper.py .. > > === 2 passed in 0.37 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/test_config.py .. > > === 6 passed in 0.47 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_disambiguator.py .. > > === 6 passed in 0.43 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/api/test_job_monitor.py . > > === 1 passed in 0.40 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > === 6 passed in 0.35 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 47 items / 1 skipped > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > ... > > = 47 passed, 1 skipped in 3.57 seconds > = > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 20 items > > src/test/python/apache/aurora/client/api/test_instance_watcher.py > src/test/python/apache/aurora/client/api/test_health_check.py > > == 20 passed in 0.25 seconds > === > = test session starts > == > platform darwin -- Python 2.
Re: Review Request 19466: Add batching to the kill and killall commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38489 --- Brian, ping? - Mark Chu-Carroll On March 24, 2014, 7:21 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19466/ > --- > > (Updated March 24, 2014, 7:21 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Brian Wickman. > > > Bugs: aurora-283 > https://issues.apache.org/jira/browse/aurora-283 > > > Repository: aurora > > > Description > --- > > Add batching to the kill and killall commands. > > (Note that this is currently a diff relative to > https://reviews.apache.org/r/19431/) > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe > src/main/python/apache/aurora/client/cli/jobs.py > 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4 > src/main/python/apache/aurora/client/cli/options.py > 1f33ea293969326c4e8cbd39e54b173f659e61bf > src/main/python/apache/aurora/client/cli/task.py > 8d4d38efbd126911f46bc3f8944e81bc9d149e32 > src/main/python/apache/aurora/client/config.py > 1fe5db429007850911f19517565d49b0518e8196 > src/test/python/apache/aurora/client/cli/test_kill.py > 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa > src/test/python/apache/aurora/client/cli/test_restart.py > 7547bd79f059c9d535db926d882abc0b46f9d046 > src/test/python/apache/aurora/client/cli/util.py > db65eee3aeba651f3dedc76233f589a7b22020e8 > > Diff: https://reviews.apache.org/r/19466/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (batchsize)]$ ./pants > src/test/python/apache/aurora/client:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/test_binding_helper.py .. > > === 2 passed in 0.37 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/test_config.py .. > > === 6 passed in 0.47 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_disambiguator.py .. > > === 6 passed in 0.43 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/api/test_job_monitor.py . > > === 1 passed in 0.40 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > === 6 passed in 0.35 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 47 items / 1 skipped > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > ... > > = 47 passed, 1 skipped in 3.57 seconds > = > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 20 items > > src/test/python/apache/aurora/client/api/test_instance_watcher.py > src/test/python/apache/aurora/client/api/test_health_check.py > > == 20 passed in 0.25 seconds > === > = test session starts > == > platform darwin -- Python 2.
Re: Review Request 19627: Updates documentation to specify template, adds headers to pages that needed them, cleans up whitespace, and makes markdown for headers consistent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19627/#review38515 --- docs/README.md <https://reviews.apache.org/r/19627/#comment70756> Per jfarrell, These headers aren't needed: you can just put the following into config.rb: page "/documentation/*"; :layout => "documentation" - Mark Chu-Carroll On March 25, 2014, 3:57 p.m., Dave Lester wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19627/ > --- > > (Updated March 25, 2014, 3:57 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > Updates documentation to specify template, adds headers to pages that needed > them, cleans up whitespace, and makes markdown for headers consistent. > > > Diffs > - > > docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b > docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec > docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db > docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 > docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 > docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b > docs/developing-aurora-scheduler.md > 95bf47278b4cf040ed902e43a151fe9fae19bfc5 > docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 > docs/resourceisolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b > docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887 > docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e > docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53 > > Diff: https://reviews.apache.org/r/19627/diff/ > > > Testing > --- > > > Thanks, > > Dave Lester > >
Re: Review Request 19396: Implement client command logging with a unique token.
thon 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.42 seconds === Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19627: Updates documentation to specify template, adds headers to pages that needed them, cleans up whitespace, and makes markdown for headers consistent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19627/#review38518 --- docs/README.md <https://reviews.apache.org/r/19627/#comment70758> What about this? It doesn't look like you added the change to config.rb?L - Mark Chu-Carroll On March 25, 2014, 4:17 p.m., Dave Lester wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19627/ > --- > > (Updated March 25, 2014, 4:17 p.m.) > > > Review request for Aurora and Mark Chu-Carroll. > > > Repository: aurora > > > Description > --- > > Updates documentation to specify template, adds headers to pages that needed > them, cleans up whitespace, and makes markdown for headers consistent. > > > Diffs > - > > docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b > docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec > docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db > docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 > docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 > docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b > docs/developing-aurora-scheduler.md > 95bf47278b4cf040ed902e43a151fe9fae19bfc5 > docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 > docs/resourceisolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b > docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887 > docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e > docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53 > > Diff: https://reviews.apache.org/r/19627/diff/ > > > Testing > --- > > > Thanks, > > Dave Lester > >
Re: Review Request 19431: Add instance specifier syntax to clientv2
Not uncaught: it gets handled exactly the way that all invalid parameters
get handled - the exception gets thrown in the parser, it bubbles up, and
gets caught by the framework and turned into an error:
[sun-wukong incubator-aurora (instance-syntax)]$ ./dist/client.pex job kill
west/mchucarroll/test/foo/asonteuh
usage: client.pex job kill [-h] [--open-browser] [--config CONFIG]
CLUSTER/ROLE/ENV/NAME/INSTANCES
client.pex job kill: error: argument CLUSTER/ROLE/ENV/NAME/INSTANCES:
invalid instance_specifier value: 'west/mchucarroll/test/foo/asonteuh'
On Tue, Mar 25, 2014 at 6:22 PM, Brian Wickman wrote:
>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19431/
>
> On March 24th, 2014, 6:57 p.m. UTC, *Mark Chu-Carroll* wrote:
>
>
> src/main/python/apache/aurora/client/cli/options.py<https://reviews.apache.org/r/19431/diff/4/?file=532893#file532893line121>
> (Diff
> revision 4)
>
> def parse_qualified_role(rolestr):
>
> 111
>
> for part in instances.split(','):
>
> 121
>
> for part in instances.split(','):
>
> 112
>
> x = part.split('-')
>
> 122
>
> x = part.split('-')
>
> 113
>
> result.update(range(int(x[0]), int(x[-1]) + 1))
>
> 123
>
> result.update(range(int(x[0]), int(x[-1]) + 1))
>
> 114
>
> return sorted(result)
>
> 124
>
> return sorted(result)
>
> "all" was never revealed to users, and we've decided to get rid of it. It
> will never show up in a user-visible way; mentioning it here will just be
> confusing.
>
> I understand, but there is no input sanitation preventing you from doing
> "west/foo/prod/bar/morfgorf" -- it will raise an uncaught ValueError here.
>
>
> - Brian
>
> On March 24th, 2014, 6:58 p.m. UTC, Mark Chu-Carroll wrote:
> Review request for Aurora, Bill Farner and Brian Wickman.
> By Mark Chu-Carroll.
>
> *Updated March 24, 2014, 6:58 p.m.*
> *Bugs: * aurora-268 <https://issues.apache.org/jira/browse/aurora-268>
> *Repository: * aurora
> Description
>
> Add instance specifier syntax to commands that can specify instances for
> clientv2.
>
> Also, while I was at it, I added the kill/killall distinction to clientv2.
>
> Testing
>
> [sun-wukong incubator-aurora (instance-syntax)]$ !./p
> ./pants src/test/python/apache/aurora/client/cli:all
> Build operating on targets:
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py
>
> === 4 passed in 0.02 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .
>
> === 5 passed in 0.48 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> == 27 passed in 1.63 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> === 2 passed in 0.49 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> === 3 passed in 0.50 seconds
> ===
> = test session starts
> ===
Re: Review Request 19466: Add batching to the kill and killall commands.
=== src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19431: Add instance specifier syntax to clientv2
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (instance-syntax)]$
[sun-wukong incubator-aurora (instance-syntax)]$ grep INSTANCES_OPTION
src/main/python/apache/aurora/client/cli/*.py
src/main/python/apache/aurora/client/cli/options.py:INSTANCES_OPTION =
CommandOption('--instances', type=parse_instances, dest='instances',
src/main/python/apache/aurora/client/cli/task.py:INSTANCES_OPTION,
[sun-wukong incubator-aurora (instance-syntax)]$ ./pants
src/test/python/apache/aurora/client/cli:all
Build operating on targets:
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py
=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_help.py .
=== 5 passed in 0.47 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...
== 27 passed in 1.65 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_plugins.py ..
=== 2 passed in 0.51 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items
src/test/python/apache/aurora/client/cli/test_quota.py ...
=== 3 passed in 0.49 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_sla.py .
=== 5 passed in 0.53 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_task_run.py ..
=== 2 passed in 0.53 seconds ===
src.test.python.apache.aurora.client.cli.bridge
. SUCCESS
src.test.python.apache.aurora.client.cli.help
. SUCCESS
src.test.python.apache.aurora.client.cli.job
. SUCCESS
src.test.python.apache.aurora.client.cli.plugins
. SUCCESS
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19431: Add instance specifier syntax to clientv2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38653 --- src/main/python/apache/aurora/client/cli/jobs.py <https://reviews.apache.org/r/19431/#comment70914> Sorry, I don't follow what you're suggesting here. Do you mean that you want each batch kill to take a minimum amount of time, and so pad with sleep if the batches are fast? (In any case, that's not really part of this review; that's just change tangling that I couldn't quickly unwind. If you want that changed, I'd like to make it a separate change.) - Mark Chu-Carroll On March 26, 2014, 2:08 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19431/ > --- > > (Updated March 26, 2014, 2:08 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Bugs: aurora-268 > https://issues.apache.org/jira/browse/aurora-268 > > > Repository: aurora > > > Description > --- > > Add instance specifier syntax to commands that can specify instances for > clientv2. > > Also, while I was at it, I added the kill/killall distinction to clientv2. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > 83f7b6a4ae1e6896278752cb481901c6e381ba0e > src/main/python/apache/aurora/client/cli/jobs.py > e354ee153da3e03ce0f134ddcef65ebd2075d8b5 > src/main/python/apache/aurora/client/cli/options.py > 040c5c213798e644ba59c4ce3f9c4fe8868af2d5 > src/main/python/apache/aurora/client/cli/task.py > e4ee77ede119fc1e3bd196293965073405bb48b3 > src/test/python/apache/aurora/client/cli/test_kill.py > 208816060789a49f6c6dc5d2081bab784a8c811d > src/test/python/apache/aurora/client/cli/test_restart.py > 6bcdd6aab7fda259b135793378b6db731fe02601 > src/test/python/apache/aurora/client/cli/util.py > bc2a3e9b88947bb9ab06d945c0f154f3b19a9ff9 > > Diff: https://reviews.apache.org/r/19431/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (instance-syntax)]$ !./p > ./pants src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 passed in 0.02 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > === 5 passed in 0.48 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 27 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py . > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ... > src/test/python/apache/aurora/client/cli/test_update.py ... > > == 27 passed in 1.63 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py .. > > === 2 passed in 0.49 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 3 items > > src/test/python/apache/aurora/client/cli/test_quota.py ... > > === 3 passed in 0.50 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 item
Re: Review Request 19431: Add instance specifier syntax to clientv2
Bill: It's been 24 hours, and I'm still waiting on a clarification request. Please, can you take a minute, and answer, so that I can get this review done? -Mark On Wed, Mar 26, 2014 at 3:28 PM, Mark Chu-Carroll < mchucarr...@twopensource.com> wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19431/ > > src/main/python/apache/aurora/client/cli/jobs.py<https://reviews.apache.org/r/19431/diff/6/?file=537713#file537713line301> > (Diff > revision 6) > > 301 > > while len(instances_to_kill) > 0: > > Sorry, I don't follow what you're suggesting here. Do you mean that you > want each batch kill to take a minimum amount of time, and so pad with sleep > if the batches are fast? > > (In any case, that's not really part of this review; that's just change > tangling that I couldn't quickly unwind. If you want that changed, I'd like > to make it a separate change.) > > > - Mark Chu-Carroll > > On March 26th, 2014, 2:08 p.m. EDT, Mark Chu-Carroll wrote: > Review request for Aurora, Bill Farner and Brian Wickman. > By Mark Chu-Carroll. > > *Updated March 26, 2014, 2:08 p.m.* > *Bugs: * aurora-268 <https://issues.apache.org/jira/browse/aurora-268> > *Repository: * aurora > Description > > Add instance specifier syntax to commands that can specify instances for > clientv2. > > Also, while I was at it, I added the kill/killall distinction to clientv2. > > Testing > > [sun-wukong incubator-aurora (instance-syntax)]$ !./p > ./pants src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 passed in 0.02 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > === 5 passed in 0.48 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 27 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py . > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ... > src/test/python/apache/aurora/client/cli/test_update.py ... > > == 27 passed in 1.63 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py .. > > === 2 passed in 0.49 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 3 items > > src/test/python/apache/aurora/client/cli/test_quota.py ... > > === 3 passed in 0.50 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_sla.py . > > === 5 passed in 0.53 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_task_run.py .. > > === 2 passed in 0.50 seconds > === > src.test.python.apache.aurora.client.cli.bridge > . SUCCESS > src.test.python.apache.aurora.client.cli.help > . SUCCESS > src.test.python.apache.aurora.client.cli
Review Request 19788: Add a clientv2 version of the e2e test.
t/test_dev/build-support/pex.venv/bin Installing easy_install-2.7 script to /home/vagrant/test_dev/build-support/pex.venv/bin Successfully installed twitter.common.python setuptools Cleaning up... Built pants-0.0.14-dev2.pex Build operating on targets: OrderedSet([PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2)]) Building PythonBinary PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2): Wrote /home/vagrant/test_dev/dist/aurorav2.pex + run_dev 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' + vagrant ssh devtools -c 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' Build operating on targets: OrderedSet([PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example)]) Building PythonBinary PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example): Wrote /home/vagrant/test_dev/dist/flask_example.pex + '[' '!' -d deploy_test ']' + mkdir deploy_test + run_dev 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + run_dev 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + test_flask_example example vagrant test flask_example deploy_test 192.168.33.6 /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + local _cluster=example _role=vagrant _env=test _job=flask_example _testdir=deploy_test _sched_ip=192.168.33.6 + local _base_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora _updated_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + jobkey=example/vagrant/test/flask_example + echo '== Creating job' == Creating job + run_sched '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + base_url=http://192.168.33.6:8081 ++ _curl -s http://192.168.33.6:8081/scheduler ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler + schedlen=' 50' + test 50 -ge 40 ++ _curl -s http://192.168.33.6:8081/scheduler/vagrant ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler/vagrant + rolelen=' 195' + test 195 -ge 50 ++ _curl http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ curl --silent --fail --retry 4 --retry-delay 10 http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ wc -l + joblen=' 526' + test 526 -ge 100 + echo '== Updating test job' == Updating test job + run_sched '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' Warning: this update is a large change. Press ^C within 5 seconds to abort ++ wc -l ++ run_sched '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' ++ vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' + runlen=' 2' + test 2 -eq 2 + run_sched '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' Allocated: CPU: 0.0 RAM: 0.00 GB Disk: 0.000000 GB Production resources consumed: CPU: 0.0 RAM: 0.00 GB Disk: 0.00 GB Non-production resources consumed: CPU: 2.0 RAM: 0.125000 GB Disk: 0.187500 GB + run_sched '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + RETCODE=0 + collect_result + [[ 0 = 0 ]] + echo '***' *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 Thanks, Mark Chu-Carroll
Re: Review Request 19788: Add a clientv2 version of the e2e test.
> On March 28, 2014, 1:46 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 43 > > <https://reviews.apache.org/r/19788/diff/1/?file=539838#file539838line43> > > > > Why not pushd once instead? Don't follow the question. What would a pushd accomplish here? > On March 28, 2014, 1:46 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 109 > > <https://reviews.apache.org/r/19788/diff/1/?file=539838#file539838line109> > > > > How about adding a check here to see that all instances are up (e.g. > > ping)? Otherwise, test hangs will be a common problem. Had that experience > > with ZK down before. In my experience, "vagrant up" will fail if the instances don't come up; that will trigger a test failure, won't it? (The problem with pinging is that in our setup, the machine doesn't have a DNS entry on the machine running the test. So you can either ping an IP address - in which case, changing the vagrant file will make this test fail; or you can ping from one of the virtual machines - but then, you've got the same potential hang problem as not pinging at all.) - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19788/#review38919 --- On March 28, 2014, 1:28 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19788/ > --- > > (Updated March 28, 2014, 1:28 p.m.) > > > Review request for Aurora, Joe Smith and Kevin Sweeney. > > > Bugs: aurora-266 > https://issues.apache.org/jira/browse/aurora-266 > > > Repository: aurora > > > Description > --- > > Add a clientv2 version of the e2e test. > > > Diffs > - > > src/main/python/apache/aurora/client/BUILD > 118c4a080b2aac88f1fb6365787b3bb55a665bea > src/main/python/apache/aurora/client/cli/BUILD > 02e061c7d485cc7f24c48c0db1b5778819961f47 > src/test/python/apache/aurora/client/cli/BUILD > d93a2df0f146e2771de2ce6223438a671d0e92a2 > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/19788/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (v2_e2e)]$ sh > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > + . src/test/sh/org/apache/aurora/e2e/test_common.sh > ++ exec > ++ _aurora_built=false > + RETCODE=1 > + export CLIENT_NAME=aurorav2.pex > + CLIENT_NAME=aurorav2.pex > + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask > + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask > + TEST_DIR=deploy_test > + TEST_CLUSTER=example > + TEST_ROLE=vagrant > + TEST_ENV=test > + TEST_JOB=flask_example > + TEST_SCHEDULER_IP=192.168.33.6 > + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR > $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora > $EXAMPLE_DIR/flask_example_updated.aurora) > + trap collect_result EXIT > + vagrant up > Bringing machine 'devtools' up with 'virtualbox' provider... > Bringing machine 'zookeeper' up with 'virtualbox' provider... > Bringing machine 'mesos-master' up with 'virtualbox' provider... > Bringing machine 'mesos-slave1' up with 'virtualbox' provider... > Bringing machine 'mesos-slave2' up with 'virtualbox' provider... > Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... > [devtools] VirtualBox VM is already running. > [zookeeper] VirtualBox VM is already running. > [mesos-master] VirtualBox VM is already running. > [mesos-slave1] VirtualBox VM is already running. > [mesos-slave2] VirtualBox VM is already running. > [aurora-scheduler] VirtualBox VM is already running. > + rm -rf deploy_test > + devtools_setup deploy_test > + local _testdir=deploy_test > ++ git branch > ++ grep '*' > ++ cut -c 3- > + branch=v2_e2e > + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi' > + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant > ~/test_dev; fi' > + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx' > + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx' > HEAD is now at 29ae4e5 end-to-end for clientv2 &
Re: Review Request 19788: Add a clientv2 version of the e2e test.
> On March 28, 2014, 1:46 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 43 > > <https://reviews.apache.org/r/19788/diff/1/?file=539838#file539838line43> > > > > Why not pushd once instead? > > Mark Chu-Carroll wrote: > Don't follow the question. What would a pushd accomplish here? > > Maxim Khutornenko wrote: > Sorry, what I meant here ssh, pushd and do everything in a single session. We get better errors this way. Right now, when the test setup fails, you can easily see exactly which step was the problem. When you bundle it into one session, it becomes harder. The time-cost of doing it this way is under 2 seconds, which is pretty much noise in the runtime of this test. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19788/#review38919 ----------- On March 28, 2014, 1:28 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19788/ > --- > > (Updated March 28, 2014, 1:28 p.m.) > > > Review request for Aurora, Joe Smith and Kevin Sweeney. > > > Bugs: aurora-266 > https://issues.apache.org/jira/browse/aurora-266 > > > Repository: aurora > > > Description > --- > > Add a clientv2 version of the e2e test. > > > Diffs > - > > src/main/python/apache/aurora/client/BUILD > 118c4a080b2aac88f1fb6365787b3bb55a665bea > src/main/python/apache/aurora/client/cli/BUILD > 02e061c7d485cc7f24c48c0db1b5778819961f47 > src/test/python/apache/aurora/client/cli/BUILD > d93a2df0f146e2771de2ce6223438a671d0e92a2 > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/19788/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (v2_e2e)]$ sh > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > + . src/test/sh/org/apache/aurora/e2e/test_common.sh > ++ exec > ++ _aurora_built=false > + RETCODE=1 > + export CLIENT_NAME=aurorav2.pex > + CLIENT_NAME=aurorav2.pex > + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask > + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask > + TEST_DIR=deploy_test > + TEST_CLUSTER=example > + TEST_ROLE=vagrant > + TEST_ENV=test > + TEST_JOB=flask_example > + TEST_SCHEDULER_IP=192.168.33.6 > + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR > $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora > $EXAMPLE_DIR/flask_example_updated.aurora) > + trap collect_result EXIT > + vagrant up > Bringing machine 'devtools' up with 'virtualbox' provider... > Bringing machine 'zookeeper' up with 'virtualbox' provider... > Bringing machine 'mesos-master' up with 'virtualbox' provider... > Bringing machine 'mesos-slave1' up with 'virtualbox' provider... > Bringing machine 'mesos-slave2' up with 'virtualbox' provider... > Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... > [devtools] VirtualBox VM is already running. > [zookeeper] VirtualBox VM is already running. > [mesos-master] VirtualBox VM is already running. > [mesos-slave1] VirtualBox VM is already running. > [mesos-slave2] VirtualBox VM is already running. > [aurora-scheduler] VirtualBox VM is already running. > + rm -rf deploy_test > + devtools_setup deploy_test > + local _testdir=deploy_test > ++ git branch > ++ grep '*' > ++ cut -c 3- > + branch=v2_e2e > + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi' > + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant > ~/test_dev; fi' > + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx' > + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx' > HEAD is now at 29ae4e5 end-to-end for clientv2 > Removing .BUILD.CPython-2.7.3.pyc > Removing .pants.d/ > Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc > Removing build-support/pants-0.0.14-dev2.pex > Removing build-support/pex.venv/ > Removing build-support/virtualenv-1.10.1.tar.gz > Removing build-support/virtualenv-1.10.1/ > Removing dist/ > Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc > Removi
Re: Review Request 19788: Add a clientv2 version of the e2e test.
allation: setuptools 0.9.8 Uninstalling setuptools: Successfully uninstalled setuptools Running setup.py install for setuptools Installing easy_install script to /home/vagrant/test_dev/build-support/pex.venv/bin Installing easy_install-2.7 script to /home/vagrant/test_dev/build-support/pex.venv/bin Successfully installed twitter.common.python setuptools Cleaning up... Built pants-0.0.14-dev2.pex Build operating on targets: OrderedSet([PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2)]) Building PythonBinary PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2): Wrote /home/vagrant/test_dev/dist/aurorav2.pex + run_dev 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' + vagrant ssh devtools -c 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' Build operating on targets: OrderedSet([PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example)]) Building PythonBinary PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example): Wrote /home/vagrant/test_dev/dist/flask_example.pex + '[' '!' -d deploy_test ']' + mkdir deploy_test + run_dev 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + run_dev 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + test_flask_example example vagrant test flask_example deploy_test 192.168.33.6 /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + local _cluster=example _role=vagrant _env=test _job=flask_example _testdir=deploy_test _sched_ip=192.168.33.6 + local _base_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora _updated_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + jobkey=example/vagrant/test/flask_example + echo '== Creating job' == Creating job + run_sched '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + base_url=http://192.168.33.6:8081 ++ _curl -s http://192.168.33.6:8081/scheduler ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler + schedlen=' 50' + test 50 -ge 40 ++ _curl -s http://192.168.33.6:8081/scheduler/vagrant ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler/vagrant + rolelen=' 195' + test 195 -ge 50 ++ _curl http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ curl --silent --fail --retry 4 --retry-delay 10 http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ wc -l + joblen=' 526' + test 526 -ge 100 + echo '== Updating test job' == Updating test job + run_sched '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' Warning: this update is a large change. Press ^C within 5 seconds to abort ++ wc -l ++ run_sched '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' ++ vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' + runlen=' 2' + test 2 -eq 2 + run_sched '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' Allocated: CPU: 0.0 RAM: 0.00 GB Disk: 0.00 GB Production resources consumed: CPU: 0.0 RAM: 0.00 GB Disk: 0.00 GB Non-production resources consumed: CPU: 2.0 RAM: 0.125000 GB Disk: 0.187500 GB + run_sched '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + RETCODE=0 + collect_result + [[ 0 = 0 ]] + echo '***' *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 Thanks, Mark Chu-Carroll
Review Request 20009: Add the "open" command to clientv2, and fix an error case in v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20009/ --- Review request for Aurora, David Robinson and Maxim Khutornenko. Bugs: aurora-307 https://issues.apache.org/jira/browse/aurora-307 Repository: aurora Description --- Add the "open" command to clientv2, and fix an error case in v1. Clientv2 didn't have an "open" command, which it needed. Clientv1 had an open command, but if you used it and you forgot to specify the parameter, it dropped its cookies. Diffs - src/main/python/apache/aurora/client/cli/context.py 83f7b6a4ae1e6896278752cb481901c6e381ba0e src/main/python/apache/aurora/client/cli/jobs.py 798f54deb35afb72cd3b8d3cb972d386e48d6c2e src/main/python/apache/aurora/client/commands/core.py b1abc9e7b1923d2e56f452c6891ddaa959d95b40 src/test/python/apache/aurora/client/cli/BUILD d93a2df0f146e2771de2ce6223438a671d0e92a2 src/test/python/apache/aurora/client/cli/test_open.py PRE-CREATION Diff: https://reviews.apache.org/r/20009/diff/ Testing --- Ran unit tests, added new tests of the open command. Thanks, Mark Chu-Carroll
Review Request 20010: Fix two clientv2 command-line bugs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20010/ --- Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-307 https://issues.apache.org/jira/browse/aurora-307 Repository: aurora Description --- Fix two clientv2 command-line bugs. - Clientv2 bridge would crash and dump cookies if you didn't give it any command-line parameters. - Clientv2 help formatting was messed up. Diffs - src/main/python/apache/aurora/client/cli/__init__.py a1063e1af24fd42adafbeebf757bca4de47db1fc src/main/python/apache/aurora/client/cli/bridge.py 37964b65b597abcf7f85b414fa5c6473da9f12ed Diff: https://reviews.apache.org/r/20010/diff/ Testing --- Manual command-line testing. Thanks, Mark Chu-Carroll
Re: Review Request 19788: Add a clientv2 version of the e2e test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19788/#review39685 --- ping? - Mark Chu-Carroll On April 2, 2014, 9:40 a.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19788/ > --- > > (Updated April 2, 2014, 9:40 a.m.) > > > Review request for Aurora, Joe Smith and Kevin Sweeney. > > > Bugs: aurora-266 > https://issues.apache.org/jira/browse/aurora-266 > > > Repository: aurora > > > Description > --- > > Add a clientv2 version of the e2e test. > > > Diffs > - > > src/main/python/apache/aurora/client/BUILD > 118c4a080b2aac88f1fb6365787b3bb55a665bea > src/main/python/apache/aurora/client/cli/BUILD > 02e061c7d485cc7f24c48c0db1b5778819961f47 > src/test/python/apache/aurora/client/cli/BUILD > d93a2df0f146e2771de2ce6223438a671d0e92a2 > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > b3292f4ec25936ff6f576518ac9814c14a9610b4 > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/19788/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (v2_e2e)]$ sh > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > + . src/test/sh/org/apache/aurora/e2e/test_common.sh > ++ exec > ++ _aurora_built=false > + RETCODE=1 > + export CLIENT_NAME=aurorav2.pex > + CLIENT_NAME=aurorav2.pex > + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask > + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask > + TEST_DIR=deploy_test > + TEST_CLUSTER=example > + TEST_ROLE=vagrant > + TEST_ENV=test > + TEST_JOB=flask_example > + TEST_SCHEDULER_IP=192.168.33.6 > + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR > $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora > $EXAMPLE_DIR/flask_example_updated.aurora) > + trap collect_result EXIT > + vagrant up > Bringing machine 'devtools' up with 'virtualbox' provider... > Bringing machine 'zookeeper' up with 'virtualbox' provider... > Bringing machine 'mesos-master' up with 'virtualbox' provider... > Bringing machine 'mesos-slave1' up with 'virtualbox' provider... > Bringing machine 'mesos-slave2' up with 'virtualbox' provider... > Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... > [devtools] VirtualBox VM is already running. > [zookeeper] VirtualBox VM is already running. > [mesos-master] VirtualBox VM is already running. > [mesos-slave1] VirtualBox VM is already running. > [mesos-slave2] VirtualBox VM is already running. > [aurora-scheduler] VirtualBox VM is already running. > + rm -rf deploy_test > + devtools_setup deploy_test > + local _testdir=deploy_test > ++ git branch > ++ grep '*' > ++ cut -c 3- > + branch=v2_e2e > + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi' > + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant > ~/test_dev; fi' > + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx' > + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx' > HEAD is now at 29ae4e5 end-to-end for clientv2 > Removing .BUILD.CPython-2.7.3.pyc > Removing .pants.d/ > Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc > Removing build-support/pants-0.0.14-dev2.pex > Removing build-support/pex.venv/ > Removing build-support/virtualenv-1.10.1.tar.gz > Removing build-support/virtualenv-1.10.1/ > Removing dist/ > Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc > Removing > src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc > Removing src/main/python/apache/thermos/
Review Request 20490: Add a "get version" API method.
= test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py = 12 passed in 0.65 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py == 4 passed in 0.43 seconds == src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (get_version)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20490: Add a "get version" API method.
= test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py = 12 passed in 0.65 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py == 4 passed in 0.43 seconds == src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (get_version)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20490: Add a "get version" API method.
3 passed in 1.14 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py = 12 passed in 0.65 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py == 4 passed in 0.43 seconds == src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (get_version)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20490: Add a "get version" API method.
3 passed in 1.14 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py = 12 passed in 0.65 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py == 4 passed in 0.43 seconds == src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (get_version)]$ Thanks, Mark Chu-Carroll
Review Request 20521: Extend the client configuration plugin architecture.
. SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (plugin_with_cleanup)]$ Thanks, Mark Chu-Carroll
Re: Review Request 19788: Add a clientv2 version of the e2e test.
und existing installation: setuptools 0.9.8 Uninstalling setuptools: Successfully uninstalled setuptools Running setup.py install for setuptools Installing easy_install script to /home/vagrant/test_dev/build-support/pex.venv/bin Installing easy_install-2.7 script to /home/vagrant/test_dev/build-support/pex.venv/bin Successfully installed twitter.common.python setuptools Cleaning up... Built pants-0.0.14-dev2.pex Build operating on targets: OrderedSet([PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2)]) Building PythonBinary PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2): Wrote /home/vagrant/test_dev/dist/aurorav2.pex + run_dev 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' + vagrant ssh devtools -c 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' Build operating on targets: OrderedSet([PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example)]) Building PythonBinary PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example): Wrote /home/vagrant/test_dev/dist/flask_example.pex + '[' '!' -d deploy_test ']' + mkdir deploy_test + run_dev 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + run_dev 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + test_flask_example example vagrant test flask_example deploy_test 192.168.33.6 /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + local _cluster=example _role=vagrant _env=test _job=flask_example _testdir=deploy_test _sched_ip=192.168.33.6 + local _base_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora _updated_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + jobkey=example/vagrant/test/flask_example + echo '== Creating job' == Creating job + run_sched '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + base_url=http://192.168.33.6:8081 ++ _curl -s http://192.168.33.6:8081/scheduler ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler + schedlen=' 50' + test 50 -ge 40 ++ _curl -s http://192.168.33.6:8081/scheduler/vagrant ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler/vagrant + rolelen=' 195' + test 195 -ge 50 ++ _curl http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ curl --silent --fail --retry 4 --retry-delay 10 http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ wc -l + joblen=' 526' + test 526 -ge 100 + echo '== Updating test job' == Updating test job + run_sched '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' Warning: this update is a large change. Press ^C within 5 seconds to abort ++ wc -l ++ run_sched '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' ++ vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' + runlen=' 2' + test 2 -eq 2 + run_sched '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' Allocated: CPU: 0.0 RAM: 0.00 GB Disk: 0.00 GB Production resources consumed: CPU: 0.0 RAM: 0.00 GB Disk: 0.00 GB Non-production resources consumed: CPU: 2.0 RAM: 0.125000 GB Disk: 0.187500 GB + run_sched '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + RETCODE=0 + collect_result + [[ 0 = 0 ]] + echo '***' *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 Thanks, Mark Chu-Carroll
Re: Review Request 20521: Extend the client configuration plugin architecture.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20521/#review40885
---
src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/20521/#comment74131>
Very good suggestion!
src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/20521/#comment74130>
This has nothing to do with hooks: this is how error codes get returned
when a verb implementation throws a Context.CommandError. The exception carries
the exit code.
- Mark Chu-Carroll
On April 21, 2014, 9:33 a.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20521/
> ---
>
> (Updated April 21, 2014, 9:33 a.m.)
>
>
> Review request for Aurora, David Robinson and Maxim Khutornenko.
>
>
> Bugs: aurora-332
> https://issues.apache.org/jira/browse/aurora-332
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Extend the client configuration plugin architecture.
>
> Plugins can now run code at three key points:
> - Before arguments are processed and execution is dispatched to a command.
> - After argument processing and dispatch, but before execution.
> - After execution.
>
> This allows plugins to perform initialization required for argument
> processing,
> and for post-execution cleanups and synchronizations.
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/client/cli/__init__.py
> f1165a05c7c66d7a06f4733eb65ae4a7de6fad76
> src/test/python/apache/aurora/client/cli/test_plugins.py
> 7cacb02ffda05fdf87a9334ed1de2092efb39f8b
>
> Diff: https://reviews.apache.org/r/20521/diff/
>
>
> Testing
> ---
>
> [sun-wukong incubator-aurora (plugin_with_cleanup)]$ ./pants
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets:
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> == test session starts
> ===
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py
>
> 4 passed in 0.02 seconds
>
> == test session starts
> ===
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .
>
> 5 passed in 0.76 seconds
>
> == test session starts
> ===
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> === 36 passed in 2.02 seconds
>
> == test session starts
> ===
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/cli/test_logging.py .
>
> 1 passed in 0.68 seconds
>
> == test session starts
> ===
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> 2 passed in 0.63 seconds
>
> =
Re: Review Request 20521: Extend the client configuration plugin architecture.
.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (plugin_with_cleanup)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20521: Extend the client configuration plugin architecture.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20521/#review40887
---
src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/20521/#comment74133>
The pre-execution plugin takes the same command-context as the actual verb
implementation. It behaves exactly as if it's part of the command
implementation - same context, same error-signalling methods.
The post-execution plugin method shouldn't be throwing exceptions at all.
It's just a cleanup - that's why it isn't supposed to change the return code.
Python being python, we can't enforce the fact that the post-execution
method doesn't throw context.CommandException. But the intention is as it's
written in the code: no attempt to catch any exception from it, because it's
not supposed to throw any.
Since it's not clear, I'll update the code documentation to reflect this.
- Mark Chu-Carroll
On April 21, 2014, 12:36 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20521/
> ---
>
> (Updated April 21, 2014, 12:36 p.m.)
>
>
> Review request for Aurora, David Robinson and Maxim Khutornenko.
>
>
> Bugs: aurora-332
> https://issues.apache.org/jira/browse/aurora-332
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Extend the client configuration plugin architecture.
>
> Plugins can now run code at three key points:
> - Before arguments are processed and execution is dispatched to a command.
> - After argument processing and dispatch, but before execution.
> - After execution.
>
> This allows plugins to perform initialization required for argument
> processing,
> and for post-execution cleanups and synchronizations.
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/client/cli/__init__.py
> f1165a05c7c66d7a06f4733eb65ae4a7de6fad76
> src/test/python/apache/aurora/client/cli/test_plugins.py
> 7cacb02ffda05fdf87a9334ed1de2092efb39f8b
>
> Diff: https://reviews.apache.org/r/20521/diff/
>
>
> Testing
> ---
>
> [sun-wukong incubator-aurora (plugin_with_cleanup)]$ ./pants
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets:
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> == test session starts
> ===
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py
>
> 4 passed in 0.02 seconds
>
> == test session starts
> ===
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .
>
> 5 passed in 0.76 seconds
>
> == test session starts
> ===
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> === 36 passed in 2.02 seconds
>
> == test session starts
> ===
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/cli/test_logging.py .
>
> 1 passed in 0.68 seconds
> =
Re: Review Request 20521: Extend the client configuration plugin architecture.
. SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (plugin_with_cleanup)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20521: Extend the client configuration plugin architecture.
> On April 21, 2014, 12:53 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 337 > > <https://reviews.apache.org/r/20521/diff/1/?file=563067#file563067line337> > > > > The pre-execution plugin takes the same command-context as the actual > > verb implementation. It behaves exactly as if it's part of the command > > implementation - same context, same error-signalling methods. > > > > The post-execution plugin method shouldn't be throwing exceptions at > > all. It's just a cleanup - that's why it isn't supposed to change the > > return code. > > > > Python being python, we can't enforce the fact that the post-execution > > method doesn't throw context.CommandException. But the intention is as it's > > written in the code: no attempt to catch any exception from it, because > > it's not supposed to throw any. > > > > Since it's not clear, I'll update the code documentation to reflect > > this. > > > > Maxim Khutornenko wrote: > Perhaps I missing something but is there anything preventing all plugins > from raising a ConfigurationPlugin.Error instead of CommandError on hook > validation failure? This would remove ambiguity on the error handling side > and enable a plugin-specific error messaging/handling. Preventing it? No. I just think that as a design point, it's clearer to say that the pre-execution method of a plugin runs as a part of the verb implementation, and so it signals errors in the same way. The only reason that there's a plugin exception type at all is because the pre-dispatch method doesn't have a context object, and you need a context to throw a Context.CommandError. - Mark ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40887 --- On April 21, 2014, 12:53 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20521/ > --- > > (Updated April 21, 2014, 12:53 p.m.) > > > Review request for Aurora, David Robinson and Maxim Khutornenko. > > > Bugs: aurora-332 > https://issues.apache.org/jira/browse/aurora-332 > > > Repository: aurora > > > Description > --- > > Extend the client configuration plugin architecture. > > Plugins can now run code at three key points: > - Before arguments are processed and execution is dispatched to a command. > - After argument processing and dispatch, but before execution. > - After execution. > > This allows plugins to perform initialization required for argument > processing, > and for post-execution cleanups and synchronizations. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/__init__.py > f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 > src/test/python/apache/aurora/client/cli/test_plugins.py > 7cacb02ffda05fdf87a9334ed1de2092efb39f8b > > Diff: https://reviews.apache.org/r/20521/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (plugin_with_cleanup)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > == test session starts > === > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > 4 passed in 0.02 seconds > > == test session starts > === > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > 5 passed in 0.76 seconds > > == test session starts > === > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 36 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py
Re: Review Request 20521: Extend the client configuration plugin architecture.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40894 --- src/main/python/apache/aurora/client/cli/__init__.py <https://reviews.apache.org/r/20521/#comment74142> The reason for this is because these errors are not intended to be handled. They're fatal, and all that they're supposed to do is stop, and print out an informative error message about what went wrong. Essentially, they're just a non-local return statement, that returns an exit code and an error message. The only thing that using a Plugin.Error would change is that the exception handling code in the except clause would need to catch two kinds of exceptions instead of just one. It wouldn't add anything. - Mark Chu-Carroll On April 21, 2014, 12:53 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20521/ > --- > > (Updated April 21, 2014, 12:53 p.m.) > > > Review request for Aurora, David Robinson and Maxim Khutornenko. > > > Bugs: aurora-332 > https://issues.apache.org/jira/browse/aurora-332 > > > Repository: aurora > > > Description > --- > > Extend the client configuration plugin architecture. > > Plugins can now run code at three key points: > - Before arguments are processed and execution is dispatched to a command. > - After argument processing and dispatch, but before execution. > - After execution. > > This allows plugins to perform initialization required for argument > processing, > and for post-execution cleanups and synchronizations. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/__init__.py > f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 > src/test/python/apache/aurora/client/cli/test_plugins.py > 7cacb02ffda05fdf87a9334ed1de2092efb39f8b > > Diff: https://reviews.apache.org/r/20521/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (plugin_with_cleanup)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > == test session starts > === > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > 4 passed in 0.02 seconds > > == test session starts > === > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > 5 passed in 0.76 seconds > > == test session starts > === > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 36 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py . > src/test/python/apache/aurora/client/cli/test_open.py . > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ... > src/test/python/apache/aurora/client/cli/test_update.py ... > > === 36 passed in 2.02 seconds > > == test session starts > === > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/cli/test_logging.py . > > 1 passed in 0.68 seconds > > == test session starts > === > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py
Re: Review Request 20521: Extend the client configuration plugin architecture.
. SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (plugin_with_cleanup)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20521: Extend the client configuration plugin architecture.
.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (plugin_with_cleanup)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20490: Add a "get version" API method.
3 passed in 1.14 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.46 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py = 12 passed in 0.65 seconds == test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py == 4 passed in 0.43 seconds == src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (get_version)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20490: Add a "get version" API method.
It's already pushed. On Thu, Apr 24, 2014 at 1:16 PM, Brian Wickman wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20490/ > > if this merges to master after r/20583, you will need to kill the directory > wrapper stuff. if it merges before r/20583, i will have to kill the > directory wrapper stuff :-) since this goes away in twitter.common.python > >=0.4.0. > > > - Brian Wickman > > On April 22nd, 2014, 7:59 p.m. UTC, Mark Chu-Carroll wrote: > Review request for Aurora, Maxim Khutornenko and Brian Wickman. > By Mark Chu-Carroll. > > *Updated April 22, 2014, 7:59 p.m.* > *Repository: * aurora > Description > > Add a "get version" API method. (This is needed for a logging-related change > for twitter.) > > While I'm in there, fix a bug in "job list". > > Testing > > ./pants src/test/python/apache/aurora/client:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) > test session starts > = > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/test_binding_helper.py .. > > == 2 passed in 0.39 seconds > == > test session starts > = > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/test_config.py .. > > == 6 passed in 0.47 seconds > == > test session starts > = > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_disambiguator.py .. > > == 6 passed in 0.46 seconds > == > test session starts > = > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/api/test_job_monitor.py . > > == 1 passed in 0.41 seconds > == > test session starts > = > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > == 6 passed in 0.36 seconds > == > test session starts > = > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 47 items / 1 skipped > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > ... > > 47 passed, 1 skipped in 3.83 seconds > > test session starts > = > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 20 items > > src/test/python/apache/aurora/client/api/test_instance_watcher.py > src/test/python/apache/aurora/client/api/test_health_check.py > > = 20 passed in 0.24 seconds > == > test session starts > = > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 27 items > > src/test/python/apache/aurora/client/api/test_updater.py > ... > > = 27 passed in 0.64 seconds > == > test session starts > = > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_quota_check.py .. > > == 6 passed in 0.15 seconds > ===
Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.56 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.54 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command_hooks)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41420
---
src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/20687/#comment74857>
Different cases.
A command hook can signal that a command shouldn't be executed, and return
the exit code that should be returned to the shell. It's intended to signal
that there wasn't an error executing the hook, but that the hook requested that
the command be aborted.
The hook can also signal an exception, which means that there was an error
in the hook.
src/main/python/apache/aurora/client/cli/command_hooks.py
<https://reviews.apache.org/r/20687/#comment74858>
d'oh.
- Mark Chu-Carroll
On April 24, 2014, 3:30 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
>
> (Updated April 24, 2014, 3:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Suman Karumuri.
>
>
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Stage 1 of implementing command hooks for aurora v2.
>
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in
> ConfigurationPlugins
> compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
>
> The dynamically loaded plugins are *not* currently active outside of tests.
>
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/client/cli/BUILD
> 17cdc287875b5f0832064a6441f33fc9837fc79b
> src/main/python/apache/aurora/client/cli/__init__.py
> 5a10328e49f0128965aed73b9c167324dfcfde0f
> src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION
> src/main/python/apache/aurora/client/cli/jobs.py
> 0534bdf72a332caa606dd3a7ca743a59e03738ef
> src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD
> 34fdb47baa647b9c3bd149ff2710b175c7435dae
> src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20687/diff/
>
>
> Testing
> ---
>
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets:
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py
>
> === 4 passed in 0.03 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_command_hooks.py
>
> === 4 passed in 0.58 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .
>
> === 5 passed in 0.52 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
=== = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.56 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.54 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command_hooks)]$ Thanks, Mark Chu-Carroll
Review Request 20707: Fix a plugins glitch.
ked_api.py == 12 passed in 0.45 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.44 seconds === src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (fix_plugins)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20707: Fix a plugins glitch.
ion starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py == 12 passed in 0.45 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.44 seconds === src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (fix_plugins)]$ Thanks, Mark Chu-Carroll
Review Request 20723: Add batch options to kill and killall.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20723/ --- Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-356 https://issues.apache.org/jira/browse/aurora-356 Repository: aurora Description --- Add batch options to kill and killall. (This brings the kill commands in client v1 into parity with client v2. At the moment, in order to avoid disrupting current users, v1 still defaults to non-batched operation.) Diffs - src/main/python/apache/aurora/client/commands/core.py 67c061eace86b7a28d2c3ae03e23c7d77fc7957f src/main/python/apache/aurora/client/options.py 0d85c360dc4c62ab0baf58315a68a32c304fcffc src/test/python/apache/aurora/client/commands/test_kill.py 825f5f13da1c8bee843581a34f3357c0fa2dbb00 Diff: https://reviews.apache.org/r/20723/diff/ Testing --- [sun-wukong incubator-aurora (batch_v1)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.57 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 28 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py .. src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py ... src/test/python/apache/aurora/client/commands/test_update.py ... == 28 passed in 1.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/commands/test_hooks.py ... === 3 passed in 1.21 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py === 4 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . === 1 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . === 1 passed in 0.47 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS [sun-wukong incubator-aurora (batch_v1)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20707: Fix a plugins glitch.
.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . === 1 passed in 0.46 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py == 12 passed in 0.45 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.44 seconds === src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (fix_plugins)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
> On April 24, 2014, 8:15 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 344 > > <https://reviews.apache.org/r/20687/diff/1/?file=567983#file567983line344> > > > > Different cases. > > > > A command hook can signal that a command shouldn't be executed, and > > return the exit code that should be returned to the shell. It's intended to > > signal that there wasn't an error executing the hook, but that the hook > > requested that the command be aborted. > > > > The hook can also signal an exception, which means that there was an > > error in the hook. > > > > David McLaughlin wrote: > I think exceptions are designed for exactly this... the hook authors can > also give their own error messages. > > David McLaughlin wrote: > I'm not sure I understand why the distinction between an error in the > hook and a request to stop the command is important. Why not just ask the > hook to throw a special exception type? If you're adamant about error codes, > how would they give a reason for preventing the command running? I still think that there's an important difference between an error, and a normal return. Hook writers can opt to just use exceptions, and the code will handle it correctly if they do. But the plugin code is supposed to look as much as possible like it's running as part of a verb implementation. Verbs return status codes to the shell when they finish; this is following the same model. The design doc that we ran by the team and the dev mailing list specified this behavior, and I'm still not seeing why it should be removed. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41420 --- On April 24, 2014, 8:17 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20687/ > --- > > (Updated April 24, 2014, 8:17 p.m.) > > > Review request for Aurora, David McLaughlin and Suman Karumuri. > > > Bugs: aurora-270 > https://issues.apache.org/jira/browse/aurora-270 > > > Repository: aurora > > > Description > --- > > Stage 1 of implementing command hooks for aurora v2. > > This change includes: > (1) The ability to add hard-wired hooks, by registering them in > ConfigurationPlugins > compiled into a pex; > (2) Dynamically loaded plugins, loaded from plugin files. > > The dynamically loaded plugins are *not* currently active outside of tests. > > The second stage of this change will activate dynamically loaded plugins, and > provide a mechanism to allow privileged users to override hooks. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/BUILD > 17cdc287875b5f0832064a6441f33fc9837fc79b > src/main/python/apache/aurora/client/cli/__init__.py > 5a10328e49f0128965aed73b9c167324dfcfde0f > src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION > src/main/python/apache/aurora/client/cli/jobs.py > 0534bdf72a332caa606dd3a7ca743a59e03738ef > src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > 34fdb47baa647b9c3bd149ff2710b175c7435dae > src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION > > Diff: https://reviews.apache.org/r/20687/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (command_hooks)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 passed in 0.03 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_command_hooks.py > >
Re: Review Request 20723: Add batch options to kill and killall.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20723/ --- (Updated April 25, 2014, 3:15 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Changes --- Fix typo in option name. Bugs: aurora-356 https://issues.apache.org/jira/browse/aurora-356 Repository: aurora Description --- Add batch options to kill and killall. (This brings the kill commands in client v1 into parity with client v2. At the moment, in order to avoid disrupting current users, v1 still defaults to non-batched operation.) Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py 67c061eace86b7a28d2c3ae03e23c7d77fc7957f src/main/python/apache/aurora/client/options.py 0d85c360dc4c62ab0baf58315a68a32c304fcffc src/test/python/apache/aurora/client/commands/test_kill.py 825f5f13da1c8bee843581a34f3357c0fa2dbb00 Diff: https://reviews.apache.org/r/20723/diff/ Testing --- [sun-wukong incubator-aurora (batch_v1)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.57 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 28 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py .. src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py ... src/test/python/apache/aurora/client/commands/test_update.py ... == 28 passed in 1.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/commands/test_hooks.py ... === 3 passed in 1.21 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py === 4 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . === 1 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . === 1 passed in 0.47 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS [sun-wukong incubator-aurora (batch_v1)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
Thanks for doing this so quickly! On Fri, Apr 25, 2014 at 3:31 PM, David McLaughlin wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20687/ > > Ship it! > > Ship It! > > > - David McLaughlin > > On April 25th, 2014, 12:17 a.m. UTC, Mark Chu-Carroll wrote: > Review request for Aurora, David McLaughlin and Suman Karumuri. > By Mark Chu-Carroll. > > *Updated April 25, 2014, 12:17 a.m.* > *Bugs: * aurora-270 <https://issues.apache.org/jira/browse/aurora-270> > *Repository: * aurora > Description > > Stage 1 of implementing command hooks for aurora v2. > > This change includes: > (1) The ability to add hard-wired hooks, by registering them in > ConfigurationPlugins > compiled into a pex; > (2) Dynamically loaded plugins, loaded from plugin files. > > The dynamically loaded plugins are *not* currently active outside of tests. > > The second stage of this change will activate dynamically loaded plugins, and > provide a mechanism to allow privileged users to override hooks. > > Testing > > [sun-wukong incubator-aurora (command_hooks)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 passed in 0.03 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_command_hooks.py > > === 4 passed in 0.58 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > === 5 passed in 0.52 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 36 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py . > src/test/python/apache/aurora/client/cli/test_open.py . > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ... > src/test/python/apache/aurora/client/cli/test_update.py ... > > == 36 passed in 1.87 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/cli/test_logging.py . > > === 1 passed in 0.62 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py .. > > === 2 passed in 0.53 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_quota.py > > === 4 passed in 0.55 seconds > === > =
Re: Review Request 20726: Removing client HTTP health checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20726/#review41515 --- Ship it! Ship It! - Mark Chu-Carroll On April 25, 2014, 3:41 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20726/ > --- > > (Updated April 25, 2014, 3:41 p.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-361 > https://issues.apache.org/jira/browse/AURORA-361 > > > Repository: aurora > > > Description > --- > > Dropping client http health checks in favor of status checks only. > > > Diffs > - > > src/main/python/apache/aurora/client/api/health_check.py > e3bbf71a37c3137d580378ac185eaf65f4b056af > src/main/python/apache/aurora/client/api/instance_watcher.py > 530868348142c73708fa7f0d7296a3fb5b6ebb5d > src/test/python/apache/aurora/client/api/test_health_check.py > f59fe42cc4808aeece34f55978ca34e62404ac58 > src/test/python/apache/aurora/client/cli/test_restart.py > 43412c44edba19e8c7d753118d7ad0be78a4fd39 > src/test/python/apache/aurora/client/cli/test_update.py > e3e433262f354ed0573273bd0c28746c3cef902b > src/test/python/apache/aurora/client/commands/test_restart.py > 526c501869b7ae22550e5d84613ca38f8071b9b7 > src/test/python/apache/aurora/client/commands/test_update.py > f90783779805313f529487509f7d457ba8ee138c > > Diff: https://reviews.apache.org/r/20726/diff/ > > > Testing > --- > > ./pants src/test/python:all > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 19788: Add a clientv2 version of the e2e test.
/site-packages/twitter.common.python-0.3.1-py2.7-nspkg.pth Installing pex script to /home/vagrant/test_dev/build-support/pex.venv/bin Found existing installation: setuptools 0.9.8 Uninstalling setuptools: Successfully uninstalled setuptools Running setup.py install for setuptools Installing easy_install script to /home/vagrant/test_dev/build-support/pex.venv/bin Installing easy_install-2.7 script to /home/vagrant/test_dev/build-support/pex.venv/bin Successfully installed twitter.common.python setuptools Cleaning up... Built pants-0.0.14-dev2.pex Build operating on targets: OrderedSet([PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2)]) Building PythonBinary PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2): Wrote /home/vagrant/test_dev/dist/aurorav2.pex + run_dev 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' + vagrant ssh devtools -c 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' Build operating on targets: OrderedSet([PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example)]) Building PythonBinary PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example): Wrote /home/vagrant/test_dev/dist/flask_example.pex + '[' '!' -d deploy_test ']' + mkdir deploy_test + run_dev 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + run_dev 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + test_flask_example example vagrant test flask_example deploy_test 192.168.33.6 /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + local _cluster=example _role=vagrant _env=test _job=flask_example _testdir=deploy_test _sched_ip=192.168.33.6 + local _base_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora _updated_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + jobkey=example/vagrant/test/flask_example + echo '== Creating job' == Creating job + run_sched '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + base_url=http://192.168.33.6:8081 ++ _curl -s http://192.168.33.6:8081/scheduler ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler + schedlen=' 50' + test 50 -ge 40 ++ _curl -s http://192.168.33.6:8081/scheduler/vagrant ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler/vagrant + rolelen=' 195' + test 195 -ge 50 ++ _curl http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ curl --silent --fail --retry 4 --retry-delay 10 http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ wc -l + joblen=' 526' + test 526 -ge 100 + echo '== Updating test job' == Updating test job + run_sched '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' Warning: this update is a large change. Press ^C within 5 seconds to abort ++ wc -l ++ run_sched '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' ++ vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' + runlen=' 2' + test 2 -eq 2 + run_sched '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' Allocated: CPU: 0.0 RAM: 0.00 GB Disk: 0.00 GB Production resources consumed: CPU: 0.0 RAM: 0.00 GB Disk: 0.00 GB Non-production resources consumed: CPU: 2.0 RAM: 0.125000 GB Disk: 0.187500 GB + run_sched '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + RETCODE=0 + collect_result + [[ 0 = 0 ]] + echo '***' *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 Thanks, Mark Chu-Carroll
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41616 --- src/main/python/apache/aurora/client/cli/__init__.py <https://reviews.apache.org/r/20687/#comment75150> No. This logging is for the log server; from the perspective of the log server, this is a routine, acceptable event. It was an error for the user, but not an error for the system. src/main/python/apache/aurora/client/cli/command_hooks.py <https://reviews.apache.org/r/20687/#comment75151> No, neither. We're following the model of Vagrantfile or Makefile. Hooks affect the behavior of the system, so they should not be hidden. src/main/python/apache/aurora/client/cli/command_hooks.py <https://reviews.apache.org/r/20687/#comment75149> Can't. print_err is a context method. There is no context here. src/main/python/apache/aurora/client/cli/command_hooks.py <https://reviews.apache.org/r/20687/#comment75154> Can't. These two variables are used for visible side-effects - we need to have variable to reference them after the exec returns. - Mark Chu-Carroll On April 24, 2014, 8:17 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20687/ > --- > > (Updated April 24, 2014, 8:17 p.m.) > > > Review request for Aurora, David McLaughlin and Suman Karumuri. > > > Bugs: aurora-270 > https://issues.apache.org/jira/browse/aurora-270 > > > Repository: aurora > > > Description > --- > > Stage 1 of implementing command hooks for aurora v2. > > This change includes: > (1) The ability to add hard-wired hooks, by registering them in > ConfigurationPlugins > compiled into a pex; > (2) Dynamically loaded plugins, loaded from plugin files. > > The dynamically loaded plugins are *not* currently active outside of tests. > > The second stage of this change will activate dynamically loaded plugins, and > provide a mechanism to allow privileged users to override hooks. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/BUILD > 17cdc287875b5f0832064a6441f33fc9837fc79b > src/main/python/apache/aurora/client/cli/__init__.py > 5a10328e49f0128965aed73b9c167324dfcfde0f > src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION > src/main/python/apache/aurora/client/cli/jobs.py > 0534bdf72a332caa606dd3a7ca743a59e03738ef > src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > 34fdb47baa647b9c3bd149ff2710b175c7435dae > src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION > > Diff: https://reviews.apache.org/r/20687/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (command_hooks)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 passed in 0.03 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_command_hooks.py > > === 4 passed in 0.58 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > === 5 passed in 0.52 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 36 items > > src/test/pyth
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
-- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_quota.py === 4 passed in 0.55 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.56 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.54 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command_hooks)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
=== = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.56 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.54 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command_hooks)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
-- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_quota.py === 4 passed in 0.55 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.56 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.54 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command_hooks)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_quota.py === 4 passed in 0.55 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.56 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.54 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command_hooks)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
-- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_quota.py === 4 passed in 0.55 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.56 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.54 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command_hooks)]$ Thanks, Mark Chu-Carroll
Review Request 20928: Command hooks: stage 2.
src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command-hooks-two)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review41938 --- src/main/python/apache/aurora/client/api/job_monitor.py <https://reviews.apache.org/r/20950/#comment75594> shouldn't this be >=? src/test/python/apache/aurora/client/api/test_job_monitor.py <https://reviews.apache.org/r/20950/#comment75595> You can just "assert monitor.wait_until...". - Mark Chu-Carroll On May 1, 2014, 1:01 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20950/ > --- > > (Updated May 1, 2014, 1:01 p.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-370 > https://issues.apache.org/jira/browse/AURORA-370 > > > Repository: aurora > > > Description > --- > > Migration plan: > 1. Prepare client to poll for the status of tasks being killed. This is > mostly a noop at this point while the scheduler wait with a shorter timeout > is still in place. > 2. Cut off scheduler killTasks wait thus relying on the client poll (coming > next). > > This RB addresses client changes: > - Repurposing JobMonitor to poll for all job tasks regardless of their > arrival time. > - Introducing a timeout cap into JobMonitor to interrupt wait upon reaching > the max_poll_interval. > - Setting the JobMonitor max_poll_interval to be higher than the scheduler > killTasks backoff to ensure smooth migration. > - Added wait_util calls into kill/killall/updater calls. > > Once this ticket is closed, the next step would be to make kill/killall truly > async: AURORA-371 > > > Diffs > - > > src/main/python/apache/aurora/client/api/BUILD > 32097d220a6f8a58555260ce081ace0c58b9fa99 > src/main/python/apache/aurora/client/api/job_monitor.py > b694ef62ba708c4b67c5cc931b0edfd93702027f > src/main/python/apache/aurora/client/api/updater.py > 0acf45034db124ed369d0bcb8095fe5545605eed > src/main/python/apache/aurora/client/cli/jobs.py > 782b34800def55c54b67ca5f13da66c4997a0777 > src/main/python/apache/aurora/client/cli/task.py > 62747ed3e3f5f6ecd9b9c46f6f175c634c068358 > src/main/python/apache/aurora/client/commands/core.py > 39190e06f3eac1ab4dabf48055418bc383be14ed > src/test/python/apache/aurora/client/api/BUILD > dd9b79764db0bbc3a11c51051e43b93a9b5d370a > src/test/python/apache/aurora/client/api/test_job_monitor.py > 32609e4e97afc7b8b164f3db438c60efd0ebbe11 > src/test/python/apache/aurora/client/api/test_updater.py > e7eb1e783baaabe9437e55ecb848f6a42de13dd7 > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 7c6f70c7ef7534e9dd4986364331c67f6f7c36b1 > src/test/python/apache/aurora/client/cli/test_create.py > 875573e2ee534ea50da71fac2174ecc8877a714d > src/test/python/apache/aurora/client/cli/test_kill.py > cf5df648206e0cc234d603c1fd56dc7ab1311fa9 > src/test/python/apache/aurora/client/cli/test_plugins.py > 2dab749d1dcba99a1e3c792c8f26ee86441673d1 > src/test/python/apache/aurora/client/cli/test_update.py > cf077e821ebe32104b3e1345014f5c7b07c44c34 > src/test/python/apache/aurora/client/cli/util.py > 2225ab071dff72be547c43f66ffdc890171c3288 > src/test/python/apache/aurora/client/commands/test_create.py > e0ecb523db4ce3b1901adcc96a2fd5ce8184f621 > src/test/python/apache/aurora/client/commands/test_kill.py > db820a543b0ea11e5a40cc2a00209aa8fa6186c9 > src/test/python/apache/aurora/client/commands/test_update.py > 6e145db9ff8213c8f098b53b9a9668532d664249 > > Diff: https://reviews.apache.org/r/20950/diff/ > > > Testing > --- > > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review41943 --- Ship it! Ship It! - Mark Chu-Carroll On May 1, 2014, 4:42 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20950/ > --- > > (Updated May 1, 2014, 4:42 p.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-370 > https://issues.apache.org/jira/browse/AURORA-370 > > > Repository: aurora > > > Description > --- > > Migration plan: > 1. Prepare client to poll for the status of tasks being killed. This is > mostly a noop at this point while the scheduler wait with a shorter timeout > is still in place. > 2. Cut off scheduler killTasks wait thus relying on the client poll (coming > next). > > This RB addresses client changes: > - Repurposing JobMonitor to poll for all job tasks regardless of their > arrival time. > - Introducing a timeout cap into JobMonitor to interrupt wait upon reaching > the max_poll_interval. > - Setting the JobMonitor max_poll_interval to be higher than the scheduler > killTasks backoff to ensure smooth migration. > - Added wait_util calls into kill/killall/updater calls. > > Once this ticket is closed, the next step would be to make kill/killall truly > async: AURORA-371 > > > Diffs > - > > src/main/python/apache/aurora/client/api/BUILD > 32097d220a6f8a58555260ce081ace0c58b9fa99 > src/main/python/apache/aurora/client/api/job_monitor.py > b694ef62ba708c4b67c5cc931b0edfd93702027f > src/main/python/apache/aurora/client/api/updater.py > 0acf45034db124ed369d0bcb8095fe5545605eed > src/main/python/apache/aurora/client/cli/jobs.py > 782b34800def55c54b67ca5f13da66c4997a0777 > src/main/python/apache/aurora/client/cli/task.py > 62747ed3e3f5f6ecd9b9c46f6f175c634c068358 > src/main/python/apache/aurora/client/commands/core.py > 39190e06f3eac1ab4dabf48055418bc383be14ed > src/test/python/apache/aurora/client/api/BUILD > dd9b79764db0bbc3a11c51051e43b93a9b5d370a > src/test/python/apache/aurora/client/api/test_job_monitor.py > 32609e4e97afc7b8b164f3db438c60efd0ebbe11 > src/test/python/apache/aurora/client/api/test_updater.py > e7eb1e783baaabe9437e55ecb848f6a42de13dd7 > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 7c6f70c7ef7534e9dd4986364331c67f6f7c36b1 > src/test/python/apache/aurora/client/cli/test_create.py > 875573e2ee534ea50da71fac2174ecc8877a714d > src/test/python/apache/aurora/client/cli/test_kill.py > cf5df648206e0cc234d603c1fd56dc7ab1311fa9 > src/test/python/apache/aurora/client/cli/test_plugins.py > 2dab749d1dcba99a1e3c792c8f26ee86441673d1 > src/test/python/apache/aurora/client/cli/test_update.py > cf077e821ebe32104b3e1345014f5c7b07c44c34 > src/test/python/apache/aurora/client/cli/util.py > 2225ab071dff72be547c43f66ffdc890171c3288 > src/test/python/apache/aurora/client/commands/test_create.py > e0ecb523db4ce3b1901adcc96a2fd5ce8184f621 > src/test/python/apache/aurora/client/commands/test_kill.py > db820a543b0ea11e5a40cc2a00209aa8fa6186c9 > src/test/python/apache/aurora/client/commands/test_update.py > 6e145db9ff8213c8f098b53b9a9668532d664249 > > Diff: https://reviews.apache.org/r/20950/diff/ > > > Testing > --- > > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 20723: Add batch options to kill and killall.
> On April 25, 2014, 3:18 p.m., David McLaughlin wrote: > > lgtm ping, suman? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20723/#review41509 --- On April 25, 2014, 3:15 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20723/ > --- > > (Updated April 25, 2014, 3:15 p.m.) > > > Review request for Aurora, David McLaughlin and Suman Karumuri. > > > Bugs: aurora-356 > https://issues.apache.org/jira/browse/aurora-356 > > > Repository: aurora > > > Description > --- > > Add batch options to kill and killall. (This brings the kill commands in > client v1 into parity with client v2. > At the moment, in order to avoid disrupting current users, v1 still defaults > to non-batched operation.) > > > Diffs > - > > src/main/python/apache/aurora/client/commands/core.py > 67c061eace86b7a28d2c3ae03e23c7d77fc7957f > src/main/python/apache/aurora/client/options.py > 0d85c360dc4c62ab0baf58315a68a32c304fcffc > src/test/python/apache/aurora/client/commands/test_kill.py > 825f5f13da1c8bee843581a34f3357c0fa2dbb00 > > Diff: https://reviews.apache.org/r/20723/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (batch_v1)]$ ./pants > src/test/python/apache/aurora/client/commands:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 13 items > > src/test/python/apache/aurora/client/commands/test_admin_sla.py . > > == 13 passed in 0.57 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 28 items > > src/test/python/apache/aurora/client/commands/test_cancel_update.py .. > src/test/python/apache/aurora/client/commands/test_create.py .. > src/test/python/apache/aurora/client/commands/test_diff.py ... > src/test/python/apache/aurora/client/commands/test_kill.py .. > src/test/python/apache/aurora/client/commands/test_listjobs.py .. > src/test/python/apache/aurora/client/commands/test_restart.py ... > src/test/python/apache/aurora/client/commands/test_status.py ... > src/test/python/apache/aurora/client/commands/test_update.py ... > > == 28 passed in 1.47 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 3 items > > src/test/python/apache/aurora/client/commands/test_hooks.py ... > > === 3 passed in 1.21 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/commands/test_maintenance.py > > === 4 passed in 0.48 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/commands/test_run.py . > > === 1 passed in 0.58 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/commands/test_ssh.py . > > === 1 passed in 0.47 seconds > === > src.test.python.apache.aurora.client.commands.admin > . SUCCESS > src.test.python.apache.aurora.client.commands.core > . SUCCESS > src.test.python.apache.aurora.client.commands.hooks > . SUCCESS > src.test.python.apache.aurora.client.commands.maintenance > . SUCCESS > src.test.python.apache.aurora.client.commands.run > . SUCCESS > src.test.python.apache.aurora.client.commands.ssh > . SUCCESS > [sun-wukong incubator-aurora (batch_v1)]$ > > > Thanks, > > Mark Chu-Carroll > >
Re: Review Request 20928: Command hooks: stage 2.
=== src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command-hooks-two)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20928: Command hooks: stage 2.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20928/#review41951
---
docs/design/command-hooks.md
<https://reviews.apache.org/r/20928/#comment75619>
Good catch, thanks!
src/main/python/apache/aurora/client/cli/command_hooks.py
<https://reviews.apache.org/r/20928/#comment75620>
The intention is that any field of a hook skip rule that is left blank
means "match anything, as long as the rest of the rule matches", so that is
intentional.
But I think you're right - that's not the best approach. I'll modify it,
and update the docs.
src/test/python/apache/aurora/client/cli/test_command_hooks.py
<https://reviews.apache.org/r/20928/#comment75621>
They do - the cases that use exception 'b".
- Mark Chu-Carroll
On May 1, 2014, 4:47 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20928/
> ---
>
> (Updated May 1, 2014, 4:47 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Suman Karumuri.
>
>
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
>
>
> Repository: aurora
>
>
> Description
> ---
>
> The second half of command hooks:
> - Dynamically registered hook exceptions are provided, by fetching a hooks
> skip rules file from a
> URL.
> - Hooks are loaded and activated by the noun/verb framework.
> - Hook selection and dispatch has been substantially updated.
>
> Also did some long overdue cleanup of string quoting consistency.
>
>
> Diffs
> -
>
> 3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6
> docs/design/command-hooks.md ee320ed3922928408d23a2dfdf3c42ef96e62ff7
> src/main/python/apache/aurora/client/cli/BUILD
> 1bd565effb3dbe2aeb5d6156575e9316bd77c6a8
> src/main/python/apache/aurora/client/cli/__init__.py
> 1e396b2263451b41cd223708f4cc4cdb1eeddbf0
> src/main/python/apache/aurora/client/cli/command_hooks.py
> 2d200682209e1df83c03f9d515f3b118aaa85a99
> src/test/python/apache/aurora/client/cli/test_command_hooks.py
> 7c6f70c7ef7534e9dd4986364331c67f6f7c36b1
>
> Diff: https://reviews.apache.org/r/20928/diff/
>
>
> Testing
> ---
>
> [sun-wukong incubator-aurora (command-hooks-two)]$ !./p
> ./pants src/test/python/apache/aurora/client/cli:all
> Build operating on targets:
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py
>
> === 4 passed in 0.02 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
>
> src/test/python/apache/aurora/client/cli/test_command_hooks.py .
>
> === 9 passed in 0.80 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .
>
> === 5 passed in 0.70 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 36 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> == 36 passed in 2.02 seconds
> ===
> = test session starts
> ==
> platform darwin -- Python
Re: Review Request 20928: Command hooks: stage 2.
=== src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command-hooks-two)]$ Thanks, Mark Chu-Carroll
Re: Review Request 21020: Set owner field correctly in getTasksStatus call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21020/#review42042 --- Ship it! Ship It! - Mark Chu-Carroll On May 2, 2014, 2:55 p.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21020/ > --- > > (Updated May 2, 2014, 2:55 p.m.) > > > Review request for Aurora and Mark Chu-Carroll. > > > Bugs: AURORA-373 > https://issues.apache.org/jira/browse/AURORA-373 > > > Repository: aurora > > > Description > --- > > Was incorrectly setting the identity field instead of the owner field in > getTasksStatus call. > > > Diffs > - > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js > 96748eb0c3723d48b1f98e8ae4244785639b5da3 > > Diff: https://reviews.apache.org/r/21020/diff/ > > > Testing > --- > > Tested on local laptop using ./gradlew run. > Verified logs. > Looked at client code in test_status.py to ensure we are making the backend > call correctly. > > > Thanks, > > Suman Karumuri > >
Review Request 21023: Make "--help" defer to bridged help in the bridged client executable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21023/ --- Review request for Aurora, David McLaughlin and Brian Wickman. Repository: aurora Description --- Make "--help" defer to bridged help in the bridged client executable. Diffs - src/main/python/apache/aurora/client/cli/bridge.py 30f1718456deb30632efb57fd8e04d97f74ad00d Diff: https://reviews.apache.org/r/21023/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 21023: Make "--help" defer to bridged help in the bridged client executable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21023/ --- (Updated May 2, 2014, 4:02 p.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Changes --- Get rid of extra nl. Repository: aurora Description --- Make "--help" defer to bridged help in the bridged client executable. Diffs (updated) - src/main/python/apache/aurora/client/cli/bridge.py 30f1718456deb30632efb57fd8e04d97f74ad00d Diff: https://reviews.apache.org/r/21023/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 21023: Make "--help" defer to bridged help in the bridged client executable.
Thanks guys! This has been pushed to master. On Fri, May 2, 2014 at 4:33 PM, David McLaughlin wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21023/ > > Ship it! > > Ship It! > > > - David McLaughlin > > On May 2nd, 2014, 8:02 p.m. UTC, Mark Chu-Carroll wrote: > Review request for Aurora, David McLaughlin and Brian Wickman. > By Mark Chu-Carroll. > > *Updated May 2, 2014, 8:02 p.m.* > *Repository: * aurora > Description > > Make "--help" defer to bridged help in the bridged client executable. > > Diffs > >- src/main/python/apache/aurora/client/cli/bridge.py >(30f1718456deb30632efb57fd8e04d97f74ad00d) > > View Diff <https://reviews.apache.org/r/21023/diff/> >
Re: Review Request 21093: Showing status message in Job UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21093/#review42230 --- Ship it! Ship It! - Mark Chu-Carroll On May 5, 2014, 8:43 p.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21093/ > --- > > (Updated May 5, 2014, 8:43 p.m.) > > > Review request for Aurora, David McLaughlin and Mark Chu-Carroll. > > > Bugs: AURORA-339 and AURORA-374 > https://issues.apache.org/jira/browse/AURORA-339 > https://issues.apache.org/jira/browse/AURORA-374 > > > Repository: aurora > > > Description > --- > > Bug fix. > > > Diffs > - > > src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html > 2cab2362aebce8015239051a2901de16b4a82ec5 > > Diff: https://reviews.apache.org/r/21093/diff/ > > > Testing > --- > > Tested on local laptop. Attached screenshot. > > > File Attachments > > > Screen Shot 2014-05-05 at 5.41.10 PM.png > > https://reviews.apache.org/media/uploaded/files/2014/05/06/2e4cbd97-44d6-4b40-9dfc-5f6acdc3922a__Screen_Shot_2014-05-05_at_5.41.10_PM.png > > > Thanks, > > Suman Karumuri > >
Re: Review Request 20928: Command hooks: stage 2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20928/#review42283 --- src/main/python/apache/aurora/client/cli/__init__.py <https://reviews.apache.org/r/20928/#comment76059> Done. (Getting comments like this in a review is always a bit frustrating, because I just want to get stuff done. But then, I look at the code, and you're absolutely right, and the code is so much nicer after I fix it. This is exactly what makes code review so valuable. Thanks!) src/main/python/apache/aurora/client/cli/__init__.py <https://reviews.apache.org/r/20928/#comment76060> I don't think so. I thought it was just 4 space indent on the next line. That's the style that I've used throughout the client. src/main/python/apache/aurora/client/cli/command_hooks.py <https://reviews.apache.org/r/20928/#comment76064> In this case, these submethods are just there to make the condition below more readable. They're not intended to ever be used outside of this method (which is why they're privates). The overall method that they're part of has a good set of tests. src/main/python/apache/aurora/client/cli/command_hooks.py <https://reviews.apache.org/r/20928/#comment76066> (I could have sworn I replied to this already, but reviewboard says I didn't. Forgive me if this is a duplicate.) These are local private methods which only exist to make the compound conditional below easier to read. They should never (and in fact can never) be called from anywhere else. The condition that they're part of has a decent set of tests. src/main/python/apache/aurora/client/cli/command_hooks.py <https://reviews.apache.org/r/20928/#comment76067> Added an additional link at the top of the file, but I'd prefer to also leave this here. src/main/python/apache/aurora/client/cli/command_hooks.py <https://reviews.apache.org/r/20928/#comment76065> Nope, this is the correct behavior. The client should not abort because it couldn't read skip rules. The only effect that the skip rules error will have is that attempts to execute commands blocked by hooks won't be executable. We don't want the client to abort all commands because some commands might be block. All we want to do is let them (and the loggie service) know that there was a problem with the skip rules. This will get logged to loggie, because it's got a global handler in place. - Mark Chu-Carroll On May 1, 2014, 5:39 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20928/ > --- > > (Updated May 1, 2014, 5:39 p.m.) > > > Review request for Aurora, David McLaughlin and Suman Karumuri. > > > Bugs: aurora-270 > https://issues.apache.org/jira/browse/aurora-270 > > > Repository: aurora > > > Description > --- > > The second half of command hooks: > - Dynamically registered hook exceptions are provided, by fetching a hooks > skip rules file from a > URL. > - Hooks are loaded and activated by the noun/verb framework. > - Hook selection and dispatch has been substantially updated. > > Also did some long overdue cleanup of string quoting consistency. > > > Diffs > - > > 3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 > docs/design/command-hooks.md ee320ed3922928408d23a2dfdf3c42ef96e62ff7 > src/main/python/apache/aurora/client/cli/BUILD > 1bd565effb3dbe2aeb5d6156575e9316bd77c6a8 > src/main/python/apache/aurora/client/cli/__init__.py > 1e396b2263451b41cd223708f4cc4cdb1eeddbf0 > src/main/python/apache/aurora/client/cli/command_hooks.py > 2d200682209e1df83c03f9d515f3b118aaa85a99 > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 7c6f70c7ef7534e9dd4986364331c67f6f7c36b1 > > Diff: https://reviews.apache.org/r/20928/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (command-hooks-two)]$ !./p > ./pants src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 pass
Re: Review Request 20928: Command hooks: stage 2.
conds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command-hooks-two)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20723: Add batch options to kill and killall.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20723/ --- (Updated May 6, 2014, 2 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Changes --- Address Suman's review. Bugs: aurora-356 https://issues.apache.org/jira/browse/aurora-356 Repository: aurora Description --- Add batch options to kill and killall. (This brings the kill commands in client v1 into parity with client v2. At the moment, in order to avoid disrupting current users, v1 still defaults to non-batched operation.) Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py 089a2c6aaa742dc7479014b90c2b3fac46d4befd src/main/python/apache/aurora/client/options.py 0d85c360dc4c62ab0baf58315a68a32c304fcffc src/test/python/apache/aurora/client/commands/test_kill.py 7f0b73ca2701f0ce250d906bce1bd8b07b49ae99 Diff: https://reviews.apache.org/r/20723/diff/ Testing --- [sun-wukong incubator-aurora (batch_v1)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.57 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 28 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py .. src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py ... src/test/python/apache/aurora/client/commands/test_update.py ... == 28 passed in 1.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/commands/test_hooks.py ... === 3 passed in 1.21 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py === 4 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . === 1 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . === 1 passed in 0.47 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS [sun-wukong incubator-aurora (batch_v1)]$ Thanks, Mark Chu-Carroll
Re: Review Request 20928: Command hooks: stage 2.
. SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (command-hooks-two)]$ Thanks, Mark Chu-Carroll
Review Request 21205: Bugfix: restart doesn't notify user about invalid max_total_failures option.
pi.py === 12 passed in 0.44 seconds === == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.41 seconds src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (restart_max)] $ Thanks, Mark Chu-Carroll
Re: Review Request 19788: Add a clientv2 version of the e2e test.
v/bin Found existing installation: setuptools 0.9.8 Uninstalling setuptools: Successfully uninstalled setuptools Running setup.py install for setuptools Installing easy_install script to /home/vagrant/test_dev/build-support/pex.venv/bin Installing easy_install-2.7 script to /home/vagrant/test_dev/build-support/pex.venv/bin Successfully installed twitter.common.python setuptools Cleaning up... Built pants-0.0.14-dev2.pex Build operating on targets: OrderedSet([PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2)]) Building PythonBinary PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2): Wrote /home/vagrant/test_dev/dist/aurorav2.pex + run_dev 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' + vagrant ssh devtools -c 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' Build operating on targets: OrderedSet([PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example)]) Building PythonBinary PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example): Wrote /home/vagrant/test_dev/dist/flask_example.pex + '[' '!' -d deploy_test ']' + mkdir deploy_test + run_dev 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + run_dev 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + test_flask_example example vagrant test flask_example deploy_test 192.168.33.6 /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + local _cluster=example _role=vagrant _env=test _job=flask_example _testdir=deploy_test _sched_ip=192.168.33.6 + local _base_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora _updated_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + jobkey=example/vagrant/test/flask_example + echo '== Creating job' == Creating job + run_sched '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + base_url=http://192.168.33.6:8081 ++ _curl -s http://192.168.33.6:8081/scheduler ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler + schedlen=' 50' + test 50 -ge 40 ++ _curl -s http://192.168.33.6:8081/scheduler/vagrant ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler/vagrant + rolelen=' 195' + test 195 -ge 50 ++ _curl http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ curl --silent --fail --retry 4 --retry-delay 10 http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ wc -l + joblen=' 526' + test 526 -ge 100 + echo '== Updating test job' == Updating test job + run_sched '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' Warning: this update is a large change. Press ^C within 5 seconds to abort ++ wc -l ++ run_sched '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' ++ vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' + runlen=' 2' + test 2 -eq 2 + run_sched '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' Allocated: CPU: 0.0 RAM: 0.00 GB Disk: 0.000000 GB Production resources consumed: CPU: 0.0 RAM: 0.00 GB Disk: 0.00 GB Non-production resources consumed: CPU: 2.0 RAM: 0.125000 GB Disk: 0.187500 GB + run_sched '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + RETCODE=0 + collect_result + [[ 0 = 0 ]] + echo '***' *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 Thanks, Mark Chu-Carroll
Review Request 21232: Add a strict mode for commands that specify instances.
ython 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. == 2 passed in 0.63 seconds == src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (shard_errors)]$ Thanks, Mark Chu-Carroll
Re: Review Request 19788: Add a clientv2 version of the e2e test.
ion: setuptools 0.9.8 Uninstalling setuptools: Successfully uninstalled setuptools Running setup.py install for setuptools Installing easy_install script to /home/vagrant/test_dev/build-support/pex.venv/bin Installing easy_install-2.7 script to /home/vagrant/test_dev/build-support/pex.venv/bin Successfully installed twitter.common.python setuptools Cleaning up... Built pants-0.0.14-dev2.pex Build operating on targets: OrderedSet([PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2)]) Building PythonBinary PythonBinary(src/main/python/apache/aurora/client/cli/BUILD:aurorav2): Wrote /home/vagrant/test_dev/dist/aurorav2.pex + run_dev 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' + vagrant ssh devtools -c 'cd ~/test_dev; ./pants src/test/sh/org/apache/aurora/e2e/flask:flask_example' Build operating on targets: OrderedSet([PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example)]) Building PythonBinary PythonBinary(src/test/sh/org/apache/aurora/e2e/flask/BUILD:flask_example): Wrote /home/vagrant/test_dev/dist/flask_example.pex + '[' '!' -d deploy_test ']' + mkdir deploy_test + run_dev 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/flask_example.pex /vagrant/deploy_test' + run_dev 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + vagrant ssh devtools -c 'cd ~/test_dev; cp dist/aurorav2.pex /vagrant/deploy_test' + test_flask_example example vagrant test flask_example deploy_test 192.168.33.6 /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + local _cluster=example _role=vagrant _env=test _job=flask_example _testdir=deploy_test _sched_ip=192.168.33.6 + local _base_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora _updated_config=/vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora + jobkey=example/vagrant/test/flask_example + echo '== Creating job' == Creating job + run_sched '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job create example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora' + base_url=http://192.168.33.6:8081 ++ _curl -s http://192.168.33.6:8081/scheduler ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler + schedlen=' 50' + test 50 -ge 40 ++ _curl -s http://192.168.33.6:8081/scheduler/vagrant ++ wc -l ++ curl --silent --fail --retry 4 --retry-delay 10 -s http://192.168.33.6:8081/scheduler/vagrant + rolelen=' 195' + test 195 -ge 50 ++ _curl http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ curl --silent --fail --retry 4 --retry-delay 10 http://192.168.33.6:8081/scheduler/vagrant/test/flask_example ++ wc -l + joblen=' 526' + test 526 -ge 100 + echo '== Updating test job' == Updating test job + run_sched '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job update example/vagrant/test/flask_example /vagrant/src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora' Warning: this update is a large change. Press ^C within 5 seconds to abort ++ wc -l ++ run_sched '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' ++ vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex task run example/vagrant/test/flask_example '\''pwd'\''' + runlen=' 2' + test 2 -eq 2 + run_sched '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex quota get example/vagrant' Allocated: CPU: 0.0 RAM: 0.00 GB Disk: 0.000000 GB Production resources consumed: CPU: 0.0 RAM: 0.00 GB Disk: 0.00 GB Non-production resources consumed: CPU: 2.0 RAM: 0.125000 GB Disk: 0.187500 GB + run_sched '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + vagrant ssh aurora-scheduler -c '/vagrant/deploy_test/aurorav2.pex job killall example/vagrant/test/flask_example' + RETCODE=0 + collect_result + [[ 0 = 0 ]] + echo '***' *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 Thanks, Mark Chu-Carroll
Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/ --- (Updated May 12, 2014, 8:15 a.m.) Review request for Aurora, Dave Lester and Tom Galloway. Changes --- Address Joe's comments. Bugs: aurora-253 https://issues.apache.org/jira/browse/aurora-253 Repository: aurora Description --- Add an updated version of the clientv2 doc to apache. (Also make a few changes in the interfaces to match the updated doc.) Diffs (updated) - docs/clientv2.md PRE-CREATION src/main/python/apache/aurora/client/cli/__init__.py 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44 Diff: https://reviews.apache.org/r/18979/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/#review42682 --- docs/clientv2.md <https://reviews.apache.org/r/18979/#comment76500> No, it's part of the paragraph for the previous bullet. docs/clientv2.md <https://reviews.apache.org/r/18979/#comment76501> Good point; killall didn't exist when I wrote this doc! docs/clientv2.md <https://reviews.apache.org/r/18979/#comment76502> It does use updateconfig. The semantics are exactly the same as the original update command. docs/clientv2.md <https://reviews.apache.org/r/18979/#comment76503> Strange - that all looks fine in my editor. I'm wiping all the indents and retyping them; guessing some tab characters accidentally got inserted. - Mark Chu-Carroll On March 21, 2014, 1:58 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18979/ > --- > > (Updated March 21, 2014, 1:58 p.m.) > > > Review request for Aurora, Dave Lester and Tom Galloway. > > > Bugs: aurora-253 > https://issues.apache.org/jira/browse/aurora-253 > > > Repository: aurora > > > Description > --- > > Add an updated version of the clientv2 doc to apache. > > (Also make a few changes in the interfaces to match the updated doc.) > > > Diffs > - > > docs/clientv2.md PRE-CREATION > src/main/python/apache/aurora/client/cli/__init__.py > 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 > src/main/python/apache/aurora/client/cli/jobs.py > 3b327df5f9c5f1d5e7e68863191313921a8dde44 > > Diff: https://reviews.apache.org/r/18979/diff/ > > > Testing > --- > > n/a > > > Thanks, > > Mark Chu-Carroll > >
Re: Review Request 21223: Bugfix: make "restart" command generate a correct error message in some cases.
test-2.5.2 plugins: cov collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . === 1 passed in 0.45 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py == 12 passed in 0.44 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.41 seconds === Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21273/#review42833 --- ping? (just trying to get this back into the mail queue.) - Mark Chu-Carroll On May 9, 2014, 2:05 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21273/ > --- > > (Updated May 9, 2014, 2:05 p.m.) > > > Review request for Aurora, David McLaughlin and Suman Karumuri. > > > Bugs: aurora-403 > https://issues.apache.org/jira/browse/aurora-403 > > > Repository: aurora > > > Description > --- > > Add a "config" noun with a "list" verb to list jobs defined in a config file. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/BUILD > 0c5a8c5cd11ad29b43027c0556710018b6ee3adc > src/main/python/apache/aurora/client/cli/client.py > f7bafca8285ba5779ee185273d4843995a241b70 > src/main/python/apache/aurora/client/cli/config.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > 9766b3bdd0f5f552349453b6724573d43ddb02e5 > src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION > > Diff: https://reviews.apache.org/r/21273/diff/ > > > Testing > --- > > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 passed in 0.04 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 9 items > > src/test/python/apache/aurora/client/cli/test_command_hooks.py . > > === 9 passed in 0.80 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > === 5 passed in 0.65 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 37 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py .. > src/test/python/apache/aurora/client/cli/test_open.py . > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ... > src/test/python/apache/aurora/client/cli/test_update.py ... > > == 37 passed in 2.10 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 3 items > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > > === 3 passed in 0.66 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 1 items > > src/test/python/apache/aurora/client/cli/test_logging.py . > > === 1 passed in 0.67 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 3 items > > src/test/python/apache/aurora/client/cli/test_plugins.py ... > > === 3 passed in 0.73 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 4 items > > src/test/python/apache/aurora/client/cli/test_quota.p
Re: Review Request 21205: Bugfix: restart doesn't notify user about invalid max_total_failures option.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21205/#review42832 --- Suman, ping? - Mark Chu-Carroll On May 8, 2014, 10:26 a.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21205/ > --- > > (Updated May 8, 2014, 10:26 a.m.) > > > Review request for Aurora, David McLaughlin and Suman Karumuri. > > > Bugs: aurora-399 > https://issues.apache.org/jira/browse/aurora-399 > > > Repository: aurora > > > Description > --- > > Bugfix: restart doesn't notify user about invalid max_total_failures option. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/jobs.py > cf45640a66c76ae4daa0ceaa3ff8da80c4cbe91d > src/main/python/apache/aurora/client/commands/core.py > 0046c7686261ec11c2064348e21a35758b449d27 > src/test/python/apache/aurora/client/cli/test_restart.py > 9b7a2c69b53d4be35587f630f429943a4907b74b > src/test/python/apache/aurora/client/commands/test_restart.py > 9af6334264f40cbccbef545bd15ffa85171ad348 > > Diff: https://reviews.apache.org/r/21205/diff/ > > > Testing > --- > > [sun-wukong incubator-aurora (restart_max)]$ ./pants > src/test/python/apache/aurora/client:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) > == test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 2 items > > src/test/python/apache/aurora/client/test_binding_helper.py .. > > === 2 passed in 0.36 seconds > > == test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 6 items > > src/test/python/apache/aurora/client/test_config.py .. > > === 6 passed in 0.45 seconds > > == test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 6 items > > src/test/python/apache/aurora/client/api/test_disambiguator.py .. > > === 6 passed in 0.41 seconds > > == test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 4 items > > src/test/python/apache/aurora/client/api/test_job_monitor.py > > === 4 passed in 0.39 seconds > > == test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 6 items > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > === 6 passed in 0.34 seconds > > == test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 47 items / 1 skipped > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > ... > > = 47 passed, 1 skipped in 4.05 seconds > == > == test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 12 items > > src/test/python/apache/aurora/client/api/test_instance_watcher.py > src/test/python/apache/aurora/client/api/test_health_check.py > > === 12 passed in 0.22 seconds > === > == test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 28 items > > src/test/pyt
Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.
> On May 13, 2014, 12:46 p.m., David McLaughlin wrote: > > src/main/python/apache/aurora/client/cli/config.py, lines 21-23 > > <https://reviews.apache.org/r/21273/diff/1/?file=577370#file577370line21> > > > > Is it just me or a lot of these imports unused? No, you're absolutely right. I started the file with a cut-and-paste, and then didn't go back and clean up the imports. Doing it now. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21273/#review42836 ------- On May 9, 2014, 2:05 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21273/ > --- > > (Updated May 9, 2014, 2:05 p.m.) > > > Review request for Aurora, David McLaughlin and Suman Karumuri. > > > Bugs: aurora-403 > https://issues.apache.org/jira/browse/aurora-403 > > > Repository: aurora > > > Description > --- > > Add a "config" noun with a "list" verb to list jobs defined in a config file. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/BUILD > 0c5a8c5cd11ad29b43027c0556710018b6ee3adc > src/main/python/apache/aurora/client/cli/client.py > f7bafca8285ba5779ee185273d4843995a241b70 > src/main/python/apache/aurora/client/cli/config.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > 9766b3bdd0f5f552349453b6724573d43ddb02e5 > src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION > > Diff: https://reviews.apache.org/r/21273/diff/ > > > Testing > --- > > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py > > === 4 passed in 0.04 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 9 items > > src/test/python/apache/aurora/client/cli/test_command_hooks.py . > > === 9 passed in 0.80 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py . > > === 5 passed in 0.65 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 37 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py .. > src/test/python/apache/aurora/client/cli/test_open.py . > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ... > src/test/python/apache/aurora/client/cli/test_update.py ... > > == 37 passed in 2.10 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 3 items > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > > === 3 passed in 0.66 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 1 items > > src/test/python/apache/aurora/client/cli/test_logging.py . > > === 1 passed in 0.67 seconds > === > = test session starts > == > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 3 items > > src/test/python/apache/aurora/client/cli/t
Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.
client/cli/BUILD:all)]) src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: aurora-417 https://issues.apache.org/jira/browse/aurora-417 Repository: aurora Description --- Add cron schedule and deschedule calls to the scheduler API. Diffs - src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 226b71ce7749492abd3e1d673382668c9011a1c8 src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java f33059904fb5f6fc18a3a66dfe63c059008affe3 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9bb5c255e1118038b953fc72f0a074d461ba1fb5 src/main/thrift/org/apache/aurora/gen/api.thrift 66292dc0369941fc62719d49209edc07adc81a53 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java da6c0ff1bdfaefef2f72ad2559f4059cd44612b6 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 933a56bf3f7165fa84aedcc8d1392e32824fd487 Diff: https://reviews.apache.org/r/21383/diff/ Testing --- Ran all tests with gradlew; no errors. (Includes two new tests, that ensure that calling the new APIs causes the right internal cron methods to be called.) Thanks, Mark Chu-Carroll
Re: Review Request 21205: Bugfix: restart doesn't notify user about invalid max_total_failures option.
/test/python/apache/aurora/client/hooks/test_hooked_api.py === 12 passed in 0.44 seconds === == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.41 seconds src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (restart_max)] $ Thanks, Mark Chu-Carroll
Re: Review Request 21170: Make the "task run" command accept an instances spec.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21170/ --- (Updated May 13, 2014, 3:33 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Changes --- Rebase to master. Bugs: aurora-198 https://issues.apache.org/jira/browse/aurora-198 Repository: aurora Description --- Make the "task run" command accept an instances spec. Also, add a subclass of DistributedCommandRunner that takes an instance list, and runs a command only on the specific task instances in that list. Diffs (updated) - src/main/python/apache/aurora/client/api/command_runner.py 14f8e454ac6b8fe2c2925f834d0761c053eea337 src/main/python/apache/aurora/client/cli/options.py bf86c3abe218d28b13a6d1bc25abe4f48e999b92 src/main/python/apache/aurora/client/cli/task.py 1253ece196413075c86840b633c61ebd2188a2fc src/test/python/apache/aurora/client/cli/test_task_run.py c60189ca74bcd7152209430537ea2790e6db8457 Diff: https://reviews.apache.org/r/21170/diff/ Testing --- [sun-wukong incubator-aurora (run_with_instances)]$ ./pants src/test/python/apache/aurora/client/cli:task Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/cli/BUILD:task)]) == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 3 items src/test/python/apache/aurora/client/cli/test_task_run.py ... 3 passed in 0.64 seconds src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (run_with_instances)]$ Thanks, Mark Chu-Carroll
Re: Review Request 21354: Fixed duration calculation in the job page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21354/#review42872 --- Ship it! Ship It! - Mark Chu-Carroll On May 12, 2014, 8:58 p.m., Suman Karumuri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21354/ > --- > > (Updated May 12, 2014, 8:58 p.m.) > > > Review request for Aurora, David McLaughlin and Mark Chu-Carroll. > > > Bugs: AURORA-411 > https://issues.apache.org/jira/browse/AURORA-411 > > > Repository: aurora > > > Description > --- > > Fixed duration calculation in the job page. > > > Diffs > - > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js > 768c4fe0db2813c50400370390a34cd428f88df5 > > Diff: https://reviews.apache.org/r/21354/diff/ > > > Testing > --- > > Tested locally on laptop. Attached screenshot. > > > File Attachments > > > Now showing correct duration > > https://reviews.apache.org/media/uploaded/files/2014/05/13/f3afd556-c062-4829-ba9c-cd30d04b74fc__Screen_Shot_2014-05-12_at_5.49.51_PM.png > > > Thanks, > > Suman Karumuri > >
Review Request 21170: Make the "task run" command accept an instances spec.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21170/ --- Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-198 https://issues.apache.org/jira/browse/aurora-198 Repository: aurora Description --- Make the "task run" command accept an instances spec. Also, add a subclass of DistributedCommandRunner that takes an instance list, and runs a command only on the specific task instances in that list. Diffs - src/main/python/apache/aurora/client/api/command_runner.py 1af6a782d6c0c419702ebfe0935eebbba0ea888a src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5 src/main/python/apache/aurora/client/cli/task.py a162b86e465991f14160ceff465ddd7d110b57a3 src/test/python/apache/aurora/client/cli/test_task_run.py fba812efc2292be3d66cb821f0877b60afa28072 Diff: https://reviews.apache.org/r/21170/diff/ Testing --- [sun-wukong incubator-aurora (run_with_instances)]$ ./pants src/test/python/apache/aurora/client/cli:task Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/cli/BUILD:task)]) == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 3 items src/test/python/apache/aurora/client/cli/test_task_run.py ... 3 passed in 0.64 seconds src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (run_with_instances)]$ Thanks, Mark Chu-Carroll
Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/ --- (Updated May 14, 2014, 10:39 a.m.) Review request for Aurora, David McLaughlin and Bill Farner. Changes --- Fix python scheduler client test. Bugs: aurora-417 https://issues.apache.org/jira/browse/aurora-417 Repository: aurora Description --- Add cron schedule and deschedule calls to the scheduler API. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 226b71ce7749492abd3e1d673382668c9011a1c8 src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java f33059904fb5f6fc18a3a66dfe63c059008affe3 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9bb5c255e1118038b953fc72f0a074d461ba1fb5 src/main/thrift/org/apache/aurora/gen/api.thrift 66292dc0369941fc62719d49209edc07adc81a53 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java da6c0ff1bdfaefef2f72ad2559f4059cd44612b6 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 933a56bf3f7165fa84aedcc8d1392e32824fd487 src/test/python/apache/aurora/client/api/test_scheduler_client.py 399d4c614dda93ae0e7d8f38a02379bc0f42e4af Diff: https://reviews.apache.org/r/21383/diff/ Testing --- Ran all tests with gradlew; no errors. (Includes two new tests, that ensure that calling the new APIs causes the right internal cron methods to be called.) Thanks, Mark Chu-Carroll
Re: Review Request 21294: Only serve thrift over HTTP.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21294/#review43002 --- Ship it! Ship It! - Mark Chu-Carroll On May 9, 2014, 8:50 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21294/ > --- > > (Updated May 9, 2014, 8:50 p.m.) > > > Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim > Khutornenko. > > > Bugs: AURORA-342 > https://issues.apache.org/jira/browse/AURORA-342 > > > Repository: aurora > > > Description > --- > > Only serve thrift over HTTP. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java > c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8 > src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java > 5b55e941d8efb17fd8740614d8f67cea3931e2c5 > src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java > bb93be365cfe4f85433e6055290f39723735bd70 > src/main/python/apache/aurora/client/api/scheduler_client.py > b298d8f310b9e977d74c35a064554bc6d5ee563c > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > ddbb02560bb8fb94dafe26c1a66c767e9a3a863b > src/test/python/apache/aurora/client/api/test_scheduler_client.py > 2736d67e8c47c3ec8d32336aee9fd8cdf3eabc6d > src/test/python/apache/aurora/client/cli/BUILD > c0492cc41c5e253fb3a38e347081fe9ef68f3426 > src/test/resources/org/apache/aurora/scheduler/app/AuroraTestKeyStore > 1157471621099e296fef156dd49569cd9f47e3c1 > > Diff: https://reviews.apache.org/r/21294/diff/ > > > Testing > --- > > I also fixed a bad BUILD reference that was causing python tests to fail. > > vagrant up > bash examples/vagrant/test_tutorial.sh > > > bash build-support/jenkins/build.sh > > > Thanks, > > Bill Farner > >
Re: Review Request 21440: Implementing parallel updater
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43004 --- src/main/python/apache/aurora/client/api/instance_watcher.py <https://reviews.apache.org/r/21440/#comment76988> Doc comment please. It's not clear reading this just what "terminating" or "terminate" means. It would be a huge help to just put a couple of words here. src/main/python/apache/aurora/client/api/updater.py <https://reviews.apache.org/r/21440/#comment76989> Why? src/main/python/apache/aurora/client/api/updater.py <https://reviews.apache.org/r/21440/#comment76990> It took me several readthroughs to figure out what this was doing. Is there maybe a clearer way of writing this? src/main/python/apache/aurora/client/api/updater.py <https://reviews.apache.org/r/21440/#comment76992> What is this supposed to return? src/test/python/apache/aurora/client/api/test_updater.py <https://reviews.apache.org/r/21440/#comment76995> Doesn't this mean that the test will be running with just one thread? That will serialize everything, which will mask a lot of potential error cases. - Mark Chu-Carroll On May 14, 2014, 2:49 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21440/ > --- > > (Updated May 14, 2014, 2:49 p.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-350 > https://issues.apache.org/jira/browse/AURORA-350 > > > Repository: aurora > > > Description > --- > > The updater now spawns upto batch_size threads to process one instance per > thread. > > All mutating calls are multiplexed by the SchedulerMux to do batch > kill/add/restart calls. This is the first step towards a fully multiplexed > SchedulerProxy and is intended to mitigate LDAP/scheduler load. > > > Diffs > - > > src/main/python/apache/aurora/client/api/instance_watcher.py > 8992b93d25ce71b5784bad24429fd32356f64763 > src/main/python/apache/aurora/client/api/job_monitor.py > a27f6fbbf38e981f259aea35c9bf979d2d9b1b87 > src/main/python/apache/aurora/client/api/scheduler_client.py > ff5d2bc52af75ff2d2eee2d9b72c8d9a0df12581 > src/main/python/apache/aurora/client/api/updater.py > e8692ea4fdf924fb1ea06803d5e7321340754442 > src/main/python/apache/aurora/client/api/updater_util.py > 5ea96cd2797c4957d05168fb7ba9f950fd82bbbf > src/test/python/apache/aurora/client/api/test_updater.py > 03a14186646daede689ac77e2ab7144aa5a7fa14 > src/test/python/apache/aurora/client/cli/test_update.py > a357c44c87065474bce47fa403ddd72625da072d > src/test/python/apache/aurora/client/cli/util.py > 9d51a2e1fe961d4b522ac5b70f0737130326abe9 > src/test/python/apache/aurora/client/commands/test_update.py > 0b1e3498311d946631452e45ea2c7edb100dc43c > src/test/python/apache/aurora/client/commands/util.py > fc9e2f17537e1e731381b825ac4b5646e5130654 > src/test/python/apache/aurora/client/fake_scheduler_proxy.py > 6a1f78b97d67adab0cf00acc31f20c5d6197a508 > src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora > ad5aafec1f796baef766ed12b2a597f26997d5b3 > src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora > 6d54463c349699946c2063385b1bd38a0f8c9e58 > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > c8fa07a5426c6c7748412062c26996b84637efb3 > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > 3c4165c8464b42f7f5dc4f94a079ff7c3086cdbc > > Diff: https://reviews.apache.org/r/21440/diff/ > > > Testing > --- > > ./pants src/test/python:all > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Maxim Khutornenko > >
Review Request 21223: Bugfix: make "restart" command generate a correct error message in some cases.
est_ssh.py . === 1 passed in 0.45 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py == 12 passed in 0.44 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.41 seconds === Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 21188: Fix broken test build.
-- pytest-2.5.2 plugins: cov collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . = 1 passed in 0.45 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py 12 passed in 0.45 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py = 4 passed in 0.41 seconds = src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Review Request 21188: Fix broken test build.
passed in 0.45 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py 12 passed in 0.45 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py = 4 passed in 0.41 seconds = src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Review Request 21268: Add a "config" noun with a "list" verb to list jobs defined in a config file.
python/finders.py", line 203, in find_wheels_in_zip dist = wheel_from_metadata(path_item, metadata) File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/finders.py", line 165, in wheel_from_metadata pkg_info = Parser().parsestr(metadata.get_metadata(pkg_resources.DistInfoDistribution.PKG_INFO)) File "/Users/mchucarroll/Code/incubator-aurora/build-support/pants-0.0.23.pex/.bootstrap/pkg_resources.py", line 1361, in get_metadata return self._get(self._fn(self.egg_info,name)) File "/Users/mchucarroll/Code/incubator-aurora/build-support/pants-0.0.23.pex/.bootstrap/pkg_resources.py", line 1425, in _get return self.loader.get_data(path) ZipImportError: bad local file header in /Users/mchucarroll/Code/incubator-aurora/.pants.d/python/eggs/thrift-0.9.1-cp26-none-macosx_10_9_intel.whl Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . EXCEPTION Thanks, Mark Chu-Carroll
Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/ --- (Updated May 15, 2014, 12:02 p.m.) Review request for Aurora and Joe Smith. Bugs: aurora-253 https://issues.apache.org/jira/browse/aurora-253 Repository: aurora Description --- Add an updated version of the clientv2 doc to apache. (Also make a few changes in the interfaces to match the updated doc.) Diffs - docs/clientv2.md PRE-CREATION src/main/python/apache/aurora/client/cli/__init__.py 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44 Diff: https://reviews.apache.org/r/18979/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 21273: Add a "config" noun with a "list" verb to list jobs defined in a config file.
. SUCCESS src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
