Re: Review Request 31418: Add admin port support in mname.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31418/ --- (Updated Feb. 25, 2015, 5:48 p.m.) Review request for Aurora and Bill Farner. Summary (updated) - Add admin port support in mname. Repository: aurora Description --- Add admin port support in Mname. Diffs - src/main/java/org/apache/aurora/scheduler/http/Mname.java 69ce2aa3bcb494997fb655a1b51585aebc28f235 src/test/java/org/apache/aurora/scheduler/http/MnameTest.java afa83f2c6f8b03fbd869c8e5c4d81b27a0cc5be5 Diff: https://reviews.apache.org/r/31418/diff/ Testing --- Thanks, Tony Dong
Review Request 31418: Add admin port support in Mname.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31418/ --- Review request for Aurora. Repository: aurora Description --- Add admin port support in Mname. Diffs - src/main/java/org/apache/aurora/scheduler/http/Mname.java 69ce2aa3bcb494997fb655a1b51585aebc28f235 src/test/java/org/apache/aurora/scheduler/http/MnameTest.java afa83f2c6f8b03fbd869c8e5c4d81b27a0cc5be5 Diff: https://reviews.apache.org/r/31418/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
On Dec. 12, 2014, 4:52 p.m., Jay Buffington wrote: This is *awesome*. Using docker to do aurora builds in and to ship an aurora runtime is fantastic. My major issue with this commit is that you're unnecessarily putting build dependencies (aurora source, python-dev, git, etc) into a runtime container. I suggest a slightly different approach than you've taken here: there should be two Dockerfiles: one for build and one for runtime. Also, I don't think they should be examples, let's hook docker up to the CI process and ship a runnable docker image for every commit of aurora! The build Dockerfile should produce a docker image which we can run the build in. It will contain all build time dependencies (gradle, python-dev, etc). When a developer wants to do the build they will simply run docker run aurora/build This will use volume mounts to import the code into the container and will write out a number of jar and pex files back to the developer's workspace. This is really useful because now we have a programatic way (in the Dockerfile) to express *all* build time dependencies. To build a runtime container, we ship another Dockerfile which installs all the runtime deps (java 1.7, etc) and uses Dockerfile's ADD to copy the jar and pex files from the developer's workspace into the container. We run build this docker container on every commit through a CI process and ship it to a docker registry. Then to run, users just have to do docker run aurora/aurora Thanks for the feedback, I agree with your concerns and I'll try to rework the docker builds when I get some time to do so. As we improve some of our deploy processes, i.e. deploying new builds of Aurora, I'll get a chance to work on this again. - Tony --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review64919 --- On Dec. 11, 2014, 6:32 p.m., Tony Dong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Dec. 11, 2014, 6:32 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, Bill Farner, and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Dec. 11, 2014, 6:32 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, Bill Farner, and Zameer Manji. Changes --- reviewers += wfarner Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
On Nov. 21, 2014, 9:12 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, line 30 https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line30 We should expose the mesos-master (5050), mesos-slave (5051), and thermos-observer (1338) UIs too. And possibly ZooKeeper (2181)? Done On Nov. 21, 2014, 9:12 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, line 16 https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line16 I'm ignorant here - is there a way we can reuse the existing aurorabuild script here? It wasn't really working for me. I can investigate more into it, but I mostly just moved straight to Docker. - Tony --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62640 --- On Nov. 19, 2014, 6:02 p.m., Tony Dong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 6:02 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 25, 2014, 7:37 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs (updated) - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
On Nov. 25, 2014, 7:43 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, line 35 https://reviews.apache.org/r/28198/diff/3/?file=775982#file775982line35 Presumably we're not all going to use your zookeeper ensemble? oh oops... sorry I had it in my local version and forgot to delete it from the version I wanted to contribute. - Tony --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review63027 --- On Nov. 25, 2014, 7:37 p.m., Tony Dong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 25, 2014, 7:37 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 25, 2014, 7:47 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs (updated) - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
On Nov. 25, 2014, 8:49 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, lines 14-16 https://reviews.apache.org/r/28198/diff/4/?file=776032#file776032line14 Can we avoid the extra clone here and build from the currently checked out repo? That way this script is likely to stay maintained in the future and might even make it into our development workflow. If that's not possible then as far as I know this sha has no special significance, maybe replace it with a download of the 0.6.0 release? What do you mean by the currently checked out repo? do you mean head? I just picked that sha because it's the one before my change. I was thinking of using 0.6.0 but there was no tag, I can use 0.6.0-rc0 branch if that works. On Nov. 25, 2014, 8:49 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, line 34 https://reviews.apache.org/r/28198/diff/4/?file=776032#file776032line34 Should we also add the upstart configs from the vagrant example to the container? How about documentation for running - can I do something similar to vagrant up and get a full cluster-in-a-box? I'm still in the process of getting a cluster-in-a-box running, so far I've just been copying the pex and libs out into my existing machine. I haven't really prioritized figuring out how to run everything from the docker container, it's something I'll work on in the future. - Tony --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review63040 --- On Nov. 25, 2014, 7:47 p.m., Tony Dong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 25, 2014, 7:47 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
On Nov. 19, 2014, 6:32 p.m., Zameer Manji wrote: examples/docker/Dockerfile, line 13 https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line13 Since we are not checking out a specific version this will break once aurora updates to a new version of mesos and the given mesos egg is not new enough. Kevin Sweeney wrote: Can we copy the current worktree here instead of taking an arbitrary future master? I'll use 6d06d8639a92b8be034a0ee0b1815ea318508e35 because it's the commit my head was on, unless someone has another suggest commit. - Tony --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62185 --- On Nov. 19, 2014, 6:02 p.m., Tony Dong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 6:02 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 4 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Review Request 28198: Add an example on how to build with Docker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- Review request for Aurora. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 12:35 a.m.) Review request for Aurora and Benjamin Staffin. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62079 --- @ReviewBot retry - Tony Dong On Nov. 19, 2014, 12:35 a.m., Tony Dong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 12:35 a.m.) Review request for Aurora and Benjamin Staffin. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Re: Review Request 28198: Add an example on how to build with Docker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 12:54 a.m.) Review request for Aurora, Benjamin Staffin and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
