Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41384
---


Should the documentation for this feature be part of this review? 


src/main/python/apache/aurora/client/cli/__init__.py


Why error codes rather than exceptions?



src/main/python/apache/aurora/client/cli/command_hooks.py


@abstractmethod



- David McLaughlin


On April 24, 2014, 7:30 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 24, 2014, 7:30 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> === 1 passed in 0.62 seconds

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41420
---



src/main/python/apache/aurora/client/cli/__init__.py


Different cases.

A command hook can signal that a command shouldn't be executed, and return 
the exit code that should be returned to the shell. It's intended to signal 
that there wasn't an error executing the hook, but that the hook requested that 
the command be aborted. 

The hook can also signal an exception, which means that there was an error 
in the hook.




src/main/python/apache/aurora/client/cli/command_hooks.py


d'oh.


- Mark Chu-Carroll


On April 24, 2014, 3:30 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 24, 2014, 3:30 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ===

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/
---

(Updated April 24, 2014, 8:17 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Add missing @abstracmethod.


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

Stage 1 of implementing command hooks for aurora v2.

This change includes:
(1) The ability to add hard-wired hooks, by registering them in 
ConfigurationPlugins
  compiled into a pex;
(2) Dynamically loaded plugins, loaded from plugin files.

The dynamically loaded plugins are *not* currently active outside of tests.

The second stage of this change will activate dynamically loaded plugins, and
provide a mechanism to allow privileged users to override hooks.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
17cdc287875b5f0832064a6441f33fc9837fc79b 
  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 
  src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
0534bdf72a332caa606dd3a7ca743a59e03738ef 
  src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
34fdb47baa647b9c3bd149ff2710b175c7435dae 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20687/diff/


Testing
---

[sun-wukong incubator-aurora (command_hooks)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.03 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py 

=== 4 passed in 0.58 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.52 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 1.87 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.62 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=== 2 passed in 0.53 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py 

=== 4 passed in 0.55 seconds 
===

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin 


> On April 25, 2014, 12:15 a.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 344
> > 
> >
> > Different cases.
> > 
> > A command hook can signal that a command shouldn't be executed, and 
> > return the exit code that should be returned to the shell. It's intended to 
> > signal that there wasn't an error executing the hook, but that the hook 
> > requested that the command be aborted. 
> > 
> > The hook can also signal an exception, which means that there was an 
> > error in the hook.
> >

I think exceptions are designed for exactly this... the hook authors can also 
give their own error messages. 


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41420
---


On April 25, 2014, 12:17 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 25, 2014, 12:17 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> =

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin 


> On April 25, 2014, 12:15 a.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 344
> > 
> >
> > Different cases.
> > 
> > A command hook can signal that a command shouldn't be executed, and 
> > return the exit code that should be returned to the shell. It's intended to 
> > signal that there wasn't an error executing the hook, but that the hook 
> > requested that the command be aborted. 
> > 
> > The hook can also signal an exception, which means that there was an 
> > error in the hook.
> >
> 
> David McLaughlin wrote:
> I think exceptions are designed for exactly this... the hook authors can 
> also give their own error messages.

I'm not sure I understand why the distinction between an error in the hook and 
a request to stop the command is important. Why not just ask the hook to throw 
a special exception type? If you're adamant about error codes, how would they 
give a reason for preventing the command running?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41420
---


On April 25, 2014, 12:17 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 25, 2014, 12:17 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/a

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread Mark Chu-Carroll 


> On April 24, 2014, 8:15 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 344
> > 
> >
> > Different cases.
> > 
> > A command hook can signal that a command shouldn't be executed, and 
> > return the exit code that should be returned to the shell. It's intended to 
> > signal that there wasn't an error executing the hook, but that the hook 
> > requested that the command be aborted. 
> > 
> > The hook can also signal an exception, which means that there was an 
> > error in the hook.
> >
> 
> David McLaughlin wrote:
> I think exceptions are designed for exactly this... the hook authors can 
> also give their own error messages.
> 
> David McLaughlin wrote:
> I'm not sure I understand why the distinction between an error in the 
> hook and a request to stop the command is important. Why not just ask the 
> hook to throw a special exception type? If you're adamant about error codes, 
> how would they give a reason for preventing the command running?

I still think that there's an important difference between an error, and a 
normal return.

Hook writers can opt to just use exceptions, and the code will handle it 
correctly if they do. But the plugin code is supposed to look as much as 
possible like it's running as part of a verb implementation. Verbs return 
status codes to the shell when they finish; this is following the same model.

The design doc that we ran by the team and the dev mailing list specified this 
behavior, and I'm still not seeing why it should be removed.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41420
---


On April 24, 2014, 8:17 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 24, 2014, 8:17 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> ===

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41510
---

Ship it!


Ship It!

- David McLaughlin


On April 25, 2014, 12:17 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 25, 2014, 12:17 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> === 1 passed in 0.62 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
> 
> ==

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread Mark Chu-Carroll 
Thanks for doing this so quickly!


On Fri, Apr 25, 2014 at 3:31 PM, David McLaughlin wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
>
> Ship it!
>
> Ship It!
>
>
> - David McLaughlin
>
> On April 25th, 2014, 12:17 a.m. UTC, Mark Chu-Carroll wrote:
>   Review request for Aurora, David McLaughlin and Suman Karumuri.
> By Mark Chu-Carroll.
>
> *Updated April 25, 2014, 12:17 a.m.*
>  *Bugs: * aurora-270 
>  *Repository: * aurora
> Description
>
> Stage 1 of implementing command hooks for aurora v2.
>
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
>
> The dynamically loaded plugins are *not* currently active outside of tests.
>
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
>
>   Testing
>
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py 
>
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
>
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .
>
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/cli/test_logging.py .
>
> === 1 passed in 0.62 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> === 2 passed in 0.53 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py 
>
> === 4 passed in 0.55 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .
>
> === 5 passed in 0.56 seconds 
> ===
> = te

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-28 Thread Suman Karumuri 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41612
---



src/main/python/apache/aurora/client/cli/__init__.py


Refactor this code into a separate function.



src/main/python/apache/aurora/client/cli/__init__.py


refactoring this logic like _run_pre_command into a separate function will 
improve the readability further.



src/main/python/apache/aurora/client/cli/__init__.py


Shouldn't this be logged as logging.ERROR?



src/main/python/apache/aurora/client/cli/__init__.py


Add a new line before the try block.

Also, this method is too big, consider refactoring this method into smaller 
methods. I think it will also improve the testability of this code.



src/main/python/apache/aurora/client/cli/command_hooks.py


Please add a class doc here.



src/main/python/apache/aurora/client/cli/command_hooks.py


should the name be prefixed with a . or make the name all caps?



src/main/python/apache/aurora/client/cli/command_hooks.py


Include more doc about what a hooks file is. Is it a python file? Can it be 
any python file? A pointer to a sample file will he helpful here.



src/main/python/apache/aurora/client/cli/command_hooks.py


I think we should resolve this before we ship this change.



src/main/python/apache/aurora/client/cli/command_hooks.py


change to print_err?



src/main/python/apache/aurora/client/cli/command_hooks.py


inline



src/main/python/apache/aurora/client/cli/command_hooks.py


inline



src/test/python/apache/aurora/client/cli/test_command_hooks.py


Is it possible to add a file that has compile and execution errors to test? 
Ensuring that the logging and error handling works as expected will simplify 
writing and debugging hooks.


- Suman Karumuri


On April 25, 2014, 12:17 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 25, 2014, 12:17 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> =

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-28 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41616
---



src/main/python/apache/aurora/client/cli/__init__.py


No. This logging is for the log server; from the perspective of the log 
server, this is a routine, acceptable event. It was an error for the user, but 
not an error for the system.




src/main/python/apache/aurora/client/cli/command_hooks.py


No, neither. We're following the model of Vagrantfile or Makefile. Hooks 
affect the behavior of the system, so they should not be hidden.




src/main/python/apache/aurora/client/cli/command_hooks.py


Can't. print_err is a context method. There is no context here.




src/main/python/apache/aurora/client/cli/command_hooks.py


Can't.

These two variables are used for visible side-effects - we need to have 
variable to reference them after the exec returns.



- Mark Chu-Carroll


On April 24, 2014, 8:17 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 24, 2014, 8:17 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apa

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-28 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/
---

(Updated April 28, 2014, 3 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Address most of Suman's review comments.
(Haven't updated the tests yet; trying to figure out how to do that without 
mock-a-palooza.
Maybe that can wait until the second half of the command-hooks impl?)


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

Stage 1 of implementing command hooks for aurora v2.

This change includes:
(1) The ability to add hard-wired hooks, by registering them in 
ConfigurationPlugins
  compiled into a pex;
(2) Dynamically loaded plugins, loaded from plugin files.

The dynamically loaded plugins are *not* currently active outside of tests.

The second stage of this change will activate dynamically loaded plugins, and
provide a mechanism to allow privileged users to override hooks.


Diffs (updated)
-

  docs/design/command-hooks.md PRE-CREATION 
  src/main/python/apache/aurora/client/cli/BUILD 
17cdc287875b5f0832064a6441f33fc9837fc79b 
  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 
  src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
0534bdf72a332caa606dd3a7ca743a59e03738ef 
  src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
34fdb47baa647b9c3bd149ff2710b175c7435dae 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20687/diff/


Testing
---

[sun-wukong incubator-aurora (command_hooks)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.03 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py 

=== 4 passed in 0.58 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.52 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 1.87 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.62 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=== 2 passed in 0.53 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-28 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/
---

(Updated April 28, 2014, 3:01 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Responding to review comments.


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

Stage 1 of implementing command hooks for aurora v2.

This change includes:
(1) The ability to add hard-wired hooks, by registering them in 
ConfigurationPlugins
  compiled into a pex;
(2) Dynamically loaded plugins, loaded from plugin files.

The dynamically loaded plugins are *not* currently active outside of tests.

The second stage of this change will activate dynamically loaded plugins, and
provide a mechanism to allow privileged users to override hooks.


Diffs
-

  docs/design/command-hooks.md PRE-CREATION 
  src/main/python/apache/aurora/client/cli/BUILD 
17cdc287875b5f0832064a6441f33fc9837fc79b 
  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 
  src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
0534bdf72a332caa606dd3a7ca743a59e03738ef 
  src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
34fdb47baa647b9c3bd149ff2710b175c7435dae 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20687/diff/


Testing
---

[sun-wukong incubator-aurora (command_hooks)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.03 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py 

=== 4 passed in 0.58 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.52 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 1.87 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.62 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=== 2 passed in 0.53 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py 

=== 4 passed in 0.55 seconds 
==

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-28 Thread Suman Karumuri 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41669
---


lgtm. Please cut a separate ticket for the tests.

The only ship it blocker is answer to 2.6 compatibility? 

- Suman Karumuri


On April 28, 2014, 7:01 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 28, 2014, 7:01 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   docs/design/command-hooks.md PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> === 1 passed in 0.62 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Pytho

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/
---

(Updated April 29, 2014, 10:27 a.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Address Suman's reviews.


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

Stage 1 of implementing command hooks for aurora v2.

This change includes:
(1) The ability to add hard-wired hooks, by registering them in 
ConfigurationPlugins
  compiled into a pex;
(2) Dynamically loaded plugins, loaded from plugin files.

The dynamically loaded plugins are *not* currently active outside of tests.

The second stage of this change will activate dynamically loaded plugins, and
provide a mechanism to allow privileged users to override hooks.


Diffs (updated)
-

  docs/design/command-hooks.md PRE-CREATION 
  src/main/python/apache/aurora/client/cli/BUILD 
17cdc287875b5f0832064a6441f33fc9837fc79b 
  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 
  src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
0534bdf72a332caa606dd3a7ca743a59e03738ef 
  src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
34fdb47baa647b9c3bd149ff2710b175c7435dae 
  
src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks 
PRE-CREATION 
  
src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks 
PRE-CREATION 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20687/diff/


Testing
---

[sun-wukong incubator-aurora (command_hooks)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.03 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py 

=== 4 passed in 0.58 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.52 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 1.87 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.62 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=== 2 passed in 0.53 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/
---

(Updated April 29, 2014, 12:47 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Use twitter.common.lang.Compatibility for exec.


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

Stage 1 of implementing command hooks for aurora v2.

This change includes:
(1) The ability to add hard-wired hooks, by registering them in 
ConfigurationPlugins
  compiled into a pex;
(2) Dynamically loaded plugins, loaded from plugin files.

The dynamically loaded plugins are *not* currently active outside of tests.

The second stage of this change will activate dynamically loaded plugins, and
provide a mechanism to allow privileged users to override hooks.


Diffs (updated)
-

  docs/design/command-hooks.md PRE-CREATION 
  src/main/python/apache/aurora/client/cli/BUILD 
17cdc287875b5f0832064a6441f33fc9837fc79b 
  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 
  src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
0534bdf72a332caa606dd3a7ca743a59e03738ef 
  src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
34fdb47baa647b9c3bd149ff2710b175c7435dae 
  
src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks 
PRE-CREATION 
  
src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks 
PRE-CREATION 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20687/diff/


Testing
---

[sun-wukong incubator-aurora (command_hooks)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.03 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py 

=== 4 passed in 0.58 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.52 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 1.87 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.62 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=== 2 passed in 0.53 seconds 
===
= test session starts 
==
platform darwin

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Suman Karumuri 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41733
---

Ship it!



src/main/python/apache/aurora/client/cli/command_hooks.py


+1 for using this.


- Suman Karumuri


On April 29, 2014, 4:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 29, 2014, 4:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   docs/design/command-hooks.md PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   
> src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks
>  PRE-CREATION 
>   
> src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks
>  PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> ==

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/
---

(Updated April 29, 2014, 3:01 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Rebase to master.


Bugs: aurora-270
https://issues.apache.org/jira/browse/aurora-270


Repository: aurora


Description
---

Stage 1 of implementing command hooks for aurora v2.

This change includes:
(1) The ability to add hard-wired hooks, by registering them in 
ConfigurationPlugins
  compiled into a pex;
(2) Dynamically loaded plugins, loaded from plugin files.

The dynamically loaded plugins are *not* currently active outside of tests.

The second stage of this change will activate dynamically loaded plugins, and
provide a mechanism to allow privileged users to override hooks.


Diffs (updated)
-

  docs/design/command-hooks.md PRE-CREATION 
  src/main/python/apache/aurora/client/cli/BUILD 
17cdc287875b5f0832064a6441f33fc9837fc79b 
  src/main/python/apache/aurora/client/cli/__init__.py 
78c109dce4909dcc99b3a8baad02531b42a9ec4d 
  src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
bd7a30838daf8a0d7cfeca5cecfa6594658b2a7c 
  src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
34fdb47baa647b9c3bd149ff2710b175c7435dae 
  
src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks 
PRE-CREATION 
  
src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks 
PRE-CREATION 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20687/diff/


Testing
---

[sun-wukong incubator-aurora (command_hooks)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.03 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py 

=== 4 passed in 0.58 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .

=== 5 passed in 0.52 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 36 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 36 passed in 1.87 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=== 1 passed in 0.62 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=== 2 passed in 0.53 seconds 
===
= test session starts 
==
platform darwin -- Python 2.6.8 -- py-1.4.20 -