Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-14 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17823/#review34508
---

Ship it!


Ship It!

- Brian Wickman


On Feb. 13, 2014, 10:59 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17823/
> ---
> 
> (Updated Feb. 13, 2014, 10:59 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a utility to list missing shipits.
> 
> This is a tool to assist committers in finding review requests that require 
> their attention (i.e. when the request is addressed to you explicitly and 
> missing a public shipit from you). It uses the ReviewBoard API via "./rbt 
> api-get" (thus avoiding the need to wire in RB creds).
> 
> 
> Diffs
> -
> 
>   build-support/tools/list-missing-shipits PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17823/diff/
> 
> 
> Testing
> ---
> 
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints
> https://reviews.apache.org/r/17818/   jfarrellAURORA-145:Test 
> dependencies leak into distribution
> https://reviews.apache.org/r/17785/   wfarner Ignore THROTTLED tasks when 
> looking for tasks associated with a slave.
> https://reviews.apache.org/r/17562/   mansu   Added cluster name to page 
> title.
> https://reviews.apache.org/r/17303/   mansu   Updated getJobs API to return 
> task stats and latest task config
> https://reviews.apache.org/r/17347/   mansu   Added non-prod consumption info 
> to getQuota call.
> https://reviews.apache.org/r/17042/   weingartAdd a web interface to 
> the zookeeper instance.
> https://reviews.apache.org/r/17026/   jonboulle   update release tag 
> script to support patch versions as well as minor versions
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints | wc -l
>7
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-13 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17823/
---

(Updated Feb. 13, 2014, 2:59 p.m.)


Review request for Aurora and Brian Wickman.


Changes
---

Brian and Jake's feedback.


Repository: aurora


Description
---

Add a utility to list missing shipits.

This is a tool to assist committers in finding review requests that require 
their attention (i.e. when the request is addressed to you explicitly and 
missing a public shipit from you). It uses the ReviewBoard API via "./rbt 
api-get" (thus avoiding the need to wire in RB creds).


Diffs (updated)
-

  build-support/tools/list-missing-shipits PRE-CREATION 

Diff: https://reviews.apache.org/r/17823/diff/


Testing
---

~aurora git aurora/. kts/missing-shipits
% ./build-support/list-missing-shipits kevints
https://reviews.apache.org/r/17818/ jfarrellAURORA-145:Test 
dependencies leak into distribution
https://reviews.apache.org/r/17785/ wfarner Ignore THROTTLED tasks when 
looking for tasks associated with a slave.
https://reviews.apache.org/r/17562/ mansu   Added cluster name to page 
title.
https://reviews.apache.org/r/17303/ mansu   Updated getJobs API to return 
task stats and latest task config
https://reviews.apache.org/r/17347/ mansu   Added non-prod consumption info 
to getQuota call.
https://reviews.apache.org/r/17042/ weingartAdd a web interface to 
the zookeeper instance.
https://reviews.apache.org/r/17026/ jonboulle   update release tag 
script to support patch versions as well as minor versions
~aurora git aurora/. kts/missing-shipits
% ./build-support/list-missing-shipits kevints | wc -l
   7


Thanks,

Kevin Sweeney

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-13 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17823/#review34396
---



build-support/list-missing-shipits


sys.argv[1] if len(sys.argv) == 2 else getpass.getuser()

(bias to engineers whose $USER == apache account names :)



build-support/list-missing-shipits


don't be lazy.

os.path.realpath(os.path.join(os.path.dirname(sys.argv[0]), '..', '..', 
'rbt')))

(once moved to tools, natch)


- Brian Wickman


On Feb. 6, 2014, 11:52 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17823/
> ---
> 
> (Updated Feb. 6, 2014, 11:52 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a utility to list missing shipits.
> 
> This is a tool to assist committers in finding review requests that require 
> their attention (i.e. when the request is addressed to you explicitly and 
> missing a public shipit from you). It uses the ReviewBoard API via "./rbt 
> api-get" (thus avoiding the need to wire in RB creds).
> 
> 
> Diffs
> -
> 
>   build-support/list-missing-shipits PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17823/diff/
> 
> 
> Testing
> ---
> 
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints
> https://reviews.apache.org/r/17818/   jfarrellAURORA-145:Test 
> dependencies leak into distribution
> https://reviews.apache.org/r/17785/   wfarner Ignore THROTTLED tasks when 
> looking for tasks associated with a slave.
> https://reviews.apache.org/r/17562/   mansu   Added cluster name to page 
> title.
> https://reviews.apache.org/r/17303/   mansu   Updated getJobs API to return 
> task stats and latest task config
> https://reviews.apache.org/r/17347/   mansu   Added non-prod consumption info 
> to getQuota call.
> https://reviews.apache.org/r/17042/   weingartAdd a web interface to 
> the zookeeper instance.
> https://reviews.apache.org/r/17026/   jonboulle   update release tag 
> script to support patch versions as well as minor versions
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints | wc -l
>7
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Suman Karumuri 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17823/#review33910
---


+1

- Suman Karumuri


On Feb. 6, 2014, 11:52 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17823/
> ---
> 
> (Updated Feb. 6, 2014, 11:52 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a utility to list missing shipits.
> 
> This is a tool to assist committers in finding review requests that require 
> their attention (i.e. when the request is addressed to you explicitly and 
> missing a public shipit from you). It uses the ReviewBoard API via "./rbt 
> api-get" (thus avoiding the need to wire in RB creds).
> 
> 
> Diffs
> -
> 
>   build-support/list-missing-shipits PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17823/diff/
> 
> 
> Testing
> ---
> 
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints
> https://reviews.apache.org/r/17818/   jfarrellAURORA-145:Test 
> dependencies leak into distribution
> https://reviews.apache.org/r/17785/   wfarner Ignore THROTTLED tasks when 
> looking for tasks associated with a slave.
> https://reviews.apache.org/r/17562/   mansu   Added cluster name to page 
> title.
> https://reviews.apache.org/r/17303/   mansu   Updated getJobs API to return 
> task stats and latest task config
> https://reviews.apache.org/r/17347/   mansu   Added non-prod consumption info 
> to getQuota call.
> https://reviews.apache.org/r/17042/   weingartAdd a web interface to 
> the zookeeper instance.
> https://reviews.apache.org/r/17026/   jonboulle   update release tag 
> script to support patch versions as well as minor versions
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints | wc -l
>7
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Jake Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17823/#review33895
---


to help keep things a little more organized we should put this in a dir like 
build-support/tools/, otherwise +1

- Jake Farrell


On Feb. 6, 2014, 11:52 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17823/
> ---
> 
> (Updated Feb. 6, 2014, 11:52 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a utility to list missing shipits.
> 
> This is a tool to assist committers in finding review requests that require 
> their attention (i.e. when the request is addressed to you explicitly and 
> missing a public shipit from you). It uses the ReviewBoard API via "./rbt 
> api-get" (thus avoiding the need to wire in RB creds).
> 
> 
> Diffs
> -
> 
>   build-support/list-missing-shipits PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17823/diff/
> 
> 
> Testing
> ---
> 
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints
> https://reviews.apache.org/r/17818/   jfarrellAURORA-145:Test 
> dependencies leak into distribution
> https://reviews.apache.org/r/17785/   wfarner Ignore THROTTLED tasks when 
> looking for tasks associated with a slave.
> https://reviews.apache.org/r/17562/   mansu   Added cluster name to page 
> title.
> https://reviews.apache.org/r/17303/   mansu   Updated getJobs API to return 
> task stats and latest task config
> https://reviews.apache.org/r/17347/   mansu   Added non-prod consumption info 
> to getQuota call.
> https://reviews.apache.org/r/17042/   weingartAdd a web interface to 
> the zookeeper instance.
> https://reviews.apache.org/r/17026/   jonboulle   update release tag 
> script to support patch versions as well as minor versions
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints | wc -l
>7
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Bill Farner 
Thief!  You stole my idea!

On Thursday, February 6, 2014, Kevin Sweeney  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17823/
> ---
>
> (Updated Feb. 6, 2014, 3:52 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Changes
> ---
>
> s/continue/break/
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Add a utility to list missing shipits.
>
> This is a tool to assist committers in finding review requests that
> require their attention (i.e. when the request is addressed to you
> explicitly and missing a public shipit from you). It uses the ReviewBoard
> API via "./rbt api-get" (thus avoiding the need to wire in RB creds).
>
>
> Diffs (updated)
> -
>
>   build-support/list-missing-shipits PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17823/diff/
>
>
> Testing (updated)
> ---
>
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints
> https://reviews.apache.org/r/17818/ jfarrellAURORA-145:Test
> dependencies leak into distribution
> https://reviews.apache.org/r/17785/ wfarner Ignore THROTTLED tasks
> when looking for tasks associated with a slave.
> https://reviews.apache.org/r/17562/ mansu   Added cluster name to
> page title.
> https://reviews.apache.org/r/17303/ mansu   Updated getJobs API to
> return task stats and latest task config
> https://reviews.apache.org/r/17347/ mansu   Added non-prod
> consumption info to getQuota call.
> https://reviews.apache.org/r/17042/ weingartAdd a web
> interface to the zookeeper instance.
> https://reviews.apache.org/r/17026/ jonboulle   update release
> tag script to support patch versions as well as minor versions
> ~aurora git aurora/. kts/missing-shipits
> % ./build-support/list-missing-shipits kevints | wc -l
>7
>
>
> Thanks,
>
> Kevin Sweeney
>
>

-- 
-=Bill

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17823/
---

(Updated Feb. 6, 2014, 3:52 p.m.)


Review request for Aurora and Brian Wickman.


Changes
---

s/continue/break/


Repository: aurora


Description
---

Add a utility to list missing shipits.

This is a tool to assist committers in finding review requests that require 
their attention (i.e. when the request is addressed to you explicitly and 
missing a public shipit from you). It uses the ReviewBoard API via "./rbt 
api-get" (thus avoiding the need to wire in RB creds).


Diffs (updated)
-

  build-support/list-missing-shipits PRE-CREATION 

Diff: https://reviews.apache.org/r/17823/diff/


Testing (updated)
---

~aurora git aurora/. kts/missing-shipits
% ./build-support/list-missing-shipits kevints
https://reviews.apache.org/r/17818/ jfarrellAURORA-145:Test 
dependencies leak into distribution
https://reviews.apache.org/r/17785/ wfarner Ignore THROTTLED tasks when 
looking for tasks associated with a slave.
https://reviews.apache.org/r/17562/ mansu   Added cluster name to page 
title.
https://reviews.apache.org/r/17303/ mansu   Updated getJobs API to return 
task stats and latest task config
https://reviews.apache.org/r/17347/ mansu   Added non-prod consumption info 
to getQuota call.
https://reviews.apache.org/r/17042/ weingartAdd a web interface to 
the zookeeper instance.
https://reviews.apache.org/r/17026/ jonboulle   update release tag 
script to support patch versions as well as minor versions
~aurora git aurora/. kts/missing-shipits
% ./build-support/list-missing-shipits kevints | wc -l
   7


Thanks,

Kevin Sweeney

Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17823/
---

Review request for Aurora and Brian Wickman.


Repository: aurora


Description
---

Add a utility to list missing shipits.

This is a tool to assist committers in finding review requests that require 
their attention (i.e. when the request is addressed to you explicitly and 
missing a public shipit from you). It uses the ReviewBoard API via "./rbt 
api-get" (thus avoiding the need to wire in RB creds).


Diffs
-

  build-support/list-missing-shipits PRE-CREATION 

Diff: https://reviews.apache.org/r/17823/diff/


Testing
---

~aurora git aurora/. kts/missing-shipits
% ./build-support/list-missing-shipits kevints
https://reviews.apache.org/r/17724/ markcc  Add an exception catch to 
provide a better error message when distributed command runner fails
https://reviews.apache.org/r/17723/ maxim   Implementing support for 
DRAINING state.
https://reviews.apache.org/r/17818/ jfarrellAURORA-145:Test 
dependencies leak into distribution
https://reviews.apache.org/r/17056/ wickman fix dependencies for setup_py
https://reviews.apache.org/r/17785/ wfarner Ignore THROTTLED tasks when 
looking for tasks associated with a slave.
https://reviews.apache.org/r/17562/ mansu   Added cluster name to page 
title.
https://reviews.apache.org/r/17303/ mansu   Updated getJobs API to return 
task stats and latest task config
https://reviews.apache.org/r/17060/ wickman Fix noisy status checker debug 
log.
https://reviews.apache.org/r/17347/ mansu   Added non-prod consumption info 
to getQuota call.
https://reviews.apache.org/r/17042/ weingartAdd a web interface to 
the zookeeper instance.
https://reviews.apache.org/r/17026/ jonboulle   update release tag 
script to support patch versions as well as minor versions
~aurora git aurora/. kts/missing-shipits
% ./build-support/list-missing-shipits kevints | wc -l
  11


Thanks,

Kevin Sweeney