Review Request 20010: Fix two clientv2 command-line bugs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20010/ --- Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-307 https://issues.apache.org/jira/browse/aurora-307 Repository: aurora Description --- Fix two clientv2 command-line bugs. - Clientv2 bridge would crash and dump cookies if you didn't give it any command-line parameters. - Clientv2 help formatting was messed up. Diffs - src/main/python/apache/aurora/client/cli/__init__.py a1063e1af24fd42adafbeebf757bca4de47db1fc src/main/python/apache/aurora/client/cli/bridge.py 37964b65b597abcf7f85b414fa5c6473da9f12ed Diff: https://reviews.apache.org/r/20010/diff/ Testing --- Manual command-line testing. Thanks, Mark Chu-Carroll
Re: Review Request 20010: Fix two clientv2 command-line bugs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20010/#review39472 --- Ship it! Ship It! - Brian Wickman On April 3, 2014, 5:15 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20010/ > --- > > (Updated April 3, 2014, 5:15 p.m.) > > > Review request for Aurora, David Robinson and Brian Wickman. > > > Bugs: aurora-307 > https://issues.apache.org/jira/browse/aurora-307 > > > Repository: aurora > > > Description > --- > > Fix two clientv2 command-line bugs. > > - Clientv2 bridge would crash and dump cookies if you didn't give it > any command-line parameters. > - Clientv2 help formatting was messed up. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/__init__.py > a1063e1af24fd42adafbeebf757bca4de47db1fc > src/main/python/apache/aurora/client/cli/bridge.py > 37964b65b597abcf7f85b414fa5c6473da9f12ed > > Diff: https://reviews.apache.org/r/20010/diff/ > > > Testing > --- > > Manual command-line testing. > > > Thanks, > > Mark Chu-Carroll > >
Re: Review Request 20010: Fix two clientv2 command-line bugs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20010/#review39480 --- Ship it! Ship It! - David Robinson On April 3, 2014, 5:15 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20010/ > --- > > (Updated April 3, 2014, 5:15 p.m.) > > > Review request for Aurora, David Robinson and Brian Wickman. > > > Bugs: aurora-307 > https://issues.apache.org/jira/browse/aurora-307 > > > Repository: aurora > > > Description > --- > > Fix two clientv2 command-line bugs. > > - Clientv2 bridge would crash and dump cookies if you didn't give it > any command-line parameters. > - Clientv2 help formatting was messed up. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/__init__.py > a1063e1af24fd42adafbeebf757bca4de47db1fc > src/main/python/apache/aurora/client/cli/bridge.py > 37964b65b597abcf7f85b414fa5c6473da9f12ed > > Diff: https://reviews.apache.org/r/20010/diff/ > > > Testing > --- > > Manual command-line testing. > > > Thanks, > > Mark Chu-Carroll > >
