Re: Review Request 20723: Add batch options to kill and killall.

2014-05-06 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/
---

(Updated May 6, 2014, 2 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Address Suman's review.


Bugs: aurora-356
https://issues.apache.org/jira/browse/aurora-356


Repository: aurora


Description
---

Add batch options to kill and killall. (This brings the kill commands in client 
v1 into parity with client v2.
At the moment, in order to avoid disrupting current users, v1 still defaults to 
non-batched operation.)


Diffs (updated)
-

  src/main/python/apache/aurora/client/commands/core.py 
089a2c6aaa742dc7479014b90c2b3fac46d4befd 
  src/main/python/apache/aurora/client/options.py 
0d85c360dc4c62ab0baf58315a68a32c304fcffc 
  src/test/python/apache/aurora/client/commands/test_kill.py 
7f0b73ca2701f0ce250d906bce1bd8b07b49ae99 

Diff: https://reviews.apache.org/r/20723/diff/


Testing
---

[sun-wukong incubator-aurora (batch_v1)]$ ./pants 
src/test/python/apache/aurora/client/commands:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .

== 13 passed in 0.57 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ..
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ..
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...

== 28 passed in 1.47 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items

src/test/python/apache/aurora/client/commands/test_hooks.py ...

=== 3 passed in 1.21 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py 

=== 4 passed in 0.48 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

=== 1 passed in 0.58 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

=== 1 passed in 0.47 seconds ===
src.test.python.apache.aurora.client.commands.admin 
.   SUCCESS
src.test.python.apache.aurora.client.commands.core  
.   SUCCESS
src.test.python.apache.aurora.client.commands.hooks 
.   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance   
.   SUCCESS
src.test.python.apache.aurora.client.commands.run   
.   SUCCESS
src.test.python.apache.aurora.client.commands.ssh   
.   SUCCESS
[sun-wukong incubator-aurora (batch_v1)]$


Thanks,

Mark Chu-Carroll



Re: Review Request 20723: Add batch options to kill and killall.

2014-05-06 Thread Suman Karumuri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/#review42346
---

Ship it!


Ship It!

- Suman Karumuri


On May 6, 2014, 6 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20723/
 ---
 
 (Updated May 6, 2014, 6 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Suman Karumuri.
 
 
 Bugs: aurora-356
 https://issues.apache.org/jira/browse/aurora-356
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add batch options to kill and killall. (This brings the kill commands in 
 client v1 into parity with client v2.
 At the moment, in order to avoid disrupting current users, v1 still defaults 
 to non-batched operation.)
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/commands/core.py 
 089a2c6aaa742dc7479014b90c2b3fac46d4befd 
   src/main/python/apache/aurora/client/options.py 
 0d85c360dc4c62ab0baf58315a68a32c304fcffc 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 7f0b73ca2701f0ce250d906bce1bd8b07b49ae99 
 
 Diff: https://reviews.apache.org/r/20723/diff/
 
 
 Testing
 ---
 
 [sun-wukong incubator-aurora (batch_v1)]$ ./pants 
 src/test/python/apache/aurora/client/commands:all
 Build operating on targets: 
 OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 13 items
 
 src/test/python/apache/aurora/client/commands/test_admin_sla.py .
 
 == 13 passed in 0.57 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 28 items
 
 src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
 src/test/python/apache/aurora/client/commands/test_create.py ..
 src/test/python/apache/aurora/client/commands/test_diff.py ...
 src/test/python/apache/aurora/client/commands/test_kill.py ..
 src/test/python/apache/aurora/client/commands/test_listjobs.py ..
 src/test/python/apache/aurora/client/commands/test_restart.py ...
 src/test/python/apache/aurora/client/commands/test_status.py ...
 src/test/python/apache/aurora/client/commands/test_update.py ...
 
 == 28 passed in 1.47 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 3 items
 
 src/test/python/apache/aurora/client/commands/test_hooks.py ...
 
 === 3 passed in 1.21 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 4 items
 
 src/test/python/apache/aurora/client/commands/test_maintenance.py 
 
 === 4 passed in 0.48 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_run.py .
 
 === 1 passed in 0.58 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_ssh.py .
 
 === 1 passed in 0.47 seconds 
 ===
 src.test.python.apache.aurora.client.commands.admin   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.core
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.hooks   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.maintenance 
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.run 
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.ssh 
   .   SUCCESS
 [sun-wukong incubator-aurora (batch_v1)]$
 
 
 Thanks,
 
 Mark Chu-Carroll
 




Re: Review Request 20723: Add batch options to kill and killall.

2014-05-05 Thread Suman Karumuri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/#review42206
---



src/main/python/apache/aurora/client/commands/core.py
https://reviews.apache.org/r/20723/#comment75960

I think this code would be much more easier to read and test if it is 
written as: 

if batch_size is not None and batch_size  0 and len(instance_ids_to_kill) 
 0:
  for batch in make_batches(instances_to_kill):
 kill_jobs(batch)






src/test/python/apache/aurora/client/commands/test_kill.py
https://reviews.apache.org/r/20723/#comment75964

Is there a test for an unsuccessful batch kill? If not, please add it.


- Suman Karumuri


On April 25, 2014, 7:15 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20723/
 ---
 
 (Updated April 25, 2014, 7:15 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Suman Karumuri.
 
 
 Bugs: aurora-356
 https://issues.apache.org/jira/browse/aurora-356
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add batch options to kill and killall. (This brings the kill commands in 
 client v1 into parity with client v2.
 At the moment, in order to avoid disrupting current users, v1 still defaults 
 to non-batched operation.)
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/commands/core.py 
 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
   src/main/python/apache/aurora/client/options.py 
 0d85c360dc4c62ab0baf58315a68a32c304fcffc 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 825f5f13da1c8bee843581a34f3357c0fa2dbb00 
 
 Diff: https://reviews.apache.org/r/20723/diff/
 
 
 Testing
 ---
 
 [sun-wukong incubator-aurora (batch_v1)]$ ./pants 
 src/test/python/apache/aurora/client/commands:all
 Build operating on targets: 
 OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 13 items
 
 src/test/python/apache/aurora/client/commands/test_admin_sla.py .
 
 == 13 passed in 0.57 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 28 items
 
 src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
 src/test/python/apache/aurora/client/commands/test_create.py ..
 src/test/python/apache/aurora/client/commands/test_diff.py ...
 src/test/python/apache/aurora/client/commands/test_kill.py ..
 src/test/python/apache/aurora/client/commands/test_listjobs.py ..
 src/test/python/apache/aurora/client/commands/test_restart.py ...
 src/test/python/apache/aurora/client/commands/test_status.py ...
 src/test/python/apache/aurora/client/commands/test_update.py ...
 
 == 28 passed in 1.47 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 3 items
 
 src/test/python/apache/aurora/client/commands/test_hooks.py ...
 
 === 3 passed in 1.21 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 4 items
 
 src/test/python/apache/aurora/client/commands/test_maintenance.py 
 
 === 4 passed in 0.48 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_run.py .
 
 === 1 passed in 0.58 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_ssh.py .
 
 === 1 passed in 0.47 seconds 
 ===
 src.test.python.apache.aurora.client.commands.admin   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.core
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.hooks   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.maintenance 
   .   SUCCESS
 

Re: Review Request 20723: Add batch options to kill and killall.

2014-05-01 Thread Mark Chu-Carroll


 On April 25, 2014, 3:18 p.m., David McLaughlin wrote:
  lgtm

ping, suman?


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/#review41509
---


On April 25, 2014, 3:15 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20723/
 ---
 
 (Updated April 25, 2014, 3:15 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Suman Karumuri.
 
 
 Bugs: aurora-356
 https://issues.apache.org/jira/browse/aurora-356
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add batch options to kill and killall. (This brings the kill commands in 
 client v1 into parity with client v2.
 At the moment, in order to avoid disrupting current users, v1 still defaults 
 to non-batched operation.)
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/commands/core.py 
 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
   src/main/python/apache/aurora/client/options.py 
 0d85c360dc4c62ab0baf58315a68a32c304fcffc 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 825f5f13da1c8bee843581a34f3357c0fa2dbb00 
 
 Diff: https://reviews.apache.org/r/20723/diff/
 
 
 Testing
 ---
 
 [sun-wukong incubator-aurora (batch_v1)]$ ./pants 
 src/test/python/apache/aurora/client/commands:all
 Build operating on targets: 
 OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 13 items
 
 src/test/python/apache/aurora/client/commands/test_admin_sla.py .
 
 == 13 passed in 0.57 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 28 items
 
 src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
 src/test/python/apache/aurora/client/commands/test_create.py ..
 src/test/python/apache/aurora/client/commands/test_diff.py ...
 src/test/python/apache/aurora/client/commands/test_kill.py ..
 src/test/python/apache/aurora/client/commands/test_listjobs.py ..
 src/test/python/apache/aurora/client/commands/test_restart.py ...
 src/test/python/apache/aurora/client/commands/test_status.py ...
 src/test/python/apache/aurora/client/commands/test_update.py ...
 
 == 28 passed in 1.47 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 3 items
 
 src/test/python/apache/aurora/client/commands/test_hooks.py ...
 
 === 3 passed in 1.21 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 4 items
 
 src/test/python/apache/aurora/client/commands/test_maintenance.py 
 
 === 4 passed in 0.48 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_run.py .
 
 === 1 passed in 0.58 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_ssh.py .
 
 === 1 passed in 0.47 seconds 
 ===
 src.test.python.apache.aurora.client.commands.admin   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.core
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.hooks   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.maintenance 
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.run 
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.ssh 
   .   SUCCESS
 [sun-wukong incubator-aurora (batch_v1)]$
 
 
 Thanks,
 
 Mark Chu-Carroll
 




Review Request 20723: Add batch options to kill and killall.

2014-04-25 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/
---

Review request for Aurora, David McLaughlin and Suman Karumuri.


Bugs: aurora-356
https://issues.apache.org/jira/browse/aurora-356


Repository: aurora


Description
---

Add batch options to kill and killall. (This brings the kill commands in client 
v1 into parity with client v2.
At the moment, in order to avoid disrupting current users, v1 still defaults to 
non-batched operation.)


Diffs
-

  src/main/python/apache/aurora/client/commands/core.py 
67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
  src/main/python/apache/aurora/client/options.py 
0d85c360dc4c62ab0baf58315a68a32c304fcffc 
  src/test/python/apache/aurora/client/commands/test_kill.py 
825f5f13da1c8bee843581a34f3357c0fa2dbb00 

Diff: https://reviews.apache.org/r/20723/diff/


Testing
---

[sun-wukong incubator-aurora (batch_v1)]$ ./pants 
src/test/python/apache/aurora/client/commands:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .

== 13 passed in 0.57 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ..
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ..
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...

== 28 passed in 1.47 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items

src/test/python/apache/aurora/client/commands/test_hooks.py ...

=== 3 passed in 1.21 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py 

=== 4 passed in 0.48 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

=== 1 passed in 0.58 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

=== 1 passed in 0.47 seconds ===
src.test.python.apache.aurora.client.commands.admin 
.   SUCCESS
src.test.python.apache.aurora.client.commands.core  
.   SUCCESS
src.test.python.apache.aurora.client.commands.hooks 
.   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance   
.   SUCCESS
src.test.python.apache.aurora.client.commands.run   
.   SUCCESS
src.test.python.apache.aurora.client.commands.ssh   
.   SUCCESS
[sun-wukong incubator-aurora (batch_v1)]$


Thanks,

Mark Chu-Carroll



Re: Review Request 20723: Add batch options to kill and killall.

2014-04-25 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/#review41505
---



src/main/python/apache/aurora/client/options.py
https://reviews.apache.org/r/20723/#comment74960

Shouldn't this be batch_size for consistency with the other commands?


- David McLaughlin


On April 25, 2014, 6:23 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20723/
 ---
 
 (Updated April 25, 2014, 6:23 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Suman Karumuri.
 
 
 Bugs: aurora-356
 https://issues.apache.org/jira/browse/aurora-356
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add batch options to kill and killall. (This brings the kill commands in 
 client v1 into parity with client v2.
 At the moment, in order to avoid disrupting current users, v1 still defaults 
 to non-batched operation.)
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/commands/core.py 
 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
   src/main/python/apache/aurora/client/options.py 
 0d85c360dc4c62ab0baf58315a68a32c304fcffc 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 825f5f13da1c8bee843581a34f3357c0fa2dbb00 
 
 Diff: https://reviews.apache.org/r/20723/diff/
 
 
 Testing
 ---
 
 [sun-wukong incubator-aurora (batch_v1)]$ ./pants 
 src/test/python/apache/aurora/client/commands:all
 Build operating on targets: 
 OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 13 items
 
 src/test/python/apache/aurora/client/commands/test_admin_sla.py .
 
 == 13 passed in 0.57 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 28 items
 
 src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
 src/test/python/apache/aurora/client/commands/test_create.py ..
 src/test/python/apache/aurora/client/commands/test_diff.py ...
 src/test/python/apache/aurora/client/commands/test_kill.py ..
 src/test/python/apache/aurora/client/commands/test_listjobs.py ..
 src/test/python/apache/aurora/client/commands/test_restart.py ...
 src/test/python/apache/aurora/client/commands/test_status.py ...
 src/test/python/apache/aurora/client/commands/test_update.py ...
 
 == 28 passed in 1.47 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 3 items
 
 src/test/python/apache/aurora/client/commands/test_hooks.py ...
 
 === 3 passed in 1.21 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 4 items
 
 src/test/python/apache/aurora/client/commands/test_maintenance.py 
 
 === 4 passed in 0.48 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_run.py .
 
 === 1 passed in 0.58 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_ssh.py .
 
 === 1 passed in 0.47 seconds 
 ===
 src.test.python.apache.aurora.client.commands.admin   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.core
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.hooks   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.maintenance 
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.run 
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.ssh 
   .   SUCCESS
 [sun-wukong incubator-aurora (batch_v1)]$
 
 
 Thanks,
 
 Mark Chu-Carroll
 




Re: Review Request 20723: Add batch options to kill and killall.

2014-04-25 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/#review41509
---

Ship it!


lgtm

- David McLaughlin


On April 25, 2014, 7:15 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20723/
 ---
 
 (Updated April 25, 2014, 7:15 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Suman Karumuri.
 
 
 Bugs: aurora-356
 https://issues.apache.org/jira/browse/aurora-356
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add batch options to kill and killall. (This brings the kill commands in 
 client v1 into parity with client v2.
 At the moment, in order to avoid disrupting current users, v1 still defaults 
 to non-batched operation.)
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/commands/core.py 
 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
   src/main/python/apache/aurora/client/options.py 
 0d85c360dc4c62ab0baf58315a68a32c304fcffc 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 825f5f13da1c8bee843581a34f3357c0fa2dbb00 
 
 Diff: https://reviews.apache.org/r/20723/diff/
 
 
 Testing
 ---
 
 [sun-wukong incubator-aurora (batch_v1)]$ ./pants 
 src/test/python/apache/aurora/client/commands:all
 Build operating on targets: 
 OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 13 items
 
 src/test/python/apache/aurora/client/commands/test_admin_sla.py .
 
 == 13 passed in 0.57 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 28 items
 
 src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
 src/test/python/apache/aurora/client/commands/test_create.py ..
 src/test/python/apache/aurora/client/commands/test_diff.py ...
 src/test/python/apache/aurora/client/commands/test_kill.py ..
 src/test/python/apache/aurora/client/commands/test_listjobs.py ..
 src/test/python/apache/aurora/client/commands/test_restart.py ...
 src/test/python/apache/aurora/client/commands/test_status.py ...
 src/test/python/apache/aurora/client/commands/test_update.py ...
 
 == 28 passed in 1.47 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 3 items
 
 src/test/python/apache/aurora/client/commands/test_hooks.py ...
 
 === 3 passed in 1.21 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 4 items
 
 src/test/python/apache/aurora/client/commands/test_maintenance.py 
 
 === 4 passed in 0.48 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_run.py .
 
 === 1 passed in 0.58 seconds 
 ===
 = test session starts 
 ==
 platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
 collected 1 items
 
 src/test/python/apache/aurora/client/commands/test_ssh.py .
 
 === 1 passed in 0.47 seconds 
 ===
 src.test.python.apache.aurora.client.commands.admin   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.core
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.hooks   
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.maintenance 
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.run 
   .   SUCCESS
 src.test.python.apache.aurora.client.commands.ssh 
   .   SUCCESS
 [sun-wukong incubator-aurora (batch_v1)]$
 
 
 Thanks,
 
 Mark Chu-Carroll