Review Request 23817: Do not rely upon pytest capsys since command line parameters alter outcome.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23817/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-595 https://issues.apache.org/jira/browse/AURORA-595 Repository: aurora Description --- Do not rely upon pytest capsys since command line parameters alter outcome. Diffs - src/test/python/apache/aurora/common/test_cluster_option.py 2213d8cda42566dd015217de06be8d0572edb649 Diff: https://reviews.apache.org/r/23817/diff/ Testing --- ./pants src/test/python/apache/aurora/common:test_cluster_option -s Thanks, Brian Wickman
Re: Review Request 23817: Do not rely upon pytest capsys since command line parameters alter outcome.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23817/#review48371 --- Ship it! Ship It! - Bill Farner On July 22, 2014, 4:27 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23817/ > --- > > (Updated July 22, 2014, 4:27 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-595 > https://issues.apache.org/jira/browse/AURORA-595 > > > Repository: aurora > > > Description > --- > > Do not rely upon pytest capsys since command line parameters alter outcome. > > > Diffs > - > > src/test/python/apache/aurora/common/test_cluster_option.py > 2213d8cda42566dd015217de06be8d0572edb649 > > Diff: https://reviews.apache.org/r/23817/diff/ > > > Testing > --- > > ./pants src/test/python/apache/aurora/common:test_cluster_option -s > > > Thanks, > > Brian Wickman > >
Re: Review Request 23817: Do not rely upon pytest capsys since command line parameters alter outcome.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23817/#review48381 --- Ship it! Ship It! - Kevin Sweeney On July 22, 2014, 9:27 a.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23817/ > --- > > (Updated July 22, 2014, 9:27 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-595 > https://issues.apache.org/jira/browse/AURORA-595 > > > Repository: aurora > > > Description > --- > > Do not rely upon pytest capsys since command line parameters alter outcome. > > > Diffs > - > > src/test/python/apache/aurora/common/test_cluster_option.py > 2213d8cda42566dd015217de06be8d0572edb649 > > Diff: https://reviews.apache.org/r/23817/diff/ > > > Testing > --- > > ./pants src/test/python/apache/aurora/common:test_cluster_option -s > > > Thanks, > > Brian Wickman > >