Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-22 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23834/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-94
https://issues.apache.org/jira/browse/AURORA-94


Repository: aurora


Description
---

Moving restartShards from SchedulerCore into SchedulerThriftInterface.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
137bd6ccafc48508ccd48004e7111fe69449152d 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
adc2dbc8c451260e8e4749dd07f47e1b0cd7dda2 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7f94e0447066a2e9f2e460a284c7f93eac347a91 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
5ec7cf395080cd593a5d5291eff835f89c65dac2 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d3ac7c7585e8fcac6d26f06f53c9101aa9787808 

Diff: https://reviews.apache.org/r/23834/diff/


Testing
---

gradle -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-22 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23834/#review48467
---

Ship it!



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java


@Nullable


- Bill Farner


On July 23, 2014, 2:21 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23834/
> ---
> 
> (Updated July 23, 2014, 2:21 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-94
> https://issues.apache.org/jira/browse/AURORA-94
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moving restartShards from SchedulerCore into SchedulerThriftInterface.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 137bd6ccafc48508ccd48004e7111fe69449152d 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> adc2dbc8c451260e8e4749dd07f47e1b0cd7dda2 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f94e0447066a2e9f2e460a284c7f93eac347a91 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  5ec7cf395080cd593a5d5291eff835f89c65dac2 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d3ac7c7585e8fcac6d26f06f53c9101aa9787808 
> 
> Diff: https://reviews.apache.org/r/23834/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-22 Thread Maxim Khutornenko 


> On July 23, 2014, 2:29 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 779
> > 
> >
> > @Nullable

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23834/#review48467
---


On July 23, 2014, 2:21 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23834/
> ---
> 
> (Updated July 23, 2014, 2:21 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-94
> https://issues.apache.org/jira/browse/AURORA-94
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moving restartShards from SchedulerCore into SchedulerThriftInterface.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 137bd6ccafc48508ccd48004e7111fe69449152d 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> adc2dbc8c451260e8e4749dd07f47e1b0cd7dda2 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f94e0447066a2e9f2e460a284c7f93eac347a91 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  5ec7cf395080cd593a5d5291eff835f89c65dac2 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d3ac7c7585e8fcac6d26f06f53c9101aa9787808 
> 
> Diff: https://reviews.apache.org/r/23834/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-22 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23834/
---

(Updated July 23, 2014, 2:36 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-94
https://issues.apache.org/jira/browse/AURORA-94


Repository: aurora


Description
---

Moving restartShards from SchedulerCore into SchedulerThriftInterface.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
137bd6ccafc48508ccd48004e7111fe69449152d 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
adc2dbc8c451260e8e4749dd07f47e1b0cd7dda2 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7f94e0447066a2e9f2e460a284c7f93eac347a91 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
5ec7cf395080cd593a5d5291eff835f89c65dac2 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d3ac7c7585e8fcac6d26f06f53c9101aa9787808 

Diff: https://reviews.apache.org/r/23834/diff/


Testing
---

gradle -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-24 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23834/#review48667
---


Ping, Kevin.

- Maxim Khutornenko


On July 23, 2014, 2:36 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23834/
> ---
> 
> (Updated July 23, 2014, 2:36 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-94
> https://issues.apache.org/jira/browse/AURORA-94
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moving restartShards from SchedulerCore into SchedulerThriftInterface.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 137bd6ccafc48508ccd48004e7111fe69449152d 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> adc2dbc8c451260e8e4749dd07f47e1b0cd7dda2 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f94e0447066a2e9f2e460a284c7f93eac347a91 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  5ec7cf395080cd593a5d5291eff835f89c65dac2 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d3ac7c7585e8fcac6d26f06f53c9101aa9787808 
> 
> Diff: https://reviews.apache.org/r/23834/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-24 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23834/#review48672
---

Ship it!


Ship It!

- Kevin Sweeney


On July 22, 2014, 7:36 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23834/
> ---
> 
> (Updated July 22, 2014, 7:36 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-94
> https://issues.apache.org/jira/browse/AURORA-94
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moving restartShards from SchedulerCore into SchedulerThriftInterface.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 137bd6ccafc48508ccd48004e7111fe69449152d 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> adc2dbc8c451260e8e4749dd07f47e1b0cd7dda2 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f94e0447066a2e9f2e460a284c7f93eac347a91 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  5ec7cf395080cd593a5d5291eff835f89c65dac2 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d3ac7c7585e8fcac6d26f06f53c9101aa9787808 
> 
> Diff: https://reviews.apache.org/r/23834/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-24 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23834/
---

(Updated July 25, 2014, 3:05 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Rebased.


Bugs: AURORA-94
https://issues.apache.org/jira/browse/AURORA-94


Repository: aurora


Description
---

Moving restartShards from SchedulerCore into SchedulerThriftInterface.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
38ef8467830914ab23ccff2621cc58b9dd48c2ef 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
f053c72e1fa98004336422197ed4d4023b725091 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
f2ad92057a474dc75d3172f236db6c6a54d51613 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
0206d00f460d4788aea9bfb7af5a66bcbe2237b8 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 b8677ae0e9bde8853ba07be9ee19c7375efa07c1 

Diff: https://reviews.apache.org/r/23834/diff/


Testing
---

gradle -Pq build


Thanks,

Maxim Khutornenko