Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65119 --- Ship it! Ship It! - Zameer Manji On Dec. 15, 2014, 12:54 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/ --- (Updated Dec. 15, 2014, 12:54 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Extract mechanism for determining pex version so it can be used for cases other than client version. I'm going to use this for the soon-to-follow user agent changes. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 0e6e40a8766f80e6bc558dc08e03dc679008eb45 src/main/python/apache/aurora/client/commands/core.py 8d9286249f176c2974d9d097597b93ce9d9a8660 src/main/python/apache/aurora/common/BUILD 21496881eae42bff52d1f25b276b34e2dee237dd src/main/python/apache/aurora/common/pex_version.py PRE-CREATION src/test/python/apache/aurora/client/commands/test_version.py d3b315e156fe0ace2f2dd473e89cc991645bc084 src/test/python/apache/aurora/common/BUILD afc0659e1917811b206004b1dc2b9edbffddaacf src/test/python/apache/aurora/common/test_pex_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29058/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Thanks, Joshua Cohen
Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65120 --- src/main/python/apache/aurora/client/cli/__init__.py https://reviews.apache.org/r/29058/#comment108075 How about constraining the exceptions thrown here in the library? Better, why not just have the library return an opaque string? One more thing - is it possible to somehow bake .auroraversion into the client so that we can see its release version as well? src/test/python/apache/aurora/common/test_pex_version.py https://reviews.apache.org/r/29058/#comment108073 instance=True? isn't from_pex a classmethod? src/test/python/apache/aurora/common/test_pex_version.py https://reviews.apache.org/r/29058/#comment108074 same question as above - Kevin Sweeney On Dec. 15, 2014, 12:54 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/ --- (Updated Dec. 15, 2014, 12:54 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Extract mechanism for determining pex version so it can be used for cases other than client version. I'm going to use this for the soon-to-follow user agent changes. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 0e6e40a8766f80e6bc558dc08e03dc679008eb45 src/main/python/apache/aurora/client/commands/core.py 8d9286249f176c2974d9d097597b93ce9d9a8660 src/main/python/apache/aurora/common/BUILD 21496881eae42bff52d1f25b276b34e2dee237dd src/main/python/apache/aurora/common/pex_version.py PRE-CREATION src/test/python/apache/aurora/client/commands/test_version.py d3b315e156fe0ace2f2dd473e89cc991645bc084 src/test/python/apache/aurora/common/BUILD afc0659e1917811b206004b1dc2b9edbffddaacf src/test/python/apache/aurora/common/test_pex_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29058/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Thanks, Joshua Cohen
Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.
On Dec. 15, 2014, 9:18 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 73 https://reviews.apache.org/r/29058/diff/1/?file=792296#file792296line73 How about constraining the exceptions thrown here in the library? Better, why not just have the library return an opaque string? One more thing - is it possible to somehow bake .auroraversion into the client so that we can see its release version as well? Re: constraining exceptions: done. Re: returning an opaque string, I think it makes sense to leave it up to the caller to determine how best to format the version for their use case. Re: .auroraversion, I agree w/ Zameer's comment below, that'd be good to have, but let's limit the scope of this change? On Dec. 15, 2014, 9:18 p.m., Kevin Sweeney wrote: src/test/python/apache/aurora/common/test_pex_version.py, line 28 https://reviews.apache.org/r/29058/diff/1/?file=792302#file792302line28 instance=True? isn't from_pex a classmethod? Not sure how that snuck in. Fixed here and below. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65120 --- On Dec. 15, 2014, 8:54 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/ --- (Updated Dec. 15, 2014, 8:54 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Extract mechanism for determining pex version so it can be used for cases other than client version. I'm going to use this for the soon-to-follow user agent changes. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 0e6e40a8766f80e6bc558dc08e03dc679008eb45 src/main/python/apache/aurora/client/commands/core.py 8d9286249f176c2974d9d097597b93ce9d9a8660 src/main/python/apache/aurora/common/BUILD 21496881eae42bff52d1f25b276b34e2dee237dd src/main/python/apache/aurora/common/pex_version.py PRE-CREATION src/test/python/apache/aurora/client/commands/test_version.py d3b315e156fe0ace2f2dd473e89cc991645bc084 src/test/python/apache/aurora/common/BUILD afc0659e1917811b206004b1dc2b9edbffddaacf src/test/python/apache/aurora/common/test_pex_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29058/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Thanks, Joshua Cohen
Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/ --- (Updated Dec. 15, 2014, 9:52 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji. Changes --- - Handle errors getting pex version at the source, rather than letting them bubble up to callers. - Fix autospec calls for from_pex. Repository: aurora Description --- Extract mechanism for determining pex version so it can be used for cases other than client version. I'm going to use this for the soon-to-follow user agent changes. Diffs (updated) - src/main/python/apache/aurora/client/cli/__init__.py 0e6e40a8766f80e6bc558dc08e03dc679008eb45 src/main/python/apache/aurora/client/commands/core.py 8d9286249f176c2974d9d097597b93ce9d9a8660 src/main/python/apache/aurora/common/BUILD 21496881eae42bff52d1f25b276b34e2dee237dd src/main/python/apache/aurora/common/pex_version.py PRE-CREATION src/test/python/apache/aurora/client/commands/test_version.py d3b315e156fe0ace2f2dd473e89cc991645bc084 src/test/python/apache/aurora/common/BUILD afc0659e1917811b206004b1dc2b9edbffddaacf src/test/python/apache/aurora/common/test_pex_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29058/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Thanks, Joshua Cohen
Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65127 --- Ship it! Master (52efc93) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 15, 2014, 9:52 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/ --- (Updated Dec. 15, 2014, 9:52 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Extract mechanism for determining pex version so it can be used for cases other than client version. I'm going to use this for the soon-to-follow user agent changes. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 0e6e40a8766f80e6bc558dc08e03dc679008eb45 src/main/python/apache/aurora/client/commands/core.py 8d9286249f176c2974d9d097597b93ce9d9a8660 src/main/python/apache/aurora/common/BUILD 21496881eae42bff52d1f25b276b34e2dee237dd src/main/python/apache/aurora/common/pex_version.py PRE-CREATION src/test/python/apache/aurora/client/commands/test_version.py d3b315e156fe0ace2f2dd473e89cc991645bc084 src/test/python/apache/aurora/common/BUILD afc0659e1917811b206004b1dc2b9edbffddaacf src/test/python/apache/aurora/common/test_pex_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29058/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Thanks, Joshua Cohen
Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.
On Dec. 15, 2014, 9:54 p.m., Kevin Sweeney wrote: +1, please file a followup ticket to include the actual version in the version output. https://issues.apache.org/jira/browse/AURORA-970 - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65126 --- On Dec. 15, 2014, 9:52 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/ --- (Updated Dec. 15, 2014, 9:52 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Extract mechanism for determining pex version so it can be used for cases other than client version. I'm going to use this for the soon-to-follow user agent changes. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 0e6e40a8766f80e6bc558dc08e03dc679008eb45 src/main/python/apache/aurora/client/commands/core.py 8d9286249f176c2974d9d097597b93ce9d9a8660 src/main/python/apache/aurora/common/BUILD 21496881eae42bff52d1f25b276b34e2dee237dd src/main/python/apache/aurora/common/pex_version.py PRE-CREATION src/test/python/apache/aurora/client/commands/test_version.py d3b315e156fe0ace2f2dd473e89cc991645bc084 src/test/python/apache/aurora/common/BUILD afc0659e1917811b206004b1dc2b9edbffddaacf src/test/python/apache/aurora/common/test_pex_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29058/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Thanks, Joshua Cohen
Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65131 --- Ship it! Ship It! - David McLaughlin On Dec. 15, 2014, 9:52 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/ --- (Updated Dec. 15, 2014, 9:52 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Extract mechanism for determining pex version so it can be used for cases other than client version. I'm going to use this for the soon-to-follow user agent changes. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 0e6e40a8766f80e6bc558dc08e03dc679008eb45 src/main/python/apache/aurora/client/commands/core.py 8d9286249f176c2974d9d097597b93ce9d9a8660 src/main/python/apache/aurora/common/BUILD 21496881eae42bff52d1f25b276b34e2dee237dd src/main/python/apache/aurora/common/pex_version.py PRE-CREATION src/test/python/apache/aurora/client/commands/test_version.py d3b315e156fe0ace2f2dd473e89cc991645bc084 src/test/python/apache/aurora/common/BUILD afc0659e1917811b206004b1dc2b9edbffddaacf src/test/python/apache/aurora/common/test_pex_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29058/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Thanks, Joshua Cohen
Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65151 --- This is on apache master. Feel free to close this review. - David McLaughlin On Dec. 15, 2014, 9:52 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/ --- (Updated Dec. 15, 2014, 9:52 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Extract mechanism for determining pex version so it can be used for cases other than client version. I'm going to use this for the soon-to-follow user agent changes. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 0e6e40a8766f80e6bc558dc08e03dc679008eb45 src/main/python/apache/aurora/client/commands/core.py 8d9286249f176c2974d9d097597b93ce9d9a8660 src/main/python/apache/aurora/common/BUILD 21496881eae42bff52d1f25b276b34e2dee237dd src/main/python/apache/aurora/common/pex_version.py PRE-CREATION src/test/python/apache/aurora/client/commands/test_version.py d3b315e156fe0ace2f2dd473e89cc991645bc084 src/test/python/apache/aurora/common/BUILD afc0659e1917811b206004b1dc2b9edbffddaacf src/test/python/apache/aurora/common/test_pex_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29058/diff/ Testing --- ./pants build src/test/python/apache/aurora:: Thanks, Joshua Cohen
