[GitHub] bahir issue #58: [BAHIR-152] Enforce License Header in Java Sources
Github user tedyu commented on the issue: https://github.com/apache/bahir/pull/58 lgtm ---
[GitHub] bahir issue #53: [BAHIR-141] Added support for passing json cred file as byt...
Github user tedyu commented on the issue: https://github.com/apache/bahir/pull/53 Is it possible to add a test ? ---
[GitHub] bahir issue #50: [BAHIR-123] Support latest version of play-json for sql-clo...
Github user tedyu commented on the issue: https://github.com/apache/bahir/pull/50 lgtm ---
[GitHub] bahir pull request #47: [BAHIR-100] Implement new function to pass byte arra...
Github user tedyu commented on a diff in the pull request: https://github.com/apache/bahir/pull/47#discussion_r126583567 --- Diff: streaming-mqtt/README.md --- @@ -52,12 +52,14 @@ this actor can be configured to handle failures, etc. val lines = MQTTUtils.createStream(ssc, brokerUrl, topic) val lines = MQTTUtils.createPairedStream(ssc, brokerUrl, topic) +val lines = MQTTUtils.createPairedByteArrayStreamStream(ssc, brokerUrl, topic) --- End diff -- Where is createPairedByteArrayStreamStream defined ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bahir pull request #47: [BAHIR-100] Implement new function to pass byte arra...
Github user tedyu commented on a diff in the pull request: https://github.com/apache/bahir/pull/47#discussion_r126583641 --- Diff: streaming-mqtt/src/main/scala/org/apache/spark/streaming/mqtt/MQTTPairedByteArrayInputDStream.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.streaming.mqtt + +import org.eclipse.paho.client.mqttv3._ +import org.eclipse.paho.client.mqttv3.persist.MemoryPersistence + +import org.apache.spark.storage.StorageLevel +import org.apache.spark.streaming.StreamingContext +import org.apache.spark.streaming.dstream._ +import org.apache.spark.streaming.receiver.Receiver + +/** + * Input stream that subscribe messages from a Mqtt Broker. + * Uses eclipse paho as MqttClient http://www.eclipse.org/paho/ + * @param brokerUrl Url of remote mqtt publisher --- End diff -- Add @param for _ssc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bahir-flink issue #4: [BAHIR-59][AMQ] Fix constructor visibility and error m...
Github user tedyu commented on the issue: https://github.com/apache/bahir-flink/pull/4 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
