[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations
Bharath Vissapragada has posted comments on this change. (
http://gerrit.cloudera.org:8080/11228 )
Change subject: IMPALA-7450. Set thread name during refresh/load operations
..
Patch Set 2:
(6 comments)
Lgtm. There are quite a few places where we could use this annotator but that
is definitely out of scope for this patch. There are a couple of interesting
ones I pointed to in the comments that we could start with. Really liked the
test, thanks for adding it :-)
http://gerrit.cloudera.org:8080/#/c/11228/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11228/2//COMMIT_MSG@24
PS2, Line 24: This patch is tricky to automate tests for, but I verified it
manually
: by jstacking a catalogd while performing some workload. Also
added a
: simple unit test to verify the thread renaming behavior
Can be removed I guess.
http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:
http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@301
PS2, Line 301: long end;
Annotate here? This is one of those common interesting entry points for table
locks where the threads are usually hung.
Waiting to lock .
http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2185
PS2, Line 2185: private TGetPartialCatalogObjectResponse
doGetPartialCatalogObject(
This is another interesting entry point RPC for catalog v2 stuff. Add some
annotations here?
http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java
File fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java:
http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java@24
PS2, Line 24: public class ThreadNameAnnotatorTest {
great test :-)
http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java@44
PS2, Line 44: wait();
nit: I hope nothing hangs here forever due to a faulty test? Add a largish
timeout?
http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java@107
PS2, Line 107: public void testExternalRename() throws InterruptedException {
nit: Add a doc of what it does? Probably difficult to understand without any
context.
--
To view, visit http://gerrit.cloudera.org:8080/11228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c850d6bb2eedc375ee567c19eb17add335f60c
Gerrit-Change-Number: 11228
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Paul Rogers
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Sun, 27 Jan 2019 06:52:06 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12280 ) Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1903/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecdf301065da8f091a274e7a0585a11fcc79da7d Gerrit-Change-Number: 12280 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 27 Jan 2019 05:42:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12280 Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. IMPALA-5031: out-of-range enum values are undefined behavior This patch adds a utility, Ubsan::EnumToInt(), that can take a pointer to an enumeration value and return its integral value without invoking undefined behavior. This is not as simple as "int i = *pe" because (a) the underlying integral type might not be int, and (b) if pe points to a value outside of the range of the enum as defined in the standard (section dcl.enum), then dereferencing it is undefined behavior. This fixes errors found in the end-to-end tests: exec/parquet/parquet-metadata-utils.cc:215:26: runtime error: load of value 5000, which is not a valid value for type 'CompressionCodec::type' exec/parquet/parquet-metadata-utils.cc:216:26: runtime error: load of value 5000, which is not a valid value for type 'CompressionCodec::type' exec/parquet/parquet-metadata-utils.cc:217:26: runtime error: load of value 5000, which is not a valid value for type 'CompressionCodec::type' exec/parquet/parquet-metadata-utils.cc:219:47: runtime error: load of value 5000, which is not a valid value for type 'CompressionCodec::type' exec/parquet/parquet-metadata-utils.cc:501:22: runtime error: load of value 4294967278, which is not a valid value for type 'FieldRepetitionType::type' exec/parquet/parquet-metadata-utils.cc:503:29: runtime error: load of value 4294967278, which is not a valid value for type 'FieldRepetitionType::type' Change-Id: Iecdf301065da8f091a274e7a0585a11fcc79da7d --- M be/src/exec/parquet/parquet-metadata-utils.cc M be/src/util/ubsan.h 2 files changed, 54 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/12280/1 -- To view, visit http://gerrit.cloudera.org:8080/12280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iecdf301065da8f091a274e7a0585a11fcc79da7d Gerrit-Change-Number: 12280 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12277 ) Change subject: IMPALA-8062: Call impala-config in single_node_perf_run .. IMPALA-8062: Call impala-config in single_node_perf_run This wraps most shell calls in single_node_perf_run.py with a bash shell that first sources impala-config.sh, to make sure environment variables are set properly. Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba Reviewed-on: http://gerrit.cloudera.org:8080/12277 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/single_node_perf_run.py 1 file changed, 20 insertions(+), 11 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba Gerrit-Change-Number: 12277 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 ) Change subject: IMPALA-8062: Call impala-config in single_node_perf_run .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba Gerrit-Change-Number: 12277 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 27 Jan 2019 03:04:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 ) Change subject: IMPALA-8062: Call impala-config in single_node_perf_run .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba Gerrit-Change-Number: 12277 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 26 Jan 2019 23:11:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 ) Change subject: IMPALA-8062: Call impala-config in single_node_perf_run .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3678/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba Gerrit-Change-Number: 12277 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 26 Jan 2019 23:11:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 ) Change subject: IMPALA-8062: Call impala-config in single_node_perf_run .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba Gerrit-Change-Number: 12277 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 26 Jan 2019 22:28:07 + Gerrit-HasComments: No
