[Impala-ASF-CR] Ensure ssh config change is on its own line
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12900 Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end in a newline character, than the change in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/1 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12900/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12900/1/bin/bootstrap_system.sh@304 PS1, Line 304: echo -e "\nNoHostAuthenticationForLocalhost yes" >> ~/.ssh/config && chmod 0600 ~/.ssh/config line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 20:34:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Ensure ssh config change is on its own line
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#2). Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end in a newline character, than the change in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/2 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Ensure ssh config change is on its own line
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#3). Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end in a newline character, than the change in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/3 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh@304 PS3, Line 304: echo -e "\nNoHostAuthenticationForLocalhost yes" >> ~/.ssh/config && chmod 0600 ~/.ssh/config line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 20:40:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12900/2/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12900/2/bin/bootstrap_system.sh@304 PS2, Line 304: echo -e "\nNoHostAuthenticationForLocalhost yes" >> ~/.ssh/config && chmod 0600 ~/.ssh/config line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 20:39:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2598/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 21:17:38 + Gerrit-HasComments: No
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2599/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 21:19:29 + Gerrit-HasComments: No
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2600/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 21:24:18 + Gerrit-HasComments: No
[native-toolchain-CR] Install newer nss version in centos 6.6
Hello Laszlo Gaal, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12862 to look at the new patch set (#4). Change subject: Install newer nss version in centos 6.6 .. Install newer nss version in centos 6.6 Centos 6.6 ships with an nss version that can't clone from github. To fix it we include a new Centos-Vault repo file with disabled repositories and explicitly install nss from centos 6.9, which works. Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb --- M docker/all/assert-dependencies-present.py A docker/redhat/Centos6-Vault.repo M docker/redhat6.df 3 files changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/62/12862/4 -- To view, visit http://gerrit.cloudera.org:8080/12862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb Gerrit-Change-Number: 12862 Gerrit-PatchSet: 4 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Laszlo Gaal
[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag
radford nguyen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12901 Change subject: IMPALA-8309: add user authorization_provider flag .. IMPALA-8309: add user authorization_provider flag This commit adds a `authorization_provider` user-facing flag in order to provide a more human-readable alternative to the `authorization_factory_class` for internally-provided authorization strategies. The `authorization_factory_class` flag is retained, but no longer takes a default value if not specified. The default for `authorization_provider` is "sentry" in order to retain backwards-compatibility. If specified, `authorization_factory_class` will take precedence. Testing: Manually started minicluster with each of following flags and verified correct authorization strategy chosen: - provider='' factory='' => sentry - provider=sentry factory='' => sentry - provider=ranger factory='' => ranger - provider='' factory=sentry => sentry - provider='' factory=ranger => ranger - provider=sentry factory=sentry => sentry - provider=ranger factory=sentry => sentry - provider=sentry factory=ranger => ranger - provider=ranger factory=ranger => ranger Wrote unit tests to capture above assertions Ran fe unit and e2e tests Change-Id: I001c20505ba4f0562b60fdef73d15308e8500c19 --- M be/src/service/frontend.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/authorization/AuthorizationConfig.java M fe/src/main/java/org/apache/impala/authorization/AuthorizationProvider.java M fe/src/main/java/org/apache/impala/authorization/NoneAuthorizationFactory.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationConfig.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M fe/src/main/java/org/apache/impala/service/JniFrontend.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java M fe/src/test/java/org/apache/impala/service/JniFrontendTest.java 14 files changed, 201 insertions(+), 57 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/12901/1 -- To view, visit http://gerrit.cloudera.org:8080/12901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I001c20505ba4f0562b60fdef73d15308e8500c19 Gerrit-Change-Number: 12901 Gerrit-PatchSet: 1 Gerrit-Owner: radford nguyen
[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 1: Hi guys, relatively simply ticket here to add a more human-friendly flag for choosing authorization provider(s) -- To view, visit http://gerrit.cloudera.org:8080/12901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I001c20505ba4f0562b60fdef73d15308e8500c19 Gerrit-Change-Number: 12901 Gerrit-PatchSet: 1 Gerrit-Owner: radford nguyen Gerrit-Reviewer: Austin Nobis Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Mon, 01 Apr 2019 05:24:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/12901 )
Change subject: IMPALA-8309: add user authorization_provider flag
..
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java@113
PS1, Line 113: final AuthorizationFactory authzFactory =
JniFrontend.authzFactoryFrom(BackendConfig.INSTANCE);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java
File fe/src/test/java/org/apache/impala/service/JniFrontendTest.java:
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@92
PS1, Line 92: Class
authorization_factory_class, String authorization_provider) {
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@93
PS1, Line 93: return
authCfg(authorization_factory_class.getCanonicalName(), authorization_provider);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@110
PS1, Line 110: public void
testAuthorizationPolicySelection_FactoryTakesPrecedenceOverProvider() throws
Exception {
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@113
PS1, Line 113:
JniFrontend.authzFactoryClassNameFrom(authCfg(SentryAuthorizationFactory.class,
"ranger"))
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@118
PS1, Line 118:
JniFrontend.authzFactoryClassNameFrom(authCfg(RangerAuthorizationFactory.class,
"sentry"))
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@123
PS1, Line 123:
JniFrontend.authzFactoryClassNameFrom(authCfg(SentryAuthorizationFactory.class,
"sentry"))
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@128
PS1, Line 128:
JniFrontend.authzFactoryClassNameFrom(authCfg(RangerAuthorizationFactory.class,
"ranger"))
line too long (98 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I001c20505ba4f0562b60fdef73d15308e8500c19
Gerrit-Change-Number: 12901
Gerrit-PatchSet: 1
Gerrit-Owner: radford nguyen
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Mon, 01 Apr 2019 05:23:28 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2601/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I001c20505ba4f0562b60fdef73d15308e8500c19 Gerrit-Change-Number: 12901 Gerrit-PatchSet: 1 Gerrit-Owner: radford nguyen Gerrit-Reviewer: Austin Nobis Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Mon, 01 Apr 2019 06:04:21 + Gerrit-HasComments: No
