Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )
Change subject: IMPALA-8750: Fix profile observability tests ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/13851/1/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/13851/1/tests/common/impala_service.py@90 PS1, Line 90: 'flags' nit: it's better to not mix quotes. For consistency, maybe use "" instead. http://gerrit.cloudera.org:8080/#/c/13851/1/tests/common/impala_service.py@90 PS1, Line 90: for var in varz.get('flags'): : if var["name"] == flag: : return var["current"] what should this method return when varz.get("flags") is empty? http://gerrit.cloudera.org:8080/#/c/13851/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/13851/1/tests/query_test/test_observability.py@326 PS1, Line 326: 'lineage_event_log_dir' nit: use double quotes for consistency http://gerrit.cloudera.org:8080/#/c/13851/1/tests/query_test/test_observability.py@327 PS1, Line 327: print (lineage_event_log_dir_value) remove debug information -- To view, visit http://gerrit.cloudera.org:8080/13851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a Gerrit-Change-Number: 13851 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fre...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Mon, 15 Jul 2019 04:50:12 +0000 Gerrit-HasComments: Yes
