date:20190723

Hello Michael Ho, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13907

to look at the new patch set (#2).

Change subject: IMPALA-8781: Result spooling tests to cover edge cases and 
cancellation
..

IMPALA-8781: Result spooling tests to cover edge cases and cancellation

Adds additional tests to test_result_spooling.py to cover various edge
cases when fetching query results (ensure all Impala types are returned
properly, UDFs are evaluated correctly, etc.). A new QueryTest file
result-spooling.test is added to encapsulate all these tests. Tests with
a decreased ROW_BATCH_SIZE are added as well to validate that
BufferedPlanRootSink buffers row batches correctly.

BufferedPlanRootSink requires careful synchronization of the producer
and consumer threads, especially when queries are cancelled. The
TestResultSpoolingCancellation class is dedicated to running
cancellation tests with SPOOL_QUERY_RESULTS = true. The implementation
is heavily borrowed from test_cancellation.py and some of the logic is
re-factored into a new utility class called cancel_utils.py to avoid
code duplication between test_cancellation.py and
test_result_spooling.py.

Testing:
* Looped test_result_spooling.py overnight with no failures
* Core tests passed

Change-Id: Ib3b3a1539c4a5fa9b43c8ca315cea16c9701e283
---
A testdata/workloads/functional-query/queries/QueryTest/result-spooling.test
M tests/query_test/test_cancellation.py
M tests/query_test/test_result_spooling.py
A tests/util/cancel_util.py
4 files changed, 295 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/13907/2
--
To view, visit http://gerrit.cloudera.org:8080/13907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3b3a1539c4a5fa9b43c8ca315cea16c9701e283
Gerrit-Change-Number: 13907
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sahil Takiar

[Impala-ASF-CR] IMPALA-8781: Result spooling tests to cover edge cases and cancellation

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13907 )

Change subject: IMPALA-8781: Result spooling tests to cover edge cases and 
cancellation
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13907/1/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:

http://gerrit.cloudera.org:8080/#/c/13907/1/tests/query_test/test_cancellation.py@153
PS1, Line 153: v
flake8: E126 continuation line over-indented for hanging indent


http://gerrit.cloudera.org:8080/#/c/13907/1/tests/query_test/test_result_spooling.py
File tests/query_test/test_result_spooling.py:

http://gerrit.cloudera.org:8080/#/c/13907/1/tests/query_test/test_result_spooling.py@38
PS1, Line 38: \
flake8: E502 the backslash is redundant between brackets



--
To view, visit http://gerrit.cloudera.org:8080/13907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b3a1539c4a5fa9b43c8ca315cea16c9701e283
Gerrit-Change-Number: 13907
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 24 Jul 2019 03:12:59 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS imp

Hello Michael Ho, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13883

to look at the new patch set (#7).

Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and 
BufferedPRS imp
..

IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS imp

Introduces a generic RowBatchQueue interface with a blocking and
non-blocking implementation. The blocking implementation is a
re-factored version of the current RowBatchQueue. The non-blocking
implementation is simple wrapper around std::queue. The current
RowBatchQueue, which is used by the scanners, is renamed to
BlockingRowBatchQueue and it is a subclass of the new RowBatchQueue
interface. This patch stops short of completely abstracting all the
details of the current RowBatchQueue and instead includes a few TODOs.
NonBlockingRowBatchQueue has max capacity, after which calls to AddBatch
will return false.

Implements BufferedPlanRootSink using the new RowBatchQueue interface.
Currently, the NonBlockingRowBatchQueue is injected into the
BufferedPlanRootSink, however, the implementation of
BufferedPlanRootSink is not tied to NonBlockingRowBatchQueue, although
it does assume the RowBatchQueue is not thread safe. This allows a
future patch to add a RowBatchQueue backed by a BufferedTupleStream
without re-factoring BufferedPlanRootSink.

BufferedPlanRootSink FlushFinal blocks until the consumer thread has
processed all RowBatches. This ensures that the coordinator fragment
stays alive until all results are fetched, but allows all other
fragments to be shutdown immediately.

Testing:
* Running core tests
* Updated tests/query_test/test_result_spooling.py

Follow up work:
* Add a stress test in test_result_spooling.py to validate the
synchronization logic in BufferedPlanRootSink
* Handle Send calls where num_results < batch->num_rows()
* Add a direct write path in Send that directly writes a RowBatch to a
QueryResultSet, if one is available and if the RowBatchQueue is empty
* Implement a RowBatchQueue backed by a BufferedTupleStream
* Re-factor the resource management logic to release all
non-coordinator fragment resources

Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
---
M be/src/exec/blocking-plan-root-sink.cc
M be/src/exec/blocking-plan-root-sink.h
M be/src/exec/buffered-plan-root-sink.cc
M be/src/exec/buffered-plan-root-sink.h
M be/src/exec/data-sink.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/kudu-scan-node.cc
M be/src/exec/plan-root-sink.cc
M be/src/exec/plan-root-sink.h
M be/src/exec/scan-node.cc
M be/src/exec/scan-node.h
M be/src/exec/scanner-context.cc
M be/src/runtime/CMakeLists.txt
R be/src/runtime/blocking-row-batch-queue.cc
A be/src/runtime/blocking-row-batch-queue.h
A be/src/runtime/non-blocking-row-batch-queue.cc
A be/src/runtime/non-blocking-row-batch-queue.h
M be/src/runtime/row-batch-queue.h
M be/src/util/blocking-queue.h
M tests/query_test/test_result_spooling.py
20 files changed, 464 insertions(+), 97 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13883/7
--
To view, visit http://gerrit.cloudera.org:8080/13883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
Gerrit-Change-Number: 13883
Gerrit-PatchSet: 7
Gerrit-Owner: Sahil Takiar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl

Hello Michael Ho, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13883

to look at the new patch set (#6).

Change subject: IMPALA-8656: Add RowBatchQueue interface and 
BufferedPlanRootSink impl
..

IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl

Introduces a generic RowBatchQueue interface with a blocking and
non-blocking implementation. The blocking implementation is a
re-factored version of the current RowBatchQueue. The non-blocking
implementation is simple wrapper around std::queue. The current
RowBatchQueue, which is used by the scanners, is renamed to
BlockingRowBatchQueue and it is a subclass of the new RowBatchQueue
interface. This patch stops short of completely abstracting all the
details of the current RowBatchQueue and instead includes a few TODOs.
NonBlockingRowBatchQueue has max capacity, after which calls to AddBatch
will return false.

Implements BufferedPlanRootSink using the new RowBatchQueue interface.
Currently, the NonBlockingRowBatchQueue is injected into the
BufferedPlanRootSink, however, the implementation of
BufferedPlanRootSink is not tied to NonBlockingRowBatchQueue, although
it does assume the RowBatchQueue is not thread safe. This allows a
future patch to add a RowBatchQueue backed by a BufferedTupleStream
without re-factoring BufferedPlanRootSink.

BufferedPlanRootSink FlushFinal blocks until the consumer thread has
processed all RowBatches. This ensures that the coordinator fragment
stays alive until all results are fetched, but allows all other
fragments to be shutdown immediately.

Testing:
* Running core tests
* Updated tests/query_test/test_result_spooling.py

Follow up work:
* Add a stress test in test_result_spooling.py to validate the
synchronization logic in BufferedPlanRootSink
* Handle Send calls where num_results < batch->num_rows()
* Add a direct write path in Send that directly writes a RowBatch to a
QueryResultSet, if one is available and if the RowBatchQueue is empty
* Implement a RowBatchQueue backed by a BufferedTupleStream
* Re-factor the resource management logic to release all
non-coordinator fragment resources

Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
---
M be/src/exec/blocking-plan-root-sink.cc
M be/src/exec/blocking-plan-root-sink.h
M be/src/exec/buffered-plan-root-sink.cc
M be/src/exec/buffered-plan-root-sink.h
M be/src/exec/data-sink.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/kudu-scan-node.cc
M be/src/exec/plan-root-sink.cc
M be/src/exec/plan-root-sink.h
M be/src/exec/scan-node.cc
M be/src/exec/scan-node.h
M be/src/exec/scanner-context.cc
M be/src/runtime/CMakeLists.txt
R be/src/runtime/blocking-row-batch-queue.cc
A be/src/runtime/blocking-row-batch-queue.h
A be/src/runtime/non-blocking-row-batch-queue.cc
A be/src/runtime/non-blocking-row-batch-queue.h
M be/src/runtime/row-batch-queue.h
M be/src/util/blocking-queue.h
M tests/query_test/test_result_spooling.py
20 files changed, 464 insertions(+), 97 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13883/6
--
To view, visit http://gerrit.cloudera.org:8080/13883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
Gerrit-Change-Number: 13883
Gerrit-PatchSet: 6
Gerrit-Owner: Sahil Takiar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8781: Result spooling tests to cover edge cases and cancellation

Sahil Takiar has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13907


Change subject: IMPALA-8781: Result spooling tests to cover edge cases and 
cancellation
..

IMPALA-8781: Result spooling tests to cover edge cases and cancellation

Adds additional tests to test_result_spooling.py to cover various edge
cases when fetching query results (ensure all Impala types are returned
properly, UDFs are evaluated correctly, etc.). A new QueryTest file
result-spooling.test is added to encapsulate all these tests. Tests with
a decreased ROW_BATCH_SIZE are added as well to validate that
BufferedPlanRootSink buffers row batches correctly.

BufferedPlanRootSink requires careful synchronization of the producer
and consumer threads, especially when queries are cancelled. The
TestResultSpoolingCancellation class is dedicated to running
cancellation tests with SPOOL_QUERY_RESULTS = true. The implementation
is heavily borrowed from test_cancellation.py and some of the logic is
re-factored into a new utility class called cancel_utils.py to avoid
code duplication between test_cancellation.py and
test_result_spooling.py.

Testing:
* Looped test_result_spooling.py overnight with no failures
* Core tests passed

Change-Id: Ib3b3a1539c4a5fa9b43c8ca315cea16c9701e283
---
A testdata/workloads/functional-query/queries/QueryTest/result-spooling.test
M tests/query_test/test_cancellation.py
M tests/query_test/test_result_spooling.py
A tests/util/cancel_util.py
4 files changed, 295 insertions(+), 61 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/13907/1
--
To view, visit http://gerrit.cloudera.org:8080/13907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3b3a1539c4a5fa9b43c8ca315cea16c9701e283
Gerrit-Change-Number: 13907
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl

2019-07-23 Thread Michael Ho (Code Review)

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13883 )

Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and 
BufferedPRS impl
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h
File be/src/runtime/non-blocking-row-batch-queue.h:

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h@32
PS3, Line 32:  NonBlockingRowBatchQueue
> Adding support for TryAddBatch and TryGetBatch to BlockingQueue isn't exact
As discussed offline, we may be able to get away with TryPutBatch() only. I am 
also fine with using std::queue in BufferedPlanRootSInk if changing 
BlockingQueue causes other complication.



--
To view, visit http://gerrit.cloudera.org:8080/13883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
Gerrit-Change-Number: 13883
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 24 Jul 2019 01:58:47 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8615: [DOCS] Document the scalable admission control parameters

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13906 )

Change subject: IMPALA-8615: [DOCS] Document the scalable admission control 
parameters
..


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/402/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca9cf9586359ee0f1ce0dd8744b4709752a26f1
Gerrit-Change-Number: 13906
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 24 Jul 2019 01:30:51 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13748 )

Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution
..


Patch Set 16:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/3969/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/13748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb88422f7cfe86947d11ce57d2b4c63e57d1b643
Gerrit-Change-Number: 13748
Gerrit-PatchSet: 16
Gerrit-Owner: radford nguyen 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: radford nguyen 
Gerrit-Comment-Date: Wed, 24 Jul 2019 01:17:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8615: [DOCS] Document the scalable admission control parameters

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13906


Change subject: IMPALA-8615: [DOCS] Document the scalable admission control 
parameters
..

IMPALA-8615: [DOCS] Document the scalable admission control parameters

- Max Memory Multiple
- Max Running Queries Multiple
- Max Queued Queries Multiple

Change-Id: Ibca9cf9586359ee0f1ce0dd8744b4709752a26f1
---
M docs/topics/impala_admission.xml
1 file changed, 35 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/13906/1
--
To view, visit http://gerrit.cloudera.org:8080/13906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibca9cf9586359ee0f1ce0dd8744b4709752a26f1
Gerrit-Change-Number: 13906
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni

[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13746 )

Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint
..


Patch Set 7:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3968/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534
Gerrit-Change-Number: 13746
Gerrit-PatchSet: 7
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 24 Jul 2019 01:10:11 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8615: [DOCS] Document the scalable admission control parameters

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13906 )

Change subject: IMPALA-8615: [DOCS] Document the scalable admission control 
parameters
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/402/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca9cf9586359ee0f1ce0dd8744b4709752a26f1
Gerrit-Change-Number: 13906
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 24 Jul 2019 01:10:18 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8434: retain tables and functions in altering database

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13904 )

Change subject: IMPALA-8434: retain tables and functions in altering database
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3967/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3dc9857fd2733e20cf10fbe17bb1a4670d7d015
Gerrit-Change-Number: 13904
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 24 Jul 2019 00:55:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..


Patch Set 15:

(2 comments)

Thanks for the fixes. I think I'm going to struggle to find time to review the 
core unpacking logic. Csaba, are you planning to review that?

http://gerrit.cloudera.org:8080/#/c/13807/4/be/src/util/bit-packing.h
File be/src/util/bit-packing.h:

http://gerrit.cloudera.org:8080/#/c/13807/4/be/src/util/bit-packing.h@67
PS4, Line 67:   template 
> Csaba had an idea that we could get rid of the VECTORIZE parameter complete
Ah if there is a measurable difference then the template parameter is OK by me, 
I just thought it might be fair enough outside the hot loops that it didn't 
make a difference. Either way it's a good improvement!


http://gerrit.cloudera.org:8080/#/c/13807/4/be/src/util/bit-packing.inline.h
File be/src/util/bit-packing.inline.h:

http://gerrit.cloudera.org:8080/#/c/13807/4/be/src/util/bit-packing.inline.h@84
PS4, Line 84:   if (LIKELY((std::is_same::value
> We also use bool somewhere, at least bit-packing.cc instantiates the method
Probably ParquetBoolDecoder::DecodeValue(). Might be worth seeing if you can 
switch that to storing an array of uint8_t and remove this.

I think supporting signed values in these low-level routines is probably adding 
unnecessary complexity.



--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 24 Jul 2019 00:53:10 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13748 )

Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution
..


Patch Set 16:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13748/16/be/src/util/hook-metrics.cc
File be/src/util/hook-metrics.cc:

http://gerrit.cloudera.org:8080/#/c/13748/16/be/src/util/hook-metrics.cc@58
PS16, Line 58:
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/13748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb88422f7cfe86947d11ce57d2b4c63e57d1b643
Gerrit-Change-Number: 13748
Gerrit-PatchSet: 16
Gerrit-Owner: radford nguyen 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: radford nguyen 
Gerrit-Comment-Date: Wed, 24 Jul 2019 00:52:05 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-23 Thread radford nguyen (Code Review)

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13748

to look at the new patch set (#16).

Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution
..

IMPALA-8571[WIP]: improve QueryEventHook execution

(WIP because still need to implement polling of metrics by backend)

This commit hardens guarantees around QueryEventHook execution by
adding the following features:

*hook timeout/cancellation*

A timeout for hook execution can be configured through the backend
flag `query_event_hook_timeout_s`, which specified a timeout value
in seconds. If a hook has not completed execution within this timeout
(measured from hook submission, not execution) then the hook task
will be cancelled in order to free up resources.

*hook rejection*

The hook execution engine now has a fixed-capacity work queue whose
capacity can be configured through the backend flag
`query_event_hook_queue_capacity`. This queue is used to store
hook tasks that are submitted when there are no free threads
available for hook execution. All hook tasks submitted when the
queue is at capacity will be rejected and logged without affecting
the result of the query.

*hook performance metrics*

The following hook metrics are captured:

*query-event-hook.${hook_method}.execution-rejections*

Counter indicating how many submitted tasks have been rejected
due to a full work queue

*query-event-hook.${hook_method}.execution-exceptions*

Counter indicating how many tasks have thrown an exception
during execution

*query-event-hook.${hook_method}.execution-timeouts*

Counter indicating how many tasks have been cancelled due to
not completing within {@code hookTimeout_s} of submission.

*query-event-hook.${hook_method}.execution-submissions*

Counter indicating the number of times ${hookClass}.${method}
has been submitted for execution.

*query-event-hook.${hook_method}.mean-execution-time*

Mean time in [ns] that ${hook_name} has taken to complete,
whether normally or by error (e.g. timeout or exception).

*query-event-hook.${hook_method}.mean-queued-time*

Mean time in [ns] between hook task submission
and hook task execution. This indicates how long a hook
task has been queued waiting to execute.

Testing:

- added unit tests for new features
- re-ran existing E2E tests

Change-Id: Ibb88422f7cfe86947d11ce57d2b4c63e57d1b643
---
M be/src/service/frontend.cc
M be/src/service/frontend.h
M be/src/service/impala-server.cc
M be/src/util/CMakeLists.txt
M be/src/util/backend-gflag-util.cc
A be/src/util/hook-metrics-test.cc
A be/src/util/hook-metrics.cc
A be/src/util/hook-metrics.h
M common/thrift/BackendGflags.thrift
M common/thrift/Frontend.thrift
M common/thrift/metrics.json
A fe/src/main/java/org/apache/impala/hooks/FixedCapacityQueryHookExecutor.java
M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
A 
fe/src/test/java/org/apache/impala/hooks/FixedCapacityQueryHookExecutorTest.java
M fe/src/test/java/org/apache/impala/hooks/QueryEventHookManagerTest.java
M query-event-hook-api/src/main/java/org/apache/impala/hooks/QueryEventHook.java
19 files changed, 1,375 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/13748/16
--
To view, visit http://gerrit.cloudera.org:8080/13748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb88422f7cfe86947d11ce57d2b4c63e57d1b643
Gerrit-Change-Number: 13748
Gerrit-PatchSet: 16
Gerrit-Owner: radford nguyen 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: radford nguyen

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13807/4/be/src/util/bit-packing-vectorized.h
File be/src/util/bit-packing-vectorized.h:

PS4:
> We could also take option 2 now and add a TODO to include the code generati
That is ok by me



--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 24 Jul 2019 00:38:58 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13746 )

Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13746/7/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java:

http://gerrit.cloudera.org:8080/#/c/13746/7/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@123
PS7, Line 123: String[] commandWithoutAuth = {"impala-shell.sh", "", 
String.format("--query=%s", query)};
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/13746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534
Gerrit-Change-Number: 13746
Gerrit-PatchSet: 7
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 24 Jul 2019 00:29:35 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint

2019-07-23 Thread Bharath Vissapragada (Code Review)

Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13746 )

Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint
..


Patch Set 7:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/13746/6/fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java:

http://gerrit.cloudera.org:8080/#/c/13746/6/fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java@116
PS6, Line 116: 
> line has trailing whitespace
Done


http://gerrit.cloudera.org:8080/#/c/13746/6/fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java@133
PS6, Line 133:
 :
> Instead of catching the assertion failure to log and rethrow it, I think yo
Done


http://gerrit.cloudera.org:8080/#/c/13746/6/fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java@140
PS6, Line 140:
> nit: I probably got this wrong in some places in my patches around this, bu
removed it here. Basic is specific to http, but here were are testing all the 
protocols.


http://gerrit.cloudera.org:8080/#/c/13746/6/fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java@143
PS6, Line 143:
> We don't really want to inherit all of the JDBC related setup stuff here, e
ya, I should've seen that. Fixed it now.


http://gerrit.cloudera.org:8080/#/c/13746/6/fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java@149
PS6, Line 149:
> Could you make the 'select logged_in_user()' and actually verify that its c
Done


http://gerrit.cloudera.org:8080/#/c/13746/6/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/13746/6/shell/impala_shell.py@804
PS6, Line 804: assert options.protocol.lower() == 'beeswax'
 : port = str(DEFAULT_BEESWAX_PORT)
> Probably only want to log if its actually wrong, and we should probably ret
oops, debugging message leaked here. thanks for catching. I don't think anyone 
would ever hit this assertion unless they are changing something in the code. 
So I think its ok to keep it as is.



--
To view, visit http://gerrit.cloudera.org:8080/13746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534
Gerrit-Change-Number: 13746
Gerrit-PatchSet: 7
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 24 Jul 2019 00:29:24 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint

2019-07-23 Thread Bharath Vissapragada (Code Review)

Hello Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13746

to look at the new patch set (#7).

Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint
..

IMPALA-8717: impala-shell support for HS2 HTTP endpoint

Adds impala-shell support to connect to HiveServer2 HTTP endpoint.
Relies on toolchain change at https://gerrit.cloudera.org/#/c/13725/.

Use --protocol='hs2-http' to enable this behavior.

Example usages:
---
impala-shell --protocol='hs2-http'  (No auth)
impala-shell --protocol='hs2-http' --ldap -u. (PLAIN auth)
impala-shell --protocol-'hs2-http' --ssl --ca_cert... (TLS)
impala-shell --protocol='hs2-http' --ldap --ssl --ca_cert... (LDAP +
TLS)

Limitations:
---
- Does not support Kerberos (-k) due to lack ot SPNEGO support.

Testing:

- Parameterized existing shell tests to support this combination.
- Added shell test coverage for LDAP auth.

Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534
---
M be/src/service/impala-server.cc
M bin/impala-config.sh
A fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M shell/impala_client.py
M shell/impala_shell.py
M shell/option_parser.py
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/common/impala_test_suite.py
M tests/common/test_dimensions.py
M tests/conftest.py
M tests/custom_cluster/test_client_ssl.py
M tests/run-tests.py
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
16 files changed, 284 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/13746/7
--
To view, visit http://gerrit.cloudera.org:8080/13746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534
Gerrit-Change-Number: 13746
Gerrit-PatchSet: 7
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8434: retain tables and functions in altering database

Quanlong Huang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13904


Change subject: IMPALA-8434: retain tables and functions in altering database
..

IMPALA-8434: retain tables and functions in altering database

In the legacy catalog implementation (ImpaladCatalog), when altering a
database, the tables and functions in it will disappear until we run
INVALIDATE METADATA to reset the cache. The cause is that we just
replace the old Db object with the new one deserialized from the
TDatabase. We should migrate the existing tables and functions to the
new Db object.

Tests:
 - Add test_metadata_after_alter_database for the bug.

Change-Id: Ia3dc9857fd2733e20cf10fbe17bb1a4670d7d015
---
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M tests/metadata/test_ddl.py
2 files changed, 27 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/13904/1
--
To view, visit http://gerrit.cloudera.org:8080/13904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3dc9857fd2733e20cf10fbe17bb1a4670d7d015
Gerrit-Change-Number: 13904
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang

[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13903 )

Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout 
flag for HS2
..


Patch Set 1: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/401/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Wed, 24 Jul 2019 00:00:53 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list

Tim Armstrong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13899 )

Change subject: IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list
..

IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list

Adds a plain-text space-separated image list in
docker/docker-images.txt. This is generated based on the images built by
CMake, so is kept in sync with images added to or removed from the
CMake file.

Duplicated logic per image is removed - instead there is a helper
function that is called for each daemon image to be built.

Rips out the timestamp mechanism that was intended to avoid unnecessary
container rebuilds, but has turned out to be brittle. Instead the
containers are rebuilt each time the rule is invoked.

This moves some subdirectories so that the image tag matches the
subdirectory, to simplify the build scripts.

Change-Id: I4d8e215e9b07c6491faa4751969a30f0ed373fe3
Reviewed-on: http://gerrit.cloudera.org:8080/13899
Tested-by: Impala Public Jenkins 
Reviewed-by: Lars Volker 
---
M .gitignore
M docker/CMakeLists.txt
R docker/impalad_coord_exec/Dockerfile
R docker/impalad_coordinator/Dockerfile
R docker/impalad_executor/Dockerfile
M docker/push-images.sh
6 files changed, 35 insertions(+), 101 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Lars Volker: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/13899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d8e215e9b07c6491faa4751969a30f0ed373fe3
Gerrit-Change-Number: 13899
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13872 )

Change subject: IMPALA-8766: Change cloud dependencies to use 
hadoop-cloud-storage
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08f1c36ecf54ac277d99e2d2843163eada732e50
Gerrit-Change-Number: 13872
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 23:47:59 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13903


Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout 
flag for HS2
..

IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2

Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
---
M docs/topics/impala_client.xml
1 file changed, 45 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/13903/1
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni

[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13903 )

Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout 
flag for HS2
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/401/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 23 Jul 2019 23:37:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list

2019-07-23 Thread Lars Volker (Code Review)

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13899 )

Change subject: IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list
..


Patch Set 2: Code-Review+2

LGTM, thanks for fixing this! I tried this out in a dev setup and it works.


--
To view, visit http://gerrit.cloudera.org:8080/13899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e215e9b07c6491faa4751969a30f0ed373fe3
Gerrit-Change-Number: 13899
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Tue, 23 Jul 2019 23:17:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13899 )

Change subject: IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e215e9b07c6491faa4751969a30f0ed373fe3
Gerrit-Change-Number: 13899
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Tue, 23 Jul 2019 23:15:47 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 2: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/400/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 23 Jul 2019 22:37:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files

Ethan Xue has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13857 )

Change subject: IMPALA-8549: Add support for scanning DEFLATE text files
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13857/1/tests/query_test/test_compressed_formats.py
File tests/query_test/test_compressed_formats.py:

http://gerrit.cloudera.org:8080/#/c/13857/1/tests/query_test/test_compressed_formats.py@75
PS1, Line 75:   # TODO: How about LZO?
> should we file a separate JIRA for this?
Sounds like a plan: https://issues.apache.org/jira/browse/IMPALA-8787



--
To view, visit http://gerrit.cloudera.org:8080/13857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 3
Gerrit-Owner: Ethan Xue 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Ethan Xue 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 22:18:23 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/400/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 23 Jul 2019 22:15:12 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13899 )

Change subject: IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3966/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e215e9b07c6491faa4751969a30f0ed373fe3
Gerrit-Change-Number: 13899
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Tue, 23 Jul 2019 22:09:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl

Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13883 )

Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and 
BufferedPRS impl
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h
File be/src/runtime/non-blocking-row-batch-queue.h:

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h@32
PS3, Line 32:  NonBlockingRowBatchQueue
> Yes, I agree the clean up of the RowBatchQueue interface is a good thing an
Adding support for TryAddBatch and TryGetBatch to BlockingQueue isn't exactly 
trivial because it's using two internal std::deques (one for writing and one 
for reading). So I'm not sure if its worth the effort unless we have a long 
term use case? It's also more overhead to create a full BlockingQueue if we 
just end up just using the non-blocking APIs. The 
KrpcDataStreamRecvr::SenderQueue, for example, probably can't use any of the 
blocking APIs in BlockingQueue because it uses a lock to protect a bunch of 
member variables (since BlockingQueue BlockingGet/Put potentially waits on 
internal condition variables).

What about just using std::queue inside BufferedPlanRootSink for now, and 
deferring the rest to a later patch when we add the BufferedTupleStream 
integration? I will still cleanup RowBatchQueue, but BufferedPlanRootSink won't 
use it for now. Thoughts?



--
To view, visit http://gerrit.cloudera.org:8080/13883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
Gerrit-Change-Number: 13883
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 22:04:07 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add default value to switch in kudu-util

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13901 )

Change subject: Add default value to switch in kudu-util
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3965/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a8ab4b912d443582c8ac3899f370a4b838e934
Gerrit-Change-Number: 13901
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:42:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13886 )

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..

IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function

Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Reviewed-on: http://gerrit.cloudera.org:8080/13886
Tested-by: Impala Public Jenkins 
Reviewed-by: Quanlong Huang 
---
M docs/topics/impala_functions.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_misc_functions.xml
3 files changed, 112 insertions(+), 26 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Quanlong Huang: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13886 )

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:37:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13886 )

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..


Patch Set 3: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/399/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:35:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13886 )

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..


Patch Set 2: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/398/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:33:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13886

to look at the new patch set (#3).

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..

IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function

Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
---
M docs/topics/impala_functions.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_misc_functions.xml
3 files changed, 112 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13886/3
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13886 )

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/399/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:31:52 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13886 )

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:

http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@143
PS2, Line 143: of
> nit: or
Done


http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@199
PS2, Line 199: 'NULL','NULL','3'
> Looks like we only give examples for "." and "*". It'd be better if we can
Done



--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:31:54 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list

Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13899


Change subject: IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list
..

IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list

Adds a plain-text space-separated image list in
docker/docker-images.txt. This is generated based on the images built by
CMake, so is kept in sync with images added to or removed from the
CMake file.

Duplicated logic per image is removed - instead there is a helper
function that is called for each daemon image to be built.

Rips out the timestamp mechanism that was intended to avoid unnecessary
container rebuilds, but has turned out to be brittle. Instead the
containers are rebuilt each time the rule is invoked.

This moves some subdirectories so that the image tag matches the
subdirectory, to simplify the build scripts.

Change-Id: I4d8e215e9b07c6491faa4751969a30f0ed373fe3
---
M .gitignore
M docker/CMakeLists.txt
R docker/impalad_coord_exec/Dockerfile
R docker/impalad_coordinator/Dockerfile
R docker/impalad_executor/Dockerfile
M docker/push-images.sh
6 files changed, 35 insertions(+), 101 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/13899/2
--
To view, visit http://gerrit.cloudera.org:8080/13899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d8e215e9b07c6491faa4751969a30f0ed373fe3
Gerrit-Change-Number: 13899
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13886 )

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:

http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@143
PS2, Line 143: of
nit: or


http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@199
PS2, Line 199: 'NULL','NULL','3'
Looks like we only give examples for "." and "*". It'd be better if we can add 
one more example for "[]" or "[*]". E.g.

 QUERY
SELECT GET_JSON_OBJECT(t.json, '$[1]'),
 GET_JSON_OBJECT(t.json, '$[*]')
FROM (VALUES (
 ('["a", "b", "c"]' AS json),
 ('["a", "b"]'),
 ('["a"]')
)) t
 RESULTS
'b','["a","b","c"]'
'b','["a","b"]'
'NULL','a'



--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:25:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13886

to look at the new patch set (#2).

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..

IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function

Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
---
M docs/topics/impala_functions.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_misc_functions.xml
3 files changed, 98 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13886/2
--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8765: [DOCS] Document the GET JSON OBJECT function

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13886 )

Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/398/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04
Gerrit-Change-Number: 13886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:14:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] Add default value to switch in kudu-util

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13901 )

Change subject: Add default value to switch in kudu-util
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a8ab4b912d443582c8ac3899f370a4b838e934
Gerrit-Change-Number: 13901
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:12:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] Add default value to switch in kudu-util

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13901 )

Change subject: Add default value to switch in kudu-util
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4641/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a8ab4b912d443582c8ac3899f370a4b838e934
Gerrit-Change-Number: 13901
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:12:21 +
Gerrit-HasComments: No

[Impala-ASF-CR] Add default value to switch in kudu-util

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13901 )

Change subject: Add default value to switch in kudu-util
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a8ab4b912d443582c8ac3899f370a4b838e934
Gerrit-Change-Number: 13901
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:12:07 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-8575: [DOCS] Document the query options for Parquet page 
indexes
..


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/397/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:02:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] Add default value to switch in kudu-util

2019-07-23 Thread Attila Bukor (Code Review)

Hello Thomas Tauber-Marshall, Anonymous Coward (314), Adar Dembo, Grant Henke, 
Csaba Ringhofer,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/13901

to review the following change.


Change subject: Add default value to switch in kudu-util
..

Add default value to switch in kudu-util

KuduDataTypeToColumnType in kudu-util.cc has a switch that translates
kudu::client::KuduColumnSchema::DataType to PrimitiveType. It returns
PrimitiveType::INVALID_TYPE if an invalid type is passed, but it was
done after the switch instead of the 'default' case which leads to a
warning if a new unhandled Kudu type is added to the header.

Change-Id: I81a8ab4b912d443582c8ac3899f370a4b838e934
---
M be/src/exec/kudu-util.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/13901/1
--
To view, visit http://gerrit.cloudera.org:8080/13901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81a8ab4b912d443582c8ac3899f370a4b838e934
Gerrit-Change-Number: 13901
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Thomas Tauber-Marshall

[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files

Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13857 )

Change subject: IMPALA-8549: Add support for scanning DEFLATE text files
..


Patch Set 3: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 3
Gerrit-Owner: Ethan Xue 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Ethan Xue 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 20:59:32 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files

Ethan Xue has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13857 )

Change subject: IMPALA-8549: Add support for scanning DEFLATE text files
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/13857/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13857/2//COMMIT_MSG@11
PS2, Line 11: In Hadoop, the zlib library
: (an implementation of the DEFLATE algorithm) is used
: to compress text files into .DEFLATE files,
: which are not in the raw deflate format but rather
: the zlib format (has a zlib header and footer).
> would be good to mention that the zlib library supports three flavors of de
Done


http://gerrit.cloudera.org:8080/#/c/13857/2/be/src/util/codec.cc
File be/src/util/codec.cc:

http://gerrit.cloudera.org:8080/#/c/13857/2/be/src/util/codec.cc@150
PS2, Line 150: case THdfsCompression::DEFLATE:
 : case THdfsCompression::GZIP:
 :   decompressor->reset(new GzipDecompressor(mem_pool, reuse, 
false));
> so the decompressor doesn't need to differentiate between ZLIB, GZIP, and D
Yes. The compressor differentiates between GZIP and ZLIB/DEFLATE, as it needs 
to know what value of window bits to use. The decompressor on the other hand, 
can implicitly detect GZIP and ZLIB/DEFLATE formats: 
https://github.com/apache/impala/blob/2813d0c18414a5b7977cc713755daed7e53358ce/be/src/util/decompress.cc#L53-L58.
 Note again, as it can be confusing, that THdfsCompression::DEFLATE and 
THdfsCompression::ZLIB are equivalent.


http://gerrit.cloudera.org:8080/#/c/13857/1/tests/query_test/test_compressed_formats.py
File tests/query_test/test_compressed_formats.py:

http://gerrit.cloudera.org:8080/#/c/13857/1/tests/query_test/test_compressed_formats.py@71
PS1, Line 71:   def test_compressed_formats(self, vector):
> this test got skipped in your test run: https://jenkins.impala.io/job/ubunt
My guess is because of the code on line 65. If the exploration strategy is 
'core' then this test is skipped. I will rebuild this patch on Jenkins with 
exploration strategy set to 'exhaustive'.



--
To view, visit http://gerrit.cloudera.org:8080/13857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 2
Gerrit-Owner: Ethan Xue 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Ethan Xue 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 20:58:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files

Hello Abhishek Rawat, Sahil Takiar, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13857

to look at the new patch set (#3).

Change subject: IMPALA-8549: Add support for scanning DEFLATE text files
..

IMPALA-8549: Add support for scanning DEFLATE text files

Hadoop tools such as Hive and MapReduce support
reading and writing text files compressed using
the deflate algorithm. In Hadoop, the zlib library
(an implementation of the DEFLATE algorithm) is used
to compress text files into .DEFLATE files,
which are not in the raw deflate format but rather
the zlib format (the zlib library supports three flavors
of deflate, and Hadoop is using the flavor that
compresses data into deflate with zlib wrappings rather
than the raw deflate format)

This patch adds support to Impala for scanning
.DEFLATE files of tables stored using text.
To avoid confusion, it should be noted that although
these files have a compression type of DEFLATE in Impala,
they should be treated as if their compression type is ZLIB.

Testing:
There is a pre-existing unit test that validates
compressing/decompressing data with compression type
DEFLATE. Also, modified existing end-to-end testing
that simulates querying files of various formats and
compression types. All core tests pass.

Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
---
M be/src/exec/hdfs-text-scanner.cc
M be/src/exec/hdfs-text-scanner.h
M be/src/util/codec.cc
M testdata/workloads/functional-query/functional-query_exhaustive.csv
M tests/query_test/test_compressed_formats.py
5 files changed, 14 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/13857/3
--
To view, visit http://gerrit.cloudera.org:8080/13857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 3
Gerrit-Owner: Ethan Xue 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Ethan Xue 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar

[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13857 )

Change subject: IMPALA-8549: Add support for scanning DEFLATE text files
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3964/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 2
Gerrit-Owner: Ethan Xue 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Ethan Xue 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 20:47:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-8575: [DOCS] Document the query options for Parquet page 
indexes
..


Patch Set 1:

Zoltan,
Could you help me to add more context to the docs?
Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 23 Jul 2019 20:42:16 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-8575: [DOCS] Document the query options for Parquet page 
indexes
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/397/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 23 Jul 2019 20:41:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13900


Change subject: IMPALA-8575: [DOCS] Document the query options for Parquet page 
indexes
..

IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

- The following options were documented:
- parquet_read_page_index
- parquet_write_page_index
- parquet_page_row_count_limit

Change-Id: I46c1941269feff18306863f784aa36f5037da1db
---
M docs/impala.ditamap
A docs/topics/impala_parquet_page_row_count_limit.xml
A docs/topics/impala_parquet_read_page_index.xml
A docs/topics/impala_parquet_write_page_index.xml
4 files changed, 187 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13900/1
--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni

[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files

Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13857 )

Change subject: IMPALA-8549: Add support for scanning DEFLATE text files
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13857/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13857/2//COMMIT_MSG@11
PS2, Line 11: In Hadoop, the zlib library
: (an implementation of the DEFLATE algorithm) is used
: to compress text files into .DEFLATE files,
: which are not in the raw deflate format but rather
: the zlib format (has a zlib header and footer).
would be good to mention that the zlib library supports three flavors of 
deflate, and that we are specifically choosing to use the flavor with that 
writes deflate with zlib wrappings rather than the raw deflate format.


http://gerrit.cloudera.org:8080/#/c/13857/2/be/src/util/codec.cc
File be/src/util/codec.cc:

http://gerrit.cloudera.org:8080/#/c/13857/2/be/src/util/codec.cc@150
PS2, Line 150: case THdfsCompression::DEFLATE:
 : case THdfsCompression::GZIP:
 :   decompressor->reset(new GzipDecompressor(mem_pool, reuse, 
false));
so the decompressor doesn't need to differentiate between ZLIB, GZIP, and 
DEFLATE like the compressor does?



--
To view, visit http://gerrit.cloudera.org:8080/13857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 2
Gerrit-Owner: Ethan Xue 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Ethan Xue 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 20:23:36 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files

Hello Abhishek Rawat, Sahil Takiar, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13857

to look at the new patch set (#2).

Change subject: IMPALA-8549: Add support for scanning DEFLATE text files
..

IMPALA-8549: Add support for scanning DEFLATE text files

Hadoop tools such as Hive and MapReduce support
reading and writing text files compressed using
the deflate algorithm. In Hadoop, the zlib library
(an implementation of the DEFLATE algorithm) is used
to compress text files into .DEFLATE files,
which are not in the raw deflate format but rather
the zlib format (has a zlib header and footer).

This patch adds support to Impala for scanning
.DEFLATE files of tables stored using text.
To avoid confusion, it should be noted that although
these files have a compression type of DEFLATE in Impala,
they should be treated as if their compression type is ZLIB.

Testing:
There is a pre-existing unit test that validates
compressing/decompressing data with compression type
DEFLATE. Also, modified existing end-to-end testing
that simulates querying files of various formats and
compression types. All core tests pass.

Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
---
M be/src/exec/hdfs-text-scanner.cc
M be/src/exec/hdfs-text-scanner.h
M be/src/util/codec.cc
M testdata/workloads/functional-query/functional-query_exhaustive.csv
M tests/query_test/test_compressed_formats.py
5 files changed, 14 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/13857/2
--
To view, visit http://gerrit.cloudera.org:8080/13857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 2
Gerrit-Owner: Ethan Xue 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Ethan Xue 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar

[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files

Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13857 )

Change subject: IMPALA-8549: Add support for scanning DEFLATE text files
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13857/1/tests/query_test/test_compressed_formats.py
File tests/query_test/test_compressed_formats.py:

http://gerrit.cloudera.org:8080/#/c/13857/1/tests/query_test/test_compressed_formats.py@71
PS1, Line 71:   def test_compressed_formats(self, vector):
this test got skipped in your test run: 
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/6711/testReport/query_test.test_compressed_formats/TestCompressedFormats/
 any ideas why?


http://gerrit.cloudera.org:8080/#/c/13857/1/tests/query_test/test_compressed_formats.py@75
PS1, Line 75:   # TODO: How about LZO?
should we file a separate JIRA for this?



--
To view, visit http://gerrit.cloudera.org:8080/13857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 1
Gerrit-Owner: Ethan Xue 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Ethan Xue 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 19:59:57 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl

2019-07-23 Thread Michael Ho (Code Review)

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13883 )

Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and 
BufferedPRS impl
..


Patch Set 4:

(4 comments)

Unifying the RowBatchQueue implementation and cleaning up the interface makes 
sense to me. Please see replies below for a suggestion to do it without 
splitting it into two classes in this patch. Also, some of the clean ups in 
KRPC code can be done in a follow-up patch.

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/exec/buffered-plan-root-sink.h
File be/src/exec/buffered-plan-root-sink.h:

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/exec/buffered-plan-root-sink.h@29
PS3, Line 29: The blocking behavior follows
: /// the same semantics as BlockingPlanRootSink.
> Yeah, it probably makes more sense once we change BufferedPlanRootSink to u
Yes, I guess at some point soon, we may want to consolidate on the 
implementation but I am fine with keeping the two classes for now.


http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/exec/buffered-plan-root-sink.h@42
PS3, Line 42: RowBatchQueue* batch_queue)
> Dependency injection. I'm not sure if this is the right way to do this in C
Thanks for the link. I can see the advantage being that different users of this 
class can pass in different implementation of RowBatchQueue interface for their 
own purposes. However, given the rather rigid use case of PlanRootSink right 
now, it seems like an unnecessary complication until the need for this arises. 
Also, please see comments elsewhere in which this ctor is invoked. The 
RowBatchQueue object seems to be leaked right now as the code stands.

Given the limited charter of BufferedPlanRootSink, the code seems simpler if 
the batch_queue is owned by BufferedPlanRootSink instead and that also makes 
the reasoning of the lifetime of RowBatchQueue object clearer (i.e. it won't 
outlive that of the owning BufferedPlanRootSink).


http://gerrit.cloudera.org:8080/#/c/13883/4/be/src/exec/buffered-plan-root-sink.cc
File be/src/exec/buffered-plan-root-sink.cc:

http://gerrit.cloudera.org:8080/#/c/13883/4/be/src/exec/buffered-plan-root-sink.cc@45
PS4, Line 45:  is_full_.Wait(l);
> The existing BlockingQueue doesn't expose its lock, which makes the synchro
I guess the answer to my question is that we access the BlockingQueue with 
'lock_' held so we really need a non-blocking interface so we won't block other 
threads from consuming the row batch. The 'lock_' is necessary for 
synchronization multiple threads calling GetNext() / Close() / Send() 
concurrently.

I suppose using RowBatchQueue::TryAddBatch() will fit the purpose, right ?


http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h
File be/src/runtime/non-blocking-row-batch-queue.h:

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h@32
PS3, Line 32:  NonBlockingRowBatchQueue
> Adding TryAddBatch() makes sense to me.
Yes, I agree the clean up of the RowBatchQueue interface is a good thing and 
you seem to also agree that refactoring RowBatchQueue into two classes may be 
overkill. How about you keep the necessary clean-up for the RowBatchQueue 
interface but instead of splitting it into two classes, we can keep the 
original RowBatchQueue instead. Like your TODO suggested above, we can hide the 
implementation of RowBatchQueue by instantiating a BlockingQueue object in 
RowBatchQueue class instead of inheriting it from BlockingQueue.
In addition, a new interface called TryAddBatch() will be added to support the 
non-blocking behavior. Some modification may be needed in the BlockingQueue 
class to support the non-blocking insert behavior.

So, the end result is:
- we will still have a single RowBatchQueue class for this patch albeit with a 
better defined interface.

- when we get around to implement a version of the queue backed by BTS, we can 
do the refactoring like this patch and RowBatchQueue can naturally become 
BlockingRowBatchQueue.

The cleanup of KRPC sender / receiver can be done as a follow-on patch.

What do you think ?



--
To view, visit http://gerrit.cloudera.org:8080/13883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
Gerrit-Change-Number: 13883
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 19:34:49 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13874 )

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..


Patch Set 10: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 10
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 23 Jul 2019 19:13:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8772: Import Testcase failed for SQL without table refs

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13893 )

Change subject: IMPALA-8772: Import Testcase failed for SQL without table refs
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3963/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50d77d7de44bb140598a1e8db4da85a5ec87f31e
Gerrit-Change-Number: 13893
Gerrit-PatchSet: 2
Gerrit-Owner: Jiawei Wang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jiawei Wang 
Gerrit-Comment-Date: Tue, 23 Jul 2019 18:58:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13874 )

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..


Patch Set 11:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3962/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 11
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 23 Jul 2019 18:52:43 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl

Hello Michael Ho, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13883

to look at the new patch set (#5).

Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and 
BufferedPRS impl
..

IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl

Introduces a generic RowBatchQueue interface with a blocking and
non-blocking implementation. The blocking implementation is a
re-factored version of the current RowBatchQueue. The non-blocking
implementation is simple wrapper around std::queue. The current
RowBatchQueue, which is used by the scanners, is renamed to
BlockingRowBatchQueue and it is a subclass of the new RowBatchQueue
interface. This patch stops short of completely abstracting all the
details of the current RowBatchQueue and instead includes a few TODOs.
NonBlockingRowBatchQueue has max capacity, after which calls to AddBatch
will return false.

Implements BufferedPlanRootSink using the new RowBatchQueue interface.
Currently, the NonBlockingRowBatchQueue is injected into the
BufferedPlanRootSink, however, the implementation of
BufferedPlanRootSink is not tied to NonBlockingRowBatchQueue, although
it does assume the RowBatchQueue is not thread safe. This allows a
future patch to add a RowBatchQueue backed by a BufferedTupleStream
without re-factoring BufferedPlanRootSink.

BufferedPlanRootSink FlushFinal blocks until the consumer thread has
processed all RowBatches. This ensures that the coordinator fragment
stays alive until all results are fetched, but allows all other
fragments to be shutdown immediately.

Testing:
* Running core tests
* Updated tests/query_test/test_result_spooling.py

Follow up work:
* Add a stress test in test_result_spooling.py to validate the
synchronization logic in BufferedPlanRootSink
* Handle Send calls where num_results < batch->num_rows()
* Add a direct write path in Send that directly writes a RowBatch to a
QueryResultSet, if one is available and if the RowBatchQueue is empty
* Implement a RowBatchQueue backed by a BufferedTupleStream
* Re-factor the resource management logic to release all
non-coordinator fragment resources

Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
---
M be/src/exec/blocking-plan-root-sink.cc
M be/src/exec/blocking-plan-root-sink.h
M be/src/exec/buffered-plan-root-sink.cc
M be/src/exec/buffered-plan-root-sink.h
M be/src/exec/data-sink.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/kudu-scan-node.cc
M be/src/exec/plan-root-sink.cc
M be/src/exec/plan-root-sink.h
M be/src/exec/scan-node.cc
M be/src/exec/scan-node.h
M be/src/exec/scanner-context.cc
M be/src/runtime/CMakeLists.txt
R be/src/runtime/blocking-row-batch-queue.cc
A be/src/runtime/blocking-row-batch-queue.h
A be/src/runtime/non-blocking-row-batch-queue.cc
A be/src/runtime/non-blocking-row-batch-queue.h
M be/src/runtime/row-batch-queue.h
M be/src/util/blocking-queue.h
M tests/query_test/test_result_spooling.py
20 files changed, 464 insertions(+), 97 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13883/5
--
To view, visit http://gerrit.cloudera.org:8080/13883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
Gerrit-Change-Number: 13883
Gerrit-PatchSet: 5
Gerrit-Owner: Sahil Takiar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1

2019-07-23 Thread Attila Jeges (Code Review)

Attila Jeges has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13722 )

Change subject: IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1
..


Patch Set 10:

(23 comments)

Some more nitpicky comments, I'll continue tomorrow.

http://gerrit.cloudera.org:8080/#/c/13722/10//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13722/10//COMMIT_MSG@17
PS10, Line 17: is a string literal provided by the
 : user and its value can't come from a column.
nit: must specify a string literal and cannot be used with any other kind of a 
string expression.


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/exprs/cast-expr.h
File be/src/exprs/cast-expr.h:

http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/exprs/cast-expr.h@26
PS10, Line 26: //
nit: /// here and below.


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/exprs/cast-expr.cc
File be/src/exprs/cast-expr.cc:

http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/exprs/cast-expr.cc@30
PS10, Line 30: RuntimeState* state, ScalarExprEvaluator* eval) const {
nit: DCHECK(eval != nullptr);

here and in CloseEvaluator();


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/exprs/cast-functions-ir.cc
File be/src/exprs/cast-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/exprs/cast-functions-ir.cc@182
PS10, Line 182:char buf[buf_len];
  : int ret_val = tv.Format(*format_ctx, buf_len, buf);
Maybe instead of allocating 'buf' on the stack, we should allocate it on the 
heap (unless it is guaranteed that 'buf_len' is a fairly small number).

vector buf(buf_len);
int ret_val = tv.Format(*format_ctx, buf.size(), buf.data());


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/exprs/cast-functions-ir.cc@204
PS10, Line 204: char buf[buf_len];
  : int ret_val = dv.Format(*format_ctx, buf_len, buf);
Same as L182 above.


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/date-parse-util.cc
File be/src/runtime/date-parse-util.cc:

http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/date-parse-util.cc@127
PS10, Line 127: dt_ctx.has_date_toks
In DateParser::ParseSimpleDateFormat() dt_ctx.has_date_toks is DCHECKed at the 
beginning of the function.

Any reason we don't make that assumption here?


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/date-parse-util.cc@152
PS10, Line 152: !=
<


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-parser.h
File be/src/runtime/datetime-iso-sql-format-parser.h:

http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-parser.h@71
PS10, Line 71: '*tok'
**tok ?


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-parser.cc
File be/src/runtime/datetime-iso-sql-format-parser.cc:

http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-parser.cc@172
PS10, Line 172: dt_ctx_it
Maybe 'current_tok_ind' ?


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-parser.cc@195
PS10, Line 195:   // Next token, following the separator sequence.
  :   *tok = _ctx.toks[*dt_ctx_it];
Thanks for refactoring the algorithm and moving all the separator skipping to a 
separate function.

Maybe L195-196 could be moved to after L49 and then 'tok' wouldn't have to be 
passed to the function. It feels redundant to pass both 'tok' and 'dt_ctx_it' 
to ProcessSeparators.


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-tokenizer.h
File be/src/runtime/datetime-iso-sql-format-tokenizer.h:

http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-tokenizer.h@91
PS10, Line 91: we
nit: we have


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-tokenizer.cc
File be/src/runtime/datetime-iso-sql-format-tokenizer.cc:

http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-tokenizer.cc@110
PS10, Line 110: unsigned
long?

I could be wrong but I think "unsigned" is an alias for "unsigned int", so 
there is a "long->unsigned int" implicit cast happening behind the assignment. 
We should avoid implicit casts and define 'curr_token_size' as long.


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-iso-sql-format-tokenizer.cc@110
PS10, Line 110: long)MAX_TOKEN_SIZE
Either use static_cast or define MAX_TOKEN_SIZE as a long.


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-parser-common.h
File be/src/runtime/datetime-parser-common.h:

http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-parser-common.h@148
PS10, Line 148: token group
token


http://gerrit.cloudera.org:8080/#/c/13722/10/be/src/runtime/datetime-parser-common.h@150
PS10, Line 150: token groups
token

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13874 )

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..


Patch Set 11:

LocalIncompleteTable can only be acquired by getTableIfCached which only exists 
on the code path of GET_TABLES HS2 operation. It won't be used at other places. 
As long as getTable is called, a completely loaded table will be acquired. So 
having LocalIncompleteTable#isLoaded return true as same as LocalFsTable does 
won't cause troubles in the previous patch.

Anyway, to avoid confusions or introducing bugs in the future, I fix the 
isLoaded implementation.


--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 11
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 23 Jul 2019 18:18:55 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8772: Import Testcase failed for SQL without table refs

2019-07-23 Thread Jiawei Wang (Code Review)

Jiawei Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13893 )

Change subject: IMPALA-8772: Import Testcase failed for SQL without table refs
..


Patch Set 2:

(5 comments)

Thanks for your feedback!

http://gerrit.cloudera.org:8080/#/c/13893/1/tests/metadata/test_testcase_builder.py
File tests/metadata/test_testcase_builder.py:

http://gerrit.cloudera.org:8080/#/c/13893/1/tests/metadata/test_testcase_builder.py@41
PS1, Line 41: ate_query = "
> execute_query_expect_success
Done


http://gerrit.cloudera.org:8080/#/c/13893/1/tests/metadata/test_testcase_builder.py@43
PS1, Line 43:
> assert len(result.data) == 1 ?
Done


http://gerrit.cloudera.org:8080/#/c/13893/1/tests/metadata/test_testcase_builder.py@48
PS1, Line 48: self.execute_query_expect_success(self.client, 
testcase_load_query)
> Implement the TODO?
Done


http://gerrit.cloudera.org:8080/#/c/13893/1/tests/metadata/test_testcase_builder.py@49
PS1, Line 49:
> flake8: W391 blank line at end of file
Done


http://gerrit.cloudera.org:8080/#/c/13893/1/tests/metadata/test_testcase_builder.py@49
PS1, Line 49:
> Yep, remove these blank lines?
Done



--
To view, visit http://gerrit.cloudera.org:8080/13893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50d77d7de44bb140598a1e8db4da85a5ec87f31e
Gerrit-Change-Number: 13893
Gerrit-PatchSet: 2
Gerrit-Owner: Jiawei Wang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jiawei Wang 
Gerrit-Comment-Date: Tue, 23 Jul 2019 18:18:15 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8772: Import Testcase failed for SQL without table refs

2019-07-23 Thread Jiawei Wang (Code Review)

Hello Bharath Vissapragada, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13893

to look at the new patch set (#2).

Change subject: IMPALA-8772: Import Testcase failed for SQL without table refs
..

IMPALA-8772: Import Testcase failed for SQL without table refs

Description:
Query like this: select 5 * 4; can generate valid testcase, but
cannot be loaded because it does not involve any table and view
references.

Fix:
Add null check for CatalogOpExecutor when doing testcase data load

Tests:
tests/metadata/test_testcase_builder

Change-Id: I50d77d7de44bb140598a1e8db4da85a5ec87f31e
TODO: NEED TO DELETE GENERATED TESTCASE AFTER THIS IS DONE
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A tests/metadata/test_testcase_builder.py
2 files changed, 87 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/13893/2
--
To view, visit http://gerrit.cloudera.org:8080/13893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50d77d7de44bb140598a1e8db4da85a5ec87f31e
Gerrit-Change-Number: 13893
Gerrit-PatchSet: 2
Gerrit-Owner: Jiawei Wang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl

Sahil Takiar has posted comments on this change. (
http://gerrit.cloudera.org:8080/13883 )

Change subject: IMPALA-8656: Add RowBatchQueue interface and
BufferedPlanRootSink impl
..

Patch Set 3:

(4 comments)

Just responding to a few of the higher level comments so we can nail down
overall design first. Once we come to an agreement, will start working on the
rest of the comments.

> High level comment about the refactoring of the RowBatchQueue seems
> unnecessary at this stage given the similarity of the two versions. It seems
> sufficient to just add a TryAddBatch() interface to get most of the
> functionality needed now but I could be missing something.

Mentioned this in some of the other comments, but (1) as this patch stands, yes
it might not be completely necessary, but will become more useful when we add a
RowBatchQueue backed by a BufferedTupleStream, (2) there are various places in
the code we buffer RowBatches, adding RowBatchQueue gives us a unified
interface to use across the codebase, (3) the current RowBatchQueue is
blocking, which won't work well in BufferedPlanRootSink since it needs
additional locks to handle synchronization of its internal state (e.g.
SenderState) and resources (e.g. MemTrackers that are closed in
DataSink::Close).

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/exec/buffered-plan-root-sink.h
File be/src/exec/buffered-plan-root-sink.h:

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/exec/buffered-plan-root-sink.h@29
PS3, Line 29: The blocking behavior follows
: /// the same semantics as BlockingPlanRootSink.
> Now that I look at it again, I wonder if "BlockingPlanRootSink" is just a B
Yeah, it probably makes more sense once we change BufferedPlanRootSink to use a
BufferedTupleStream. Another nice thing about keeping these two classes
separate is that if there are bugs in the result spooling code, users can
simply set SPOOL_QUERY_RESULTS = false and the code will fallback to
BlockingPlanRootSink which is known to be stable.

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/exec/buffered-plan-root-sink.h@42
PS3, Line 42: RowBatchQueue* batch_queue)
> Why is this not internally owned by this class ? Why does it need to be pas
Dependency injection. I'm not sure if this is the right way to do this in C++
though.

https://en.wikipedia.org/wiki/Dependency_injection
https://en.wikipedia.org/wiki/Dependency_injection#Constructor_injection

http://gerrit.cloudera.org:8080/#/c/13883/4/be/src/exec/buffered-plan-root-sink.cc
File be/src/exec/buffered-plan-root-sink.cc:

http://gerrit.cloudera.org:8080/#/c/13883/4/be/src/exec/buffered-plan-root-sink.cc@45
PS4, Line 45: is_full_.Wait(l);
> Looking at this code again, the thread will block when the queue is full an
The existing BlockingQueue doesn't expose its lock, which makes the
synchronization more difficult. You could have two locks: one owned by the
BlockingQueue and one owned by the BufferedPlanRootSink, but that makes the
synchronization logic more complex. The BufferedPlanRootSink lock is necessary
in case the producer calls Close() while the consumer is calling
QueryResultSet::AddRows, and its needed to protect read / writes of the
SenderState. Plus, it makes the transition to BufferedTupleStream easier
because BufferedTupleStream makes no thread-safety guarantees.

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h
File be/src/runtime/non-blocking-row-batch-queue.h:

http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h@32
PS3, Line 32: NonBlockingRowBatchQueue
> If I understand this patch correctly, this queue also has a capacity but it
Adding TryAddBatch() makes sense to me.

Yes, as this patch stands now, the re-factoring for RowBatchQueue is probably
overkill. Yes, the idea is that this will be most useful when adding the
SpillableQueue (or whatever we decide to call it).

However, I do think this cleans up the code a little bit. Currently there are
several different ways we buffer RowBatches throughout the code, having a
unified interface would make things easier to understand. Doing all the
re-factoring to migrate other queues to the new RowBatchQueue is probably out
of the scope of this patch, but seems useful to do in the future.

The RowBatchQueue interface can also be useful for buffering in the KRPC sender
/ receiver. The NonBlockingRowBatchQueue could be used to replace the current
RowBatchQueue in KrpcDataStreamRecvr::SenderQueue

Non-blocking might not be the right name for this class (maybe
DequeRowBatchQueue would be better since by default a std::queue uses
std::deque). I'm attempting to follow a similar model to the JDK. Java models
this using an interface called Queue with various implementations
ArrayBlockingQueue (blocking), LinkedList (not-blocking), PriorityQueue
(not-blocking), etc.

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

Quanlong Huang has removed a vote on this change.

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..


Removed Code-Review-2 by Quanlong Huang 
--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 11
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

Hello Bharath Vissapragada, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13874

to look at the new patch set (#11).

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..

IMPALA-8606: Don't load table meta for GET_TABLES in local catalog mode

In LocalCatalog implementation, LocalDb#getTable will always return a
completely loaded table containing all the meta of columns, partitions,
files, etc. It's time consuming if we implement the GET_TABLES
HiveServer2 operation based on this interface, since GET_TABLES only
requires table names, table types and table comments, while this
interface will trigger catalogd to fully load the table meta. It becomes
worse when we do this for all the tables.

This patch introduces a new interface, getTableIfCached, to return a
LocalIncompleteTable object if the corresponding table is unloaded,
which requires no round trips to the catalogd. It's used to boost the
GET_TABLES performance in LocalCatalog mode.

Tests
 - Testing in a HMS with 100 dbs and 3000 tables, without this patch it
takes ~2mins in GET_TABLES for all tables on a cold started cluster. With
this patch, the time reduces to ~1s.
 - Testing in HUE-4.4.0 with a db with 3000 tables, the performance is the
same as using legacy catalog implementation.

Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/Db.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/FeDb.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java
M fe/src/main/java/org/apache/impala/service/MetadataOp.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
M fe/src/test/java/org/apache/impala/service/JdbcTest.java
M tests/hs2/test_hs2.py
11 files changed, 156 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/13874/11
--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 11
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang

[Impala-ASF-CR] IMPALA-8701: [DOCS] Document --idle client poll time s flag

Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13896 )

Change subject: IMPALA-8701: [DOCS] Document --idle_client_poll_time_s flag
..

IMPALA-8701: [DOCS] Document --idle_client_poll_time_s flag

Change-Id: I32ace786904f564b9c5fa3ed594e2b679b76d5c6
Reviewed-on: http://gerrit.cloudera.org:8080/13896
Tested-by: Impala Public Jenkins 
Reviewed-by: Michael Ho 
---
M docs/topics/impala_client.xml
1 file changed, 32 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Ho: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/13896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I32ace786904f564b9c5fa3ed594e2b679b76d5c6
Gerrit-Change-Number: 13896
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho

[Impala-ASF-CR] IMPALA-8746: [DOCS] Document the DEFAULT HINTS INSERT STATEMENT query option

Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13885 )

Change subject: IMPALA-8746: [DOCS] Document the DEFAULT_HINTS_INSERT_STATEMENT 
query option
..

IMPALA-8746: [DOCS] Document the DEFAULT_HINTS_INSERT_STATEMENT query option

Change-Id: Ia376721f46eb507901f9f64b5c3341dc0f36475b
Reviewed-on: http://gerrit.cloudera.org:8080/13885
Tested-by: Impala Public Jenkins 
Reviewed-by: Bharath Vissapragada 
---
M docs/impala.ditamap
A docs/topics/impala_default_hints_insert_statement.xml
2 files changed, 82 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Bharath Vissapragada: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/13885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia376721f46eb507901f9f64b5c3341dc0f36475b
Gerrit-Change-Number: 13885
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

Quanlong Huang has removed a vote on this change.

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..


Removed Code-Review+2 by Impala Public Jenkins 

--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 10
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13874 )

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..


Patch Set 10: Code-Review-2

Found that LocalIncompleteTable#isLoaded returns true. Need to fix it and check 
more code paths.


--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 10
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 23 Jul 2019 17:48:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13894 )

Change subject: modified MetaStoreEventsProcessor to catch multiple invalid 
configuration keys in one go.
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3961/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493
Gerrit-Change-Number: 13894
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 17:42:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13872 )

Change subject: IMPALA-8766: Change cloud dependencies to use 
hadoop-cloud-storage
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4640/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08f1c36ecf54ac277d99e2d2843163eada732e50
Gerrit-Change-Number: 13872
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 17:14:05 +
Gerrit-HasComments: No

[Impala-ASF-CR] modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13894 )

Change subject: modified MetaStoreEventsProcessor to catch multiple invalid 
configuration keys in one go.
..


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:

http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@242
PS1, Line 242:* Test if the error messages are caught appropriately when 
multiple config keys are invalid.
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@247
PS1, Line 247: String actual_errorMessages="[Unexpected configuration value 
for hive.metastore.notifications.add.thrift.objects"+
line too long (118 > 90)


http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@248
PS1, Line 248: " in Hive Metastore. Expected: true Found: false, 
Unexpected configuration value for hive.metastore.dml"+
line too long (117 > 90)


http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@252
PS1, Line 252: List configKeys = new 
ArrayList() {
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@259
PS1, Line 259:   
Mockito.when(test.getConfigValueFromMetastore(config.getValidator().getConfigKey(),
 "")).
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@262
PS1, Line 262: for (MetastoreEventProcessorConfig config : 
test.getEventProcessorConfigsToValidate()) {
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/13894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493
Gerrit-Change-Number: 13894
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 23 Jul 2019 17:02:10 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.

2019-07-23 Thread Anonymous Coward (Code Review)

sharanitha.har...@cloudera.com has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13894


Change subject: modified MetaStoreEventsProcessor to catch multiple invalid 
configuration keys in one go.
..

modified MetaStoreEventsProcessor to catch multiple invalid configuration keys 
in one go.

Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493
---
M 
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
2 files changed, 43 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/13894/1
--
To view, visit http://gerrit.cloudera.org:8080/13894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493
Gerrit-Change-Number: 13894
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Vihang Karajgaonkar

[native-toolchain-CR] Patch Avro to 1.7.4-p5 to add DATE type support.

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13898 )

Change subject: Patch Avro to 1.7.4-p5 to add DATE type support.
..


Patch Set 1:

I think we should really look at upstreaming this (and potentially upgrading 
Avro to a more recent release), just so that we're not maintaining a customer 
patchset. It would also be good to get someone who knows avro better to review 
this - the code looks sane but I'm not really qualified to review it.


--
To view, visit http://gerrit.cloudera.org:8080/13898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70aae9f16805e3ee806c39e9121b6525d83845b3
Gerrit-Change-Number: 13898
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 14:59:05 +
Gerrit-HasComments: No

[native-toolchain-CR] Patch Avro to 1.7.4-p5 to add DATE type support.

2019-07-23 Thread Attila Jeges (Code Review)

Attila Jeges has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13898


Change subject: Patch Avro to 1.7.4-p5 to add DATE type support.
..

Patch Avro to 1.7.4-p5 to add DATE type support.

This will be used in "IMPALA-8198: DATE: Read from avro."

TESTING:
I built the toolchain locally and using jenkins.
I built impala (including IMPALA-8198) with the new toolchain and
ran the core test suite.

Change-Id: I70aae9f16805e3ee806c39e9121b6525d83845b3
---
M buildall.sh
A 
source/avro/avro-1.7.4-patches/0005-Changes-to-Avro-C-library-to-allow-parsing-DATE.patch
2 files changed, 219 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/98/13898/1
--
To view, visit http://gerrit.cloudera.org:8080/13898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70aae9f16805e3ee806c39e9121b6525d83845b3
Gerrit-Change-Number: 13898
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13874 )

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..


Patch Set 10:

Hit flaky test failure as IMPALA-8378: 
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/6721/
Re-run the GVO again.


--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 10
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 23 Jul 2019 12:43:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13874 )

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4637/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 10
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 23 Jul 2019 12:41:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13807/4/be/src/util/bit-packing-vectorized.h
File be/src/util/bit-packing-vectorized.h:

PS4:
> Csaba prefers the second option.
We could also take option 2 now and add a TODO to include the code generation 
in the build process when we have Python 3 in the toolchain.



--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 10:16:24 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13807/4/be/src/util/bit-packing-vectorized.h
File be/src/util/bit-packing-vectorized.h:

PS4:
> I'll discuss it with other team members also.
Csaba prefers the second option.

I've partly ported the script to Python 2.6, but it requires some effort as 
some features I used in the script are not available in Python 2.6. Some of 
them are available as installable packages, but I guess installing them would 
complicate the build process too much.

Another argument in favour of the second approach is that if the generated code 
is checked in, it is possible to read it on Github and understand the code 
without having to build it.



--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 10:07:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8606: Don't load table meta for GET TABLES in local catalog mode

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13874 )

Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local 
catalog mode
..


Patch Set 10: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4636/


--
To view, visit http://gerrit.cloudera.org:8080/13874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb
Gerrit-Change-Number: 13874
Gerrit-PatchSet: 10
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 23 Jul 2019 09:22:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..


Patch Set 15:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/3960/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 08:25:13 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..


Patch Set 14:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/3959/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 14
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 08:16:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8710: Increase allowed bit width to 64 for bit packing

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13809 )

Change subject: IMPALA-8710: Increase allowed bit width to 64 for bit packing
..


Patch Set 11:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3958/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9276ca291e3d36db16f63f8caf3e9248a18d85b
Gerrit-Change-Number: 13809
Gerrit-PatchSet: 11
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 23 Jul 2019 08:07:14 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..


Patch Set 13:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/3957/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 13
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 07:50:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13807/15/be/src/util/vectorised_bit_unpacking_generator.py
File be/src/util/vectorised_bit_unpacking_generator.py:

http://gerrit.cloudera.org:8080/#/c/13807/15/be/src/util/vectorised_bit_unpacking_generator.py@184
PS15, Line 184: =
flake8: E999 SyntaxError: invalid syntax



--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 07:42:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

Daniel Becker has uploaded a new patch set (#15). ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..

IMPALA-8741: Speed up bit unpacking by vectorisation

Adding a vectorised implementation to bit unpacking using AVX, AVX2 and
BMI2 instructions through compiler intrinsics.

Vectorised bit unpacking is implemented for bit widths from 1 to 16.
Higher bit widths would not benefit from this vectorisation algorithm.

We check at runtime whether the required instructions are available on
the CPU and fall back to the scalar implementation if not.

The vectorised unpacking functions are in the file
be/src/util/bit-packing-vectorized.h, which is generated by the python
script in be/src/util/vectorised_bit_unpacking_generator.py.

Also adding benchmarks comparing the scalar and the vectorised
implementations.

Testing:
  - Added tests for the vectorised unpacking implementations.

Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
---
M be/src/benchmarks/bit-packing-benchmark.cc
M be/src/util/bit-packing-test.cc
A be/src/util/bit-packing-vectorized.h
M be/src/util/bit-packing.cc
M be/src/util/bit-packing.h
M be/src/util/bit-packing.inline.h
M be/src/util/cpu-info.cc
M be/src/util/cpu-info.h
A be/src/util/vectorised_bit_unpacking_generator.py
9 files changed, 5,977 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/13807/15
--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

2019-07-23 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..


Patch Set 14:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13807/14/be/src/util/cpu-info.h
File be/src/util/cpu-info.h:

http://gerrit.cloudera.org:8080/#/c/13807/14/be/src/util/cpu-info.h@160
PS14, Line 160:   ///   // On the next line, the block closes, 'disabler's 
destructor runs, and AVX and AVX2
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/13807/14/be/src/util/vectorised_bit_unpacking_generator.py
File be/src/util/vectorised_bit_unpacking_generator.py:

http://gerrit.cloudera.org:8080/#/c/13807/14/be/src/util/vectorised_bit_unpacking_generator.py@184
PS14, Line 184: =
flake8: E999 SyntaxError: invalid syntax



--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 14
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jul 2019 07:34:30 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

Daniel Becker has uploaded a new patch set (#14). ( 
http://gerrit.cloudera.org:8080/13807 )

Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation
..

IMPALA-8741: Speed up bit unpacking by vectorisation

Adding a vectorised implementation to bit unpacking using AVX, AVX2 and
BMI2 instructions through compiler intrinsics.

Vectorised bit unpacking is implemented for bit widths from 1 to 16.
Higher bit widths would not benefit from this vectorisation algorithm.

We check at runtime whether the required instructions are available on
the CPU and fall back to the scalar implementation if not.

The vectorised unpacking functions are in the file
be/src/util/bit-packing-vectorized.h, which is generated by the python
script in be/src/util/vectorised_bit_unpacking_generator.py.

Also adding benchmarks comparing the scalar and the vectorised
implementations.

Testing:
  - Added tests for the vectorised unpacking implementations.

Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
---
M be/src/benchmarks/bit-packing-benchmark.cc
M be/src/util/bit-packing-test.cc
A be/src/util/bit-packing-vectorized.h
M be/src/util/bit-packing.cc
M be/src/util/bit-packing.h
M be/src/util/bit-packing.inline.h
M be/src/util/cpu-info.cc
M be/src/util/cpu-info.h
A be/src/util/vectorised_bit_unpacking_generator.py
9 files changed, 5,976 insertions(+), 78 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/13807/14
--
To view, visit http://gerrit.cloudera.org:8080/13807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947
Gerrit-Change-Number: 13807
Gerrit-PatchSet: 14
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-8710: Increase allowed bit width to 64 for bit packing