[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13941 Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. IMPALA-8799: prefix Prometheus metrics with "impala_" If the metric name does not already include "impala", we add the prefix. This makes it easier to separate Impala metrics from metrics from other systems that may also be present in prometheus. It is documented as a good practice, see: https://prometheus.io/docs/practices/naming/ Testing: * Added a targeted unit test for the name transformation. * Updated unit tests to reflect the new names. * Manually inspected /metrics_prometheus output. Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f --- M be/src/util/metrics-test.cc M be/src/util/metrics.cc M be/src/util/metrics.h M tests/webserver/test_web_pages.py 4 files changed, 159 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/13941/2 -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Lars Volker has posted comments on this change. (
http://gerrit.cloudera.org:8080/13941 )
Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_"
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics-test.cc
File be/src/util/metrics-test.cc:
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics-test.cc@467
PS2, Line 467: TEST_F(MetricsTest, PrometheusMetricNames) {
nit: could add a test for "an_impala_metric" and one with uppercase characters
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h
File be/src/util/metrics.h:
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h@472
PS2, Line 472: impala
I wonder if we should actually test for "impala_" here to make sure that all
impala metrics start with "impala_"?
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.cc
File be/src/util/metrics.cc:
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.cc@310
PS2, Line 310: LOG(INFO)
Should this be something like VLOG(3)? Otherwise I think we log this every
time, no?
--
To view, visit http://gerrit.cloudera.org:8080/13941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f
Gerrit-Change-Number: 13941
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker
Gerrit-Comment-Date: Sun, 28 Jul 2019 19:24:17 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13934 to look at the new patch set (#6). Change subject: IMPALA-8534: data cache for dockerised tests .. IMPALA-8534: data cache for dockerised tests This adds support for the data cache in dockerised clusters in start-impala-cluster.py. It is handled similarly to the log directories - we ensure that a separate data cache directory is created for each container, then mount it at /opt/impala/cache inside the container. This is then enabled by default for the dockerised tests. Testing: Did a dockerised test run. Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 --- M bin/jenkins/dockerized-impala-run-tests.sh M bin/start-impala-cluster.py 2 files changed, 26 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/13934/6 -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] This commit adds support to display the metric last-synced-event-id as Catalogd/metrics#evnts page whereas previously it was displayed only on the catalod/events page. Added code to th
Sharanitha Harish has abandoned this change. ( http://gerrit.cloudera.org:8080/13925 ) Change subject: This commit adds support to display the metric last-synced-event-id as Catalogd/metrics#evnts page whereas previously it was displayed only on the catalod/events page. Added code to the MetaStoreEventsProcessorTest class under testEventProcessorMetrics() .. Abandoned abandoning this commit -- To view, visit http://gerrit.cloudera.org:8080/13925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I75b966f2b4eaafbcf7d80358f53501bb7ade67e7 Gerrit-Change-Number: 13925 Gerrit-PatchSet: 1 Gerrit-Owner: Sharanitha Harish Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13941 to look at the new patch set (#3). Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. IMPALA-8799: prefix Prometheus metrics with "impala_" If the metric name does not already include "impala", we add the prefix. This makes it easier to separate Impala metrics from metrics from other systems that may also be present in prometheus. It is documented as a good practice, see: https://prometheus.io/docs/practices/naming/ Testing: * Added a targeted unit test for the name transformation. * Updated unit tests to reflect the new names. * Manually inspected /metrics_prometheus output. Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f --- M be/src/util/metrics-test.cc M be/src/util/metrics.cc M be/src/util/metrics.h M tests/webserver/test_web_pages.py 4 files changed, 170 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/13941/3 -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/13941 )
Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_"
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics-test.cc
File be/src/util/metrics-test.cc:
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics-test.cc@467
PS2, Line 467: TEST_F(MetricsTest, PrometheusMetricNames) {
> nit: could add a test for "an_impala_metric" and one with uppercase charact
Done
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h
File be/src/util/metrics.h:
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h@472
PS2, Line 472: impala
> I wonder if we should actually test for "impala_" here to make sure that al
I started off doing that, but I was checking before other transformations so
"impala-server.metric" became impala_impala_server_metric.
I added some examples to illustrate the transformation in a few cases, I think
that makes it a little clearer why it is doing what it does.
I could alternatively change the implementation so that it checked if "impala_"
was the prefix after it did the character substitutions. I was trying to reduce
the number of string reallocations required. I also realise that I should have
made some comments in the body explaining what I was trying to do there.
So I'm not really attached to the current solution, but it seemed adequate.
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.cc
File be/src/util/metrics.cc:
http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.cc@310
PS2, Line 310: LOG(INFO)
> Should this be something like VLOG(3)? Otherwise I think we log this every
Oops, leftover debugging code. Just deleted it.
--
To view, visit http://gerrit.cloudera.org:8080/13941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f
Gerrit-Change-Number: 13941
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Sun, 28 Jul 2019 19:57:31 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4051/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 20:02:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13941/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13941/2//COMMIT_MSG@9 PS2, Line 9: include nit: start with http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h File be/src/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h@472 PS2, Line 472: impala > I started off doing that, but I was checking before other transformations s I think I'm in favor of checking after the substitution. Do you think the additional allocations will be an issue? We could check whether the character after "impala" is a substitution character. The prometheus naming guide reads as it the "_" after the prefix was mandatory. -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 20:09:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4052/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Sun, 28 Jul 2019 20:12:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4053/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 20:39:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13941 to look at the new patch set (#4). Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. IMPALA-8799: prefix Prometheus metrics with "impala_" If the metric name does not already start with "impala", we add the prefix. This makes it easier to separate Impala metrics from metrics from other systems that may also be present in prometheus. It is documented as a good practice, see: https://prometheus.io/docs/practices/naming/ Testing: * Added a targeted unit test for the name transformation. * Updated unit tests to reflect the new names. * Manually inspected /metrics_prometheus output. Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f --- M be/src/util/metrics-test.cc M be/src/util/metrics.cc M be/src/util/metrics.h M tests/webserver/test_web_pages.py 4 files changed, 165 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/13941/4 -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13941/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13941/2//COMMIT_MSG@9 PS2, Line 9: start w > nit: start with Done http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h File be/src/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/13941/2/be/src/util/metrics.h@472 PS2, Line 472: impala > I think I'm in favor of checking after the substitution. Do you think the a Done. I doubt it's an issue, it adds a bit of overhead but should be pretty efficient with tcmalloc. The previous code was doing multiple reallocations while substituting the string. I think that would only result in an issue with prometheus namespaces if we called an impala metric something like impalathing.metric or impala#thing.metric, which would be weird. -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 21:21:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13941/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13941/4//COMMIT_MSG@9 PS4, Line 9: impala nit: should this be the same as the comment in the header, i.e. "impala_"? Technically it should be the converted name after substituting some special characters, but I think "impala_" is good enough. -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 21:31:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13941 to look at the new patch set (#5). Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. IMPALA-8799: prefix Prometheus metrics with "impala_" If the converted metric name does not already start with "impala_", we add the prefix. This makes it easier to separate Impala metrics from metrics from other systems that may also be present in prometheus. It is documented as a good practice, see: https://prometheus.io/docs/practices/naming/ Testing: * Added a targeted unit test for the name transformation. * Updated unit tests to reflect the new names. * Manually inspected /metrics_prometheus output. Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f --- M be/src/util/metrics-test.cc M be/src/util/metrics.cc M be/src/util/metrics.h M tests/webserver/test_web_pages.py 4 files changed, 165 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/13941/5 -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4674/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 21:35:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13941/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13941/4//COMMIT_MSG@9 PS4, Line 9: impala > nit: should this be the same as the comment in the header, i.e. "impala_"? Done -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 21:37:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 6: Code-Review+2 carry lars' +2 -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 21:36:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8627: [WIP] Enable catalog-v2 in tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13933 ) Change subject: IMPALA-8627: [WIP] Enable catalog-v2 in tests .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4675/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddbde666de2b780c0e40df716a9dfe54524e092d Gerrit-Change-Number: 13933 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 28 Jul 2019 21:38:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8627: [WIP] Enable catalog-v2 in tests
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13933 Change subject: IMPALA-8627: [WIP] Enable catalog-v2 in tests .. IMPALA-8627: [WIP] Enable catalog-v2 in tests This patch enables catalog-v2 by default in all the tests. Testing is in progress. Change-Id: Iddbde666de2b780c0e40df716a9dfe54524e092d --- M docker/catalogd/Dockerfile M docker/impalad_coord_exec/Dockerfile M docker/impalad_coordinator/Dockerfile 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/13933/1 -- To view, visit http://gerrit.cloudera.org:8080/13933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iddbde666de2b780c0e40df716a9dfe54524e092d Gerrit-Change-Number: 13933 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13922 ) Change subject: IMPALA-8795 : Enable event polling by default in tests .. IMPALA-8795 : Enable event polling by default in tests Most of the fixes for event processing are committed. This change enables the feature by default for all the tests so that eventually we can turn it on out of the box. Testing done: 1. Ran all the tests with the patch and confirmed that there are no test failures 2. Ran all the tests with CDP build. Change-Id: I7279349d4900e24fbcf558f290549496844ce138 --- M docker/catalogd/Dockerfile M tests/common/environ.py M tests/metadata/test_hms_integration.py 3 files changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13922/4 -- To view, visit http://gerrit.cloudera.org:8080/13922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138 Gerrit-Change-Number: 13922 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8627: Enable catalog-v2 in tests
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13933 ) Change subject: IMPALA-8627: Enable catalog-v2 in tests .. IMPALA-8627: Enable catalog-v2 in tests Change-Id: Iddbde666de2b780c0e40df716a9dfe54524e092d --- M docker/catalogd/Dockerfile M docker/impalad_coord_exec/Dockerfile M docker/impalad_coordinator/Dockerfile 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/13933/2 -- To view, visit http://gerrit.cloudera.org:8080/13933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddbde666de2b780c0e40df716a9dfe54524e092d Gerrit-Change-Number: 13933 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4054/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 22:03:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8627: Enable catalog-v2 in tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13933 ) Change subject: IMPALA-8627: Enable catalog-v2 in tests .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4055/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddbde666de2b780c0e40df716a9dfe54524e092d Gerrit-Change-Number: 13933 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 28 Jul 2019 22:20:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 ) Change subject: IMPALA-8795 : Enable event polling by default in tests .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4056/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138 Gerrit-Change-Number: 13922 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Sun, 28 Jul 2019 22:39:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8627: Enable catalog-v2 in tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13933 ) Change subject: IMPALA-8627: Enable catalog-v2 in tests .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4057/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddbde666de2b780c0e40df716a9dfe54524e092d Gerrit-Change-Number: 13933 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 28 Jul 2019 22:42:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Hello Thomas Tauber-Marshall, David Knupp, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13746 to look at the new patch set (#15). Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. IMPALA-8717: impala-shell support for HS2 HTTP endpoint Adds impala-shell support to connect to HiveServer2 HTTP endpoint. Relies on toolchain change at https://gerrit.cloudera.org/#/c/13725/. Use --protocol='hs2-http' to enable this behavior. Example usages: --- impala-shell --protocol='hs2-http' (No auth) impala-shell --protocol='hs2-http' --ldap -u. (PLAIN auth) impala-shell --protocol-'hs2-http' --ssl --ca_cert... (TLS) impala-shell --protocol='hs2-http' --ldap --ssl --ca_cert... (LDAP + TLS) Limitations: --- - Does not support Kerberos (-k) due to lack ot SPNEGO support. Testing: - Parameterized existing shell tests to support this combination. - Added shell test coverage for LDAP auth. Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 --- M be/src/service/impala-server.cc M bin/impala-config.sh A fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java M shell/impala_client.py M shell/impala_shell.py M shell/option_parser.py M tests/common/impala_cluster.py M tests/common/impala_connection.py M tests/common/impala_service.py M tests/common/impala_test_suite.py M tests/common/test_dimensions.py M tests/conftest.py M tests/custom_cluster/test_client_ssl.py M tests/custom_cluster/test_shell_interactive.py M tests/custom_cluster/test_shell_interactive_reconnect.py M tests/run-tests.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py M tests/shell/util.py 19 files changed, 326 insertions(+), 62 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/13746/15 -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 15 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13746 ) Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. Patch Set 15: Fixed the one final test thats failing. Kicking off another run. -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 15 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 22:51:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13746 ) Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. Patch Set 16: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4676/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 16 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 22:52:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13746 ) Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. Patch Set 15: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4058/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 15 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jul 2019 23:34:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 ) Change subject: IMPALA-8795 : Enable event polling by default in tests .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4677/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138 Gerrit-Change-Number: 13922 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 29 Jul 2019 03:51:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 29 Jul 2019 04:05:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8799: prefix Prometheus metrics with "impala "
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13941 ) Change subject: IMPALA-8799: prefix Prometheus metrics with "impala_" .. IMPALA-8799: prefix Prometheus metrics with "impala_" If the converted metric name does not already start with "impala_", we add the prefix. This makes it easier to separate Impala metrics from metrics from other systems that may also be present in prometheus. It is documented as a good practice, see: https://prometheus.io/docs/practices/naming/ Testing: * Added a targeted unit test for the name transformation. * Updated unit tests to reflect the new names. * Manually inspected /metrics_prometheus output. Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Reviewed-on: http://gerrit.cloudera.org:8080/13941 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/util/metrics-test.cc M be/src/util/metrics.cc M be/src/util/metrics.h M tests/webserver/test_web_pages.py 4 files changed, 165 insertions(+), 119 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I607ee2a456c3ec2380ca996080ae497302b5b44f Gerrit-Change-Number: 13941 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8627: Enable catalog-v2 in tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13933 ) Change subject: IMPALA-8627: Enable catalog-v2 in tests .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4675/ -- To view, visit http://gerrit.cloudera.org:8080/13933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddbde666de2b780c0e40df716a9dfe54524e092d Gerrit-Change-Number: 13933 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Jul 2019 04:10:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8627: Enable catalog-v2 in tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13933 ) Change subject: IMPALA-8627: Enable catalog-v2 in tests .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4678/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddbde666de2b780c0e40df716a9dfe54524e092d Gerrit-Change-Number: 13933 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Jul 2019 04:10:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/13883 )
Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and
BufferedPRS impl
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13883/11/be/src/exec/buffered-plan-root-sink.cc
File be/src/exec/buffered-plan-root-sink.cc:
http://gerrit.cloudera.org:8080/#/c/13883/11/be/src/exec/buffered-plan-root-sink.cc@123
PS11, Line 123: // For now, if num_results < batch->num_rows(), we
terminate returning results
: // early.
: if (num_results > 0 && num_results < batch->num_rows()) {
> Yeah, we wouldn't publicly tell users to set SPOOL_QUERY_RESULTS=true until
I am more worried about the case in which the total number of result rows is
not a multiple of row batch size. The client may call GetNext() multiple times.
In which case, the client may have incomplete result, which arguably is more
confusing than returning no result at all.
I am a bit hesitant for checking in like this. At the minimum, we should add a
CHECK(false) << "Not implemented"; in the if-stmt body.
--
To view, visit http://gerrit.cloudera.org:8080/13883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be
Gerrit-Change-Number: 13883
Gerrit-PatchSet: 11
Gerrit-Owner: Sahil Takiar
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Sahil Takiar
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Mon, 29 Jul 2019 04:58:37 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13746 ) Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. Patch Set 16: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 16 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 29 Jul 2019 05:37:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13746 ) Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. Patch Set 16: Code-Review+2 Carrying +2. -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 16 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 29 Jul 2019 05:43:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8717: impala-shell support for HS2 HTTP endpoint
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13746 ) Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint .. IMPALA-8717: impala-shell support for HS2 HTTP endpoint Adds impala-shell support to connect to HiveServer2 HTTP endpoint. Relies on toolchain change at https://gerrit.cloudera.org/#/c/13725/. Use --protocol='hs2-http' to enable this behavior. Example usages: --- impala-shell --protocol='hs2-http' (No auth) impala-shell --protocol='hs2-http' --ldap -u. (PLAIN auth) impala-shell --protocol-'hs2-http' --ssl --ca_cert... (TLS) impala-shell --protocol='hs2-http' --ldap --ssl --ca_cert... (LDAP + TLS) Limitations: --- - Does not support Kerberos (-k) due to lack ot SPNEGO support. Testing: - Parameterized existing shell tests to support this combination. - Added shell test coverage for LDAP auth. Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Reviewed-on: http://gerrit.cloudera.org:8080/13746 Tested-by: Impala Public Jenkins Reviewed-by: Bharath Vissapragada --- M be/src/service/impala-server.cc M bin/impala-config.sh A fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java M shell/impala_client.py M shell/impala_shell.py M shell/option_parser.py M tests/common/impala_cluster.py M tests/common/impala_connection.py M tests/common/impala_service.py M tests/common/impala_test_suite.py M tests/common/test_dimensions.py M tests/conftest.py M tests/custom_cluster/test_client_ssl.py M tests/custom_cluster/test_shell_interactive.py M tests/custom_cluster/test_shell_interactive_reconnect.py M tests/run-tests.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py M tests/shell/util.py 19 files changed, 326 insertions(+), 62 deletions(-) Approvals: Impala Public Jenkins: Verified Bharath Vissapragada: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 17 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
