[Impala-ASF-CR] PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4955/ -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 17 Sep 2019 03:07:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8451: enable admission control for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13942 ) Change subject: IMPALA-8451: enable admission control for dockerised tests .. Patch Set 16: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4573/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a Gerrit-Change-Number: 13942 Gerrit-PatchSet: 16 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 17 Sep 2019 01:42:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8451: enable admission control for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13942 ) Change subject: IMPALA-8451: enable admission control for dockerised tests .. Patch Set 15: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4572/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a Gerrit-Change-Number: 13942 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 17 Sep 2019 01:37:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8451: enable admission control for dockerised tests
Hello Andrew Sherman, Lars Volker, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13942 to look at the new patch set (#16). Change subject: IMPALA-8451: enable admission control for dockerised tests .. IMPALA-8451: enable admission control for dockerised tests This gives us some additional coverage for using admission control in a simple but realistic configuration. What are the implications of this change for test stability and flakiness? On one hand were are adding some more unpredictability to tests, because they may be queued for an arbitrary amount of time. On the other, we can prevent queries from contending over memory. Currently we rely on luck to prevent concurrent queries from forcing each other out-of-memory. I think the unpredictability from the queueing is preferable, because we can generally work around these by fixing tests that are sensitive to being queued, whereas contention over memory requires us to use crude workarounds like forcing tests to execute serially. Added observability for the configured queue wait time for each pool. I noticed that I did not have a direct way to observe the effective value when I set configs. I had to tweak tests in a few ways: * Tests with large strings needed higher memory limits. * Hardcoded instances of default-pool had to handle root.default as well. * test_query_mem_limit needed to run without a mem_limit. I created a special pool root.no-limits with no memory limits to allow that. Testing: Ran the dockerised build 5-6 times to flush out flaky tests. Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a --- M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/service/impala-http-handler.h M bin/jenkins/dockerized-impala-run-tests.sh M common/thrift/metrics.json A fe/src/test/resources/minicluster-fair-scheduler.xml A fe/src/test/resources/minicluster-llama-site.xml M testdata/workloads/functional-query/queries/QueryTest/admission-reject-mem-estimate.test M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test M testdata/workloads/functional-query/queries/QueryTest/large_strings.test M testdata/workloads/functional-query/queries/QueryTest/spilling-large-rows.test M testdata/workloads/functional-query/queries/QueryTest/thread-limits.test M tests/query_test/test_insert.py M tests/query_test/test_observability.py M tests/query_test/test_query_mem_limit.py M tests/webserver/test_web_pages.py M www/admission_controller.tmpl 17 files changed, 160 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/13942/16 -- To view, visit http://gerrit.cloudera.org:8080/13942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a Gerrit-Change-Number: 13942 Gerrit-PatchSet: 16 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8451: enable admission control for dockerised tests
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/13942 )
Change subject: IMPALA-8451: enable admission control for dockerised tests
..
Patch Set 16:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13942/16/bin/jenkins/dockerized-impala-run-tests.sh
File bin/jenkins/dockerized-impala-run-tests.sh:
http://gerrit.cloudera.org:8080/#/c/13942/16/bin/jenkins/dockerized-impala-run-tests.sh@83
PS16, Line 83: TEST_START_CLUSTER_ARGS+="
--impalad_args=-fair_scheduler_allocation_path=${FAIR_SCHED_CONF}"
line too long (93 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/13942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a
Gerrit-Change-Number: 13942
Gerrit-PatchSet: 16
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Andrew Sherman
Gerrit-Reviewer: Bikramjeet Vig
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 17 Sep 2019 01:02:56 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8451: enable admission control for dockerised tests
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13942 ) Change subject: IMPALA-8451: enable admission control for dockerised tests .. Patch Set 15: Fixed the admission control test failure - the CATCH section wasn't quite right -- To view, visit http://gerrit.cloudera.org:8080/13942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a Gerrit-Change-Number: 13942 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 17 Sep 2019 00:55:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8451: enable admission control for dockerised tests
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/13942 )
Change subject: IMPALA-8451: enable admission control for dockerised tests
..
Patch Set 15:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13942/15/bin/jenkins/dockerized-impala-run-tests.sh
File bin/jenkins/dockerized-impala-run-tests.sh:
http://gerrit.cloudera.org:8080/#/c/13942/15/bin/jenkins/dockerized-impala-run-tests.sh@83
PS15, Line 83: TEST_START_CLUSTER_ARGS+="
--impalad_args=-fair_scheduler_allocation_path=${FAIR_SCHED_CONF}"
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/13942/15/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/13942/15/tests/webserver/test_web_pages.py@544
PS15, Line 544: d
flake8: F841 local variable 'default_pool_json' is assigned to but never used
--
To view, visit http://gerrit.cloudera.org:8080/13942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a
Gerrit-Change-Number: 13942
Gerrit-PatchSet: 15
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Andrew Sherman
Gerrit-Reviewer: Bikramjeet Vig
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 17 Sep 2019 00:55:39 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8451: enable admission control for dockerised tests
Hello Andrew Sherman, Lars Volker, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13942 to look at the new patch set (#15). Change subject: IMPALA-8451: enable admission control for dockerised tests .. IMPALA-8451: enable admission control for dockerised tests This gives us some additional coverage for using admission control in a simple but realistic configuration. What are the implications of this change for test stability and flakiness? On one hand were are adding some more unpredictability to tests, because they may be queued for an arbitrary amount of time. On the other, we can prevent queries from contending over memory. Currently we rely on luck to prevent concurrent queries from forcing each other out-of-memory. I think the unpredictability from the queueing is preferable, because we can generally work around these by fixing tests that are sensitive to being queued, whereas contention over memory requires us to use crude workarounds like forcing tests to execute serially. Added observability for the configured queue wait time for each pool. I noticed that I did not have a direct way to observe the effective value when I set configs. I had to tweak tests in a few ways: * Tests with large strings needed higher memory limits. * Hardcoded instances of default-pool had to handle root.default as well. * test_query_mem_limit needed to run without a mem_limit. I created a special pool root.no-limits with no memory limits to allow that. Testing: Ran the dockerised build 5-6 times to flush out flaky tests. Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a --- M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/service/impala-http-handler.h M bin/jenkins/dockerized-impala-run-tests.sh M common/thrift/metrics.json A fe/src/test/resources/minicluster-fair-scheduler.xml A fe/src/test/resources/minicluster-llama-site.xml M testdata/workloads/functional-query/queries/QueryTest/admission-reject-mem-estimate.test M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test M testdata/workloads/functional-query/queries/QueryTest/large_strings.test M testdata/workloads/functional-query/queries/QueryTest/spilling-large-rows.test M testdata/workloads/functional-query/queries/QueryTest/thread-limits.test M tests/query_test/test_insert.py M tests/query_test/test_observability.py M tests/query_test/test_query_mem_limit.py M tests/webserver/test_web_pages.py M www/admission_controller.tmpl 17 files changed, 161 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/13942/15 -- To view, visit http://gerrit.cloudera.org:8080/13942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a Gerrit-Change-Number: 13942 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] IMPALA-8884: track storage read statistics per queue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14242 ) Change subject: IMPALA-8884: track storage read statistics per queue .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4571/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8233ed02b418f22f1d0c031e378288357796f4b4 Gerrit-Change-Number: 14242 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Tue, 17 Sep 2019 00:51:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 ) Change subject: IMPALA-8947: scratch alloc error uses wrong metric .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81 Gerrit-Change-Number: 14236 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 17 Sep 2019 00:47:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14236 ) Change subject: IMPALA-8947: scratch alloc error uses wrong metric .. IMPALA-8947: scratch alloc error uses wrong metric Use the global metric instead of the per-FileGroup counter. Testing: Updated unit test to validate the error message in a case where there are two FileGroups. Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81 Reviewed-on: http://gerrit.cloudera.org:8080/14236 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M be/src/util/metrics.h 3 files changed, 14 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81 Gerrit-Change-Number: 14236 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8451: enable admission control for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13942 ) Change subject: IMPALA-8451: enable admission control for dockerised tests .. Patch Set 14: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4953/ -- To view, visit http://gerrit.cloudera.org:8080/13942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a Gerrit-Change-Number: 13942 Gerrit-PatchSet: 14 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 17 Sep 2019 00:31:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8884: track storage read statistics per queue
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14242 Change subject: IMPALA-8884: track storage read statistics per queue .. IMPALA-8884: track storage read statistics per queue Adds the following metrics for each queue: * impala-server.io-mgr.queue-$i.device-name * impala-server.io-mgr.queue-$i.read-latency * impala-server.io-mgr.queue-$i.read-size I also looked at adding metrics for open operations, but the plumbing got messy since the code paths where hdfsOpen() is invoked are more numerous and complex (e.g. HDFS caching does it outside of a disk thread). Perf: Histograms use atomic operations, so lock contention isn't an issue. Ran a TPC-H benchmark on scale factor 30 locally, saw no perf change. Change-Id: I8233ed02b418f22f1d0c031e378288357796f4b4 --- M be/src/runtime/exec-env.cc M be/src/runtime/io/cache-reader-test-stub.h M be/src/runtime/io/disk-io-mgr-internal.h M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/file-reader.h M be/src/runtime/io/hdfs-file-reader.cc M be/src/runtime/io/hdfs-file-reader.h M be/src/runtime/io/local-file-reader.cc M be/src/runtime/io/local-file-reader.h M be/src/runtime/io/request-ranges.h M be/src/runtime/io/scan-range.cc M be/src/runtime/test-env.cc M be/src/service/impala-server.cc M be/src/util/histogram-metric.h M be/src/util/impalad-metrics.cc M be/src/util/impalad-metrics.h M common/thrift/metrics.json 17 files changed, 215 insertions(+), 116 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/14242/1 -- To view, visit http://gerrit.cloudera.org:8080/14242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8233ed02b418f22f1d0c031e378288357796f4b4 Gerrit-Change-Number: 14242 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4570/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 23:34:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups
Lars Volker has posted comments on this change. (
http://gerrit.cloudera.org:8080/14103 )
Change subject: IMPALA-8858: Add metrics tracking num queries running on
executor groups
..
Patch Set 13: Code-Review+1
(3 comments)
Only some nits, otherwise LGTM.
http://gerrit.cloudera.org:8080/#/c/14103/13/be/src/scheduling/cluster-membership-mgr.h
File be/src/scheduling/cluster-membership-mgr.h:
http://gerrit.cloudera.org:8080/#/c/14103/13/be/src/scheduling/cluster-membership-mgr.h@68
PS13, Line 68: BlacklistExecutor
nit: BlacklistExecutor()
http://gerrit.cloudera.org:8080/#/c/14103/12/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
http://gerrit.cloudera.org:8080/#/c/14103/12/be/src/service/impala-server.cc@1918
PS12, Line 1918: // Add failed backend locations to all querie
> Done
Much better :)
http://gerrit.cloudera.org:8080/#/c/14103/13/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/14103/13/tests/custom_cluster/test_executor_groups.py@385
PS13, Line 385: assert self.coordinator.service.get_metric_value(
This pattern occurs quite often, maybe a helper
self._get_num_executor_groups(only_healthy = False) would be nice?
assert
self.coordinator.service.get_metric_value("cluster-membership.executor-groups.total-healthy")
--
To view, visit http://gerrit.cloudera.org:8080/14103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58cde8699c33af8b87273437e9d8bf6371a34539
Gerrit-Change-Number: 14103
Gerrit-PatchSet: 13
Gerrit-Owner: Bikramjeet Vig
Gerrit-Reviewer: Andrew Sherman
Gerrit-Reviewer: Bikramjeet Vig
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker
Gerrit-Comment-Date: Mon, 16 Sep 2019 23:25:39 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/14059/6/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/14059/6/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@175 PS6, Line 175: RunShellCommand.Run(command, /* shouldSucceed */ false, "", "Not connected to Impala"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14059/6/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/14059/6/tests/shell/test_shell_interactive.py@28 PS6, Line 28: from contextlib import contextmanager flake8: F401 'contextlib.contextmanager' imported but unused http://gerrit.cloudera.org:8080/#/c/14059/6/tests/util/run_impyla_http_query.py File tests/util/run_impyla_http_query.py: http://gerrit.cloudera.org:8080/#/c/14059/6/tests/util/run_impyla_http_query.py@30 PS6, Line 30: def run_query(query, args): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14059/6/tests/util/run_impyla_http_query.py@33 PS6, Line 33: u flake8: F841 local variable 'url' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/14059/6/tests/util/run_impyla_http_query.py@46 PS6, Line 46: def main(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14059/6/tests/util/run_impyla_http_query.py@57 PS6, Line 57: if __name__ == "__main__": flake8: E305 expected 2 blank lines after class or function definition, found 1 -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 22:55:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14059 to look at the new patch set (#6). Change subject: PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2 .. PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2 This change adds support to run backend tests over HTTP using a new version of Impyla. Currently it works with Impyla 0.16a2 and can be used to further test that release. Once Impyla releases 0.16.0, we can polish this change and submit it. Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 --- M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java A fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java A fe/src/test/java/org/apache/impala/customcluster/RunShellCommand.java M infra/python/deps/compiled-requirements.txt M tests/common/impala_connection.py M tests/common/impala_test_suite.py M tests/common/test_dimensions.py M tests/custom_cluster/test_client_ssl.py M tests/custom_cluster/test_hs2.py M tests/custom_cluster/test_session_expiration.py M tests/custom_cluster/test_shell_interactive.py M tests/custom_cluster/test_shell_interactive_reconnect.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py A tests/util/run_impyla_http_query.py 15 files changed, 342 insertions(+), 95 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/14059/6 -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4955/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 22:55:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4569/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73480872ef93215d05c1fd922e64eb68a8a63a42 Gerrit-Change-Number: 14240 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 16 Sep 2019 22:01:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4568/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73480872ef93215d05c1fd922e64eb68a8a63a42 Gerrit-Change-Number: 14240 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 16 Sep 2019 21:58:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4952/ -- To view, visit http://gerrit.cloudera.org:8080/13786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7447f8c8e7e50eb71d18643859d2e3de865368d2 Gerrit-Change-Number: 13786 Gerrit-PatchSet: 5 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 16 Sep 2019 21:51:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile
Yongzhi Chen has posted comments on this change. (
http://gerrit.cloudera.org:8080/14234 )
Change subject: IMPALA-7637: Add more hash table stats to profile
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14234/1/be/src/exec/partitioned-hash-join-builder.cc
File be/src/exec/partitioned-hash-join-builder.cc:
http://gerrit.cloudera.org:8080/#/c/14234/1/be/src/exec/partitioned-hash-join-builder.cc@595
PS1, Line 595: void PhjBuilder::AddHashTableStatsToProfile(RuntimeProfile
*profile) {
> The counters cannot be in the HashTable class. For each PhjBuilder object,
Found the place in grouping-aggregator, I will put the similar code in a common
method, it seems only HashTable possible.
--
To view, visit http://gerrit.cloudera.org:8080/14234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87
Gerrit-Change-Number: 14234
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sahil Takiar
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Yongzhi Chen
Gerrit-Comment-Date: Mon, 16 Sep 2019 21:48:09 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. IMPALA-8761: Improve events processor configuration validation. This patch aims to improve the validation of configuration keys from the HMS. IMPALA-8559 introduced configuration validation for events processor configurations. In the existing implementation, the events processor errors out as soon as it sees a validation failure. If there are more than one configuration errors, the users may have to restart HMS each time they fix a configuration error. This is bad user experience. This change collects all the configuration issues and logs expected values before erroring out. Users can now fix all issues in one go. Testing: Added testValidateConfigs() to assert if multiple incorrect values are detected at once. Change-Id: I73480872ef93215d05c1fd922e64eb68a8a63a42 --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 2 files changed, 43 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14240/2 -- To view, visit http://gerrit.cloudera.org:8080/14240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73480872ef93215d05c1fd922e64eb68a8a63a42 Gerrit-Change-Number: 14240 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14240 Change subject: IMPALA-8761: Improve events processor configuration validation. .. IMPALA-8761: Improve events processor configuration validation. This patch aims to improve the validation of configuration keys from the HMS. IMPALA-8559 introduced configuration validation for events processor configurations. In the existing implementation, the events processor errors out as soon as it sees a validation failure. If there are more than one configuration errors, the users may have to restart HMS each time they fix an configuration error. This is bad user experience. This change collects all the configuration issues and logs expected values before erroring out. Users can now fix all issues in one go. Testing: Added testValidateConfigs() to assert if multiple incorrect values are detected at once. Change-Id: I73480872ef93215d05c1fd922e64eb68a8a63a42 --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 2 files changed, 43 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14240/1 -- To view, visit http://gerrit.cloudera.org:8080/14240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I73480872ef93215d05c1fd922e64eb68a8a63a42 Gerrit-Change-Number: 14240 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada
[Impala-ASF-CR] use set-pythonpath only for impala-python
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14238 ) Change subject: use set-pythonpath only for impala-python .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4567/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff98eb261ab48c592e8d323aa409c6a65317b95a Gerrit-Change-Number: 14238 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 16 Sep 2019 21:11:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14239 ) Change subject: IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent .. IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent Change-Id: I9bee4c0935ee21d70a0964507c477a2fccb1c7cc Reviewed-on: http://gerrit.cloudera.org:8080/14239 Tested-by: Impala Public Jenkins Reviewed-by: Tim Armstrong --- M docs/topics/impala_operators.xml 1 file changed, 19 insertions(+), 19 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9bee4c0935ee21d70a0964507c477a2fccb1c7cc Gerrit-Change-Number: 14239 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14239 ) Change subject: IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bee4c0935ee21d70a0964507c477a2fccb1c7cc Gerrit-Change-Number: 14239 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 16 Sep 2019 20:55:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14239 ) Change subject: IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/484/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bee4c0935ee21d70a0964507c477a2fccb1c7cc Gerrit-Change-Number: 14239 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:39:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Reviewed-on: http://gerrit.cloudera.org:8080/14229 Reviewed-by: Bharath Vissapragada Tested-by: Impala Public Jenkins --- M docs/shared/impala_common.xml M docs/topics/impala_authorization.xml M docs/topics/impala_grant.xml 3 files changed, 54 insertions(+), 10 deletions(-) Approvals: Bharath Vissapragada: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 ) Change subject: IMPALA-8947: scratch alloc error uses wrong metric .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4954/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81 Gerrit-Change-Number: 14236 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:37:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 ) Change subject: IMPALA-8947: scratch alloc error uses wrong metric .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81 Gerrit-Change-Number: 14236 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:37:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 4: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/483/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:37:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 ) Change subject: IMPALA-8947: scratch alloc error uses wrong metric .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4566/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81 Gerrit-Change-Number: 14236 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:37:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8451: enable admission control for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13942 ) Change subject: IMPALA-8451: enable admission control for dockerised tests .. Patch Set 14: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4953/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a Gerrit-Change-Number: 13942 Gerrit-PatchSet: 14 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Mon, 16 Sep 2019 20:34:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14239 ) Change subject: IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/484/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bee4c0935ee21d70a0964507c477a2fccb1c7cc Gerrit-Change-Number: 14239 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:32:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14239 Change subject: IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent .. IMPALA-8945: [DOCS] Fixed an incorrect example of DISTINT FROM and its equivalent Change-Id: I9bee4c0935ee21d70a0964507c477a2fccb1c7cc --- M docs/topics/impala_operators.xml 1 file changed, 19 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/14239/1 -- To view, visit http://gerrit.cloudera.org:8080/14239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9bee4c0935ee21d70a0964507c477a2fccb1c7cc Gerrit-Change-Number: 14239 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] use set-pythonpath only for impala-python
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14238 ) Change subject: use set-pythonpath only for impala-python .. Patch Set 1: I tried this cleanup after a conversation we had a week and a half ago. Getting around to posting for review now. -- To view, visit http://gerrit.cloudera.org:8080/14238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff98eb261ab48c592e8d323aa409c6a65317b95a Gerrit-Change-Number: 14238 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 16 Sep 2019 20:31:24 + Gerrit-HasComments: No
[Impala-ASF-CR] use set-pythonpath only for impala-python
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14238 Change subject: use set-pythonpath only for impala-python .. use set-pythonpath only for impala-python * Don't add PYTHONPATH to environment in impala-config.sh, it is done automatically by the impala-python script anyway. I think this is legacy from when we ran some things with the system python. * Remove unnecessary set-pythonpath.sh invocations where all calls go via impala-python anyway. * Remove impala-shell eggs from python path. All these packages are installed into the virtualenv. * testdata path entry was not needed - it's imported via the root Testing: Ran core tests Change-Id: Iff98eb261ab48c592e8d323aa409c6a65317b95a --- M bin/impala-config.sh M bin/impala-shell.sh M bin/run-all-tests.sh M bin/set-pythonpath.sh M buildall.sh M testdata/bin/run-hive-server.sh M tests/query_test/test_nested_types.py 7 files changed, 10 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/14238/1 -- To view, visit http://gerrit.cloudera.org:8080/14238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iff98eb261ab48c592e8d323aa409c6a65317b95a Gerrit-Change-Number: 14238 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14236 ) Change subject: IMPALA-8947: scratch alloc error uses wrong metric .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81 Gerrit-Change-Number: 14236 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:26:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8948: [DOCS] Impala cannot write to compressed text file
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/14237 ) Change subject: IMPALA-8948: [DOCS] Impala cannot write to compressed text file .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/14237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7eac0431f3daeb1c3102c6a58670bce0e899d5f2 Gerrit-Change-Number: 14237 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 16 Sep 2019 20:23:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:19:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14229/3/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/14229/3/docs/shared/impala_common.xml@118 PS3, Line 118: Sentry > update? Done -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:15:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 4: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/483/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:15:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14229 to look at the new patch set (#4). Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 --- M docs/shared/impala_common.xml M docs/topics/impala_authorization.xml M docs/topics/impala_grant.xml 3 files changed, 54 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14229/4 -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8948: [DOCS] Impala cannot write to compressed text file
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14237 ) Change subject: IMPALA-8948: [DOCS] Impala cannot write to compressed text file .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/482/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7eac0431f3daeb1c3102c6a58670bce0e899d5f2 Gerrit-Change-Number: 14237 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 16 Sep 2019 20:12:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14235 ) Change subject: IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/481/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib457775fab03d7f30430fd7dea6404dfcf0783a8 Gerrit-Change-Number: 14235 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 16 Sep 2019 20:11:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14229/3/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/14229/3/docs/shared/impala_common.xml@118 PS3, Line 118: Sentry update? -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:09:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8948: [DOCS] Impala cannot write to compressed text file
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14237 to look at the new patch set (#2). Change subject: IMPALA-8948: [DOCS] Impala cannot write to compressed text file .. IMPALA-8948: [DOCS] Impala cannot write to compressed text file Change-Id: I7eac0431f3daeb1c3102c6a58670bce0e899d5f2 --- M docs/topics/impala_file_formats.xml 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/14237/2 -- To view, visit http://gerrit.cloudera.org:8080/14237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7eac0431f3daeb1c3102c6a58670bce0e899d5f2 Gerrit-Change-Number: 14237 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8948": [DOCS] Impala cannot write to compressed text file
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14237 ) Change subject: IMPALA-8948": [DOCS] Impala cannot write to compressed text file .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/482/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7eac0431f3daeb1c3102c6a58670bce0e899d5f2 Gerrit-Change-Number: 14237 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 20:05:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8948": [DOCS] Impala cannot write to compressed text file
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14237 Change subject: IMPALA-8948": [DOCS] Impala cannot write to compressed text file .. IMPALA-8948": [DOCS] Impala cannot write to compressed text file Change-Id: I7eac0431f3daeb1c3102c6a58670bce0e899d5f2 --- M docs/topics/impala_file_formats.xml 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/14237/1 -- To view, visit http://gerrit.cloudera.org:8080/14237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7eac0431f3daeb1c3102c6a58670bce0e899d5f2 Gerrit-Change-Number: 14237 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile
Yongzhi Chen has posted comments on this change. (
http://gerrit.cloudera.org:8080/14234 )
Change subject: IMPALA-7637: Add more hash table stats to profile
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14234/1/be/src/exec/partitioned-hash-join-builder.cc
File be/src/exec/partitioned-hash-join-builder.cc:
http://gerrit.cloudera.org:8080/#/c/14234/1/be/src/exec/partitioned-hash-join-builder.cc@595
PS1, Line 595: void PhjBuilder::AddHashTableStatsToProfile(RuntimeProfile
*profile) {
> The HashTable class is also used in the hash aggregation (grouping-aggregat
The counters cannot be in the HashTable class. For each PhjBuilder object, it
can have more than one hash table. For counters and profile object are all in
PhjBuilder, it is more natural the method is in the class. I will do more
research on where to profile grouping-aggregator.
--
To view, visit http://gerrit.cloudera.org:8080/14234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87
Gerrit-Change-Number: 14234
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sahil Takiar
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Yongzhi Chen
Gerrit-Comment-Date: Mon, 16 Sep 2019 20:03:44 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8947: scratch alloc error uses wrong metric
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14236 Change subject: IMPALA-8947: scratch alloc error uses wrong metric .. IMPALA-8947: scratch alloc error uses wrong metric Use the global metric instead of the per-FileGroup counter. Testing: Updated unit test to validate the error message in a case where there are two FileGroups. Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81 --- M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M be/src/util/metrics.h 3 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/14236/1 -- To view, visit http://gerrit.cloudera.org:8080/14236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2732dcd49c277d5d278fad68efa6ef381bc0eb81 Gerrit-Change-Number: 14236 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14235 ) Change subject: IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/481/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib457775fab03d7f30430fd7dea6404dfcf0783a8 Gerrit-Change-Number: 14235 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 19:48:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14235 Change subject: IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables .. IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables Change-Id: Ib457775fab03d7f30430fd7dea6404dfcf0783a8 --- M docs/topics/impala_transactions.xml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/14235/1 -- To view, visit http://gerrit.cloudera.org:8080/14235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib457775fab03d7f30430fd7dea6404dfcf0783a8 Gerrit-Change-Number: 14235 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. IMPALA-8825: Add additional counters to PlanRootSink Adds the counters RowsSent and RowsSentRate to the PLAN_ROOT_SINK section of the profile: PLAN_ROOT_SINK: - PeakMemoryUsage: 4.01 MB (4202496) - RowBatchGetWaitTime: 0.000ns - RowBatchSendWaitTime: 0.000ns - RowsSent: 10 (10) - RowsSentRate: 416.00 /sec RowsSent tracks the number of rows sent to the PlanRootSink via PlanRootSink::Send. RowsSentRate tracks the rate that rows are sent to the PlanRootSink. Adds the counters NumRowsFetched, NumRowsFetchedFromCache, and RowMaterializationRate to the ImpalaServer section of the profile. ImpalaServer: - ClientFetchWaitTimer: 11.999ms - NumRowsFetched: 10 (10) - NumRowsFetchedFromCache: 10 (10) - RowMaterializationRate: 9.00 /sec - RowMaterializationTimer: 1s007ms NumRowsFetched tracks the total number of rows fetched by the query, but does not include rows fetched from the cache. NumRowsFetchedFromCache tracks the total number of rows fetched from the query results cache. RowMaterializationRate tracks the rate at which rows are materialized. RowMaterializationTimer already existed and tracks how much time is spent materializing rows. Testing: * Added tests to test_fetch_first.py and query_test/test_fetch.py * Enabled some tests in test_fetch_first.py that were pending the completion of IMPALA-8819 * Ran core tests Change-Id: Id9e101e2f3e2bf8324e149c780d35825ceecc036 Reviewed-on: http://gerrit.cloudera.org:8080/14180 Tested-by: Impala Public Jenkins Reviewed-by: Sahil Takiar --- M be/src/exec/blocking-plan-root-sink.cc M be/src/exec/buffered-plan-root-sink.cc M be/src/exec/plan-root-sink.cc M be/src/exec/plan-root-sink.h M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M tests/common/impala_test_suite.py M tests/custom_cluster/test_result_spooling.py M tests/hs2/test_fetch_first.py A tests/query_test/test_fetch.py 10 files changed, 199 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Verified Sahil Takiar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id9e101e2f3e2bf8324e149c780d35825ceecc036 Gerrit-Change-Number: 14180 Gerrit-PatchSet: 8 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 7: Code-Review+2 Carrying +2 -- To view, visit http://gerrit.cloudera.org:8080/14180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9e101e2f3e2bf8324e149c780d35825ceecc036 Gerrit-Change-Number: 14180 Gerrit-PatchSet: 7 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 16 Sep 2019 19:36:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9e101e2f3e2bf8324e149c780d35825ceecc036 Gerrit-Change-Number: 14180 Gerrit-PatchSet: 7 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 16 Sep 2019 19:33:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/480/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 18:52:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14229/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/14229/2/docs/shared/impala_common.xml@113 PS2, Line 113: : : Sentry-Related Content > What about these? Done http://gerrit.cloudera.org:8080/#/c/14229/2/docs/topics/impala_authorization.xml File docs/topics/impala_authorization.xml: http://gerrit.cloudera.org:8080/#/c/14229/2/docs/topics/impala_authorization.xml@180 PS2, Line 180: . > Refer the jira? Done -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 18:50:04 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/480/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 18:46:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14229 to look at the new patch set (#3). Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 --- M docs/shared/impala_common.xml M docs/topics/impala_authorization.xml M docs/topics/impala_grant.xml 3 files changed, 50 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14229/3 -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/479/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 18:44:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 25: I'll take a deeper look at this today. Thanks for your patience. -- To view, visit http://gerrit.cloudera.org:8080/13748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb88422f7cfe86947d11ce57d2b4c63e57d1b643 Gerrit-Change-Number: 13748 Gerrit-PatchSet: 25 Gerrit-Owner: radford nguyen Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Mon, 16 Sep 2019 18:40:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 2: (2 comments) Couple of nits, lgtm otherwise. http://gerrit.cloudera.org:8080/#/c/14229/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/14229/2/docs/shared/impala_common.xml@113 PS2, Line 113: : : Sentry-Related Content What about these? http://gerrit.cloudera.org:8080/#/c/14229/2/docs/topics/impala_authorization.xml File docs/topics/impala_authorization.xml: http://gerrit.cloudera.org:8080/#/c/14229/2/docs/topics/impala_authorization.xml@180 PS2, Line 180: . Refer the jira? -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 18:34:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/479/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 18:31:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14229 to look at the new patch set (#2). Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 --- M docs/shared/impala_common.xml M docs/topics/impala_authorization.xml M docs/topics/impala_grant.xml 3 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14229/2 -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml@123 PS1, Line 123: > This should be in Ranger integration section? Done http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml@128 PS1, Line 128: includes > implies? (nit: extra space) There is no extra space. Changed "includes" to "implies". http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml File docs/topics/impala_authorization.xml: http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@156 PS1, Line 156: ownership is enabled by default in Impala, > I think this should be rephrased. Done http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@162 PS1, Line 162: An owner has the OWNER privilege if enabled in : Sentry. > remove. Done http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@173 PS1, Line 173: > We should also mention the caveat with Ranger ownership integration that "S Done -- To view, visit http://gerrit.cloudera.org:8080/14229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5 Gerrit-Change-Number: 14229 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 18:31:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4952/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7447f8c8e7e50eb71d18643859d2e3de865368d2 Gerrit-Change-Number: 13786 Gerrit-PatchSet: 5 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 16 Sep 2019 17:39:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7447f8c8e7e50eb71d18643859d2e3de865368d2 Gerrit-Change-Number: 13786 Gerrit-PatchSet: 5 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 16 Sep 2019 17:39:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7447f8c8e7e50eb71d18643859d2e3de865368d2 Gerrit-Change-Number: 13786 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 16 Sep 2019 17:39:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14234/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/14234/1/tests/query_test/test_observability.py@675 PS1, Line 675: assert "Hash Table" in runtime_profile : assert "Probes:" in runtime_profile : assert "Travel:" in runtime_profile : assert "HashCollisions:" in runtime_profile : assert "Resizes:" in runtime_profile > would be good to validate that they have valid values - e.g. they are non-z That's a good point. I think it would be easy with the way the code is structured for us to double-count some of these things by moving code around, so some kind of range check might be useful too (I'm fairly flexible on this though since we've generally not validated profile counters for pragmatic reasons). -- To view, visit http://gerrit.cloudera.org:8080/14234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 Gerrit-Change-Number: 14234 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 16 Sep 2019 17:38:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger
Bharath Vissapragada has posted comments on this change. (
http://gerrit.cloudera.org:8080/14229 )
Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated
with Ranger
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml@123
PS1, Line 123:
This should be in Ranger integration section?
http://gerrit.cloudera.org:8080/#/c/14229/1/docs/shared/impala_common.xml@128
PS1, Line 128: includes
implies? (nit: extra space)
http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@156
PS1, Line 156: ownership is enabled by default in Impala,
I think this should be rephrased.
Object ownership for tables, views and databases is enabled by default in
Impala. To define owner specific privileges, go to ranger UI and define
appropriate policies on {OWNER} user
http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@162
PS1, Line 162: An owner has the OWNER privilege if enabled in
: Sentry.
remove.
http://gerrit.cloudera.org:8080/#/c/14229/1/docs/topics/impala_authorization.xml@173
PS1, Line 173:
We should also mention the caveat with Ranger ownership integration that "SHOW
TABLES" may not work as expected. I added it in the commit message [1]. TL;DR
"show tables" command cannot infer ownership information because the current
design of metadata lacks aggressive caching of ownership information. The user
behavior ends up like, show tables does not list the table even though a user
owns it unless it is fully loaded in the coordinator catalog cache IMPALA-8937.
Users can still do queries on the table (like select * from foo) because these
kinds of statements preload the table before performing the authz checks.
[1]
https://github.com/apache/impala/commit/ced6e98fb4c361efa4bcc7e5441ccdb8debba8e9
--
To view, visit http://gerrit.cloudera.org:8080/14229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fdaf05953373c8d1870b7eface257830c7c6e5
Gerrit-Change-Number: 14229
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Mon, 16 Sep 2019 17:30:58 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8572: Skip test lineage output on S3
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14230 ) Change subject: IMPALA-8572: Skip test_lineage_output on S3 .. IMPALA-8572: Skip test_lineage_output on S3 The test has a hbase dependency that does not run in S3. Change-Id: I781c2dc42c042747eed6134cea4f3f0879a40294 Reviewed-on: http://gerrit.cloudera.org:8080/14230 Tested-by: Impala Public Jenkins Reviewed-by: Sahil Takiar --- M tests/custom_cluster/test_lineage.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Sahil Takiar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I781c2dc42c042747eed6134cea4f3f0879a40294 Gerrit-Change-Number: 14230 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14231 ) Change subject: IMPALA-8228: Fix _test_ownership on CentOS6 .. IMPALA-8228: Fix _test_ownership on CentOS6 String format() with positional formatting does not work without position argument specifiers in Python 2.6 that ships with CentOs6. Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157 Reviewed-on: http://gerrit.cloudera.org:8080/14231 Tested-by: Impala Public Jenkins Reviewed-by: Sahil Takiar --- M tests/authorization/test_ranger.py 1 file changed, 18 insertions(+), 18 deletions(-) Approvals: Impala Public Jenkins: Verified Sahil Takiar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157 Gerrit-Change-Number: 14231 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-8572: Skip test lineage output on S3
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14230 ) Change subject: IMPALA-8572: Skip test_lineage_output on S3 .. Patch Set 1: Thanks for the review. This test does not add any coverage specific to S3. The lineages are still written to a local directory and not S3. In a way it is redundant to run this with S3. -- To view, visit http://gerrit.cloudera.org:8080/14230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I781c2dc42c042747eed6134cea4f3f0879a40294 Gerrit-Change-Number: 14230 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Mon, 16 Sep 2019 17:04:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14234/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14234/1//COMMIT_MSG@17 PS1, Line 17: Hash Join Builder (join_node_id=2): : ExecOption: Codegen Disabled: disabled due to optimization hints : Runtime filters: 1 of 1 Runtime Filter Published : - BuildRowsPartitionTime: 157.960us : - BuildRowsPartitioned: 100 (100) : - HashTablesBuildTime: 298.817us : - LargestPartitionPercent: 7 (7) : - MaxPartitionLevel: 0 (0) : - NumRepartitions: 0 (0) : - PartitionsCreated: 16 (16) : - PeakMemoryUsage: 17.12 KB (17536) : - RepartitionTime: 0.000ns : - SpilledPartitions: 0 (0) : Hash Table: :- HashBuckets: 256 (256) :- HashCollisions: 0 (0) :- Probes: 2.52K (2520) :- Resizes: 0 (0) :- Travel: 1.79K (1787) nit: don't think this has to be indented so much, just two spaces is probably sufficient, plus the `ExecOption` line is exceeding the max width of the commit message. http://gerrit.cloudera.org:8080/#/c/14234/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/14234/1/tests/query_test/test_observability.py@675 PS1, Line 675: assert "Hash Table" in runtime_profile : assert "Probes:" in runtime_profile : assert "Travel:" in runtime_profile : assert "HashCollisions:" in runtime_profile : assert "Resizes:" in runtime_profile would be good to validate that they have valid values - e.g. they are non-zero. not sure that would apply to all of these (e.g. resizes), but it would be good to add the validation for the ones that are non-zero. -- To view, visit http://gerrit.cloudera.org:8080/14234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 Gerrit-Change-Number: 14234 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 16 Sep 2019 16:55:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/14234 )
Change subject: IMPALA-7637: Add more hash table stats to profile
..
Patch Set 1:
(2 comments)
Looks good, I had a couple of requests for cleanup that were problems with the
pre-existing code.
http://gerrit.cloudera.org:8080/#/c/14234/1/be/src/exec/hash-table.h
File be/src/exec/hash-table.h:
http://gerrit.cloudera.org:8080/#/c/14234/1/be/src/exec/hash-table.h@741
PS1, Line 741: int64_t NumHashCollisions() const { return
num_hash_collisions_; }
nit: we usually use lower_case for trivial accessor functions (this is allowed
by the google style guide - see
https://google.github.io/styleguide/cppguide.html#Function_Names)
This was a pre-existing pattern in this file, but I think now is a good time to
make it consistent with the rest of the codebase.
http://gerrit.cloudera.org:8080/#/c/14234/1/be/src/exec/partitioned-hash-join-builder.cc
File be/src/exec/partitioned-hash-join-builder.cc:
http://gerrit.cloudera.org:8080/#/c/14234/1/be/src/exec/partitioned-hash-join-builder.cc@595
PS1, Line 595: void PhjBuilder::AddHashTableStatsToProfile(RuntimeProfile
*profile) {
The HashTable class is also used in the hash aggregation
(grouping-aggregator.cc), so we should try to also include the stats there too.
I think it would make more sense to have helper methods in HashTable to create
and update the profile counters, so that it can be easily reused.
It looks like this pattern of having counters in the hash join but not the agg
was already there, but it would be really nice to improve it at this point.
--
To view, visit http://gerrit.cloudera.org:8080/14234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87
Gerrit-Change-Number: 14234
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sahil Takiar
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Yongzhi Chen
Gerrit-Comment-Date: Mon, 16 Sep 2019 16:19:54 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4951/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9e101e2f3e2bf8324e149c780d35825ceecc036 Gerrit-Change-Number: 14180 Gerrit-PatchSet: 7 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 16 Sep 2019 15:19:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8572: Skip test lineage output on S3
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14230 ) Change subject: IMPALA-8572: Skip test_lineage_output on S3 .. Patch Set 1: Code-Review+2 Might be nice to split lineage.test into HBase and non-HBase versions - e.g. make a hbase-lineage.test file. That way we don't lose the coverage when running on S3. I'm not particularly familiar with lineage so not sure if it is worth the effort. If you don't think it is necessary, then +2. -- To view, visit http://gerrit.cloudera.org:8080/14230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I781c2dc42c042747eed6134cea4f3f0879a40294 Gerrit-Change-Number: 14230 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Mon, 16 Sep 2019 15:19:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14231 ) Change subject: IMPALA-8228: Fix _test_ownership on CentOS6 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157 Gerrit-Change-Number: 14231 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Mon, 16 Sep 2019 15:12:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4565/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 Gerrit-Change-Number: 14234 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 16 Sep 2019 14:00:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 17: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4564/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0289394adcb97a3529313030930c9c5b85aaa12 Gerrit-Change-Number: 13329 Gerrit-PatchSet: 17 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 16 Sep 2019 13:25:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile
Yongzhi Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14234 Change subject: IMPALA-7637: Add more hash table stats to profile .. IMPALA-7637: Add more hash table stats to profile Add hash table counters(probes, travel and resizes) to profile. Put hash table stats into the child profile "hash table". Tests: Add new test test_query_profle_hashtable. Ran exhaustive tests. Profile Sample: Hash Join Builder (join_node_id=2): ExecOption: Codegen Disabled: disabled due to optimization hints Runtime filters: 1 of 1 Runtime Filter Published - BuildRowsPartitionTime: 157.960us - BuildRowsPartitioned: 100 (100) - HashTablesBuildTime: 298.817us - LargestPartitionPercent: 7 (7) - MaxPartitionLevel: 0 (0) - NumRepartitions: 0 (0) - PartitionsCreated: 16 (16) - PeakMemoryUsage: 17.12 KB (17536) - RepartitionTime: 0.000ns - SpilledPartitions: 0 (0) Hash Table: - HashBuckets: 256 (256) - HashCollisions: 0 (0) - Probes: 2.52K (2520) - Resizes: 0 (0) - Travel: 1.79K (1787) Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 --- M be/src/exec/hash-table.h M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h M tests/query_test/test_observability.py 4 files changed, 48 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/14234/1 -- To view, visit http://gerrit.cloudera.org:8080/14234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 Gerrit-Change-Number: 14234 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen
[Impala-ASF-CR] IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 17: (1 comment) Some information for reviewers: I started this refactor and later asked Danial to finish it, which led to quite big changes. It may help to look at the change in two steps: 1. till PS 3 - I tried to use mainly copy paste to avoid changing existing logic 2. rest of the review - several small logic changes were done to make the interfaces + code cleaner http://gerrit.cloudera.org:8080/#/c/13329/17/be/src/exec/parquet/parquet-page-reader-low.cc File be/src/exec/parquet/parquet-page-reader-low.cc: http://gerrit.cloudera.org:8080/#/c/13329/17/be/src/exec/parquet/parquet-page-reader-low.cc@37 PS17, Line 37: #include "util/codec.h" This header is not needed in this - can you look through the change for other unnecessary header files? -- To view, visit http://gerrit.cloudera.org:8080/13329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0289394adcb97a3529313030930c9c5b85aaa12 Gerrit-Change-Number: 13329 Gerrit-PatchSet: 17 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 16 Sep 2019 13:03:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader
Csaba Ringhofer has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/13329 ) Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader Moved some responsibilities from parquet-column-readers.cc to new classes 'ParquetPageReader' and 'ParquetPageReaderLow': - reading pages from ScanRange - decompress data if needed The main motivation is to make the implementation of V2 data page reading simpler by moving most parts that will differ between V1 and V2 into a class with manageable complexity. Testing: - ran parquet related scanner tests Change-Id: Ic0289394adcb97a3529313030930c9c5b85aaa12 --- M be/src/exec/parquet/CMakeLists.txt M be/src/exec/parquet/hdfs-parquet-scanner.h M be/src/exec/parquet/parquet-column-readers.cc M be/src/exec/parquet/parquet-column-readers.h A be/src/exec/parquet/parquet-page-reader-low.cc A be/src/exec/parquet/parquet-page-reader-low.h A be/src/exec/parquet/parquet-page-reader.cc A be/src/exec/parquet/parquet-page-reader.h 8 files changed, 1,016 insertions(+), 474 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/13329/17 -- To view, visit http://gerrit.cloudera.org:8080/13329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic0289394adcb97a3529313030930c9c5b85aaa12 Gerrit-Change-Number: 13329 Gerrit-PatchSet: 17 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
