[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5031/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 02:21:58 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-8977: Update version of maven used for building docker containers
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14326 ) Change subject: IMPALA-8977: Update version of maven used for building docker containers .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53f261b4f9b20b966522bddd34d5aaf4882fb66e Gerrit-Change-Number: 14326 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 00:22:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml File docs/topics/impala_fetch_rows_timeout_ms.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@21 PS1, Line 21: IMPALA-3200 is this the right JIRA? http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@46 PS1, Line 46: should mention IMPALA-8962 as well. the timeout also applies to fetch request issued against 'RUNNING' queries. a query that is 'RUNNING' has no rows available, so any fetch request will wait until the query transitions to the 'FINISHED' state and for it to fetch all requested rows. a query in the 'FINISHED' state means that the rows are available to be fetched (the query may actually still be executing though). http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@51 PS1, Line 51: 10 default is 10 seconds, so 1 ms, should the units be somewhere? http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_result_spooling_mem.xml File docs/topics/impala_max_result_spooling_mem.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_result_spooling_mem.xml@39 PS1, Line 39: unpinned I don't think our docs really explain the difference between unpinned vs pinned memory, so we should probably avoid mentioning pinned and unpinned memory altogether. for this section, we can just say that all memory will most likely be spilled to disk. http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_spilled_result_spooling_mem.xml File docs/topics/impala_max_spilled_result_spooling_mem.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_spilled_result_spooling_mem.xml@47 PS1, Line 47: to allow unpinning all pinned : memory when the amount of spooled results exceeds : MAX_RESULT_SPOOLING_MEM can just remove this part http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml File docs/topics/impala_query_results_spooling.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@32 PS1, Line 32: cause causing http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@32 PS1, Line 32: wait for : extended wait for an extended http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@40 PS1, Line 40: this spooled locations the spooled results. http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@54 PS1, Line 54: unpinned remove unpin reference here and below http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@95 PS1, Line 95: of the number of rows returned by the query of the amount of memory needed to spool all the rows returned by the query http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@98 PS1, Line 98: and remove "and". the read and write buffers are 2 MB in size each, which is why the default is 4 MB http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@117 PS1, Line 117: asynchronously remove, it isn't really asynchronously -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 00:12:46 + Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-8977: Update version of maven used for building docker containers
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14326 Change subject: IMPALA-8977: Update version of maven used for building docker containers .. IMPALA-8977: Update version of maven used for building docker containers postinstall.sh currently downloads and uses maven 3.6.0. However, maven 3.6.0 is no longer available at the URL hardcoded in postinstall.sh. This switches to using maven 3.6.2. This also modifies docker/buildall.py to allow building a single docker file. I verified that the following docker images build: - Redhat 7 - Debian 8 - Ubuntu 18.04 / 16.04 / 14.04 / 12.04 These do not: - Redhat 6 - tracked by IMPALA-8978 - Debian 7 - tracked by IMPALA-8992 I did not check SLES12. Change-Id: I53f261b4f9b20b966522bddd34d5aaf4882fb66e --- M docker/README.md M docker/all/postinstall.sh M docker/buildall.py 3 files changed, 18 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/26/14326/1 -- To view, visit http://gerrit.cloudera.org:8080/14326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I53f261b4f9b20b966522bddd34d5aaf4882fb66e Gerrit-Change-Number: 14326 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 30 Sep 2019 23:52:15 + Gerrit-HasComments: No
[Impala-ASF-CR] Upgrade jackson-databind to 2.10
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14324 ) Change subject: Upgrade jackson-databind to 2.10 .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4683/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c4f175bfb454d79429b2308a58c4d5e1ac93a84 Gerrit-Change-Number: 14324 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 30 Sep 2019 23:06:12 + Gerrit-HasComments: No
[Impala-ASF-CR] Upgrade jackson-databind to 2.10
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14324 ) Change subject: Upgrade jackson-databind to 2.10 .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4682/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c4f175bfb454d79429b2308a58c4d5e1ac93a84 Gerrit-Change-Number: 14324 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 30 Sep 2019 23:08:51 + Gerrit-HasComments: No
[Impala-ASF-CR] Upgrade jackson-databind to 2.10
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14324 ) Change subject: Upgrade jackson-databind to 2.10 .. WIP Change-Id: I4c4f175bfb454d79429b2308a58c4d5e1ac93a84 --- M impala-parent/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/14324/2 -- To view, visit http://gerrit.cloudera.org:8080/14324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c4f175bfb454d79429b2308a58c4d5e1ac93a84 Gerrit-Change-Number: 14324 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Upgrade jackson-databind to 2.10
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14324 to look at the new patch set (#3). Change subject: Upgrade jackson-databind to 2.10 .. Upgrade jackson-databind to 2.10 This release has some changes that should reduce the number of CVEs associated with the dependency. See https://medium.com/@cowtowncoder/jackson-2-10-features-cd880674d8a2 Change-Id: I4c4f175bfb454d79429b2308a58c4d5e1ac93a84 --- M impala-parent/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/14324/3 -- To view, visit http://gerrit.cloudera.org:8080/14324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c4f175bfb454d79429b2308a58c4d5e1ac93a84 Gerrit-Change-Number: 14324 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5027/ -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 21:39:49 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4681/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 30 Sep 2019 20:16:08 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14197/7/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: http://gerrit.cloudera.org:8080/#/c/14197/7/be/src/exec/kudu-util.cc@239 PS7, Line 239: case DataType::VARCHAR: return ColumnType::CreateVarcharType(type_attributes.length()); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 30 Sep 2019 19:36:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5029/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 30 Sep 2019 19:36:30 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14197 to look at the new patch set (#7). Change subject: [WIP] Add POC Kudu VARCHAR .. [WIP] Add POC Kudu VARCHAR Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 --- M be/src/exec/kudu-util.cc M bin/impala-config.sh M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/KuduUtil.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test 7 files changed, 62 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/14197/7 -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4680/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 18:05:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4679/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 17:48:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14323/1/be/src/util/webserver-test.cc File be/src/util/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/14323/1/be/src/util/webserver-test.cc@351 PS1, Line 351: // TODO(todd): import curl into native-toolchain and test this with Do we have a JIRA for this? -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 17:13:55 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5027/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 17:23:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 2: Code-Review+2 (1 comment) carrying forward http://gerrit.cloudera.org:8080/#/c/14323/1/be/src/util/webserver-test.cc File be/src/util/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/14323/1/be/src/util/webserver-test.cc@351 PS1, Line 351: // TODO(todd) IMPALA-8987: import curl into native-toolchain and test this with > Do we have a JIRA for this? Done -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 17:22:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14323 to look at the new patch set (#2). Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. IMPALA-8982: Fix webserver handling of OPTIONS Previously, Impala's webserver always returned 500 errors to OPTIONS requests. Fixing this requires two changes: - Squeasel is updated to 36dc66b8723980feb32196a94b46734eb5eafbf9, which pulls in a patch that allows it to handle OPTIONS requests correctly. - Webserver is modified to recognize OPTIONS requests and allow Squeasel to handle them. Testing: - Added a BE test that checks that OPTIONS works without SPNEGO. - Added a test that checks that OPTIONS works when SPNEGO is turned on. The test is currently disabled until we add curl to the toolchain. Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 --- M be/src/thirdparty/squeasel/squeasel.c M be/src/util/webserver-test.cc M be/src/util/webserver.cc 3 files changed, 32 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/14323/2 -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14323 Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. IMPALA-8982: Fix webserver handling of OPTIONS Previously, Impala's webserver always returned 500 errors to OPTIONS requests. Fixing this requires two changes: - Squeasel is updated to 36dc66b8723980feb32196a94b46734eb5eafbf9, which pulls in a patch that allows it to handle OPTIONS requests correctly. - Webserver is modified to recognize OPTIONS requests and allow Squeasel to handle them. Testing: - Added a BE test that checks that OPTIONS works without SPNEGO. - Added a test that checks that OPTIONS works when SPNEGO is turned on. The test is currently disabled until we add curl to the toolchain. Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 --- M be/src/thirdparty/squeasel/squeasel.c M be/src/util/webserver-test.cc M be/src/util/webserver.cc 3 files changed, 31 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/14323/1 -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14264/4/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/14264/4/be/src/exec/parquet/hdfs-parquet-table-writer.cc@444 PS4, Line 444: std::isnan(*v) std::isnan() could be put in an UNLIKELY macro. -- To view, visit http://gerrit.cloudera.org:8080/14264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9d367500243c8ca142a16ebfeef6c841f013434 Gerrit-Change-Number: 14264 Gerrit-PatchSet: 4 Gerrit-Owner: Norbert Luksa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Norbert Luksa Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 30 Sep 2019 16:16:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. Patch Set 7: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/4678/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 7 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 15:31:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py File tests/stress/test_acid_stress.py: http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49 PS3, Line 49: nit: no space needed http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49 PS3, Line 49: ' nit: extra ' http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@67 PS3, Line 67: read write? http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@68 PS3, Line 68: from Hive. Should we add another role and test for an Impala writer? http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@86 PS3, Line 86: if len(result.data) == 0: : continue nit: __verify_result() could just return when result.data is empty http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@94 PS3, Line 94: nit: extra indentation http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@114 PS3, Line 114: CTRL+C can't interrupt the test You can use pool.map_async(...).get(long timeout) which will handle keyboard interrupts properly. See https://stackoverflow.com/a/1408476 http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@116 PS3, Line 116: for i in pool.imap(do_role, ["impala", "hive"]): : pass why not just simply pool.imap()? Or better, pool.map_async(...).get(...)? -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 30 Sep 2019 15:17:15 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14304 to look at the new patch set (#7). Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue Automated tests were failing while creating Kudu tables with openssl1.1.1 installed on the machine This issue was previously reported under KUDU-2871 and resolved by disabling TLS 1.3 in Kudu source. This change bumps the Kudu version in impala-config.sh to pull in the fix for KUDU-2871. Testing: Create kudu table via automated tests passes Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 --- M bin/impala-config.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/14304/7 -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 7 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14272 ) Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5026/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972 Gerrit-Change-Number: 14272 Gerrit-PatchSet: 7 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 14:19:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14272 ) Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. .. Patch Set 7: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5025/ -- To view, visit http://gerrit.cloudera.org:8080/14272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972 Gerrit-Change-Number: 14272 Gerrit-PatchSet: 7 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 09:36:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14272 ) Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4677/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972 Gerrit-Change-Number: 14272 Gerrit-PatchSet: 7 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Sep 2019 06:01:36 + Gerrit-HasComments: No
