[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 ) Change subject: Remove hard-coded localhost from impala_test_suite.py .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5041/ -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 02 Oct 2019 06:57:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 ) Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332 Gerrit-Change-Number: 14334 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 02 Oct 2019 03:27:05 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 ) Change subject: Remove hard-coded localhost from impala_test_suite.py .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 02 Oct 2019 02:40:56 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 ) Change subject: Remove hard-coded localhost from impala_test_suite.py .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5041/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 02 Oct 2019 02:40:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8899: Add cookie support to the webui
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14339 ) Change subject: IMPALA-8899: Add cookie support to the webui .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4699/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Gerrit-Change-Number: 14339 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 02 Oct 2019 02:25:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8899: Add cookie support to the webui
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14339 to look at the new patch set (#3). Change subject: IMPALA-8899: Add cookie support to the webui .. IMPALA-8899: Add cookie support to the webui This patches takes the machinery for generating and checking cookies for authentication that was added in IMPALA-8584 and applies to the webui. It also fixes an issue where some clients may return the cookie value surrounded by "". It adds metrics for both SPNEGO auth success/failure and cookie auth success/failure to the webserver. This patch also fixes IMPALA-8898 by returning an empty cookie with a Max-Age of 0 on requests where an invalid cookie was provided to indicate to the client that the cookie should be deleted. Testing: - Added a test that uses curl to access the webserver with SPNEGO enabled while storing and using cookies. This test only runs when curl is present, which is generally not the case in our automated testing runs. Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 --- M be/src/catalog/catalogd-main.cc M be/src/rpc/authentication.cc M be/src/rpc/cookie-util.cc M be/src/rpc/cookie-util.h M be/src/runtime/exec-env.cc M be/src/statestore/statestored-main.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M be/src/util/webserver.h M common/thrift/metrics.json M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java 11 files changed, 276 insertions(+), 144 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/14339/3 -- To view, visit http://gerrit.cloudera.org:8080/14339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Gerrit-Change-Number: 14339 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14332 ) Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/impala-hs2-server.cc@860 PS1, Line 860: return_val.status.__set_statusCode(thrift::TStatusCode::SUCCESS_STATUS); > Yes, FetchInternal always sets the statusCode, unless it returns an error i Got it, thanks. -- To view, visit http://gerrit.cloudera.org:8080/14332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 Gerrit-Change-Number: 14332 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 02 Oct 2019 01:28:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8946: Fix histogram rendering to Prometheus
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14280 ) Change subject: IMPALA-8946: Fix histogram rendering to Prometheus .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 Gerrit-Change-Number: 14280 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 02 Oct 2019 01:11:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8946: Fix histogram rendering to Prometheus
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14280 ) Change subject: IMPALA-8946: Fix histogram rendering to Prometheus .. IMPALA-8946: Fix histogram rendering to Prometheus Prometheus has two formats that allows to calculate quantiles (on client side): Histograms and Summaries. The former requires to pick a set of buckets, while the latter only requires to specifiy which quantiles (percentiles) the application wants to provide. The difference between summaries and histograms on Prometheus can be found here: https://prometheus.io/docs/practices/histograms/ Previous to this changes, Impala histograms were rendered as Prometheus histograms, but it was calculating percentiles instead of bucketing the recorded values, which is not what Prometheus clients expects. From now on, Impala histograms will be rendered as Prometheus summaries instead, which expects quantiles. To be compliant with Prometheus summaries, a `_sum` serie needs to be added, containing the sum of all the registered values. The current `HdrHistogram` implementation on be::utils does not have the `TotalSum` method (and the required properties to track it). I copied the implementation from be::kudu::utils and added a couple of unit tests which covers the sum method. Also adapted the Prometheus tests to verify that sum serie is properly rendered. Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 Reviewed-on: http://gerrit.cloudera.org:8080/14280 Tested-by: Impala Public Jenkins Reviewed-by: Tim Armstrong --- M be/src/util/CMakeLists.txt A be/src/util/hdr-histogram-test.cc M be/src/util/hdr-histogram.cc M be/src/util/hdr-histogram.h M be/src/util/histogram-metric.cc M be/src/util/metrics-test.cc 6 files changed, 127 insertions(+), 75 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 Gerrit-Change-Number: 14280 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[native-toolchain-CR] IMPALA-8977: Update version of maven used for building docker containers
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14326 ) Change subject: IMPALA-8977: Update version of maven used for building docker containers .. IMPALA-8977: Update version of maven used for building docker containers postinstall.sh currently downloads and uses maven 3.6.0. However, maven 3.6.0 is no longer available at the URL hardcoded in postinstall.sh. This switches to using maven 3.6.2. This also modifies docker/buildall.py to allow building a single docker file. I verified that the following docker images build: - Redhat 7 - Debian 8 - Ubuntu 18.04 / 16.04 / 14.04 / 12.04 These do not: - Redhat 6 - tracked by IMPALA-8978 - Debian 7 - tracked by IMPALA-8992 I did not check SLES12. Change-Id: I53f261b4f9b20b966522bddd34d5aaf4882fb66e Reviewed-on: http://gerrit.cloudera.org:8080/14326 Reviewed-by: Tim Armstrong Tested-by: Joe McDonnell --- M docker/README.md M docker/all/postinstall.sh M docker/buildall.py 3 files changed, 18 insertions(+), 5 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Joe McDonnell: Verified -- To view, visit http://gerrit.cloudera.org:8080/14326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I53f261b4f9b20b966522bddd34d5aaf4882fb66e Gerrit-Change-Number: 14326 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 02 Oct 2019 00:53:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8899: Add cookie support to the webui
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14339 ) Change subject: IMPALA-8899: Add cookie support to the webui .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4698/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Gerrit-Change-Number: 14339 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 02 Oct 2019 00:28:58 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-8977: Update version of maven used for building docker containers
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14326 ) Change subject: IMPALA-8977: Update version of maven used for building docker containers .. Patch Set 1: Verified+1 Updated the docker images (except for Centos6, which used an older images) and ran a build. Everything went fine, so going ahead with this. -- To view, visit http://gerrit.cloudera.org:8080/14326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53f261b4f9b20b966522bddd34d5aaf4882fb66e Gerrit-Change-Number: 14326 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 02 Oct 2019 00:34:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 ) Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .. Patch Set 4: (2 comments) Thanks for taking this on. Some nits about a couple things, but I think this is looking good. http://gerrit.cloudera.org:8080/#/c/14311/4/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/14311/4/tests/common/impala_test_suite.py@179 PS4, Line 179: # There are multiple clients for interacting with the underlying storage service. : # : # There are two main types of clients: HTTP clients and CLI clients. CLI clients all : # use the 'hdfs dfs' CLI to execute operations againt a target filesystem. HTTP : # clients issue HTTP requests to execute operations and are filesystem specific. For : # HDFS, the HTTP client uses WebHDFS. : # : # 'hdfs_client' is a wrapper around a HTTP client and CLI client for interacting : # with HDFS. The 'hdfs_client' delegates to the HTTP client when possible, and for : # operations not supported by the HTTP client, it delegates to the CLI client. The : # 'hdfs_client' is specific to HDFS and always points to the local HDFS cluster. : # : # 'filesystem_client' is set depending on the value of the 'TARGET_FILESYSTEM'. For : # HDFS, it is the same as the 'hdfs_client'. For S3 and and ABFS, the client is a : # HadoopFsCommandLineClient which is a simple wrapper around 'hdfs dfs' commands. : # For ADLS, the 'filesystem_client' is an ADLSClient. These are mostly nits, but here goes: - I want to emphasize that 'filesystem_client' is the right thing to use and 'hdfs_client' is only for tests that run on HDFS-only. We don't want test writers to consider using hdfs_client unless they really need it. It is really only useful for HDFS ACL. - I think the HTTP vs CLI breakdown is better expressed as Hadoop CLI vs filesystem-specific library. - After thinking on this a bit, I think it might be good to have 'hdfs_client' be None when this is not HDFS. This is to discourage people from using it. - I think I would prefer ordering it to put the description of the filesystem_client up front, as I think that is the most useful part. Putting it together, here is a sketch of what I was thinking: 'filesystem_client' is a generic interface for doing filesystem operations that works across all the filesystems that Impala supports. 'filesystem_client' uses either the HDFS commandline or a filesystem-specific library to implement common HDFS operations. Etc Etc fill this in... Test writers should always use 'filesystem_client' unless they are using filesystem specific functionality (e.g. HDFS ACL). The implementation of 'filesystem_client' for each filesystem is: HDFS - uses a mixture of PyWebHdfs (which is faster than the HDFS CLI) and the HDFS CLI S3 - uses HDFS CLI ABFS - uses HDFS CLI ADLS - uses the ADLSClient (TODO: this should switch to HDFS CLI once we test it) 'hdfs_client' is an HDFS-specific client library, and it only works when running on HDFS. When using 'hdfs_client', the test must be skipped on everything other than HDFS. This is only really useful for tests that do HDFS ACL operations. This is None on non-HDFS systems. http://gerrit.cloudera.org:8080/#/c/14311/4/tests/util/hdfs_util.py File tests/util/hdfs_util.py: http://gerrit.cloudera.org:8080/#/c/14311/4/tests/util/hdfs_util.py@58 PS4, Line 58: DelegatingHdfsFilesystem Nit: The other clients all have "Client" in their name rather than Filesystem (even though they inherit from BaseFilesystem). For consistency, maybe call this DelegatingHdfsClient? -- To view, visit http://gerrit.cloudera.org:8080/14311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d45db1c00554e6fb6bcc0b552596d86d4e30144 Gerrit-Change-Number: 14311 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Wed, 02 Oct 2019 00:33:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4697/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Wed, 02 Oct 2019 00:24:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8899: Add cookie support to the webui
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14339 ) Change subject: IMPALA-8899: Add cookie support to the webui .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc@223 PS1, Line 223: response_headers.push_back( > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc@230 PS1, Line 230: > line too long (115 > 90) Done http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc@524 PS1, Line 524: > line too long (100 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/14339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Gerrit-Change-Number: 14339 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 23:48:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/501/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 23:52:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8899: Add cookie support to the webui
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14339 to look at the new patch set (#2). Change subject: IMPALA-8899: Add cookie support to the webui .. IMPALA-8899: Add cookie support to the webui This patches takes the machinery for generating and checking cookies for authentication that was added in IMPALA-8584 and applies to the webui. It also fixes an issue where some clients may return the cookie value surrounded by "". It adds metrics for both SPNEGO auth success/failure and cookie auth success/failure to the webserver. This patch also fixes IMPALA-8898 by returning an empty cookie with a Max-Age of 0 on requests where an invalid cookie was provided to indicate to the client that the cookie should be deleted. Testing: - Added a test that uses curl to access the webserver with SPNEGO enabled while storing and using cookies. This test only runs when curl is present, which is generally not the case in our automated testing runs. Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 --- M be/src/catalog/catalogd-main.cc M be/src/rpc/authentication.cc M be/src/rpc/cookie-util.cc M be/src/rpc/cookie-util.h M be/src/runtime/exec-env.cc M be/src/statestore/statestored-main.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M be/src/util/webserver.h M common/thrift/metrics.json M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java 11 files changed, 268 insertions(+), 138 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/14339/2 -- To view, visit http://gerrit.cloudera.org:8080/14339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Gerrit-Change-Number: 14339 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py@1337 PS1, Line 1337: sleep(30) # Wait for the 'lineitem' scan to complete > Will number of a in-flight fragments a more reliable metric to wait on ? The goal of the test is to actually validate that NumCompletedBackends is incremented. However, I removed the sleep and replaced it with an assert_eventually which I think is more reliable. -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 23:44:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14337 to look at the new patch set (#2). Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests Disable the tests TestResultSpooling::test_full_queue(_large_fetch) until we figure out why they are flaky. Replace the sleep in TestAdmissionController::test_release_backend with assert_eventually to reduce flakiness. Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b --- M tests/custom_cluster/test_admission_controller.py M tests/query_test/test_result_spooling.py 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/14337/2 -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14340 ) Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/501/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 23:34:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8988: [DOCS] DATE type is supported AVRO tables
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14340 Change subject: IMPALA-8988: [DOCS] DATE type is supported AVRO tables .. IMPALA-8988: [DOCS] DATE type is supported AVRO tables Change-Id: I95f37accddadcba436676498d5cbb34cda281846 --- M docs/topics/impala_avro.xml M docs/topics/impala_date.xml 2 files changed, 97 insertions(+), 55 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14340/1 -- To view, visit http://gerrit.cloudera.org:8080/14340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I95f37accddadcba436676498d5cbb34cda281846 Gerrit-Change-Number: 14340 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 4: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/500/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 23:07:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 ) Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5038/ -- To view, visit http://gerrit.cloudera.org:8080/14334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332 Gerrit-Change-Number: 14334 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 22:51:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 ) Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5040/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332 Gerrit-Change-Number: 14334 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 23:12:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py@1337 PS1, Line 1337: sleep(30) # Wait for the 'lineitem' scan to complete Will number of a in-flight fragments a more reliable metric to wait on ? -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Tue, 01 Oct 2019 23:00:22 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. IMPALA-8982: Fix webserver handling of OPTIONS Previously, Impala's webserver always returned 500 errors to OPTIONS requests. Fixing this requires two changes: - Squeasel is updated to 36dc66b8723980feb32196a94b46734eb5eafbf9, which pulls in a patch that allows it to handle OPTIONS requests correctly. - Webserver is modified to recognize OPTIONS requests and allow Squeasel to handle them. Testing: - Added a BE test that checks that OPTIONS works without SPNEGO. - Added a test that checks that OPTIONS works when SPNEGO is turned on. The test is currently disabled until we add curl to the toolchain. Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Reviewed-on: http://gerrit.cloudera.org:8080/14323 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/thirdparty/squeasel/squeasel.c M be/src/util/webserver-test.cc M be/src/util/webserver.cc 3 files changed, 32 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 23:08:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8899: Add cookie support to the webui
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14339 ) Change subject: IMPALA-8899: Add cookie support to the webui .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4696/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Gerrit-Change-Number: 14339 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 23:04:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8946: Fix histogram rendering to Prometheus
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14280 ) Change subject: IMPALA-8946: Fix histogram rendering to Prometheus .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 Gerrit-Change-Number: 14280 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 23:03:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 4: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/500/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 22:44:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14314 to look at the new patch set (#4). Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/ImpalaVariables.xml M docs/topics/impala_client.xml A docs/topics/impala_fetch_rows_timeout_ms.xml A docs/topics/impala_max_result_spooling_mem.xml A docs/topics/impala_max_spilled_result_spooling_mem.xml A docs/topics/impala_query_results_spooling.xml A docs/topics/impala_spool_query_results.xml 9 files changed, 405 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14314/4 -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml File docs/topics/impala_fetch_rows_timeout_ms.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@46 PS1, Line 46: > I think it should be documented, it is potentially impactful for any users Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@51 PS1, Line 51: 10 > The query option has "MS" in the name, implying the unit. I added "10 Secon Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml File docs/topics/impala_fetch_rows_timeout_ms.xml: http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@40 PS3, Line 40: TRUE > should be false Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@43 PS3, Line 43: FALSE > should be true Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@47 PS3, Line 47: Only positive values are allowed > sorry, just fixed a bug with this and now a value of 0 for FETCH_ROWS_TIMEO Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml File docs/topics/impala_query_results_spooling.xml: http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@43 PS3, Line 43: POOL_QUERY_RESULTS > SPOOL_QUERY_RESULTS Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@78 PS3, Line 78: TRUE > FALSE Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@81 PS3, Line 81: FALSE > TRUE Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml File docs/topics/impala_spool_query_results.xml: http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml@36 PS3, Line 36: Use the SPOOL_QUERY_RESULTS query option to enable query : result spooling, which is disabled by default. : Query result spooling controls how rows are returned to the client. : When query result spooling is disabled, Impala relies on clients to : fetch results to trigger the generation of more result row batches : until all the result rows have been produced. If a client issues a : query without fetching all the results, the query fragments will : continue to consume the resources until the query is cancelled and : unregistered, potentially tying up resources and cause other queries : to wait for extended period of time in admission control. : When query result spooling is enabled, result sets of queries are : eagerly fetched and spooled in the spooling location on a persistent : storage, either in memory or on disk. Once all result rows have : been fetched and stored in the spooling location, the resources are : freed up. Incoming client fetches can get the data from this spooled : locations. : > I think some of the review comments from impala_query_results_spooling.xml attempted -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 22:42:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4695/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Tue, 01 Oct 2019 22:25:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8899: Add cookie support to the webui
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/14339 )
Change subject: IMPALA-8899: Add cookie support to the webui
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc
File be/src/util/webserver.cc:
http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc@223
PS1, Line 223: response_headers.push_back(Substitute("WWW-Authenticate:
Negotiate $0", resp_token_b64));
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc@230
PS1, Line 230: Webserver::Webserver(MetricGroup* metrics) :
Webserver(FLAGS_webserver_interface, FLAGS_webserver_port, metrics) {}
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc@524
PS1, Line 524: sq_callback_result_t spnego_result =
HandleSpnego(connection, request_info, response_headers);
line too long (100 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/14339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4
Gerrit-Change-Number: 14339
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 01 Oct 2019 22:21:48 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8899: Add cookie support to the webui
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14339 Change subject: IMPALA-8899: Add cookie support to the webui .. IMPALA-8899: Add cookie support to the webui This patches takes the machinery for generating and checking cookies for authentication that was added in IMPALA-8584 and applies to the webui. It also fixes an issue where some clients may return the cookie value surrounded by "". It adds metrics for both SPNEGO auth success/failure and cookie auth success/failure to the webserver. This patch also fixes IMPALA-8898 by returning an empty cookie with a Max-Age of 0 on requests where an invalid cookie was provided to indicate to the client that the cookie should be deleted. Testing: - Added a test that uses curl to access the webserver with SPNEGO enabled while storing and using cookies. This test only runs when curl is present, which is generally not the case in our automated testing runs. Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 --- M be/src/catalog/catalogd-main.cc M be/src/rpc/authentication.cc M be/src/rpc/cookie-util.cc M be/src/rpc/cookie-util.h M be/src/runtime/exec-env.cc M be/src/statestore/statestored-main.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M be/src/util/webserver.h M common/thrift/metrics.json M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java 11 files changed, 262 insertions(+), 131 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/14339/1 -- To view, visit http://gerrit.cloudera.org:8080/14339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4 Gerrit-Change-Number: 14339 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14332 ) Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4693/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 Gerrit-Change-Number: 14332 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 22:15:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1071: Distributable python package for impala-shell
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14181 ) Change subject: IMPALA-1071: Distributable python package for impala-shell .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4694/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8c745bf6a16f0c039430152745a2f00e044 Gerrit-Change-Number: 14181 Gerrit-PatchSet: 6 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: David Rorke Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 22:15:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8971: [DOCS] Documented the new query option for Parquet split size
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14338 ) Change subject: IMPALA-8971: [DOCS] Documented the new query option for Parquet split size .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/499/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6343eec91df7ae01c342b5800d08248c1c4a739a Gerrit-Change-Number: 14338 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 22:09:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14332 ) Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4692/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 Gerrit-Change-Number: 14332 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 22:00:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml File docs/topics/impala_fetch_rows_timeout_ms.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@46 PS1, Line 46: > Do users need this (implementation) detail? I think it should be documented, it is potentially impactful for any users who have written their own client code to interact with Impala. http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml File docs/topics/impala_fetch_rows_timeout_ms.xml: http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@40 PS3, Line 40: TRUE should be false http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@43 PS3, Line 43: FALSE should be true http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@47 PS3, Line 47: Only positive values are allowed sorry, just fixed a bug with this and now a value of 0 for FETCH_ROWS_TIMEOUT_MS means that fetch requests wait indefinitely (essentially what the old behavior would do). http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml File docs/topics/impala_query_results_spooling.xml: http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@43 PS3, Line 43: POOL_QUERY_RESULTS SPOOL_QUERY_RESULTS http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@78 PS3, Line 78: TRUE FALSE http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@81 PS3, Line 81: FALSE TRUE http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml File docs/topics/impala_spool_query_results.xml: http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml@36 PS3, Line 36: Use the SPOOL_QUERY_RESULTS query option to enable query : result spooling, which is disabled by default. : Query result spooling controls how rows are returned to the client. : When query result spooling is disabled, Impala relies on clients to : fetch results to trigger the generation of more result row batches : until all the result rows have been produced. If a client issues a : query without fetching all the results, the query fragments will : continue to consume the resources until the query is cancelled and : unregistered, potentially tying up resources and cause other queries : to wait for extended period of time in admission control. : When query result spooling is enabled, result sets of queries are : eagerly fetched and spooled in the spooling location on a persistent : storage, either in memory or on disk. Once all result rows have : been fetched and stored in the spooling location, the resources are : freed up. Incoming client fetches can get the data from this spooled : locations. : I think some of the review comments from impala_query_results_spooling.xml need to be re-applied here. -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 22:04:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8971: [DOCS] Documented the new query option for Parquet split size
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14338 ) Change subject: IMPALA-8971: [DOCS] Documented the new query option for Parquet split size .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/499/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6343eec91df7ae01c342b5800d08248c1c4a739a Gerrit-Change-Number: 14338 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 21:58:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8971: [DOCS] Documented the new query option for Parquet split size
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14338 Change subject: IMPALA-8971: [DOCS] Documented the new query option for Parquet split size .. IMPALA-8971: [DOCS] Documented the new query option for Parquet split size Change-Id: I6343eec91df7ae01c342b5800d08248c1c4a739a --- M docs/impala.ditamap M docs/topics/impala_parquet.xml A docs/topics/impala_parquet_object_store_split_size.xml M docs/topics/impala_s3.xml 4 files changed, 68 insertions(+), 45 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/14338/1 -- To view, visit http://gerrit.cloudera.org:8080/14338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6343eec91df7ae01c342b5800d08248c1c4a739a Gerrit-Change-Number: 14338 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14337 Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests Disable the tests TestResultSpooling::test_full_queue(_large_fetch) until we figure out why they are flaky. Bump the sleep in TestAdmissionController::test_release_backend to reduce flakiness. Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b --- M tests/custom_cluster/test_admission_controller.py M tests/query_test/test_result_spooling.py 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/14337/1 -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar
[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available
Hello Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14332 to look at the new patch set (#3). Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available IMPALA-7312 added the query option FETCH_ROWS_TIMEOUT_MS, but it only applies to fetch requests against a query that has already transitioned to the 'FINISHED' state. This patch changes the timeout so that it applies to queries in the 'RUNNING' state as well. Before this patch, fetch requests issued while a query was 'RUNNING' blocked until the query transitioned to the 'FINISHED' state, and then it fetched results and returned them. After this patch, fetch requests against queries in the 'RUNNING' state will block for 'FETCH_ROWS_TIMEOUT_MS' and then return. For HS2 clients, fetch requests that return while a query is 'RUNNING' set their TStatusCode to STILL_EXECUTING_STATUS. For Beeswax clients, fetch requests that return while a query is 'RUNNING' set the 'ready' flag to false. For both clients, hasMoreRows is set to true. If the following sequence of events occurs: * A fetch request is issued and blocks on a 'RUNNING' query * The query transitions to the 'FINISHED' state * The fetch request attempts to read multiple batches Then the time spent waiting for the query to finish is deducted from the timeout used when waiting for rows to be produced by the Coordinator fragment. Fixed a bug in the current usage of FETCH_ROWS_TIMEOUT_MS where the time units for FETCH_ROWS_TIMEOUT_MS and MonotonicStopWatch were not being converted properly. Tests: * Moved existing fetch timeout tests from hs2/test_fetch.py into a new test file hs2/test_fetch_timeout.py. * Added several new tests to hs2/test_fetch_timeout.py to validate that the timeout is applied to 'RUNNING' queries and that the timeout applies across a 'RUNNING' and 'FINISHED' query. * Added new tests to query_test/test_fetch.py to validate the timeout while using the Beeswax protocol. Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 --- M be/src/common/status.cc M be/src/exec/blocking-plan-root-sink.cc M be/src/exec/blocking-plan-root-sink.h M be/src/exec/buffered-plan-root-sink.cc M be/src/exec/buffered-plan-root-sink.h M be/src/exec/plan-root-sink.cc M be/src/exec/plan-root-sink.h M be/src/runtime/coordinator.cc M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-beeswax-server.cc M be/src/service/impala-hs2-server.cc M be/src/util/error-util.cc M common/thrift/ImpalaService.thrift M tests/hs2/hs2_test_suite.py M tests/hs2/test_fetch.py A tests/hs2/test_fetch_timeout.py M tests/query_test/test_fetch.py 18 files changed, 521 insertions(+), 174 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/14332/3 -- To view, visit http://gerrit.cloudera.org:8080/14332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 Gerrit-Change-Number: 14332 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available
Sahil Takiar has posted comments on this change. (
http://gerrit.cloudera.org:8080/14332 )
Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are
available
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/common/status.cc
File be/src/common/status.cc:
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/common/status.cc@160
PS1, Line 160: apache::hive::service::cli::thrift::TStatusCode
> Maybe add a 'using TStatusCode' to this file so the formatting here isn't s
Done
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.h
File be/src/service/client-request-state.h:
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.h@108
PS1, Line 108: (
> typo?
Done
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.h@114
PS1, Line 114: wait for
> typo?
Done
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.cc@786
PS1, Line 786: void ClientRequestState::BlockOnWait() {
> Could we reduce some duplication by just calling BlockOnWait(0) here?
Done
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.cc@809
PS1, Line 809: block_on_wait_cv_.Wait(l);
> So if I understand correctly, here if 'timeout' is 0 we wait indefinitely b
Thanks for catching that. Have clarified the behavior in the docs. A value of 0
should cause the fetch request to wait indefinitely. Added a test as well.
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/impala-hs2-server.cc@860
PS1, Line 860:
return_val.status.__set_statusCode(thrift::TStatusCode::SUCCESS_STATUS);
> did you mean to make this change?
Yes, FetchInternal always sets the statusCode, unless it returns an error
impala::Status, in which case the if loop above is triggered. If it reaches the
end of the if without returning, than the statusCode is set to SUCCESS_STATUS.
The change is necessary otherwise SUCCESS_STATUS is always returned, even if
the statusCode was already set to STILL_EXECUTING_STATUS
--
To view, visit http://gerrit.cloudera.org:8080/14332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4
Gerrit-Change-Number: 14332
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sahil Takiar
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 01 Oct 2019 21:36:29 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-1071: Distributable python package for impala-shell
David Knupp has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14181 ) Change subject: IMPALA-1071: Distributable python package for impala-shell .. IMPALA-1071: Distributable python package for impala-shell The patch adds a set of scripts for converting the impala-shell into a true distributable python package. The package can be installed using familiar python commands, e.g.: $ python setup.py (install|develop) or $ pip install -e /path/to/dist/dir The entry point script, make_python_package.sh, will run as a part of the standard sequence of steps that results from calling buildall.sh, and will produce a gzipped tarball inside of Impala/shell/dist as an artifact. Thereafter, make_python_package.sh can be run manually any time. The expectation is that an official maintainer would need to manually upload official releases to the Python Package Index as appropriate. Change-Id: Ib8c745bf6a16f0c039430152745a2f00e044 --- M CMakeLists.txt M bin/rat_exclude_files.txt M shell/impala_client.py A shell/packaging/MANIFEST.in A shell/packaging/README.md A shell/packaging/__init__.py A shell/packaging/make_python_package.sh A shell/packaging/requirements.txt A shell/packaging/setup.py 9 files changed, 422 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/14181/6 -- To view, visit http://gerrit.cloudera.org:8080/14181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib8c745bf6a16f0c039430152745a2f00e044 Gerrit-Change-Number: 14181 Gerrit-PatchSet: 6 Gerrit-Owner: David Knupp Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: David Rorke Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available
Hello Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14332 to look at the new patch set (#2). Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available IMPALA-7312 added the query option FETCH_ROWS_TIMEOUT_MS, but it only applies to fetch requests against a query that has already transitioned to the 'FINISHED' state. This patch changes the timeout so that it applies to queries in the 'RUNNING' state as well. Before this patch, fetch requests issued while a query was 'RUNNING' blocked until the query transitioned to the 'FINISHED' state, and then it fetched results and returned them. After this patch, fetch requests against queries in the 'RUNNING' state will block for 'FETCH_ROWS_TIMEOUT_MS' and then return. For HS2 clients, fetch requests that return while a query is 'RUNNING' set their TStatusCode to STILL_EXECUTING_STATUS. For Beeswax clients, fetch requests that return while a query is 'RUNNING' set the 'ready' flag to false. For both clients, hasMoreRows is set to true. If the following sequence of events occurs: * A fetch request is issued and blocks on a 'RUNNING' query * The query transitions to the 'FINISHED' state * The fetch request attempts to read multiple batches Then the time spent waiting for the query to finish is deducted from the timeout used when waiting for rows to be produced by the Coordinator fragment. Fixed a bug in the current usage of FETCH_ROWS_TIMEOUT_MS where the time units for FETCH_ROWS_TIMEOUT_MS and MonotonicStopWatch were not being converted properly. Tests: * Moved existing fetch timeout tests from hs2/test_fetch.py into a new test file hs2/test_fetch_timeout.py. * Added several new tests to hs2/test_fetch_timeout.py to validate that the timeout is applied to 'RUNNING' queries and that the timeout applies across a 'RUNNING' and 'FINISHED' query. * Added new tests to query_test/test_fetch.py to validate the timeout while using the Beeswax protocol. Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 --- M be/src/common/status.cc M be/src/exec/blocking-plan-root-sink.cc M be/src/exec/blocking-plan-root-sink.h M be/src/exec/buffered-plan-root-sink.cc M be/src/exec/buffered-plan-root-sink.h M be/src/exec/plan-root-sink.cc M be/src/exec/plan-root-sink.h M be/src/runtime/coordinator.cc M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-beeswax-server.cc M be/src/service/impala-hs2-server.cc M be/src/util/error-util.cc M common/thrift/ImpalaService.thrift M tests/hs2/hs2_test_suite.py M tests/hs2/test_fetch.py A tests/hs2/test_fetch_timeout.py M tests/query_test/test_fetch.py 18 files changed, 495 insertions(+), 174 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/14332/2 -- To view, visit http://gerrit.cloudera.org:8080/14332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 Gerrit-Change-Number: 14332 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4691/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 21:25:39 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/14197/8/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: http://gerrit.cloudera.org:8080/#/c/14197/8/be/src/exec/kudu-util.cc@239 PS8, Line 239: case DataType::VARCHAR: return ColumnType::CreateVarcharType(type_attributes.length()); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 20:44:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5039/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 20:44:35 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14197 to look at the new patch set (#8). Change subject: [WIP] Add POC Kudu VARCHAR .. [WIP] Add POC Kudu VARCHAR Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 --- M be/src/exec/kudu-util.cc M bin/impala-config.sh M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/KuduUtil.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test M testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test M testdata/workloads/functional-query/queries/QueryTest/kudu_update.test M testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test M tests/query_test/test_kudu.py 13 files changed, 716 insertions(+), 641 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/14197/8 -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8946: Fix histogram rendering to Prometheus
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14280 ) Change subject: IMPALA-8946: Fix histogram rendering to Prometheus .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5037/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 Gerrit-Change-Number: 14280 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 19:04:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/498/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 19:08:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 19:04:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 ) Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5038/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332 Gerrit-Change-Number: 14334 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 19:04:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5036/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 19:04:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8946: Fix histogram rendering to Prometheus
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14280 ) Change subject: IMPALA-8946: Fix histogram rendering to Prometheus .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4690/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 Gerrit-Change-Number: 14280 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 18:52:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 ) Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5035/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332 Gerrit-Change-Number: 14334 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 18:41:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 ) Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4689/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332 Gerrit-Change-Number: 14334 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 18:24:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/497/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 18:19:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml File docs/topics/impala_fetch_rows_timeout_ms.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@21 PS1, Line 21: IMPALA-3200 > is this the right JIRA? No, removed. http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@46 PS1, Line 46: > should mention IMPALA-8962 as well. the timeout also applies to fetch reque Do users need this (implementation) detail? http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@51 PS1, Line 51: 10 > default is 10 seconds, so 1 ms, should the units be somewhere? The query option has "MS" in the name, implying the unit. I added "10 Seconds" to be extra clear. http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_result_spooling_mem.xml File docs/topics/impala_max_result_spooling_mem.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_result_spooling_mem.xml@39 PS1, Line 39: unpinned > I don't think our docs really explain the difference between unpinned vs pi Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_spilled_result_spooling_mem.xml File docs/topics/impala_max_spilled_result_spooling_mem.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_spilled_result_spooling_mem.xml@47 PS1, Line 47: to allow unpinning all pinned : memory when the amount of spooled results exceeds : MAX_RESULT_SPOOLING_MEM > can just remove this part Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml File docs/topics/impala_query_results_spooling.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@32 PS1, Line 32: cause > causing Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@32 PS1, Line 32: wait for : extended > wait for an extended Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@40 PS1, Line 40: this spooled locations > the spooled results. Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@54 PS1, Line 54: unpinned > remove unpin reference here and below Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@95 PS1, Line 95: of the number of rows returned by the query > of the amount of memory needed to spool all the rows returned by the query Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@98 PS1, Line 98: and > remove "and". the read and write buffers are 2 MB in size each, which is wh Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@117 PS1, Line 117: asynchronously > remove, it isn't really asynchronously Done -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 18:08:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/498/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 18:13:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14314 to look at the new patch set (#3). Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/ImpalaVariables.xml M docs/topics/impala_client.xml A docs/topics/impala_fetch_rows_timeout_ms.xml A docs/topics/impala_max_result_spooling_mem.xml A docs/topics/impala_max_spilled_result_spooling_mem.xml A docs/topics/impala_query_results_spooling.xml A docs/topics/impala_spool_query_results.xml 9 files changed, 398 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14314/3 -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-8946: Fix histogram rendering to Prometheus
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14280 ) Change subject: IMPALA-8946: Fix histogram rendering to Prometheus .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5034/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 Gerrit-Change-Number: 14280 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 18:11:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8946: Fix histogram rendering to Prometheus
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14280 to look at the new patch set (#2). Change subject: IMPALA-8946: Fix histogram rendering to Prometheus .. IMPALA-8946: Fix histogram rendering to Prometheus Prometheus has two formats that allows to calculate quantiles (on client side): Histograms and Summaries. The former requires to pick a set of buckets, while the latter only requires to specifiy which quantiles (percentiles) the application wants to provide. The difference between summaries and histograms on Prometheus can be found here: https://prometheus.io/docs/practices/histograms/ Previous to this changes, Impala histograms were rendered as Prometheus histograms, but it was calculating percentiles instead of bucketing the recorded values, which is not what Prometheus clients expects. >From now on, Impala histograms will be rendered as Prometheus summaries instead, which expects quantiles. To be compliant with Prometheus summaries, a `_sum` serie needs to be added, containing the sum of all the registered values. The current `HdrHistogram` implementation on be::utils does not have the `TotalSum` method (and the required properties to track it). I copied the implementation from be::kudu::utils and added a couple of unit tests which covers the sum method. Also adapted the Prometheus tests to verify that sum serie is properly rendered. Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 --- M be/src/util/CMakeLists.txt A be/src/util/hdr-histogram-test.cc M be/src/util/hdr-histogram.cc M be/src/util/hdr-histogram.h M be/src/util/histogram-metric.cc M be/src/util/metrics-test.cc 6 files changed, 127 insertions(+), 75 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/14280/2 -- To view, visit http://gerrit.cloudera.org:8080/14280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 Gerrit-Change-Number: 14280 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/497/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 01 Oct 2019 18:10:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14314 to look at the new patch set (#2). Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/ImpalaVariables.xml M docs/topics/impala_client.xml A docs/topics/impala_fetch_rows_timeout_ms.xml A docs/topics/impala_max_result_spooling_mem.xml A docs/topics/impala_max_spilled_result_spooling_mem.xml A docs/topics/impala_query_results_spooling.xml A docs/topics/impala_spool_query_results.xml 9 files changed, 398 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14314/2 -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available
Thomas Tauber-Marshall has posted comments on this change. (
http://gerrit.cloudera.org:8080/14332 )
Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are
available
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/common/status.cc
File be/src/common/status.cc:
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/common/status.cc@160
PS1, Line 160: apache::hive::service::cli::thrift::TStatusCode
Maybe add a 'using TStatusCode' to this file so the formatting here isn't so
awful?
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.h
File be/src/service/client-request-state.h:
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.h@108
PS1, Line 108: (
typo?
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.h@114
PS1, Line 114: wait for
typo?
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.cc@786
PS1, Line 786: void ClientRequestState::BlockOnWait() {
Could we reduce some duplication by just calling BlockOnWait(0) here?
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.cc@809
PS1, Line 809: block_on_wait_cv_.Wait(l);
So if I understand correctly, here if 'timeout' is 0 we wait indefinitely but
in the (Buffered|Blocking)PlanRootSink::GetNext if 'timeout' is 0 we don't wait
at all.
Is that intentional? It would be good to document the expected behavior for a
'0' timeout
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:
http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/impala-hs2-server.cc@860
PS1, Line 860:
return_val.status.__set_statusCode(thrift::TStatusCode::SUCCESS_STATUS);
did you mean to make this change?
--
To view, visit http://gerrit.cloudera.org:8080/14332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4
Gerrit-Change-Number: 14332
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 01 Oct 2019 17:50:38 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14334 Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 .. IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 hdfs:// URIs do not work on Impala's S3 tests. The fix is to drop the hdfs:// part of the URI. Our tests run against the default filesystem, so dropping the hdfs:// works on both HDFS test setups and S3 test setups. Testing: - Ran tests on S3 - Ran test_owner_privileges.py on HDFS locally Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332 --- M tests/authorization/test_owner_privileges.py M tests/common/sentry_cache_test_suite.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/14334/1 -- To view, visit http://gerrit.cloudera.org:8080/14334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibfe15ac2d5ba0d8a6d4383be8d01395c74d67332 Gerrit-Change-Number: 14334 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. IMPALA-8648: Add a simple stress test for reading ACID tables Add a test that runs several INSERT INTO/OVERWRITE to a single table in Hive and reads in from a parallel process using Impala. Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Reviewed-on: http://gerrit.cloudera.org:8080/13751 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- A tests/stress/test_acid_stress.py 1 file changed, 133 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 01 Oct 2019 17:15:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 3: refactor analytic planning
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14325 ) Change subject: IMPALA-2138: part 3: refactor analytic planning .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4688/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I691f1509a85cad51d2654278c0a4ba70a10b2706 Gerrit-Change-Number: 14325 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 01 Oct 2019 16:40:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14332 ) Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4687/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 Gerrit-Change-Number: 14332 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 16:18:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 3: refactor analytic planning
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14325 ) Change subject: IMPALA-2138: part 3: refactor analytic planning .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14325/2/fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java File fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java: http://gerrit.cloudera.org:8080/#/c/14325/2/fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java@179 PS2, Line 179: createNullMatchingEquals(analyzer, substitutedPartitionExprs_, sortTupleId, bufferedSmap); line too long (100 > 90) -- To view, visit http://gerrit.cloudera.org:8080/14325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I691f1509a85cad51d2654278c0a4ba70a10b2706 Gerrit-Change-Number: 14325 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 01 Oct 2019 16:00:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 ) Change subject: IMPALA-8982: Fix webserver handling of OPTIONS .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5033/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34 Gerrit-Change-Number: 14323 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 01 Oct 2019 16:08:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 3: refactor analytic planning
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14325 Change subject: IMPALA-2138: part 3: refactor analytic planning .. IMPALA-2138: part 3: refactor analytic planning This is a minor refactor of the analytic planner that moves the logic to generate a "buffered tuple descriptor" and equality expressions to the AnalyticEvalNode. This is required for projection, because the buffered tuple layout is required to match the input tuple layout, so needs to be updated if the input tuple is projected. After the refactoring, this can be correctly updated simply by regenerating the tuple descriptor and expressions, instead of attempting to "fix up" the existing expressions with smaps, etc. I think the plan node is actually a more approprate place for this logic regardless, since it's tightly entwined with the backend's assumption that the two tuple layouts are identical. Change-Id: I691f1509a85cad51d2654278c0a4ba70a10b2706 --- M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java 3 files changed, 123 insertions(+), 127 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/14325/2 -- To view, visit http://gerrit.cloudera.org:8080/14325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I691f1509a85cad51d2654278c0a4ba70a10b2706 Gerrit-Change-Number: 14325 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14332 Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available IMPALA-7312 added the query option FETCH_ROWS_TIMEOUT_MS, but it only applies to fetch requests against a query that has already transitioned to the 'FINISHED' state. This patch changes the timeout so that it applies to queries in the 'RUNNING' state as well. Before this patch, fetch requests issued while a query was 'RUNNING' blocked until the query transitioned to the 'FINISHED' state, and then it fetched results and returned them. After this patch, fetch requests against queries in the 'RUNNING' state will block for 'FETCH_ROWS_TIMEOUT_MS' and then return. For HS2 clients, fetch requests that return while a query is 'RUNNING' set their TStatusCode to STILL_EXECUTING_STATUS. For Beeswax clients, fetch requests that return while a query is 'RUNNING' set the 'ready' flag to false. For both clients, hasMoreRows is set to true. If the following sequence of events occurs: * A fetch request is issued and blocks on a 'RUNNING' query * The query transitions to the 'FINISHED' state * The fetch request attempts to read multiple batches Then the time spent waiting for the query to finish is deducted from the timeout used when waiting for rows to be produced by the Coordinator fragment. Fixed a bug in the current usage of FETCH_ROWS_TIMEOUT_MS where the time units for FETCH_ROWS_TIMEOUT_MS and MonotonicStopWatch were not being converted properly. Tests: * Moved existing fetch timeout tests from hs2/test_fetch.py into a new test file hs2/test_fetch_timeout.py. * Added several new tests to hs2/test_fetch_timeout.py to validate that the timeout is applied to 'RUNNING' queries and that the timeout applies across a 'RUNNING' and 'FINISHED' query. * Added new tests to query_test/test_fetch.py to validate the timeout while using the Beeswax protocol. Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 --- M be/src/common/status.cc M be/src/exec/blocking-plan-root-sink.cc M be/src/exec/blocking-plan-root-sink.h M be/src/exec/buffered-plan-root-sink.cc M be/src/exec/buffered-plan-root-sink.h M be/src/exec/plan-root-sink.cc M be/src/exec/plan-root-sink.h M be/src/runtime/coordinator.cc M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-beeswax-server.cc M be/src/service/impala-hs2-server.cc M be/src/util/error-util.cc M tests/hs2/hs2_test_suite.py M tests/hs2/test_fetch.py A tests/hs2/test_fetch_timeout.py M tests/query_test/test_fetch.py 17 files changed, 477 insertions(+), 152 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/14332/1 -- To view, visit http://gerrit.cloudera.org:8080/14332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 Gerrit-Change-Number: 14332 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar
[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4686/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 13:32:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4685/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 01 Oct 2019 13:29:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5032/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 01 Oct 2019 12:53:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py@578 PS2, Line 578: test_text_token > Thanks for spotting this. The code is not really prepared to handle backsla Update: I did some adjustments to include backslash in the format and input. You can now do so and even include some special chars like '\n' or '\t'. Note, that it's still not feasible to go super wild with the backslashes and include multiple ones after each other. I'm not sure if this is worth putting more efforts into because I don't see any real life scenarios where that would be needed. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 01 Oct 2019 12:58:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 5: Code-Review+2 Lgtm, do you want to add partitioned table tests as well? -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 01 Oct 2019 12:46:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 01 Oct 2019 12:53:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 01 Oct 2019 12:53:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14291 to look at the new patch set (#3). Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 This patch adds additional datetime format tokens on top of what was introduced with Milestone 1 (IMPALA-8703). The tokens introduced: - Free text token: Surrounded by double quotes, a free text section can be given in the format where the same text is expected in the input without the surrounding double quotes. - FX modifier: This modifier has to be given at the beginning of the format and is valid for the whole format. In a string to datetime conversion this forces strict separator matching and expects all the tokens in the input to have the same length as their maximum length. E.g. A month has to be of length 2 prefixed by zero if needed. This is the default in a datetime to string conversion. - FM modifier: This modifier affects only the following token and overrides the FX modifier. Using this the value of a token can be shorter than the max length if followed by a separator. E.g. 1-digit month, less than 4-digit year, etc. This is the default behaviour in a string to datetime conversion. Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 --- M be/src/runtime/date-parse-util.cc M be/src/runtime/datetime-iso-sql-format-parser.cc M be/src/runtime/datetime-iso-sql-format-parser.h M be/src/runtime/datetime-iso-sql-format-tokenizer.cc M be/src/runtime/datetime-iso-sql-format-tokenizer.h M be/src/runtime/datetime-parser-common.cc M be/src/runtime/datetime-parser-common.h M be/src/runtime/timestamp-parse-util.cc M tests/query_test/test_cast_with_format.py 9 files changed, 534 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14291/3 -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 6: Added a version of the test that writes a table with a single partition. -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 01 Oct 2019 12:49:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13751 to look at the new patch set (#6). Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. IMPALA-8648: Add a simple stress test for reading ACID tables Add a test that runs several INSERT INTO/OVERWRITE to a single table in Hive and reads in from a parallel process using Impala. Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 --- A tests/stress/test_acid_stress.py 1 file changed, 133 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13751/6 -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4684/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 01 Oct 2019 12:34:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py File tests/stress/test_acid_stress.py: http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49 PS3, Line 49: ' > nit: extra ' Done http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@114 PS3, Line 114: CTRL+C can't interrupt the test > You can use pool.map_async(...).get(long timeout) which will handle keyboar Thanks, it works well! http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@116 PS3, Line 116: for i in pool.imap(do_role, ["impala", "hive"]): : pass > why not just simply pool.imap()? Or better, pool.map_async(...).get(...)? Done -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 01 Oct 2019 11:58:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
..
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49
PS3, Line 49: V
> nit: no space needed
Done
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@67
PS3, Line 67: writ
> write?
Done
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@68
PS3, Line 68: rom Hive."
> Should we add another role and test for an Impala writer?
We should, but I consider that a different test. For Impala writers to most
interesting is the case when there are multiple impalad's doing inserts in
parallel.
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@86
PS3, Line 86: result = self.client.execute("select * from %s" % tbl_name)
: if len(res
> nit: __verify_result() could just return when result.data is empty
I made this a bit stricter - we shouldn't see 0 rows after the first insert, as
insert overwrite statement always reset to 1 row.
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@94
PS3, Line 94: ytes
> nit: extra indentation
Done
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Tue, 01 Oct 2019 11:57:55 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13751 to look at the new patch set (#5). Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. IMPALA-8648: Add a simple stress test for reading ACID tables Add a test that runs several INSERT INTO/OVERWRITE to a single table in Hive and reads in from a parallel process using Impala. Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 --- A tests/stress/test_acid_stress.py 1 file changed, 119 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13751/5 -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
