[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4928/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:57:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9110: Add table loading time break-down metrics for HdfsTable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14611 ) Change subject: IMPALA-9110: Add table loading time break-down metrics for HdfsTable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14611/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/14611/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1238 PS1, Line 1238: if (nullColumnValue_ == null) nullColumnValue_ = FeFsTable.DEFAULT_NULL_COLUMN_VALUE; line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/14611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5381f9316df588b2004876c6cd9fb7e674085b10 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 1 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 01 Nov 2019 06:47:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9110: Add table loading time break-down metrics for HdfsTable
Jiawei Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14611 Change subject: IMPALA-9110: Add table loading time break-down metrics for HdfsTable .. IMPALA-9110: Add table loading time break-down metrics for HdfsTable Catalog table loading currently only records the total loading time. We will need some break-down times, i.e. more detailed time recording on each loading function. We added "table-schema-load-duration", "all-column-stats-load -duration", "all-column-stats-load-duration". And we found that "storage-metadata-load-duration" has already represent partition and file metadata loading. So now we have a more detailed breakdown time for table loading info. Test: Will add test after the first round review. Change-Id: I5381f9316df588b2004876c6cd9fb7e674085b10 --- M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/Table.java 2 files changed, 60 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/14611/1 -- To view, visit http://gerrit.cloudera.org:8080/14611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5381f9316df588b2004876c6cd9fb7e674085b10 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 1 Gerrit-Owner: Jiawei Wang
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 2: We usually cherry-pick the Kudu patch so it's easier to track the original change (including the gerrit link to the original Kudu change). I am okay with exception if this is super urgent. -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:28:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4927/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:35:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. This adds a workaround for an upstream SASL bug which is triggered when the FQDN has more than 64 characters. In this case, SASL would truncate the FQDN and not be able to find the relevant keytab. After this change, we do not rely on SASL getting the FQDN but use our own implementation to get FQDN. Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 --- M be/src/kudu/rpc/server_negotiation.cc 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/14610/2 -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 2: (1 comment) Kudu made the same change here: https://gerrit.cloudera.org/#/c/14609/. Since it was a small change, I cross-ported it. Shall I wait for the kudu change to get merged? http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc File be/src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc@391 PS1, Line 391: (server_fqdn > nit: server_fqdn == nullptr Done -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:13:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 1: (1 comment) LGTM. Is the plan to do it on Impala side first and then backport it to Kudu ? We usually do changes the other way (i.e. from Kudu side first and then cherry-picked to Impala side). http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc File be/src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc@391 PS1, Line 391: (!server_fqdn nit: server_fqdn == nullptr -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:07:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14610 Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. This adds a workaround for an upstream SASL bug which is triggered when the FQDN has more than 64 characters. In this case, SASL would truncate the FQDN and not be able to find the relevant keytab. After this change, we do not rely on SASL getting the FQDN but use our own implementation to get FQDN. Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 --- M be/src/kudu/rpc/server_negotiation.cc 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/14610/1 -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada
[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4926/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 3 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Fri, 01 Nov 2019 05:42:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14589 ) Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue .. IMPALA-9105: Catalog debug page top-n table has a URL generation issue What's the problem: Previously, catalogd debug page does not have 'fqtn' property. Because CatalogServer::GetCatalogUsage() does not pass fqtn to the template. Thus, the generated page table detail page cannot be opened. Also, Someone might accedentially deleted which makes the catalogd UI top-K page unorganized. Fix: Correct the URL generation part. Test: Open the page and all the tables object can be correctly opened. Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 Reviewed-on: http://gerrit.cloudera.org:8080/14589 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M www/catalog.tmpl 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 Gerrit-Change-Number: 14589 Gerrit-PatchSet: 5 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 ) Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 Gerrit-Change-Number: 14589 Gerrit-PatchSet: 4 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 01 Nov 2019 05:03:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI
Jiawei Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. IMPALA-9109: Add top-k metadata loading ranking on catalogd UI Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the longest metadata loading time. Add the sorted table in Catalog server web-ui. The loading time is cacualted by the median from load_duration metrics. Testing: - Add end-to-end test for webpage to verify the label and text exisit in catalog debug page. - Launch Impala and activate some tables to see the table loading time showed successfully on the catalog debug UI page. Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf --- M be/src/catalog/catalog-server.cc M be/src/catalog/catalog-server.h M common/thrift/JniCatalog.thrift M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/Table.java M tests/webserver/test_web_pages.py M www/catalog.tmpl 9 files changed, 145 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/14600/3 -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 3 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yongzhi Chen
[Impala-ASF-CR] IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14540 ) Change subject: IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4925/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640d577200e76121c72685e4aaba1ef312a2d8b4 Gerrit-Change-Number: 14540 Gerrit-PatchSet: 2 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Alice Fan Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 01 Nov 2019 03:03:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule
Alice Fan has posted comments on this change. ( http://gerrit.cloudera.org:8080/14540 ) Change subject: IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14540/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java: http://gerrit.cloudera.org:8080/#/c/14540/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java@253 PS1, Line 253: return expr.getChild(i + 1); > I don't think this is necessarily the right fix since the rewrite should no As we discussed offline. It should be safe to remove cast here. As the SimplifyConditionalsRule only applies to analyzed expression , so the expr has ready been casted before it reaches rewrite step. Also, for some reason, the cast function will make a part of conjunction become not analyzed result in llegalStateException. http://gerrit.cloudera.org:8080/#/c/14540/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: http://gerrit.cloudera.org:8080/#/c/14540/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@502 PS1, Line 502: + "END", rule, "id > 30"); > Can you add some expression rewriter test where the two branches have diffe I added some test cases in ExprRewriterTest. But I think we knew that the change won't fix the issue of casting to compatible type for rewrite. That will require a separate jira to address the re-analyze issue. Really appreciated your examples and explanation! -- To view, visit http://gerrit.cloudera.org:8080/14540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640d577200e76121c72685e4aaba1ef312a2d8b4 Gerrit-Change-Number: 14540 Gerrit-PatchSet: 1 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Alice Fan Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 01 Nov 2019 02:32:52 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule
Hello Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14540 to look at the new patch set (#2). Change subject: IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule .. IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule For 'case' function, if left WHEN condition is true, SimplifyConditionalsRule will cast the THEN result-expression to original expression's type before return result. In this Jira, we would like to remove the cast function for two reasons: 1. SimplifyConditionalsRule only applys to analyzed expression, which means expression has already been casted to compatible type before it reaches the expression rewrite step. 2. The cast function will cause IllegalStateException when 'CASE WHEN TRUE' appearing in the where conjunction. For example: Query: select * from functional.alltypessmall where case when true then id < 50 END ERROR: IllegalStateException: null Testing: - Added e2e test to exprs.test - Added unit test to ExprRewriteRulesTest - Added unit test to ExprRewriterTest Change-Id: I640d577200e76121c72685e4aaba1ef312a2d8b4 --- M fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java M testdata/workloads/functional-query/queries/QueryTest/exprs.test 4 files changed, 54 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14540/2 -- To view, visit http://gerrit.cloudera.org:8080/14540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I640d577200e76121c72685e4aaba1ef312a2d8b4 Gerrit-Change-Number: 14540 Gerrit-PatchSet: 2 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Add query id debugging for HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14607 ) Change subject: Add query id debugging for HS2 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4924/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b Gerrit-Change-Number: 14607 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 01 Nov 2019 01:13:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 ) Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 Gerrit-Change-Number: 14589 Gerrit-PatchSet: 4 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 01 Nov 2019 00:42:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 ) Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5161/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 Gerrit-Change-Number: 14589 Gerrit-PatchSet: 4 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 01 Nov 2019 00:42:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 ) Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 Gerrit-Change-Number: 14589 Gerrit-PatchSet: 3 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 01 Nov 2019 00:41:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9073: fix test executor concurrency flakiness
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14606 ) Change subject: IMPALA-9073: fix test_executor_concurrency flakiness .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4923/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd Gerrit-Change-Number: 14606 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Fri, 01 Nov 2019 00:26:19 + Gerrit-HasComments: No
[Impala-ASF-CR] Add query id debugging for HS2
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14607 Change subject: Add query id debugging for HS2 .. Add query id debugging for HS2 As part of debugging IMPALA-9098, I realised we don't print the query ID for HS2 queries, which makes it harder finding queries in the logs. This pulls the query ID out of the Impyla handle and prints it in the expected form (I used the same logic as in impala shell). Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b --- M tests/common/impala_connection.py 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/14607/1 -- To view, visit http://gerrit.cloudera.org:8080/14607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b Gerrit-Change-Number: 14607 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4922/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 6 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang Gerrit-Comment-Date: Thu, 31 Oct 2019 23:52:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4921/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang Gerrit-Comment-Date: Thu, 31 Oct 2019 23:50:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9073: fix test executor concurrency flakiness
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14606 Change subject: IMPALA-9073: fix test_executor_concurrency flakiness .. IMPALA-9073: fix test_executor_concurrency flakiness The test was checking the incorrect invariant - the slot mechanism only prevents more than than number of queries running on a backend. More queries can run on a cluster since the query's backends are freed up before the query itself finishes. It was a little tricky picking an appropriate metric since there is no strong consistency between the metrics, e.g. decrementing a metric after a backend finishes may race with admitting the next query. So I simply used the same metric used by the admission controller in making decisions, which should be strongly consistent w.r.t. admission control decissions. Also remove the concurrency limit on the coordinator, which seemed inconsistent with the purpose of the test, because we only want concurrency to be limited by the executors. Testing: Looped the test for a bit. Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd --- M tests/custom_cluster/test_executor_groups.py 1 file changed, 15 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/14606/1 -- To view, visit http://gerrit.cloudera.org:8080/14606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd Gerrit-Change-Number: 14606 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Hello Quanlong Huang, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14589 to look at the new patch set (#3). Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue .. IMPALA-9105: Catalog debug page top-n table has a URL generation issue What's the problem: Previously, catalogd debug page does not have 'fqtn' property. Because CatalogServer::GetCatalogUsage() does not pass fqtn to the template. Thus, the generated page table detail page cannot be opened. Also, Someone might accedentially deleted which makes the catalogd UI top-K page unorganized. Fix: Correct the URL generation part. Test: Open the page and all the tables object can be correctly opened. Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 --- M www/catalog.tmpl 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/14589/3 -- To view, visit http://gerrit.cloudera.org:8080/14589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 Gerrit-Change-Number: 14589 Gerrit-PatchSet: 3 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9107: Add toolchain maven cache to speed up maven builds
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107: Add toolchain maven cache to speed up maven builds .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14562/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14562/5//COMMIT_MSG@27 PS5, Line 27: How often should this cache be refreshed? Can we automate building a new version of the cache (I see you had a comment with some high-level steps). -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 31 Oct 2019 23:34:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9107: Add toolchain maven cache to speed up maven builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107: Add toolchain maven cache to speed up maven builds .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Thu, 31 Oct 2019 23:13:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Xiaomeng Zhang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo .. IMPALA-8065 Edit OS version and Kernel version in OSInfo Before this change OsInfo::DebugString() would print two lines: - OS version: the long name of the Linux kernel from /proc/version - Clock: the type of clock used After this change OsInfo::DebugString() will print three lines: - OS version: the short name of the OS release. If Docker is being used this is the name of the Container OS - Kernel version: the long name of the Linux kernel from /proc/version. If Docker is being used this is the description of the Host Kernel. - Clock: the type of clock used. Tested locally, the displayed OS Info in Ubuntu16 dev box is: OS version: Ubuntu 16.04.6 LTS Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)) Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC Also tested with diff OS in docker: centos, redhat, ubuntu, oracle, debian. Each OS picked one version to test. Added new backend test os-info-test.cc. Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a --- M be/src/util/CMakeLists.txt A be/src/util/os-info-test.cc M be/src/util/os-info.cc M be/src/util/os-info.h 4 files changed, 77 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/6 -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 6 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Xiaomeng Zhang has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo .. IMPALA-8065 Edit OS version and Kernel version in OSInfo Before this change OsInfo::DebugString() would print two lines: - OS version: the long name of the Linux kernel from /proc/version - Clock: the type of clock used After this change OsInfo::DebugString() will print three lines: - OS version: the short name of the OS release. If Docker is being used this is the name of the Container OS - Kernel version: the long name of the Linux kernel from /proc/version. If Docker is being used this is the description of the Host Kernel. - Clock: the type of clock used. Tested locally, the displayed OS Info in Ubuntu16 dev box is: OS version: "Ubuntu 16.04.6 LTS" Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)) Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC Also tested with diff OS in docker: centos, redhat, ubuntu, oracle, debian. Each OS picked one version to test. Added new backend test os-info-test.cc. Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a --- M be/src/util/CMakeLists.txt A be/src/util/os-info-test.cc M be/src/util/os-info.cc M be/src/util/os-info.h 4 files changed, 77 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/5 -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang
[Impala-ASF-CR] IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14575 ) Change subject: IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log .. IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c Reviewed-on: http://gerrit.cloudera.org:8080/14575 Tested-by: Impala Public Jenkins Reviewed-by: Tim Armstrong --- M docs/topics/impala_auditing.xml 1 file changed, 18 insertions(+), 26 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c Gerrit-Change-Number: 14575 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14575 ) Change subject: IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c Gerrit-Change-Number: 14575 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 31 Oct 2019 22:25:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107: Add toolchain maven cache to speed up maven builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107: Add toolchain maven cache to speed up maven builds .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Thu, 31 Oct 2019 21:36:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14575 ) Change subject: IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/525/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c Gerrit-Change-Number: 14575 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 31 Oct 2019 20:59:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14575 ) Change subject: IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14575/1/docs/topics/impala_auditing.xml File docs/topics/impala_auditing.xml: http://gerrit.cloudera.org:8080/#/c/14575/1/docs/topics/impala_auditing.xml@269 PS1, Line 269: Queries with at least one fetch issued by the client. > IMPALA-8572 (coming in 3.4) actually changed this slightly, so that queries Done -- To view, visit http://gerrit.cloudera.org:8080/14575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c Gerrit-Change-Number: 14575 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 31 Oct 2019 20:36:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log
Hello Vincent Tran, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14575 to look at the new patch set (#2). Change subject: IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log .. IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c --- M docs/topics/impala_auditing.xml 1 file changed, 18 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/14575/2 -- To view, visit http://gerrit.cloudera.org:8080/14575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c Gerrit-Change-Number: 14575 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14575 ) Change subject: IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/525/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c Gerrit-Change-Number: 14575 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 31 Oct 2019 20:36:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4920/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang Gerrit-Comment-Date: Thu, 31 Oct 2019 19:11:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107: Add toolchain maven cache to speed up maven builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107: Add toolchain maven cache to speed up maven builds .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5160/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Thu, 31 Oct 2019 19:04:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14531/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14531/3//COMMIT_MSG@15 PS3, Line 15: OS version: "Ubuntu 16.04.6 LTS" > That's coming from the original file. OK, but we should make it pretty -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 3 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang Gerrit-Comment-Date: Thu, 31 Oct 2019 18:58:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Xiaomeng Zhang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo .. IMPALA-8065 Edit OS version and Kernel version in OSInfo Before this change OsInfo::DebugString() would print two lines: - OS version: the long name of the Linux kernel from /proc/version - Clock: the type of clock used After this change OsInfo::DebugString() will print three lines: - OS version: the short name of the OS release. If Docker is being used this is the name of the Container OS - Kernel version: the long name of the Linux kernel from /proc/version. If Docker is being used this is the description of the Host Kernel. - Clock: the type of clock used. Tested locally, the displayed OS Info in Ubuntu16 dev box is: OS version: "Ubuntu 16.04.6 LTS" Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)) Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC Also tested with diff OS in docker: centos, redhat, ubuntu, oracle, debian. Each OS picked one version to test. Added new backend test os-info-test.cc. Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a --- M be/src/util/CMakeLists.txt A be/src/util/os-info-test.cc M be/src/util/os-info.cc M be/src/util/os-info.h 4 files changed, 75 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/4 -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang
[Impala-ASF-CR] IMPALA-9107: Add toolchain maven cache to speed up maven builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107: Add toolchain maven cache to speed up maven builds .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4919/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Thu, 31 Oct 2019 18:47:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107: Add toolchain maven cache to speed up maven builds
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14562 to look at the new patch set (#5). Change subject: IMPALA-9107: Add toolchain maven cache to speed up maven builds .. IMPALA-9107: Add toolchain maven cache to speed up maven builds The maven build downloads a large number of artifacts from various maven repositories. When starting with an empty .m2 directory (like most upstream Jenkins jobs), downloading all the artifacts can take up to 30 minutes. This has been slowing down our precommit builds by 15-20 minutes. This adds a mode to download a tarball from the toolchain, unpack it, and use it as a maven repository. The tarball is constructed by doing a fresh Impala build with an empty .m2 directory, removing locations that should come from impala.cdp.repo or impala.cdh.repo, then packing that into a tarball. The tarball is currently around 240MB and unpacks to about 309MB, so the space requirement is fairly modest. The jars in the toolchain maven cache are copied to the .m2 directory, so the toolchain maven cache can be removed/replaced without impacting a running cluster. Testing: - Local testing shows a substantially faster build with an empty .m2 directory. - Ran gerrit-verify-dryrun-external and the jobs took about 15-20 minutes less. Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f --- M bin/bootstrap_toolchain.py M bin/impala-config.sh M bin/mvn-quiet.sh M impala-parent/pom.xml 4 files changed, 122 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/14562/5 -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-9107: Add toolchain maven cache to speed up maven builds
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107: Add toolchain maven cache to speed up maven builds .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14562/4/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/14562/4/bin/bootstrap_toolchain.py@388 PS4, Line 388: class ToolchainMavenCache(EnvVersionedPackage): > flake8: E302 expected 2 blank lines, found 1 Done -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Thu, 31 Oct 2019 18:24:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9108: exclude leveldbjni mvn dependency
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14593 ) Change subject: IMPALA-9108: exclude leveldbjni mvn dependency .. IMPALA-9108: exclude leveldbjni mvn dependency We don't need this at all - it's pulled in via some transitive dependencies, e.g. htrace and hive-serde. Add an exclusion and add it as a banned dependency. Change-Id: I90b63bc03511545530e1506bc602623591c56e98 Reviewed-on: http://gerrit.cloudera.org:8080/14593 Tested-by: Impala Public Jenkins Reviewed-by: Joe McDonnell --- M fe/pom.xml 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I90b63bc03511545530e1506bc602623591c56e98 Gerrit-Change-Number: 14593 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9107: Add toolchain maven cache to speed up maven builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107: Add toolchain maven cache to speed up maven builds .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5159/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 31 Oct 2019 17:08:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9108: exclude leveldbjni mvn dependency
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14593 ) Change subject: IMPALA-9108: exclude leveldbjni mvn dependency .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90b63bc03511545530e1506bc602623591c56e98 Gerrit-Change-Number: 14593 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Thu, 31 Oct 2019 17:07:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4918/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 14 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 31 Oct 2019 14:12:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
Gabor Kaszab has posted comments on this change. (
http://gerrit.cloudera.org:8080/14291 )
Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
..
Patch Set 14:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/14291/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14291/12//COMMIT_MSG@24
PS12, Line 24:
: In a string to datetime conversion when using this modi
> Please clarify that this is about datetime to string conversion.
That is in fact for string to datetime conversion. Re-phrased this part of the
comment to express the point better.
http://gerrit.cloudera.org:8080/#/c/14291/12/be/src/runtime/datetime-iso-sql-format-parser.h
File be/src/runtime/datetime-iso-sql-format-parser.h:
http://gerrit.cloudera.org:8080/#/c/14291/12/be/src/runtime/datetime-iso-sql-format-parser.h@81
PS12, Line 81: t
> nit: the
Done
http://gerrit.cloudera.org:8080/#/c/14291/12/be/src/runtime/datetime-iso-sql-format-parser.cc
File be/src/runtime/datetime-iso-sql-format-parser.cc:
http://gerrit.cloudera.org:8080/#/c/14291/12/be/src/runtime/datetime-iso-sql-format-parser.cc@238
PS12, Line 238: DCHECK(current_tok_idx != nullptr && *current_tok_idx <
dt_ctx.toks.size());
> Add
Done
http://gerrit.cloudera.org:8080/#/c/14291/12/be/src/runtime/datetime-iso-sql-format-tokenizer.cc
File be/src/runtime/datetime-iso-sql-format-tokenizer.cc:
http://gerrit.cloudera.org:8080/#/c/14291/12/be/src/runtime/datetime-iso-sql-format-tokenizer.cc@113
PS12, Line 113: DCHECK(str_begin <= *current_pos && *current_pos < str_end);
: if (IsStartOfTextToken(*current_pos)) {
:
> What if text token is preceded by an FM modifier?
Hmm, this is in fact an issue for text tokens. Even though the behaviour of a
text token is the same with or without FM/FX modifiers but it's misleading that
FM is applied to the token after the text token.
For separators, I don't feel this is an issue. FM is applied to the next
(non-separator) token in the format. In your example I think it's fine to apply
FM to DD.
Done the adjustment for TEXT.
http://gerrit.cloudera.org:8080/#/c/14291/12/be/src/runtime/datetime-iso-sql-format-tokenizer.cc@124
PS12, Line 124:const auto token = VALID_TOKENS.find(token_to_probe);
: if (token != VALID_TOKENS.end()) {
: if (token->second.type == FX_MODIFIER) return
MISPLACED_FX_MODIFIER_ERROR;
: if (token->second.type == FM_MODIFIER) {
: fm_modifier_active_ = true;
: *current_pos += curr_token_size;
: return SUCCESS;
: }
> 'FMFX-MM-DD' is another format string that should be rejected but curre
See above
http://gerrit.cloudera.org:8080/#/c/14291/12/be/src/runtime/datetime-iso-sql-format-tokenizer.cc@124
PS12, Line 124:const auto token = VALID_TOKENS.find(token_to_probe);
: if (token != VALID_TOKENS.end()) {
: if (token->second.type == FX_MODIFIER) return
MISPLACED_FX_MODIFIER_ERROR;
: if (token->second.type == FM_MODIFIER) {
: fm_modifier_active_ = true;
: *current_pos += curr_token_size;
: return SUCCESS;
: }
> This still allows format strings like:
Agree, to avoid confusion FX tokenization should be right before the loop.
Done
--
To view, visit http://gerrit.cloudera.org:8080/14291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855
Gerrit-Change-Number: 14291
Gerrit-PatchSet: 14
Gerrit-Owner: Gabor Kaszab
Gerrit-Reviewer: Attila Jeges
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Thu, 31 Oct 2019 13:29:04 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14600/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14600/2//COMMIT_MSG@14 PS2, Line 14: Testing: We usually add end to end test for it. http://gerrit.cloudera.org:8080/#/c/14600/2/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/14600/2/fe/src/main/java/org/apache/impala/catalog/Table.java@102 PS2, Line 102: // Time spend on table metadata loading. (ns) For the value is median loading time, you may need to add comments to state that. -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 2 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 31 Oct 2019 13:30:52 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/14291/14/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/14291/14/tests/query_test/test_cast_with_format.py@751 PS14, Line 751: assert result.data == [r'''1985 text tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14291/14/tests/query_test/test_cast_with_format.py@755 PS14, Line 755: assert result.data == [r'''1985 text tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14291/14/tests/query_test/test_cast_with_format.py@759 PS14, Line 759: assert result.data == [r'''1985 text tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14291/14/tests/query_test/test_cast_with_format.py@763 PS14, Line 763: assert result.data == [r'''1985 text tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 14 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 31 Oct 2019 13:28:42 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14291 to look at the new patch set (#14). Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 This patch adds additional datetime format tokens on top of what was introduced with Milestone 1 (IMPALA-8703). The tokens introduced: - Free text token: Surrounded by double quotes, a free text section can be given in the format where the same text is expected in the input without the surrounding double quotes. - FX modifier: This modifier has to be given at the beginning of the format and is valid for the whole format. In a string to datetime conversion this forces strict separator matching and expects all the tokens in the input to have the same length as their maximum length. E.g. A month has to be of length 2 prefixed by zero if needed. This is the default in a datetime to string conversion. - FM modifier: This modifier affects only the following token and overrides the FX modifier. In a string to datetime conversion when using this modifier the length of the token in the input can be shorter than the max length of that token type if followed by a separator. E.g. 1-digit month, less than 4-digit year, etc. This is the default behaviour in a string to datetime conversion. In a datetime to string conversion tokens with this modifier aren't padded to the maximum length. Example output: "2010-1-9". Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 --- M be/src/runtime/date-parse-util.cc M be/src/runtime/datetime-iso-sql-format-parser.cc M be/src/runtime/datetime-iso-sql-format-parser.h M be/src/runtime/datetime-iso-sql-format-tokenizer.cc M be/src/runtime/datetime-iso-sql-format-tokenizer.h M be/src/runtime/datetime-parser-common.cc M be/src/runtime/datetime-parser-common.h M be/src/runtime/timestamp-parse-util.cc M tests/query_test/test_cast_with_format.py 9 files changed, 699 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14291/14 -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 14 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 ) Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14589/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14589/2//COMMIT_MSG@13 PS2, Line 13: br typo? td? -- To view, visit http://gerrit.cloudera.org:8080/14589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 Gerrit-Change-Number: 14589 Gerrit-PatchSet: 2 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Thu, 31 Oct 2019 11:54:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4917/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 2 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 31 Oct 2019 07:33:51 + Gerrit-HasComments: No
