[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for coordinator-only mode
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode .. Patch Set 4: Code-Review+1 LGTM. -- To view, visit http://gerrit.cloudera.org:8080/15173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I373d4037f4cee203322a398b77b75810ba708bb5 Gerrit-Change-Number: 15173 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Mon, 10 Feb 2020 05:20:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5180/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01e3a195b00a98388244a922a1a79e65146cec42 Gerrit-Change-Number: 15189 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 10 Feb 2020 02:54:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8361: Propagate predicates of outer-joined InlineView
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15047 ) Change subject: IMPALA-8361: Propagate predicates of outer-joined InlineView .. Patch Set 10: (3 comments) Took another round. The patch looks good to me in general. Also add Tim since he knows some background of the planner. http://gerrit.cloudera.org:8080/#/c/15047/10/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/15047/10/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1178 PS10, Line 1178: evalInInlineViewPreds.add(e); Can we simply fix IMPALA-9356 by adding this to evalAfterJoinPreds? http://gerrit.cloudera.org:8080/#/c/15047/9/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test File testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test: http://gerrit.cloudera.org:8080/#/c/15047/9/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test@2368 PS9, Line 2368: > This looks strange to me. rand() returns a random value between 0 and 1 so I'm ok to skip adding this test as you did. I saw you create IMPALA-9356. http://gerrit.cloudera.org:8080/#/c/15047/10/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test File testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test: http://gerrit.cloudera.org:8080/#/c/15047/10/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test@2339 PS10, Line 2339: Why removing the test coverage for local views? -- To view, visit http://gerrit.cloudera.org:8080/15047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c23a45aeb5dd1aa06a95c9aa8628ecbe37ef2c1 Gerrit-Change-Number: 15047 Gerrit-PatchSet: 10 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Mon, 10 Feb 2020 02:36:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15189 Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. IMPALA-9304: Support starting Hive with Ranger in minicluster Add a new flag -with_ranger in testdata/bin/run-hive-server.sh to start Hive with Ranger integration. The relative configuration files are generated in bin/create-test-configuration.sh using a new varient ranger_auth in hive-site.xml.py. Only Hive3 is supported. Current limitation: Can't use different username in Beeline by the -n option. "select current_user()" keeps returning my username, while "select logged_in_user()" can return the username given by -n option but it's not used in authorization. Tests: - Ran bin/create-test-configuration.sh and verified the generated hive-site_ranger_auth.xml contains Ranger configurations. - Ran testdata/bin/run-hive-server.sh -with_ranger. Verified column masking and row filtering policies took effect in Beeline. Change-Id: I01e3a195b00a98388244a922a1a79e65146cec42 --- M bin/create-test-configuration.sh M fe/src/test/resources/hive-site.xml.py M testdata/bin/run-hive-server.sh 3 files changed, 44 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/15189/1 -- To view, visit http://gerrit.cloudera.org:8080/15189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I01e3a195b00a98388244a922a1a79e65146cec42 Gerrit-Change-Number: 15189 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
[Impala-ASF-CR] IMPALA-8110: Fix Parquet min/max filters for narrowed integer types
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15087 ) Change subject: IMPALA-8110: Fix Parquet min/max filters for narrowed integer types .. IMPALA-8110: Fix Parquet min/max filters for narrowed integer types This patch adds validation for the paired stats values of tinyint and smallint column data type when reading min/max column stats value from Parquet file. Testing: - Added automatic test cases in parquet-stats.test for column data type been changed from int to tinyint, from smallint to tinyint and from int to smallint. - Passed EE tests. - Passed all core tests. Change-Id: Id8bdaf4c4b2d0c6ea26d6e9bf013afca647e53a1 Reviewed-on: http://gerrit.cloudera.org:8080/15087 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exec/parquet/hdfs-parquet-scanner.cc M be/src/exec/parquet/parquet-column-stats.cc M be/src/exec/parquet/parquet-column-stats.h M testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test 4 files changed, 121 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id8bdaf4c4b2d0c6ea26d6e9bf013afca647e53a1 Gerrit-Change-Number: 15087 Gerrit-PatchSet: 11 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-8110: Fix Parquet min/max filters for narrowed integer types
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15087 ) Change subject: IMPALA-8110: Fix Parquet min/max filters for narrowed integer types .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8bdaf4c4b2d0c6ea26d6e9bf013afca647e53a1 Gerrit-Change-Number: 15087 Gerrit-PatchSet: 10 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 09 Feb 2020 23:18:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8110: Fix Parquet min/max filters for narrowed integer types
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15087 ) Change subject: IMPALA-8110: Fix Parquet min/max filters for narrowed integer types .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5308/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8bdaf4c4b2d0c6ea26d6e9bf013afca647e53a1 Gerrit-Change-Number: 15087 Gerrit-PatchSet: 10 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 09 Feb 2020 18:27:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8110: Fix Parquet min/max filters for narrowed integer types
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15087 ) Change subject: IMPALA-8110: Fix Parquet min/max filters for narrowed integer types .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8bdaf4c4b2d0c6ea26d6e9bf013afca647e53a1 Gerrit-Change-Number: 15087 Gerrit-PatchSet: 10 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 09 Feb 2020 18:27:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8110: Fix Parquet min/max filters for narrowed integer types
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15087 ) Change subject: IMPALA-8110: Fix Parquet min/max filters for narrowed integer types .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8bdaf4c4b2d0c6ea26d6e9bf013afca647e53a1 Gerrit-Change-Number: 15087 Gerrit-PatchSet: 9 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 09 Feb 2020 18:25:46 + Gerrit-HasComments: No
