[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 3: Code-Review+1 Couple of comments but these are not blockers and I would be ok to address them later. -- To view, visit http://gerrit.cloudera.org:8080/15654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 Gerrit-Change-Number: 15654 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 07 Apr 2020 05:36:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Aman Sinha has posted comments on this change. (
http://gerrit.cloudera.org:8080/15654 )
Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column
masking
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1493
PS3, Line 1493: if (node instanceof JoinNode) {
> Yeah, but to add this marker, we still need to loop over all the TableRefs
For adding the marker I thought you would just need to add a boolean
'isAssociatedWithMasking' to JoinNode and set it to true in the
JoinNode.init() line #224. Something like:
List tupleDescs = analyzer.materializeSlots(conjuncts_);
this.isAssociatedWithMasking = tupleDescs.size() > 0 ? true : false;//
<-- this is based on your clarification that other
// cases will have empty list of tuple descriptors.
Would that work ? If not, I am fine with deferring the optimization to the
future.
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java
File fe/src/main/java/org/apache/impala/planner/JoinNode.java:
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java@224
PS3, Line 224: for (TupleDescriptor tuple :
analyzer.materializeSlots(conjuncts_)) {
> analyzer.materializeSlots(conjuncts_) only returns the affected tuples. In
Yeah, if you can add a Preconditions check that would be good.
--
To view, visit http://gerrit.cloudera.org:8080/15654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3
Gerrit-Change-Number: 15654
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang
Gerrit-Reviewer: Aman Sinha
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Comment-Date: Tue, 07 Apr 2020 05:35:17 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5724/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 Gerrit-Change-Number: 15642 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 Apr 2020 05:28:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9565 Remove unused included file mm malloc.h on ARM
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15586 ) Change subject: IMPALA-9565 Remove unused included file mm_malloc.h on ARM .. Patch Set 6: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5723/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ea1f654b4da0e658843fad1c1f6de99b784dcff Gerrit-Change-Number: 15586 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 05:13:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15630 ) Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5722/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b5b63e5e52bc818ea4591292ac36da941b2cf2d Gerrit-Change-Number: 15630 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 05:06:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/15654 )
Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column
masking
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1493
PS3, Line 1493: if (node instanceof JoinNode) {
> It would be useful to tag the JoinNode with some special marker that it is
Yeah, but to add this marker, we still need to loop over all the TableRefs of
the JoinNode. Looks like it doesn't optimize a lot. I think we can do this
optimization later.
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java
File fe/src/main/java/org/apache/impala/planner/JoinNode.java:
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java@224
PS3, Line 224: for (TupleDescriptor tuple :
analyzer.materializeSlots(conjuncts_)) {
> Would this loop be penalizing joins in the normal case ? i.e if there is no
analyzer.materializeSlots(conjuncts_) only returns the affected tuples. In
normal code path (without nested columns or column masking), the returned set
is empty. I think I can add some Precondition checks for "only tuples of the
masked tables could be affected".
--
To view, visit http://gerrit.cloudera.org:8080/15654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3
Gerrit-Change-Number: 15654
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang
Gerrit-Reviewer: Aman Sinha
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Comment-Date: Tue, 07 Apr 2020 04:48:05 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
Hello Sahil Takiar, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15642 to look at the new patch set (#5). Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 Upgrades the impala-shell's bundled version of sqlparse to 0.3.1. There were some API changes in 0.2.0+ that required a re-write of the StripLeadingCommentFilter in impala_shell.py. As 0.1.19 was the last version of sqlparse to support python 2.6, this patch also breaks Impala's compatibility with python 2.6. No new tests were added, but all existing tests passed without modification. Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 --- M LICENSE.txt M README.md M bin/rat_exclude_files.txt M infra/python/deps/requirements.txt M shell/.gitignore D shell/ext-py/sqlparse-0.1.19/.travis.yml D shell/ext-py/sqlparse-0.1.19/AUTHORS D shell/ext-py/sqlparse-0.1.19/CHANGES D shell/ext-py/sqlparse-0.1.19/README.rst D shell/ext-py/sqlparse-0.1.19/bin/sqlformat D shell/ext-py/sqlparse-0.1.19/docs/source/analyzing.rst D shell/ext-py/sqlparse-0.1.19/docs/source/api.rst D shell/ext-py/sqlparse-0.1.19/docs/source/changes.rst D shell/ext-py/sqlparse-0.1.19/docs/source/conf.py D shell/ext-py/sqlparse-0.1.19/docs/source/index.rst D shell/ext-py/sqlparse-0.1.19/docs/source/indices.rst D shell/ext-py/sqlparse-0.1.19/docs/source/intro.rst D shell/ext-py/sqlparse-0.1.19/docs/source/ui.rst D shell/ext-py/sqlparse-0.1.19/docs/sqlformat.1 D shell/ext-py/sqlparse-0.1.19/pytest.ini D shell/ext-py/sqlparse-0.1.19/setup.py D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/__init__.py D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/filter.py D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/grouping.py D shell/ext-py/sqlparse-0.1.19/sqlparse/exceptions.py D shell/ext-py/sqlparse-0.1.19/sqlparse/filters.py D shell/ext-py/sqlparse-0.1.19/sqlparse/formatter.py D shell/ext-py/sqlparse-0.1.19/sqlparse/functions.py D shell/ext-py/sqlparse-0.1.19/sqlparse/keywords.py D shell/ext-py/sqlparse-0.1.19/sqlparse/lexer.py D shell/ext-py/sqlparse-0.1.19/sqlparse/pipeline.py D shell/ext-py/sqlparse-0.1.19/sqlparse/sql.py D shell/ext-py/sqlparse-0.1.19/sqlparse/tokens.py D shell/ext-py/sqlparse-0.1.19/sqlparse/utils.py D shell/ext-py/sqlparse-0.1.19/tests/test_filters.py D shell/ext-py/sqlparse-0.1.19/tests/test_format.py D shell/ext-py/sqlparse-0.1.19/tests/test_functions.py D shell/ext-py/sqlparse-0.1.19/tests/test_grouping.py D shell/ext-py/sqlparse-0.1.19/tests/test_parse.py D shell/ext-py/sqlparse-0.1.19/tests/test_pipeline.py D shell/ext-py/sqlparse-0.1.19/tests/test_regressions.py D shell/ext-py/sqlparse-0.1.19/tests/test_split.py D shell/ext-py/sqlparse-0.1.19/tests/test_tokenize.py D shell/ext-py/sqlparse-0.1.19/tests/utils.py D shell/ext-py/sqlparse-0.1.19/tox.ini A shell/ext-py/sqlparse-0.3.1/AUTHORS A shell/ext-py/sqlparse-0.3.1/CHANGELOG R shell/ext-py/sqlparse-0.3.1/LICENSE R shell/ext-py/sqlparse-0.3.1/MANIFEST.in A shell/ext-py/sqlparse-0.3.1/README.rst R shell/ext-py/sqlparse-0.3.1/TODO A shell/ext-py/sqlparse-0.3.1/setup.cfg A shell/ext-py/sqlparse-0.3.1/setup.py R shell/ext-py/sqlparse-0.3.1/sqlparse/__init__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/__main__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/cli.py A shell/ext-py/sqlparse-0.3.1/sqlparse/compat.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/__init__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/filter_stack.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/grouping.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/statement_splitter.py A shell/ext-py/sqlparse-0.3.1/sqlparse/exceptions.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/__init__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/aligned_indent.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/others.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/output.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/reindent.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/right_margin.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/tokens.py A shell/ext-py/sqlparse-0.3.1/sqlparse/formatter.py A shell/ext-py/sqlparse-0.3.1/sqlparse/keywords.py A shell/ext-py/sqlparse-0.3.1/sqlparse/lexer.py A shell/ext-py/sqlparse-0.3.1/sqlparse/sql.py A shell/ext-py/sqlparse-0.3.1/sqlparse/tokens.py A shell/ext-py/sqlparse-0.3.1/sqlparse/utils.py R shell/ext-py/sqlparse-0.3.1/tests/__init__.py A shell/ext-py/sqlparse-0.3.1/tests/conftest.py R shell/ext-py/sqlparse-0.3.1/tests/files/_Make_DirEntry.sql R shell/ext-py/sqlparse-0.3.1/tests/files/begintag.sql R shell/ext-py/sqlparse-0.3.1/tests/files/begintag_2.sql R shell/ext-py/sqlparse-0.3.1/tests/files/dashcomment.sql A shell/ext-py/sqlparse-0.3.1/tests/files/encoding_gbk.sql A shell/ext-py/sqlparse-0.3.1/tests/files/encoding_utf8.sql R shell/ext-py/sqlparse-0.3.1/tests/files/function.sql R
[Impala-ASF-CR] IMPALA-9563 Replace Intel's pcmpestri and pcmpestrm instructions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15588 ) Change subject: IMPALA-9563 Replace Intel's pcmpestri and pcmpestrm instructions .. Patch Set 6: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5721/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I208650853f3624e56fbd4698a2a8016bae6fefe7 Gerrit-Change-Number: 15588 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 04:41:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9562 Replace Intel's popcntq instruction with ARM's
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15587 ) Change subject: IMPALA-9562 Replace Intel's popcntq instruction with ARM's .. Patch Set 6: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5720/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a06b745d66064760f9f0f265ca01b7d828b13b3 Gerrit-Change-Number: 15587 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 04:41:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9565 Remove unused included file mm malloc.h on ARM
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15586 Change subject: IMPALA-9565 Remove unused included file mm_malloc.h on ARM .. IMPALA-9565 Remove unused included file mm_malloc.h on ARM Remove unused included file mm_malloc.h on ARM. ARM version gcc don't have mm_malloc.h file. Change-Id: I4ea1f654b4da0e658843fad1c1f6de99b784dcff --- M be/src/kudu/util/memory/memory.cc M be/src/kudu/util/striped64.cc 2 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/15586/6 -- To view, visit http://gerrit.cloudera.org:8080/15586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4ea1f654b4da0e658843fad1c1f6de99b784dcff Gerrit-Change-Number: 15586 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-9564 Replace Intel's crc32 instructions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15585 ) Change subject: IMPALA-9564 Replace Intel's crc32 instructions .. Patch Set 6: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5719/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a765bfee3bd8a64289b90172be460f9c40dfdb5 Gerrit-Change-Number: 15585 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 04:25:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15531 ) Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. Patch Set 13: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5717/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9 Gerrit-Change-Number: 15531 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 04:25:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5718/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/1 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id56bfa63e4b6cd957c4997f10de78a5f4111f61f Gerrit-Change-Number: 1 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 Apr 2020 04:25:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15527 ) Change subject: IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5716/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie55b89bb689375cbb55c22f6d5543a5422b29a82 Gerrit-Change-Number: 15527 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 04:25:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9563 Replace Intel's pcmpestri and pcmpestrm instructions
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15588 Change subject: IMPALA-9563 Replace Intel's pcmpestri and pcmpestrm instructions .. IMPALA-9563 Replace Intel's pcmpestri and pcmpestrm instructions Replace Intel's pcmpestri and pcmpestrm instructions with ARM mechanism Change-Id: I208650853f3624e56fbd4698a2a8016bae6fefe7 --- M be/src/util/sse-util.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/15588/6 -- To view, visit http://gerrit.cloudera.org:8080/15588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I208650853f3624e56fbd4698a2a8016bae6fefe7 Gerrit-Change-Number: 15588 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15630 Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. IMPALA-9590 Resolve error when build tsan and ubsan on arm64 Tsan build will fail on atomicops-internals-x86.cc build, so if on arm64, just don't build it. And Ubsan build should link to libclang_rt.ubsan_standalone's aarch 64 version, not x86 version. Change-Id: I1b5b63e5e52bc818ea4591292ac36da941b2cf2d --- M be/src/gutil/CMakeLists.txt M be/src/service/CMakeLists.txt 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/15630/3 -- To view, visit http://gerrit.cloudera.org:8080/15630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1b5b63e5e52bc818ea4591292ac36da941b2cf2d Gerrit-Change-Number: 15630 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-9562 Replace Intel's popcntq instruction with ARM's
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15587 Change subject: IMPALA-9562 Replace Intel's popcntq instruction with ARM's .. IMPALA-9562 Replace Intel's popcntq instruction with ARM's Replace Intel's popcntq instruction with ARM's mechanism Change-Id: I2a06b745d66064760f9f0f265ca01b7d828b13b3 --- M be/src/util/sse-util.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/15587/6 -- To view, visit http://gerrit.cloudera.org:8080/15587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2a06b745d66064760f9f0f265ca01b7d828b13b3 Gerrit-Change-Number: 15587 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. Patch Set 8: Hi, Tim, this has been modified as your request. -- To view, visit http://gerrit.cloudera.org:8080/1 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id56bfa63e4b6cd957c4997f10de78a5f4111f61f Gerrit-Change-Number: 1 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 Apr 2020 03:44:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/1/8/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/1/8/buildall.sh@471 PS8, Line 471: local cachelinesize=$(cat /sys/devices/system/cpu/cpu0/cache/index3/coherency_line_size) line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/1 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id56bfa63e4b6cd957c4997f10de78a5f4111f61f Gerrit-Change-Number: 1 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 Apr 2020 03:44:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9564 Replace Intel's crc32 instructions
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15585 Change subject: IMPALA-9564 Replace Intel's crc32 instructions .. IMPALA-9564 Replace Intel's crc32 instructions Replace Intel's crc32 instructions with ARM's instructions Change-Id: I2a765bfee3bd8a64289b90172be460f9c40dfdb5 --- M be/src/util/sse-util.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/15585/6 -- To view, visit http://gerrit.cloudera.org:8080/15585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2a765bfee3bd8a64289b90172be460f9c40dfdb5 Gerrit-Change-Number: 15585 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15531 ) Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. Patch Set 13: (39 comments) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/bit-util.cc File be/src/util/bit-util.cc: http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/bit-util.cc@237 PS13, Line 237: #ifndef __aarch64__ line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/bit-util.cc@249 PS13, Line 249: #endif line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/bloom-filter.h@212 PS13, Line 212: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/bloom-filter.h@221 PS13, Line 221: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/bloom-filter.cc File be/src/util/bloom-filter.cc: http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/bloom-filter.cc@20 PS13, Line 20: #include "sse2neon.h" line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse-util.h File be/src/util/sse-util.h: http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse-util.h@126 PS13, Line 126: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h File be/src/util/sse2neon.h: http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@210 PS13, Line 210: // https://msdn.microsoft.com/en-us/library/bb514059%28v=vs.120%29.aspx?f=255=-2147217396 line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@403 PS13, Line 403: // https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/whtfzhzk(v=vs.100) line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@410 PS13, Line 410: // https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_set1_epi64x=4961 line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@544 PS13, Line 544: return vreinterpretq_m128i_s32(vcombine_s32(vld1_s32((int32_t const *) p), vcreate_s32(0))); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@1025 PS13, Line 1025: // https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_shuffle_epi8=5146 line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@1174 PS13, Line 1174: // https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/y41dkk37(v=vs.100) line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@1513 PS13, Line 1513: // Since the widening shifts would be rather confusing to follow in little endian, everything line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@1514 PS13, Line 1514: // will be illustrated in big endian order instead. This has a different result - the bits line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@1601 PS13, Line 1601: // https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_test_all_zeros=5871 line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@3048 PS13, Line 3048: return vreinterpretq_m128i_s8(vzip1q_s8(vreinterpretq_s8_m128i(a), vreinterpretq_s8_m128i(b))); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@3073 PS13, Line 3073: return vreinterpretq_m128i_s16(vzip1q_s16(vreinterpretq_s16_m128i(a), vreinterpretq_s16_m128i(b))); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@3094 PS13, Line 3094: return vreinterpretq_m128i_s32(vzip1q_s32(vreinterpretq_s32_m128i(a), vreinterpretq_s32_m128i(b))); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@3122 PS13, Line 3122: return vreinterpretq_m128_f32(vzip1q_f32(vreinterpretq_f32_m128(a), vreinterpretq_f32_m128(b))); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@3143 PS13, Line 3143: return vreinterpretq_m128_f32(vzip2q_f32(vreinterpretq_f32_m128(a), vreinterpretq_f32_m128(b))); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@3167 PS13, Line 3167: return vreinterpretq_m128i_s8(vzip2q_s8(vreinterpretq_s8_m128i(a), vreinterpretq_s8_m128i(b))); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/15531/13/be/src/util/sse2neon.h@3194 PS13, Line 3194: return vreinterpretq_m128i_s16(vzip2q_s16(vreinterpretq_s16_m128i(a),
[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64
zhaoren...@hotmail.com has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. IMPALA-9545 Decide cacheline size of aarch64 ARM64's L3 cacheline size is different according to CPU vendor's architecture. If user defined CACHELINESIZE_AARCH64 in impala-config-local.sh, then we will use that value, if user did not define it, then we will get the value from OS, if fail, then we will use the default value 64. Change-Id: Id56bfa63e4b6cd957c4997f10de78a5f4111f61f --- M CMakeLists.txt M be/CMakeLists.txt M be/src/gutil/port.h M buildall.sh 4 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/1/8 -- To view, visit http://gerrit.cloudera.org:8080/1 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id56bfa63e4b6cd957c4997f10de78a5f4111f61f Gerrit-Change-Number: 1 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15531 Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions Replace Intel's SSE instructions with ARM's NEON instructions Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9 --- M be/src/benchmarks/bswap-benchmark.cc M be/src/benchmarks/int-hash-benchmark.cc M be/src/codegen/CMakeLists.txt M be/src/kudu/util/block_bloom_filter.cc M be/src/kudu/util/group_varint-inl.h M be/src/kudu/util/group_varint-test.cc A be/src/kudu/util/sse2neon.h M be/src/util/bit-util-test.cc M be/src/util/bit-util.cc M be/src/util/bloom-filter-ir.cc M be/src/util/bloom-filter.cc M be/src/util/bloom-filter.h M be/src/util/sse-util.h A be/src/util/sse2neon.h 14 files changed, 3,784 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/15531/13 -- To view, visit http://gerrit.cloudera.org:8080/15531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id7dfe17125b2910ece54e7dd18b4e4b25d7de8b9 Gerrit-Change-Number: 15531 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt
zhaoren...@hotmail.com has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/15527 ) Change subject: IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt .. IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt Reduce duplicate code in thrift CMakeLists.txt. And if in future, we change hive to version 4 or higher. This can adapt autometically. Change-Id: Ie55b89bb689375cbb55c22f6d5543a5422b29a82 --- M common/thrift/CMakeLists.txt 1 file changed, 2 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/15527/14 -- To view, visit http://gerrit.cloudera.org:8080/15527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie55b89bb689375cbb55c22f6d5543a5422b29a82 Gerrit-Change-Number: 15527 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 4: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5715/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 Gerrit-Change-Number: 15642 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 Apr 2020 03:35:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5714/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 Gerrit-Change-Number: 15642 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 03:19:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5613/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 Gerrit-Change-Number: 15642 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 02:55:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15642 to look at the new patch set (#4). Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 Upgrades the impala-shell's bundled version of sqlparse to 0.3.1. There were some API changes in 0.2.0+ that required a re-write of the StripLeadingCommentFilter in impala_shell.py. As 0.1.19 was the last version of sqlparse to support python 2.6, this patch also breaks Impala's compatibility with python 2.6. No new tests were added, but all existing tests passed without modification. Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 --- M LICENSE.txt M README.md M bin/rat_exclude_files.txt M infra/python/deps/requirements.txt M shell/.gitignore D shell/ext-py/sqlparse-0.1.19/.travis.yml D shell/ext-py/sqlparse-0.1.19/AUTHORS D shell/ext-py/sqlparse-0.1.19/CHANGES D shell/ext-py/sqlparse-0.1.19/README.rst D shell/ext-py/sqlparse-0.1.19/bin/sqlformat D shell/ext-py/sqlparse-0.1.19/docs/source/analyzing.rst D shell/ext-py/sqlparse-0.1.19/docs/source/api.rst D shell/ext-py/sqlparse-0.1.19/docs/source/changes.rst D shell/ext-py/sqlparse-0.1.19/docs/source/conf.py D shell/ext-py/sqlparse-0.1.19/docs/source/index.rst D shell/ext-py/sqlparse-0.1.19/docs/source/indices.rst D shell/ext-py/sqlparse-0.1.19/docs/source/intro.rst D shell/ext-py/sqlparse-0.1.19/docs/source/ui.rst D shell/ext-py/sqlparse-0.1.19/docs/sqlformat.1 D shell/ext-py/sqlparse-0.1.19/pytest.ini D shell/ext-py/sqlparse-0.1.19/setup.py D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/__init__.py D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/filter.py D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/grouping.py D shell/ext-py/sqlparse-0.1.19/sqlparse/exceptions.py D shell/ext-py/sqlparse-0.1.19/sqlparse/filters.py D shell/ext-py/sqlparse-0.1.19/sqlparse/formatter.py D shell/ext-py/sqlparse-0.1.19/sqlparse/functions.py D shell/ext-py/sqlparse-0.1.19/sqlparse/keywords.py D shell/ext-py/sqlparse-0.1.19/sqlparse/lexer.py D shell/ext-py/sqlparse-0.1.19/sqlparse/pipeline.py D shell/ext-py/sqlparse-0.1.19/sqlparse/sql.py D shell/ext-py/sqlparse-0.1.19/sqlparse/tokens.py D shell/ext-py/sqlparse-0.1.19/sqlparse/utils.py D shell/ext-py/sqlparse-0.1.19/tests/test_filters.py D shell/ext-py/sqlparse-0.1.19/tests/test_format.py D shell/ext-py/sqlparse-0.1.19/tests/test_functions.py D shell/ext-py/sqlparse-0.1.19/tests/test_grouping.py D shell/ext-py/sqlparse-0.1.19/tests/test_parse.py D shell/ext-py/sqlparse-0.1.19/tests/test_pipeline.py D shell/ext-py/sqlparse-0.1.19/tests/test_regressions.py D shell/ext-py/sqlparse-0.1.19/tests/test_split.py D shell/ext-py/sqlparse-0.1.19/tests/test_tokenize.py D shell/ext-py/sqlparse-0.1.19/tests/utils.py D shell/ext-py/sqlparse-0.1.19/tox.ini A shell/ext-py/sqlparse-0.3.1/AUTHORS A shell/ext-py/sqlparse-0.3.1/CHANGELOG R shell/ext-py/sqlparse-0.3.1/LICENSE R shell/ext-py/sqlparse-0.3.1/MANIFEST.in A shell/ext-py/sqlparse-0.3.1/README.rst R shell/ext-py/sqlparse-0.3.1/TODO A shell/ext-py/sqlparse-0.3.1/setup.cfg A shell/ext-py/sqlparse-0.3.1/setup.py R shell/ext-py/sqlparse-0.3.1/sqlparse/__init__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/__main__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/cli.py A shell/ext-py/sqlparse-0.3.1/sqlparse/compat.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/__init__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/filter_stack.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/grouping.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/statement_splitter.py A shell/ext-py/sqlparse-0.3.1/sqlparse/exceptions.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/__init__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/aligned_indent.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/others.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/output.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/reindent.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/right_margin.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/tokens.py A shell/ext-py/sqlparse-0.3.1/sqlparse/formatter.py A shell/ext-py/sqlparse-0.3.1/sqlparse/keywords.py A shell/ext-py/sqlparse-0.3.1/sqlparse/lexer.py A shell/ext-py/sqlparse-0.3.1/sqlparse/sql.py A shell/ext-py/sqlparse-0.3.1/sqlparse/tokens.py A shell/ext-py/sqlparse-0.3.1/sqlparse/utils.py R shell/ext-py/sqlparse-0.3.1/tests/__init__.py A shell/ext-py/sqlparse-0.3.1/tests/conftest.py R shell/ext-py/sqlparse-0.3.1/tests/files/_Make_DirEntry.sql R shell/ext-py/sqlparse-0.3.1/tests/files/begintag.sql R shell/ext-py/sqlparse-0.3.1/tests/files/begintag_2.sql R shell/ext-py/sqlparse-0.3.1/tests/files/dashcomment.sql A shell/ext-py/sqlparse-0.3.1/tests/files/encoding_gbk.sql A shell/ext-py/sqlparse-0.3.1/tests/files/encoding_utf8.sql R shell/ext-py/sqlparse-0.3.1/tests/files/function.sql R shell/ext-py/sqlparse-0.3.1/tests/files/function_psql.sql R
[Impala-ASF-CR] WIP - IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15642 to look at the new patch set (#3). Change subject: WIP - IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. WIP - IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 This breaks compatibility with python 2.6. Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 --- M LICENSE.txt M README.md M bin/rat_exclude_files.txt M infra/python/deps/requirements.txt M shell/.gitignore D shell/ext-py/sqlparse-0.1.19/.travis.yml D shell/ext-py/sqlparse-0.1.19/AUTHORS D shell/ext-py/sqlparse-0.1.19/CHANGES D shell/ext-py/sqlparse-0.1.19/README.rst D shell/ext-py/sqlparse-0.1.19/bin/sqlformat D shell/ext-py/sqlparse-0.1.19/docs/source/analyzing.rst D shell/ext-py/sqlparse-0.1.19/docs/source/api.rst D shell/ext-py/sqlparse-0.1.19/docs/source/changes.rst D shell/ext-py/sqlparse-0.1.19/docs/source/conf.py D shell/ext-py/sqlparse-0.1.19/docs/source/index.rst D shell/ext-py/sqlparse-0.1.19/docs/source/indices.rst D shell/ext-py/sqlparse-0.1.19/docs/source/intro.rst D shell/ext-py/sqlparse-0.1.19/docs/source/ui.rst D shell/ext-py/sqlparse-0.1.19/docs/sqlformat.1 D shell/ext-py/sqlparse-0.1.19/pytest.ini D shell/ext-py/sqlparse-0.1.19/setup.py D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/__init__.py D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/filter.py D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/grouping.py D shell/ext-py/sqlparse-0.1.19/sqlparse/exceptions.py D shell/ext-py/sqlparse-0.1.19/sqlparse/filters.py D shell/ext-py/sqlparse-0.1.19/sqlparse/formatter.py D shell/ext-py/sqlparse-0.1.19/sqlparse/functions.py D shell/ext-py/sqlparse-0.1.19/sqlparse/keywords.py D shell/ext-py/sqlparse-0.1.19/sqlparse/lexer.py D shell/ext-py/sqlparse-0.1.19/sqlparse/pipeline.py D shell/ext-py/sqlparse-0.1.19/sqlparse/sql.py D shell/ext-py/sqlparse-0.1.19/sqlparse/tokens.py D shell/ext-py/sqlparse-0.1.19/sqlparse/utils.py D shell/ext-py/sqlparse-0.1.19/tests/test_filters.py D shell/ext-py/sqlparse-0.1.19/tests/test_format.py D shell/ext-py/sqlparse-0.1.19/tests/test_functions.py D shell/ext-py/sqlparse-0.1.19/tests/test_grouping.py D shell/ext-py/sqlparse-0.1.19/tests/test_parse.py D shell/ext-py/sqlparse-0.1.19/tests/test_pipeline.py D shell/ext-py/sqlparse-0.1.19/tests/test_regressions.py D shell/ext-py/sqlparse-0.1.19/tests/test_split.py D shell/ext-py/sqlparse-0.1.19/tests/test_tokenize.py D shell/ext-py/sqlparse-0.1.19/tests/utils.py D shell/ext-py/sqlparse-0.1.19/tox.ini A shell/ext-py/sqlparse-0.3.1/AUTHORS A shell/ext-py/sqlparse-0.3.1/CHANGELOG R shell/ext-py/sqlparse-0.3.1/LICENSE R shell/ext-py/sqlparse-0.3.1/MANIFEST.in A shell/ext-py/sqlparse-0.3.1/README.rst R shell/ext-py/sqlparse-0.3.1/TODO A shell/ext-py/sqlparse-0.3.1/setup.cfg A shell/ext-py/sqlparse-0.3.1/setup.py R shell/ext-py/sqlparse-0.3.1/sqlparse/__init__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/__main__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/cli.py A shell/ext-py/sqlparse-0.3.1/sqlparse/compat.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/__init__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/filter_stack.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/grouping.py A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/statement_splitter.py A shell/ext-py/sqlparse-0.3.1/sqlparse/exceptions.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/__init__.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/aligned_indent.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/others.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/output.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/reindent.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/right_margin.py A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/tokens.py A shell/ext-py/sqlparse-0.3.1/sqlparse/formatter.py A shell/ext-py/sqlparse-0.3.1/sqlparse/keywords.py A shell/ext-py/sqlparse-0.3.1/sqlparse/lexer.py A shell/ext-py/sqlparse-0.3.1/sqlparse/sql.py A shell/ext-py/sqlparse-0.3.1/sqlparse/tokens.py A shell/ext-py/sqlparse-0.3.1/sqlparse/utils.py R shell/ext-py/sqlparse-0.3.1/tests/__init__.py A shell/ext-py/sqlparse-0.3.1/tests/conftest.py R shell/ext-py/sqlparse-0.3.1/tests/files/_Make_DirEntry.sql R shell/ext-py/sqlparse-0.3.1/tests/files/begintag.sql R shell/ext-py/sqlparse-0.3.1/tests/files/begintag_2.sql R shell/ext-py/sqlparse-0.3.1/tests/files/dashcomment.sql A shell/ext-py/sqlparse-0.3.1/tests/files/encoding_gbk.sql A shell/ext-py/sqlparse-0.3.1/tests/files/encoding_utf8.sql R shell/ext-py/sqlparse-0.3.1/tests/files/function.sql R shell/ext-py/sqlparse-0.3.1/tests/files/function_psql.sql R shell/ext-py/sqlparse-0.3.1/tests/files/function_psql2.sql R shell/ext-py/sqlparse-0.3.1/tests/files/function_psql3.sql A shell/ext-py/sqlparse-0.3.1/tests/files/function_psql4.sql R shell/ext-py/sqlparse-0.3.1/tests/files/huge_select.sql A shell/ext-py/sqlparse-0.3.1/tests/files/stream.sql R
[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5713/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f368fa9b50e22ec5057d0bf66c3fd51064d4c26 Gerrit-Change-Number: 15653 Gerrit-PatchSet: 3 Gerrit-Owner: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 02:28:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15653 to look at the new patch set (#3). Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. IMPALA-9602: Fix case-sensitivity for local catalog This patch makes the database and table names lower-case when doing lookups, insertion and invalidations of database objects or table objects in the local catalog cache. The remote catalog already does the right thing by lower-casing these names, so this patch makes the behavior consistent with what the remote catalog does. Testing: - Added unit tests for CatalogdMetaProvider by examining cache hits and misses when loading and invalidating database or tables with upper-case names. - Manually tested as follows: start Impala with local catalog enabled start-impala-cluster.py --catalogd_args="--catalog_topic_mode=minimal" --impalad_args="--use_local_catalog=true" Create database in lower-case: "CREATE DATABASE db1;" Run the following a few times (this errors without the patch): impala-shell.sh -q "DROP TABLE IF EXISTS DB1.ddl_test1 PURGE; CREATE TABLE DB1.ddl_test1 (val string);" Change-Id: I3f368fa9b50e22ec5057d0bf66c3fd51064d4c26 --- M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java 2 files changed, 65 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/15653/3 -- To view, visit http://gerrit.cloudera.org:8080/15653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f368fa9b50e22ec5057d0bf66c3fd51064d4c26 Gerrit-Change-Number: 15653 Gerrit-PatchSet: 3 Gerrit-Owner: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Aman Sinha has posted comments on this change. (
http://gerrit.cloudera.org:8080/15654 )
Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column
masking
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1493
PS3, Line 1493: if (node instanceof JoinNode) {
It would be useful to tag the JoinNode with some special marker that it is
somehow involved with the mask view and check it here .. just so we don't do
unnecessary work for all the JoinNode instances in the plan that are not
pertinent to the view.
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java
File fe/src/main/java/org/apache/impala/planner/JoinNode.java:
http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java@224
PS3, Line 224: for (TupleDescriptor tuple :
analyzer.materializeSlots(conjuncts_)) {
Would this loop be penalizing joins in the normal case ? i.e if there is no
column masking or even with column masking, there's no nested columns involved,
wouldn't this try to recompute mem layout for the tuples involved in the join
conjuncts ? The comment above does mention that 'only tuples of the masked
tables could be affected..' but is there a more explicit way to identify that ?
--
To view, visit http://gerrit.cloudera.org:8080/15654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3
Gerrit-Change-Number: 15654
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang
Gerrit-Reviewer: Aman Sinha
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Comment-Date: Tue, 07 Apr 2020 01:11:53 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5712/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 Gerrit-Change-Number: 15654 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 07 Apr 2020 00:49:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Hello Fang-Yu Rao, Vihang Karajgaonkar, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15654 to look at the new patch set (#3). Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. IMPALA-9529: Fix multi-tuple predicates not assigned in column masking Column masking is implemented by replacing the masked table with a table masking view which has masked expressions in its SelectList. However, nested columns can't be exposed in the SelectList, so we expose them in the output field of the view in IMPALA-9330. As a result, predicates that reference both primitive and nested columns of the masked table become multi-tuple predicates (referencing tuples of the view and the masked table). Such kinds of predicates are not assigned since they no longer bound to the view's tuple or the masked table's tuple. We need to pick up the masked table's tuple id when getting unassigned predicates for the table masking view. Also need to do this for assigning predicates to the JoinNode which is the only place that introduces multi-tuple predicates. Tests: - Add tests with multi-tuple predicates referencing nested columns. - Run CORE tests. Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java M fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java M fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java M fe/src/main/java/org/apache/impala/analysis/TableRef.java M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java M fe/src/main/java/org/apache/impala/planner/JoinNode.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test 10 files changed, 366 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/15654/3 -- To view, visit http://gerrit.cloudera.org:8080/15654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 Gerrit-Change-Number: 15654 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 2506706
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15668 ) Change subject: Bump up CDP_BUILD_NUMBER to 2506706 .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5711/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f3a989ccd076776615605674f046ccdd7d0dfc2 Gerrit-Change-Number: 15668 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 07 Apr 2020 00:03:01 + Gerrit-HasComments: No
[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 2506706
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15668 Change subject: Bump up CDP_BUILD_NUMBER to 2506706 .. Bump up CDP_BUILD_NUMBER to 2506706 This change bumps up the CDP_BUILD_NUMBER to 2506706. The new CDP build includes a fix on Hive side (HIVE-23018) which is needed for improving the INSERT event support in Catalog. Testing [WIP]: 1. Running core tests for with USE_CDP_HIVE=true. Change-Id: I4f3a989ccd076776615605674f046ccdd7d0dfc2 --- M bin/impala-config.sh 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/15668/1 -- To view, visit http://gerrit.cloudera.org:8080/15668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4f3a989ccd076776615605674f046ccdd7d0dfc2 Gerrit-Change-Number: 15668 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-5746: Test case for remote fragments releasing memory
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15666 ) Change subject: IMPALA-5746: Test case for remote fragments releasing memory .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5710/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9fe8309f80f797d205b756ba58219f595aba4e5 Gerrit-Change-Number: 15666 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Mon, 06 Apr 2020 22:36:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5746: Test case for remote fragments releasing memory
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15666 Change subject: IMPALA-5746: Test case for remote fragments releasing memory .. IMPALA-5746: Test case for remote fragments releasing memory Adds a test case for the scenario described in IMPALA-5746. Tests that if a coordinator is running queries, and that coordinator is killed, all remote fragments are cancelled and release any memory they are holding on to. Testing: * Ran the new test several times locally Change-Id: If9fe8309f80f797d205b756ba58219f595aba4e5 --- M tests/custom_cluster/test_restart_services.py 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/15666/1 -- To view, visit http://gerrit.cloudera.org:8080/15666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If9fe8309f80f797d205b756ba58219f595aba4e5 Gerrit-Change-Number: 15666 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar
[Impala-ASF-CR] IMPALA-9422: Re-visit and improve join node and builder's counters
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15663 ) Change subject: IMPALA-9422: Re-visit and improve join node and builder's counters .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5709/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I604075a2c8efcff26705fb39672f29f309b2ed97 Gerrit-Change-Number: 15663 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Apr 2020 21:43:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9422: Re-visit and improve join node and builder's counters
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15663 Change subject: IMPALA-9422: Re-visit and improve join node and builder's counters .. IMPALA-9422: Re-visit and improve join node and builder's counters This patch makes the following changes: - All code executed inside the builder that gets executed exactly once during query execution is attributed to the builder. This also include public calls to the builder that are used as synchronization points for shared builds. The serial execution phase in these methods are always executed once regardless of the builder execution mode (namely single-threaded, parallel execution, separate build sink). - Also makes sure there is no double counting of total time in builder. - BuildTime counter has been removed from the join node's profile in favor of the builder's total time. - BuildRowsPartitioned from the builder is equivalent to BuildRows in the join node and hence that counter has been moved to the builders. An example of the new profiles: HASH_JOIN_NODE (id=2):(Total: 29s994ms, non-child: 0.000ns, % non-child: 0.00%) - PeakMemoryUsage: 512.09 MB (536969472) - ProbeRows: 2.00M (2000405) - ProbeRowsPartitioned: 0 (0) - ProbeTime: 348.899ms - RowsReturned: 2.00M (2000405) - RowsReturnedRate: 66.69 K/sec Buffer pool: - AllocTime: 3.290ms - CompressionTime: 0.000ns - CumulativeAllocationBytes: 512.00 MB (536870912) - CumulativeAllocations: 240 (240) - EncryptionTime: 0.000ns - PeakReservation: 512.00 MB (536870912) - PeakUnpinnedBytes: 0 - PeakUsedReservation: 512.00 MB (536870912) - ReadIoBytes: 0 - ReadIoOps: 0 (0) - ReadIoWaitTime: 0.000ns - SystemAllocTime: 2.955ms - WriteIoBytes: 0 - WriteIoOps: 0 (0) - WriteIoWaitTime: 0.000ns Hash Join Builder (join_node_id=2):(Total: 1s873ms, non-child: 0.000ns, % non-child: 0.00%) - BuildRows: 2.00M (2000405) - BuildRowsPartitionTime: 1s222ms - HashTablesBuildTime: 647.959ms - LargestPartitionPercent: 6 (6) - MaxPartitionLevel: 0 (0) - NumHashTableBuildsSkipped: 0 (0) - NumRepartitions: 0 (0) - PartitionsCreated: 16 (16) - PeakMemoryUsage: 44.12 KB (45184) - RepartitionTime: 0.000ns - SpilledPartitions: 0 (0) Hash Table: - HashBuckets: 4.19M (4194304) - HashCollisions: 898 (898) - Probes: 4.00M (4000810) - Resizes: 0 (0) - Travel: 1.61M (1607615) NESTED_LOOP_JOIN_NODE (id=3):(Total: 2s042ms, non-child: 0.000ns, % non-child: 0.00%) ExecOption: Join Build-Side Prepared Asynchronously Node Lifecycle Event Timeline: 2s326ms - Open Started: 266.030ms (266.030ms) - Open Finished: 2s160ms (1s894ms) - First Batch Requested: 2s160ms (4.652us) - First Batch Returned: 2s161ms (513.662us) - Last Batch Returned: 2s324ms (163.194ms) - Closed: 2s326ms (2.685ms) - PeakMemoryUsage: 51.75 MB (54263808) - ProbeRows: 3 (3) - ProbeTime: 0.000ns - RowsReturned: 301.15K (301146) - RowsReturnedRate: 147.45 K/sec Nested Loop Join Builder:(Total: 486.669ms, non-child: 0.000ns, % non-child: 0.00%) - BuildRows: 100.38K (100382) - PeakMemoryUsage: 51.72 MB (54235136) Change-Id: I604075a2c8efcff26705fb39672f29f309b2ed97 --- M be/src/exec/blocking-join-node.cc M be/src/exec/blocking-join-node.h M be/src/exec/join-builder.h M be/src/exec/nested-loop-join-builder.cc M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h M be/src/exec/partitioned-hash-join-node.cc 7 files changed, 99 insertions(+), 83 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/15663/1 -- To view, visit http://gerrit.cloudera.org:8080/15663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I604075a2c8efcff26705fb39672f29f309b2ed97 Gerrit-Change-Number: 15663 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 6: I need to take another pass over this, will try to get to this afternoon -- To view, visit http://gerrit.cloudera.org:8080/15524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb004d352fe230a890a6b6356496ba76c2fab615 Gerrit-Change-Number: 15524 Gerrit-PatchSet: 6 Gerrit-Owner: David Knupp Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Apr 2020 20:29:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.
Sahil Takiar has posted comments on this change. (
http://gerrit.cloudera.org:8080/15524 )
Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with
python 3.
..
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/15524/6/bin/impala-shell.sh
File bin/impala-shell.sh:
http://gerrit.cloudera.org:8080/#/c/15524/6/bin/impala-shell.sh@27
PS6, Line 27: USE_THRIFT11_GEN_PY
who sets this? the user?
http://gerrit.cloudera.org:8080/#/c/15524/6/shell/packaging/requirements.txt
File shell/packaging/requirements.txt:
http://gerrit.cloudera.org:8080/#/c/15524/6/shell/packaging/requirements.txt@8
PS6, Line 8: thrift==0.11.0
a bit confused about the version of Thrift being used. after this patch, will
impala-shell always use thrift 11, regardless of whether it runs on Python 2 or
3? some of the changes in bin/impala-shell.sh seems to indicate there is a way
to switch between using the thrift 11 vs thrift 9 code?
http://gerrit.cloudera.org:8080/#/c/15524/6/shell/shell_output.py
File shell/shell_output.py:
http://gerrit.cloudera.org:8080/#/c/15524/6/shell/shell_output.py@101
PS6, Line 101: with open(self.filename, 'ab') as out_file:
this seems to change the logic so that it opens and closed the file during each
call to write, whereas the previous logic would just open the file once and
then close it when the object is deleted. what's the reason for changing the
logic?
http://gerrit.cloudera.org:8080/#/c/15524/6/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:
http://gerrit.cloudera.org:8080/#/c/15524/6/tests/shell/test_shell_commandline.py@472
PS6, Line 472: # args = ['-q', "select '{0}'".format(RUSSIAN_CHARS)]
delete?
--
To view, visit http://gerrit.cloudera.org:8080/15524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb004d352fe230a890a6b6356496ba76c2fab615
Gerrit-Change-Number: 15524
Gerrit-PatchSet: 6
Gerrit-Owner: David Knupp
Gerrit-Reviewer: Abhishek Rawat
Gerrit-Reviewer: David Knupp
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sahil Takiar
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Mon, 06 Apr 2020 17:50:51 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 11: Patch Set 11 add improvement for insertion into Robin-Hood hash table. If an insertion target a bucket that is an empty, do insertion in-place, bypassing temporary bucket and swap routine. This reduce unnecessary number of bucket swaps. Based on Patch Set 11, I have run initial performance measurement against TPC-DS with scale 60 GB over 3 nodes. The baseline is TPC-DS under quadratic probing hash table. Among 91 queries, 34 queries perform better in Robin-Hood than Quadratic, 57 others show degradation. The breakdown are the following: - 1 query improve by 18.69% - 3 queries improve between 11.29% to 14.21% - 8 queries improve between 5.90% to 9.93% - 22 queries improve between 0.02% to 4.14% - 42 queries degrade 0% to -4.86% - 8 queries degrade between -5.51% to -8.50% - 6 queries degrade between -10.49% to -14.89% - 1 queries degrade between -23.50% The improvement and degradations mostly still within tens and hundreds of miliseconds, so I suspect larger test scale will be more representative. Meanwhile, I will study the query profile from my runs and look if we can find some explanation about this result. -- To view, visit http://gerrit.cloudera.org:8080/15511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28eeccd7f9ccae39e31972391f971901bcbfe986 Gerrit-Change-Number: 15511 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: David Rorke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Apr 2020 17:31:09 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 11: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5708/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28eeccd7f9ccae39e31972391f971901bcbfe986 Gerrit-Change-Number: 15511 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: David Rorke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Apr 2020 17:25:53 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#11). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. WIP IMPALA-9434: Implement Robin Hood Hash Table. Robin hood hashing reduces the variances of probe lengths by continually rebalancing elements. This patch is the first step towards full robin hood hash table implementation by doing bucket rebalancing after every insert. If a hash table is configured as a robin hood hash table, the new element insertion will be buffered in a temporary bucket. This temporary bucket will then matched against existing bucket elements, swapped with a "rich" bucket, and continue doing so until it swap with an empty bucket. The PSL (probe sequence length) invariant is maintained in robin hood hash table. This allow us to add short-circuit in the Probe function to immediately returns when it finds out that the PSL of currently visited bucket is smaller/richer than the key that is being looked up, indicating that the key does not exist in the table. Instead of continue probing until next empty bucket is found, Probe can immediately the return the index of recently visited richer bucket to caller along with the not found flag. In turn, the caller use this returned index to specify in which index the new element should be inserted to. Testing: - Add backend test for Robin Hood hash table in hash-table-test.cc - Pass core tests Change-Id: I28eeccd7f9ccae39e31972391f971901bcbfe986 --- M be/src/benchmarks/CMakeLists.txt A be/src/benchmarks/hash-table-benchmark.cc M be/src/exec/grouping-aggregator.cc M be/src/exec/hash-table-test.cc M be/src/exec/hash-table.cc M be/src/exec/hash-table.h M be/src/exec/hash-table.inline.h M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-node.cc M be/src/exprs/scalar-expr.h 10 files changed, 793 insertions(+), 84 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/15511/11 -- To view, visit http://gerrit.cloudera.org:8080/15511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I28eeccd7f9ccae39e31972391f971901bcbfe986 Gerrit-Change-Number: 15511 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: David Rorke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4faf46134f44d91e56748642f47d448707db53c Gerrit-Change-Number: 15345 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 06 Apr 2020 13:54:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5707/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 Gerrit-Change-Number: 15654 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 06 Apr 2020 12:48:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Hello Fang-Yu Rao, Vihang Karajgaonkar, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15654 to look at the new patch set (#2). Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. IMPALA-9529: Fix multi-tuple predicates not assigned in column masking Column masking is implemented by replacing the masked table with a table masking view which has masked expressions in its SelectList. However, nested columns can't be exposed in the SelectList, so we expose them in the output field of the view in IMPALA-9330. As a result, predicates that reference both primitive and nested columns of the masked table become multi-tuple predicates (referencing tuples of the view and the masked table). Such kinds of predicates are not assigned since they no longer bound to the view's tuple or the masked table's tuple. We need to pick up the masked table's tuple id when getting unassigned predicates for the table masking view. Also need to do this for assigning predicates to the JoinNode which is the only place that introduces multi-tuple predicates. Tests: - Add tests with multi-tuple predicates referencing nested columns. - Run CORE tests. Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java M fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java M fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java M fe/src/main/java/org/apache/impala/analysis/TableRef.java M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java M fe/src/main/java/org/apache/impala/planner/JoinNode.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test 10 files changed, 365 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/15654/2 -- To view, visit http://gerrit.cloudera.org:8080/15654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 Gerrit-Change-Number: 15654 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/15654 )
Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column
masking
..
Patch Set 1:
(2 comments)
Thanks for your quick review, Csaba!
http://gerrit.cloudera.org:8080/#/c/15654/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java
File fe/src/main/java/org/apache/impala/planner/JoinNode.java:
http://gerrit.cloudera.org:8080/#/c/15654/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java@225
PS1, Line 225: used not
> rather "not used"?
Yes! Done.
http://gerrit.cloudera.org:8080/#/c/15654/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java@240
PS1, Line 240: for (TupleId tid : tblRefIds_) {
> Is it possible to move this logic to analyzer.getUnassignedConjuncts? Or t
Yeah, don't want to impact other kind of PlanNodes since only the query block
of joins can have multi-tuple predicates. But I agree to move these logics into
Analyzer which looks more clean.
--
To view, visit http://gerrit.cloudera.org:8080/15654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3
Gerrit-Change-Number: 15654
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Comment-Date: Mon, 06 Apr 2020 12:05:13 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5612/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4faf46134f44d91e56748642f47d448707db53c Gerrit-Change-Number: 15345 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 06 Apr 2020 09:27:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5706/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4faf46134f44d91e56748642f47d448707db53c Gerrit-Change-Number: 15345 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 06 Apr 2020 09:21:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/15654 )
Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column
masking
..
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15654/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java
File fe/src/main/java/org/apache/impala/planner/JoinNode.java:
http://gerrit.cloudera.org:8080/#/c/15654/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java@225
PS1, Line 225: used not
rather "not used"?
http://gerrit.cloudera.org:8080/#/c/15654/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java@240
PS1, Line 240: for (TupleId tid : tblRefIds_) {
Is it possible to move this logic to analyzer.getUnassignedConjuncts? Or that
would have side-effects in other nodes?
--
To view, visit http://gerrit.cloudera.org:8080/15654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3
Gerrit-Change-Number: 15654
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Comment-Date: Mon, 06 Apr 2020 09:01:59 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks
Tamas Mate has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. IMPALA-9398: Fix shell history duplication when cmdloop breaks The duplication issue was due to calling the history file reading readline method multiple times during the lifetime of an ImpalaShell. Readline appends the content of the file after the already read history. History was read in the Cmd.preloop() method which is called every time when the Cmd.cmdloop() starts, the cmdloop() break and re-start could be triggered by an exception for example KeyboardInterrupt in this case. This change refactors the history file reading logic and moves it outside of the preloop() method. Testing: - The change was tested manually on local dev env - Added a new EE shell test to verify the history after SIGINT Change-Id: If4faf46134f44d91e56748642f47d448707db53c --- M shell/impala_shell.py M tests/shell/test_shell_interactive.py 2 files changed, 43 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/15345/4 -- To view, visit http://gerrit.cloudera.org:8080/15345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If4faf46134f44d91e56748642f47d448707db53c Gerrit-Change-Number: 15345 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 Gerrit-Change-Number: 15654 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 06 Apr 2020 06:49:17 + Gerrit-HasComments: No
