[Impala-ASF-CR] IMPALA-9990: Support SET OWNER for Kudu tables
Fang-Yu Rao has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16273 ) Change subject: IMPALA-9990: Support SET OWNER for Kudu tables .. IMPALA-9990: Support SET OWNER for Kudu tables KUDU-3090 adds the support for table ownership and exposes the API's of setting owner on creating and altering tables, which allows Impala to also pass to Kudu the new owner of the Kudu table for the ALTER TABLE SET OWNER statement. Specifically, based on the API of AlterTableOptions#setOwner(), this patch stores the ownership information of the Kudu table in the corresponding instance of AlterTableOptions, which will be passed to Kudu via a KuduClient. Testing: - Added a FE test in AnalyzeKuduDDLTest.java to verify the statement could be correctly analyzed. - Added an E2E test in kudu_alter.test to verify the statement could be correctly executed. - Added an E2E test in kudu_hms_alter.test and verified that the statement could be correctly executed after manually re-enabling TestKuduHMSIntegration::test_kudu_alter_table(). Note that this was not possible before IMPALA-10092 was resolved due to a bug in the class of CustomClusterTestSuite. In addition, we may need to delete the Kudu table 'simple' via a Kudu-Python client if the E2E test complains that the Kudu table already exists, which may be related to IMPALA-8751. - Verified that the patch could pass the exhaustive tests in the DEBUG mode. Change-Id: I29d641efc8db314964bc5ee9828a86d4a44ae95c --- M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test M testdata/workloads/functional-query/queries/QueryTest/kudu_hms_alter.test 5 files changed, 70 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/16273/2 -- To view, visit http://gerrit.cloudera.org:8080/16273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I29d641efc8db314964bc5ee9828a86d4a44ae95c Gerrit-Change-Number: 16273 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9990: Support SET OWNER for Kudu tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16273 ) Change subject: IMPALA-9990: Support SET OWNER for Kudu tables .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7474/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29d641efc8db314964bc5ee9828a86d4a44ae95c Gerrit-Change-Number: 16273 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Sun, 18 Oct 2020 23:44:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9974: Join elimination based on referential integrity.
Aman Sinha has posted comments on this change. (
http://gerrit.cloudera.org:8080/16182 )
Change subject: IMPALA-9974: Join elimination based on referential integrity.
..
Patch Set 4:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/16182/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16182/4//COMMIT_MSG@32
PS4, Line 32: - Q72 74.3s -> 24.8s
It seems q72 and q84 don't show up in the plan changes below .. are we tracking
those tests ? Also q82 plan diff doesn't show any join elimination. Perhaps
the fk-pk constraints defined in the performance run were different from the
constraints here.
http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/main/java/org/apache/impala/analysis/TableConstraintRewriter.java
File fe/src/main/java/org/apache/impala/analysis/TableConstraintRewriter.java:
http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/main/java/org/apache/impala/analysis/TableConstraintRewriter.java@53
PS4, Line 53: correlated
Is the code meant to handle correlated subqueries also ? The isRewriteable()
method below has a check 'if (!t.isCorrelated()' ..
http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/main/java/org/apache/impala/analysis/TableConstraintRewriter.java@154
PS4, Line 154: static Expr wrapWithIsNotNull(Expr slot, Expr whereExpr) {
In case one or more of these columns have an IS NOT NULL predicate already in
the original query, this will add an extra one. You could check whether the
slot is already not-nullable before adding.
http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/main/java/org/apache/impala/catalog/Column.java
File fe/src/main/java/org/apache/impala/catalog/Column.java:
http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/main/java/org/apache/impala/catalog/Column.java@47
PS4, Line 47: protected boolean isUnique_ = false;
It would be good to add a comment here or in the accessor method that the
uniqueness is derived from the primary key which is an Informational constraint
only (as opposed to an enforced UNIQUE constraint).
http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java:
http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@519
PS4, Line 519: //assertFalse(idCol.isNullable());
nit: remove
http://gerrit.cloudera.org:8080/#/c/16182/4/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@528
PS4, Line 528: //assertFalse(aCol.isNullable());
nit: remove
--
To view, visit http://gerrit.cloudera.org:8080/16182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd07d45e419175af7d62f6035ba51be841ebc074
Gerrit-Change-Number: 16182
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian
Gerrit-Reviewer: Aman Sinha
Gerrit-Reviewer: David Rorke
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Shant Hovsepian
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Mon, 19 Oct 2020 00:58:37 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10248: Fix test column storage attributes date string errors
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16608 Change subject: IMPALA-10248: Fix test_column_storage_attributes date string errors .. IMPALA-10248: Fix test_column_storage_attributes date string errors After IMPALA-10225 bumps the impyla version to 0.17a1, we should expect impyla return a datetime.date instead of a string for DATE type data. Tests: - Run test_column_storage_attributes with --exploration_strategy=exhaustive to verify the fix. Change-Id: I618a759a03213efc22a5e54e9a30fa09e8929023 --- M tests/query_test/test_kudu.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/16608/1 -- To view, visit http://gerrit.cloudera.org:8080/16608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I618a759a03213efc22a5e54e9a30fa09e8929023 Gerrit-Change-Number: 16608 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
[Impala-ASF-CR] IMPALA-10248: Fix test column storage attributes date string errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16608 ) Change subject: IMPALA-10248: Fix test_column_storage_attributes date string errors .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7475/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618a759a03213efc22a5e54e9a30fa09e8929023 Gerrit-Change-Number: 16608 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 19 Oct 2020 03:26:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10248: Fix test column storage attributes date string errors
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16608 ) Change subject: IMPALA-10248: Fix test_column_storage_attributes date string errors .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618a759a03213efc22a5e54e9a30fa09e8929023 Gerrit-Change-Number: 16608 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 19 Oct 2020 04:02:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10226: Change buildall.sh -notests to invoke a single Make target
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16605 ) Change subject: IMPALA-10226: Change buildall.sh -notests to invoke a single Make target .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id881d6f481b32ba82501b16bada14b6630ba32d2 Gerrit-Change-Number: 16605 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 19 Oct 2020 04:04:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10248: Fix test column storage attributes date string errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16608 ) Change subject: IMPALA-10248: Fix test_column_storage_attributes date string errors .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6580/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618a759a03213efc22a5e54e9a30fa09e8929023 Gerrit-Change-Number: 16608 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 19 Oct 2020 05:00:34 + Gerrit-HasComments: No
