[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7674/ -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Nov 2021 00:18:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10871: Add MetastoreShim to support Apache Hive 3.1.2
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17774 ) Change subject: IMPALA-10871: Add MetastoreShim to support Apache Hive 3.1.2 .. Patch Set 9: (3 comments) Thanks a lot for working on this. This is really very useful. I took a quick look and the approach makes sense to me. I will take a more detailed look again (possibly after Thanksgiving holidays). http://gerrit.cloudera.org:8080/#/c/17774/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsUtils.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsUtils.java: http://gerrit.cloudera.org:8080/#/c/17774/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsUtils.java@20 PS9, Line 20: CatalogHmsUtils can you add a class level comment to describe what goes into this file? Looks like this file is currently being used for constants which are specific the the HMS cache. http://gerrit.cloudera.org:8080/#/c/17774/9/testdata/bin/patch_hive.sh File testdata/bin/patch_hive.sh: http://gerrit.cloudera.org:8080/#/c/17774/9/testdata/bin/patch_hive.sh@20 PS9, Line 20: # This script fixes the bugs that occurred during the integration of Apache Hive 3. not sure I understand. Can you be more specific on the purpose of this file? http://gerrit.cloudera.org:8080/#/c/17774/9/testdata/cluster/hive/README File testdata/cluster/hive/README: http://gerrit.cloudera.org:8080/#/c/17774/9/testdata/cluster/hive/README@5 PS9, Line 5: Contains only patches for `hive_metastore.thrift` is used to solve the problem that the : generated cpp file cannot be compiled. do you mean that Hive 3.1's thrift file cannot generate compilable cpp code? That sounds like a bug to me and we should probably get it fixed in Hive source code as well. -- To view, visit http://gerrit.cloudera.org:8080/17774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f08db5f6da735ac431819063060941f0941f606 Gerrit-Change-Number: 17774 Gerrit-PatchSet: 9 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 24 Nov 2021 23:41:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18043 ) Change subject: IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18043/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18043/2//COMMIT_MSG@10 PS2, Line 10: After compaction happened in Hive(HIVE ACID table), queries made in : Impala possibly fail with a FileNotFoundException if files already : removed by the Hive cleaner. Can you confirm if Impala open's a transaction for select queries for ACID tables? My understanding is that this approach would only work as long as the select query opens a transaction so that a compaction which runs immediately after we check does not remove the files after we mark them as not stale. http://gerrit.cloudera.org:8080/#/c/18043/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/18043/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@898 PS2, Line 898: List stalePartitions = directProvider_.checkLatestCompaction( : refImpl.dbName_, refImpl.tableName_, refImpl, refToMeta); looks like this is going to be called during each query's compilation when the query references a ACID table. Do you have a rough estimate of how much overhead per query are we introducing here? http://gerrit.cloudera.org:8080/#/c/18043/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/18043/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@525 PS2, Line 525: /** :* Fetches the latest compaction id from HMS and compares with partition metadata in :* cache. If a partition is stale due to compaction, removes it from metas. :*/ please also mention what is it that this method returns. Looks like we are returning all the PartitionRef which are deemed to be stale due to compaction. -- To view, visit http://gerrit.cloudera.org:8080/18043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I173ea848917b6a41139b25b80677111463bfdc4b Gerrit-Change-Number: 18043 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Wen Lai Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sourabh Goyal Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yu-Wen Lai Gerrit-Comment-Date: Wed, 24 Nov 2021 20:00:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17981 ) Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public .. IMPALA-10954: Make create, drop methods of kudu catalog service public External frontend needs access to some private methods of kudu catalog service. Hence, they are made public here to add support for CREATE and DROP tables for Kudu from external frontend. Change-Id: Ib60142424d8e758031de596831d98aed69d488ef Reviewed-on: http://gerrit.cloudera.org:8080/17981 Reviewed-by: Impala Public Jenkins Tested-by: Aman Sinha Reviewed-by: Aman Sinha --- M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Aman Sinha: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef Gerrit-Change-Number: 17981 Gerrit-PatchSet: 6 Gerrit-Owner: Deepti Sehrawat Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Deepti Sehrawat Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 ) Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef Gerrit-Change-Number: 17981 Gerrit-PatchSet: 5 Gerrit-Owner: Deepti Sehrawat Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Deepti Sehrawat Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 19:44:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Aman Sinha has removed a vote on this change. Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/17981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef Gerrit-Change-Number: 17981 Gerrit-PatchSet: 5 Gerrit-Owner: Deepti Sehrawat Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Deepti Sehrawat Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 ) Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public .. Patch Set 5: Verified+1 The 2 Hbase test failures are due to flaky tests described in IMPALA-9161. -- To view, visit http://gerrit.cloudera.org:8080/17981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef Gerrit-Change-Number: 17981 Gerrit-PatchSet: 5 Gerrit-Owner: Deepti Sehrawat Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Deepti Sehrawat Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 19:43:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 17:27:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7674/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 17:27:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 33: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36364e401911352c474eb98c8d61bbaae9b9 Gerrit-Change-Number: 17859 Gerrit-PatchSet: 33 Gerrit-Owner: Sourabh Goyal Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sourabh Goyal Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yu-Wen Lai Gerrit-Comment-Date: Wed, 24 Nov 2021 17:19:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 32: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7672/ -- To view, visit http://gerrit.cloudera.org:8080/17859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36364e401911352c474eb98c8d61bbaae9b9 Gerrit-Change-Number: 17859 Gerrit-PatchSet: 32 Gerrit-Owner: Sourabh Goyal Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sourabh Goyal Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yu-Wen Lai Gerrit-Comment-Date: Wed, 24 Nov 2021 16:24:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupsMapping
Amogh Margoor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18019 ) Change subject: IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupsMapping .. IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupsMapping Currently, Impala doesn't support ShellBasedUnixGroupsMapping and ShellBasedUnixGroupsNetgroupMapping to fetch Hadoop groups as they spawn a new process and run shell command to fetch group info. In Impala, this would happen for every session being created when user delegation is enabled via impala.doas.user and authorized_proxy_group_config. It can have many gotcha's like spawning many processes together in a highly concurrent setting, creation of zombie processes on abrupt crashing of impalad etc. However, not everyone in ecosystem have moved away from shell based group mapping. For instance, in cloudera distribution many components still rely on it. So we need a way to allow users to use shell based mapping instead of not allowing it altogether. This patch provides flag which would allow the support for users that are aware about the gotchas it comes with. Change-Id: I023f396a79f3aa27ad6ac80e91f527058a5a5470 Reviewed-on: http://gerrit.cloudera.org:8080/18019 Reviewed-by: Zoltan Borok-Nagy Tested-by: Impala Public Jenkins --- M be/src/service/frontend.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M docs/topics/impala_delegation.xml M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/java/org/apache/impala/service/JniFrontend.java 6 files changed, 18 insertions(+), 2 deletions(-) Approvals: Zoltan Borok-Nagy: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/18019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I023f396a79f3aa27ad6ac80e91f527058a5a5470 Gerrit-Change-Number: 18019 Gerrit-PatchSet: 4 Gerrit-Owner: Amogh Margoor Gerrit-Reviewer: Amogh Margoor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 33: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9840/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36364e401911352c474eb98c8d61bbaae9b9 Gerrit-Change-Number: 17859 Gerrit-PatchSet: 33 Gerrit-Owner: Sourabh Goyal Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sourabh Goyal Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yu-Wen Lai Gerrit-Comment-Date: Wed, 24 Nov 2021 11:24:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection
Hello Vihang Karajgaonkar, kis...@cloudera.com, Yu-Wen Lai, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17859 to look at the new patch set (#33). Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. IMPALA-10926: Improve catalogd consistency and self events detection In the current design catalogd cache gets updated from 2 sources: 1. Impala shell 2. MetastoreEventProcessor The updates from the Impala shell are applied in place whereas MetastoreEventProcessor runs as a background thread, polls HMS events and apply them asynchronously. These two stream of updates cause consistency issues. For example consider a following sequence of alter table events on a table t1 as per HMS: 1. alter table t1 from source s1 say other Impala cluster 2. alter table t1 from source s2 say other Hive cluster 3. alter table t1 from local Impala cluster The #3 alter table ddl operation would get reflected in the local cache immediately. However, later on event processor would process events from #1 and #2 above and try to alter the table. In an ideal scenario, these alters should have been applied before #3 i.e in the same order as they appear in HMS notification log. This leaves table t1 in an inconsistent state. Proposed solution: The main idea of the solution is to keep track of the last event id for a given table as eventId which the catalogd has synced to in the Table object. The events processor ignores any event whose EVENT_ID is less than or equal to the eventId stored in the table. Once the events processor successfully processes a given event, it updates the value of eventId in the table before releasing the table lock. Also, any DDL or refresh operation on the catalogd (from both catalog HMS endpoint and Impala shell) will follow the following steps to update the event id for the table: 1. Acquire write lock on the table 2. Perform ddl operation in HMS 3. Sync table till the latest event id (as per HMS) since its last synced event id The above steps ensure that any concurrent updates applied on a same db/table from multiple sources like Hive, Impala or say multiple Impala clusters, get reflected in the local catalogd cache (in the same order as they appear in HMS) thus removing any inconsistencies. Also the solution relies on the existing locking mechanism in the catalogd to prevent any other concurrent updates to the table (even via EventsProcessor). In case of database objects, we will also have a similar eventId which represents the events on the database object (CREATE, DROP, ALTER database) to which the catalogd as synced to. This patch addresses the following: 1. Add a new flag enable_sync_to_latest_event_on_ddls to enable/disable this improvement. It is turned off by default. 2. If flag in #1 is enabled then apart from Impala shell and MetastoreEventProcessor the cache would also get updated for ddls executed via catalog HMS endpoints. While excuting a ddl, db/table will be synced till latest event id. 3. Event processor skips processing an event if db/table is already synced till that event id. Sets that event id in db/table if the event is processed. 4. When EventProcessor detects a self event, it sets the last synced event id in db/table before skipping the processing of an event. 5. Full table refresh sets the last event processed in table cache. Future Work: 1. Sync db/table to latest event id for ddls executed from Impala shell (execDdlRequest() in catalogOpExecutor) Testing: 1. Added new unit tests and modified existing ones 2. Ran exhaustive tests with flag both turned on and off Change-Id: I36364e401911352c474eb98c8d61bbaae9b9 --- M be/src/catalog/catalog-server.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/catalog/TableLoader.java M fe/src/main/java/org/apache/impala/catalog/events/EventFactory.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/main/java/org/apache/impala/catalog/events/NoOpEventProcessor.java M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java M fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java A
[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 33: (1 comment) http://gerrit.cloudera.org:8080/#/c/17859/33/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17859/33/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1299 PS33, Line 1299: MetastoreEventsProcessor.getNextMetastoreEventsInBatches(catalog_, currentEventId, line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36364e401911352c474eb98c8d61bbaae9b9 Gerrit-Change-Number: 17859 Gerrit-PatchSet: 33 Gerrit-Owner: Sourabh Goyal Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sourabh Goyal Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yu-Wen Lai Gerrit-Comment-Date: Wed, 24 Nov 2021 11:03:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 33: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7673/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/17859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36364e401911352c474eb98c8d61bbaae9b9 Gerrit-Change-Number: 17859 Gerrit-PatchSet: 33 Gerrit-Owner: Sourabh Goyal Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sourabh Goyal Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yu-Wen Lai Gerrit-Comment-Date: Wed, 24 Nov 2021 11:02:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 32: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7672/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/17859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36364e401911352c474eb98c8d61bbaae9b9 Gerrit-Change-Number: 17859 Gerrit-PatchSet: 32 Gerrit-Owner: Sourabh Goyal Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sourabh Goyal Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yu-Wen Lai Gerrit-Comment-Date: Wed, 24 Nov 2021 10:06:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7671/ -- To view, visit http://gerrit.cloudera.org:8080/18048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c4070a4a2d5ad9decb186a9219957d8c26a7d7 Gerrit-Change-Number: 18048 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 10:05:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 ) Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7670/ -- To view, visit http://gerrit.cloudera.org:8080/17981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef Gerrit-Change-Number: 17981 Gerrit-PatchSet: 5 Gerrit-Owner: Deepti Sehrawat Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Deepti Sehrawat Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 24 Nov 2021 08:18:25 + Gerrit-HasComments: No
