[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in
exhaustive build
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/18299/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18299/1//COMMIT_MSG@9
PS1, Line 9: The test was getting skipped as it was not in exhaustive strategy,
to fix that its
: been moved to TestHmsIntegrationSanity(ImpalaTestSuite) class. Now
there are two tests,
: test_desc_json_tbl and test_desc_json_tbl_hive to check whether
tables created in
: impala can be described in hive and vice versa.
nit: please fix the width to be 72.
http://gerrit.cloudera.org:8080/#/c/18299/1//COMMIT_MSG@13
PS1, Line 13: the below commands:
: impala-py.test --exploration=exhaustive
:
tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl
: impala-py.test --exploration=exhaustive
:
tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl_hive
nit: don't need to add these
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@108
PS1, Line 108: tables
nit: JSON tables
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@109
PS1, Line 109: unique_table_impala
nit: we can use a simpler table name, e.g. just as "json_tbl", and using it
directly in the string.
self.client.execute("create table {0}.json_tbl (x int) stored as jsonfile"
.format(unique_database))
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@116
PS1, Line 116: tables
nit: JSON tables
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@117
PS1, Line 117: unique_table_hive
nit: I'd prefer a simpler table name and use it directly in the string. E.g.
self.run_stmt_in_hive("create table {0}.json_tbl (x int) stored as jsonfile"
.format(unique_database))
self.client.execute("INVALIDATE METADATA
{0}.json_tbl".format(unique_database))
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Thu, 10 Mar 2022 06:35:49 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Thu, 10 Mar 2022 04:14:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 22: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7922/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75cf17290be2c64fd4b732a5505bdac31869712a Gerrit-Change-Number: 18178 Gerrit-PatchSet: 22 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 10 Mar 2022 03:25:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 21: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7920/ -- To view, visit http://gerrit.cloudera.org:8080/18178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75cf17290be2c64fd4b732a5505bdac31869712a Gerrit-Change-Number: 18178 Gerrit-PatchSet: 21 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 10 Mar 2022 01:48:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11110: Switch debug builds to use -Og
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18200 ) Change subject: IMPALA-0: Switch debug builds to use -Og .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7921/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c149c8181c90572b8668bd01dfd26c0a5971e Gerrit-Change-Number: 18200 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 09 Mar 2022 23:39:27 + Gerrit-HasComments: No
[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 ) Change subject: Bump up CDP_BUILD_NUMBER to 23144489 .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10274/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27 Gerrit-Change-Number: 18296 Gerrit-PatchSet: 5 Gerrit-Owner: Yu-Wen Lai Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Wed, 09 Mar 2022 17:29:36 + Gerrit-HasComments: No
[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489
Yu-Wen Lai has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18296 ) Change subject: Bump up CDP_BUILD_NUMBER to 23144489 .. Bump up CDP_BUILD_NUMBER to 23144489 This patch is to include HIVE-25753, which is needed to improve the performance of retrieving the latest committed compaction for a table. Besides, we also need to fix ClassCastException after SerializableTable is added to iceberg. Since BaseTable is always transformed to SerializableTable for serialization, we cannot restore BaseTable after deserializing it. Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27 --- M bin/impala-config.sh M common/thrift/CatalogObjects.thrift M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java M fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java M fe/src/main/java/org/apache/impala/util/IcebergUtil.java M testdata/workloads/functional-planner/queries/PlannerTest/joins.test M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test 10 files changed, 68 insertions(+), 58 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18296/5 -- To view, visit http://gerrit.cloudera.org:8080/18296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27 Gerrit-Change-Number: 18296 Gerrit-PatchSet: 5 Gerrit-Owner: Yu-Wen Lai Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate
[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 21: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10273/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75cf17290be2c64fd4b732a5505bdac31869712a Gerrit-Change-Number: 18178 Gerrit-PatchSet: 21 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 09 Mar 2022 16:06:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 21: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7920/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75cf17290be2c64fd4b732a5505bdac31869712a Gerrit-Change-Number: 18178 Gerrit-PatchSet: 21 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 09 Mar 2022 15:48:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/18178/20/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/18178/20/fe/src/main/java/org/apache/impala/service/Frontend.java@1805 PS20, Line 1805: } > Should this group have a name? Yeah. It needs one to work with the scheduler in this corner case. Done. -- To view, visit http://gerrit.cloudera.org:8080/18178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75cf17290be2c64fd4b732a5505bdac31869712a Gerrit-Change-Number: 18178 Gerrit-PatchSet: 21 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 09 Mar 2022 15:46:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory
Qifan Chen has uploaded a new patch set (#21). ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. IMPALA-10992 Planner changes for estimate peak memory This patch provides replan support for multiple executor group sets. Each executor group set is associated with a distinct number of nodes and a threshold for estimated memory per host in bytes that can be denoted as [:<#nodes>, ]. In the patch, a query of type EXPLAIN, QUERY or DML can be compiled more than once. In each attempt, per host memory is estimated and compared with the threshold of an executor group set. If the estimated memory is no more than the threshold, the iteration process terminates and the final plan is determined. The executor group set with the threshold is selected to run the query. A new query option 'enable_replan', default to 1 (enabled), is added. It can be set to 0 to disable this patch and to generate the distributed plan for the default executor group. To avoid long compilation time, the following enhancement is enabled. Note 1) and 2) can be disabled when relevant meta-data change is detected. 1. Authorization is performed only for the 1st compilation; 2. The needed meta-data is fetched into a StmtTableCache in 1st compilation and reused in subsequent compilations; 3. openTransaction() is called for transactional queries in 1st compilation and the saved transactional info is used in subsequent compilations. Similar logic is applied to Kudu transactional queries. To facilitate testing, the patch imposes an artificial two executor group setup in FE as follows. 1. [regular:<#nodes>, 64MB] 2. [large:<#nodes>, 8PB] This setup is enabled when a new query option 'test_replan' is set to 1 in backend tests, or RuntimeEnv.INSTANCE.isTestEnv() is true as in most frontend tests. This query option is set to 0 by default. Compilation time increases when a query is compiled in several iterations, as shown below for several TPCDs queries. The increase is mostly due to redundant work in either single node plan creation or recomputing value transfer graph phase. For small queries, the increase can be avoided if they can be compiled in single iteration by properly setting the smallest threshold among all executor group sets. For example, for the set of queries listed below, the smallest threshold can be set to 320MB to catch both q15 and q21 in one compilation. Compilation time (ms) Queries Estimated Memory 2-iterations 1-iteration Percentage of increase q1 408MB 18.32 13.0140.81% q11 1.37GB 186.17 86.28 115.77% q10a 519MB 108.27 53.58 102.07% q13339MB 118.03 82.4343.19% q14a 3.56GB 628.27307.24 104.49% q14b 2.20GB 518.79239.05 117.02% q15314MB 13.12 4.51 190.91% q21275MB 11.04 6.3474.13% q23a 1.34GB 458.7227.62 101.52% q23b 1.50GB 471.29224.75 109.70% q42.60GB 206.34 98.64 109.18% q67 5.16GB 691.45336.31 105.60% Testing: 1. Almost all FE and BE tests are now run in the artificial two executor setup except a few where a specific cluster configuration is desirable; 2. Ran core tests successfully; 3. Added a new observability test and a new query assignment test. Change-Id: I75cf17290be2c64fd4b732a5505bdac31869712a --- M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M common/thrift/ImpalaService.thrift M common/thrift/Query.thrift M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/util/ClassUtil.java M fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java M fe/src/test/java/org/apache/impala/planner/ClusterSizeTest.java A fe/src/test/resources/fair-scheduler-2-groups.xml A fe/src/test/resources/llama-site-2-groups.xml M tests/common/test_dimensions.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_coordinators.py M tests/custom_cluster/test_executor_groups.py M tests/query_test/test_observability.py 22 files changed, 655 insertions(+), 69 deletions
[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 ) Change subject: IMPALA-11038: Zipping unnest from view .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10272/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68f649dda9e41f257e7f6596193d07b24049f92a Gerrit-Change-Number: 18094 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 09 Mar 2022 13:18:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18094 to look at the new patch set (#5). Change subject: IMPALA-11038: Zipping unnest from view .. IMPALA-11038: Zipping unnest from view IMPALA-10920 introduced zipping unnest functionality for arrays that are in a table. This patch improves that support further by accepting inputs from views as well. Testing: - Added planner tests to verify which execution node handles the predicates on unnested items. - E2E tests for both unnesting syntaxes (select list and from clause) to cover when the source of the unnested arrays is not a table but a view. Also tested multi-level views and filtering the unnested items on different levels. Change-Id: I68f649dda9e41f257e7f6596193d07b24049f92a --- M be/src/exec/subplan-node.cc M be/src/exec/unnest-node.cc M be/src/exec/unnest-node.h M common/thrift/PlanNodes.thrift M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java M fe/src/main/java/org/apache/impala/analysis/FromClause.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/SlotRef.java M fe/src/main/java/org/apache/impala/analysis/TableRef.java M fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/PlanNode.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/main/java/org/apache/impala/planner/SingularRowSrcNode.java M fe/src/main/java/org/apache/impala/planner/UnnestNode.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test M testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-from-view.test M testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-select-list.test 20 files changed, 1,035 insertions(+), 65 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/18094/5 -- To view, visit http://gerrit.cloudera.org:8080/18094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I68f649dda9e41f257e7f6596193d07b24049f92a Gerrit-Change-Number: 18094 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 ) Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10271/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18299 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1 Gerrit-Change-Number: 18299 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 09 Mar 2022 12:44:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 ) Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@112 PS1, Line 112: e flake8: E501 line too long (110 > 90 characters) http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@113 PS1, Line 113: flake8: E501 line too long (138 > 90 characters) http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@122 PS1, Line 122: b flake8: E501 line too long (115 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/18299 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1 Gerrit-Change-Number: 18299 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 09 Mar 2022 12:26:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
pranav.lo...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18299 Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build .. IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build The test was getting skipped as it was not in exhaustive strategy, to fix that its been moved to TestHmsIntegrationSanity(ImpalaTestSuite) class. Now there are two tests, test_desc_json_tbl and test_desc_json_tbl_hive to check whether tables created in impala can be described in hive and vice versa. The tests can be checked by running the below commands: impala-py.test --exploration=exhaustive tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl impala-py.test --exploration=exhaustive tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl_hive Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1 --- M tests/metadata/test_hms_integration.py 1 file changed, 19 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18299/1 -- To view, visit http://gerrit.cloudera.org:8080/18299 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1 Gerrit-Change-Number: 18299 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
