[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18349 ) Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0 Gerrit-Change-Number: 18349 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 24 Mar 2022 05:04:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10723: Treat materialized view as a table instead of a view
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17595 ) Change subject: IMPALA-10723: Treat materialized view as a table instead of a view .. Patch Set 12: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10331/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3108996124c6544a97fb0c34b6aff5e324a6cff Gerrit-Change-Number: 17595 Gerrit-PatchSet: 12 Gerrit-Owner: Aman Sinha Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 24 Mar 2022 02:42:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10723: Treat materialized view as a table instead of a view
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17595 ) Change subject: IMPALA-10723: Treat materialized view as a table instead of a view .. Patch Set 12: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7961/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/17595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3108996124c6544a97fb0c34b6aff5e324a6cff Gerrit-Change-Number: 17595 Gerrit-PatchSet: 12 Gerrit-Owner: Aman Sinha Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 24 Mar 2022 01:43:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10723: Treat materialized view as a table instead of a view
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17595 ) Change subject: IMPALA-10723: Treat materialized view as a table instead of a view .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/17595/11/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/17595/11/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@225 PS11, Line 225: mvAuthException > nit. missing suffix _ for these two new fields? added the suffix. http://gerrit.cloudera.org:8080/#/c/17595/5/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/17595/5/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3110 PS5, Line 3110: onServer(TPrivilegeLevel.ALL)); > Added a new MV called mv1_alltypes_jointbl which has a join of 2 new source Done http://gerrit.cloudera.org:8080/#/c/17595/12/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/17595/12/testdata/datasets/functional/functional_schema_template.sql@3446 PS12, Line 3446: -- Create a duplicate materialized view because we want to test Reviewers, I added this duplicate MV in the patch set 12 because of reasons mentioned here. I thought it was a cleaner way since create materialized view requires Hive and can only be done in this initial load phase. -- To view, visit http://gerrit.cloudera.org:8080/17595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3108996124c6544a97fb0c34b6aff5e324a6cff Gerrit-Change-Number: 17595 Gerrit-PatchSet: 12 Gerrit-Owner: Aman Sinha Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 24 Mar 2022 01:41:38 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10723: Treat materialized view as a table instead of a view
Hello Quanlong Huang, Qifan Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17595 to look at the new patch set (#12). Change subject: IMPALA-10723: Treat materialized view as a table instead of a view .. IMPALA-10723: Treat materialized view as a table instead of a view The existing behavior is that materialized views are treated as views and therefore expanded similar to a view when one queries the MV directly (SELECT * FROM materialized_view). This is incorrect since an MV is a regular table with physical properties such as partitioning, clustering etc. and should be treated as such even though it has a view definition associated with it. This patch focuses on the use case where MVs are created as HDFS tables and makes the MVs a derived class of HdfsTable, therefore making it a Table object. It adds support for collecting and displaying statistics on materialized views and these statistics could be leveraged by an external frontend that supports MV based query rewrites (note that such a rewrite is not supported by Impala with or without this patch). Note that we are not introducing new syntax for MVs since DDL, DML operations on MVs are only supported through Hive. Directly querying a MV is permitted but inserts into MVs is not since MVs are supposed to be only modified through an external refresh when the source tables have modifications. If the source tables associated with a materialized view have column masking or row-filtering Ranger policies, querying the MV will throw an error. This behavior is consistent with that of Hive. Testing: - Added transactional tables for alltypes, jointbl and used them as source tables to create materialized view. - Added tests for compute stats, drop stats, show stats and simple select query on a materialized view. - Added test for select on a materialized view when the source table has a column mask. - Modified analyzer tests related to alter, insert, drop of materialized view. Change-Id: If3108996124c6544a97fb0c34b6aff5e324a6cff --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java A fe/src/main/java/org/apache/impala/catalog/MaterializedViewHdfsTable.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java M fe/src/test/java/org/apache/impala/service/FrontendTest.java M testdata/bin/compute-table-stats.sh M testdata/datasets/functional/functional_schema_template.sql M testdata/datasets/functional/schema_constraints.csv M testdata/workloads/functional-planner/queries/PlannerTest/views.test M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test M testdata/workloads/functional-query/queries/QueryTest/views.test 17 files changed, 346 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/17595/12 -- To view, visit http://gerrit.cloudera.org:8080/17595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If3108996124c6544a97fb0c34b6aff5e324a6cff Gerrit-Change-Number: 17595 Gerrit-PatchSet: 12 Gerrit-Owner: Aman Sinha Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18349 ) Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10330/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0 Gerrit-Change-Number: 18349 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 24 Mar 2022 00:58:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11197/IMPALA-11149: Address CVEs in pac4j/xmlsec
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18348 ) Change subject: IMPALA-11197/IMPALA-11149: Address CVEs in pac4j/xmlsec .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10329/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8421d867dd0fce8eeaa6bc13a511ca3e8dd05723 Gerrit-Change-Number: 18348 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 24 Mar 2022 00:56:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18349 ) Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7960/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0 Gerrit-Change-Number: 18349 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 24 Mar 2022 00:38:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18349 Change subject: IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit .. IMPALA-11198: Exclude aws-java-sdk-bundle coming from Ranger audit Ranger started pulling in aws-java-sdk-bundle. Impala uses a stripped down version of this jar (impala-minimal-s3a-aws-sdk) to save space and we don't need aws-java-sdk-bundle. This adds an exclusion to ranger-plugins-audit to avoid this dependency. Testing: - Ran core tests Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0 --- M fe/pom.xml 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/18349/1 -- To view, visit http://gerrit.cloudera.org:8080/18349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia60601e9f21661f62a6c261e547f67a26e0400d0 Gerrit-Change-Number: 18349 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
[Impala-ASF-CR] IMPALA-11197/IMPALA-11149: Address CVEs in pac4j/xmlsec
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18348 Change subject: IMPALA-11197/IMPALA-11149: Address CVEs in pac4j/xmlsec .. IMPALA-11197/IMPALA-11149: Address CVEs in pac4j/xmlsec This upgrades pac4j and several of its dependencies (including xmlsec) to address CVEs in those components. Specifically: - pac4j 4.5.5 addresses CVE-2021-44878 - xmlsec 2.2.3 addresses CVE-2021-40690 - bcprov 1.68 addresses CVE-2020-15522 This also upgrade springframework to 5.2.9.RELEASE to match the version for pac4j 4.5.5. Testing: - Ran core job Change-Id: I8421d867dd0fce8eeaa6bc13a511ca3e8dd05723 --- M java/pom.xml 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/18348/1 -- To view, visit http://gerrit.cloudera.org:8080/18348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8421d867dd0fce8eeaa6bc13a511ca3e8dd05723 Gerrit-Change-Number: 18348 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
[Impala-ASF-CR] IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18346 ) Change subject: IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1afbd6dfcad6b8fbc2e82763222996fabba207cf Gerrit-Change-Number: 18346 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Wed, 23 Mar 2022 23:23:59 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11195: Disable SSL session renegotiation
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18347 ) Change subject: IMPALA-11195: Disable SSL session renegotiation .. Patch Set 1: Code-Review+1 Looks good! -- To view, visit http://gerrit.cloudera.org:8080/18347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44ee3ff729798834fdda5862f4e50dae8bb287a2 Gerrit-Change-Number: 18347 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Wed, 23 Mar 2022 23:22:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10723: Treat materialized view as a table instead of a view
Aman Sinha has posted comments on this change. (
http://gerrit.cloudera.org:8080/17595 )
Change subject: IMPALA-10723: Treat materialized view as a table instead of a
view
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17595/7/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/compute-stats.test:
http://gerrit.cloudera.org:8080/#/c/17595/7/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test@1841
PS7, Line 1841: table
> Yeah, I am considering this too, as what it means to treat MVs as tables. I
Adding the MV syntax is not in scope for this patch because the DDLs for MV
create/drop/alter are actually done through Hive, not through Impala. That's
the reason why in the load script functional_schema_template.sql, it is under
the 'CREATE_HIVE' section:
+ CREATE_HIVE
+CREATE MATERIALIZED VIEW IF NOT EXISTS {db_name}{db_suffix}.{table_name}
In general, MVs are full-ACID tables (although insert-only is also allowed).
Impala does not support writing to full-ACID tables but it can read from it.
So, the main focus of this patch is to allow read operations on MVs including
computing stats. This allows an external frontend to leverage these stats
while doing all the complex query rewrite operations and MV refresh
(full/incremental based on the delta change in the source tables) via the
external frontend.
I can clarify this in the commit message in case that would make the scope
clearer.
--
To view, visit http://gerrit.cloudera.org:8080/17595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3108996124c6544a97fb0c34b6aff5e324a6cff
Gerrit-Change-Number: 17595
Gerrit-PatchSet: 11
Gerrit-Owner: Aman Sinha
Gerrit-Reviewer: Aman Sinha
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Qifan Chen
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Wed, 23 Mar 2022 23:08:51 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18346 ) Change subject: IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10328/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1afbd6dfcad6b8fbc2e82763222996fabba207cf Gerrit-Change-Number: 18346 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Wed, 23 Mar 2022 18:58:45 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11195: Disable SSL session renegotiation
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18347 ) Change subject: IMPALA-11195: Disable SSL session renegotiation .. Patch Set 1: internal build job is still running. -- To view, visit http://gerrit.cloudera.org:8080/18347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44ee3ff729798834fdda5862f4e50dae8bb287a2 Gerrit-Change-Number: 18347 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 23 Mar 2022 18:47:34 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11195: Disable SSL session renegotiation
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18347 Change subject: IMPALA-11195: Disable SSL session renegotiation .. IMPALA-11195: Disable SSL session renegotiation This patch disables TLS ciphers renegotiation for TLSv1.2 and prior protocol versions. Renegotiation is not possible in a TLSv1.3 connection. In case of OpenSSL version 1.1.0h and newer, we are using SSL_OP_NO_RENEGOTIATION option to disable all renegotiations. In case of OpenSSL version prior to 1.1.0a, the undocumented flag SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS is used. The moot point is the version interval between 1.1.0a and 1.1.0g (inclusive): the SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS flag is no longer available from the application side, but SSL_OP_NO_RENEGOTIATION is not yet present. So, if a server binary has been compiled with OpenSSL in the specified version range, it's still advertising the renegotiation option, even if it's run against OpenSSL 1.1.0h or later versions. Change-Id: I44ee3ff729798834fdda5862f4e50dae8bb287a2 --- M buildall.sh A source/thrift/thrift-0.11.0-patches/0005-IMPALA-11195-Disable-SSL-renegotiations.patch 2 files changed, 55 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/47/18347/1 -- To view, visit http://gerrit.cloudera.org:8080/18347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I44ee3ff729798834fdda5862f4e50dae8bb287a2 Gerrit-Change-Number: 18347 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server
Hello Riza Suminto, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18346 to look at the new patch set (#2). Change subject: IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server .. IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server SSL renegotiation has had a couple of CVEs in the past. This patch disables TLS ciphers renegotiation for TLSv1.2 and prior protocol versions in the Impala web server. Renegotiation is not possible in a TLSv1.3 connection. Disabling renegotiations on the Thrift servers require Thrift-side changes, hence this is handled in the native-toolchain. This change is based on KUDU-1926. In case of OpenSSL version 1.1.0h and newer, we are using SSL_OP_NO_RENEGOTIATION option to disable all renegotiations. In case of OpenSSL version prior to 1.1.0a, the undocumented flag SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS is used. The moot point is the version interval between 1.1.0a and 1.1.0g (inclusive): the SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS flag is no longer available from the application side, but SSL_OP_NO_RENEGOTIATION is not yet present. So, if a server binary has been compiled with OpenSSL in the specified version range, it's still advertising the renegotiation option, even if it's run against OpenSSL 1.1.0h or later versions. Change-Id: I1afbd6dfcad6b8fbc2e82763222996fabba207cf --- M be/src/thirdparty/squeasel/squeasel.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/18346/2 -- To view, visit http://gerrit.cloudera.org:8080/18346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1afbd6dfcad6b8fbc2e82763222996fabba207cf Gerrit-Change-Number: 18346 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18346 Change subject: IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server .. IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server SSL renegotiation has had a couple of CVEs in the past. This patch disables TLS ciphers renegotiation for TLSv1.2 and prior protocol versions in the Impala web server. Renegotiation is not possible in a TLSv1.3 connection. Disabling renegotiations on the Thrift servers require Thrift-side changes, hence this is handled in the native-toolchain. In case of OpenSSL version 1.1.0h and newer, we are using SSL_OP_NO_RENEGOTIATION option to disable all renegotiations. In case of OpenSSL version prior to 1.1.0a, the undocumented flag SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS is used. The moot point is the version interval between 1.1.0a and 1.1.0g (inclusive): the SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS flag is no longer available from the application side, but SSL_OP_NO_RENEGOTIATION is not yet present. So, if a server binary has been compiled with OpenSSL in the specified version range, it's still advertising the renegotiation option, even if it's run against OpenSSL 1.1.0h or later versions. Change-Id: I1afbd6dfcad6b8fbc2e82763222996fabba207cf --- M be/src/thirdparty/squeasel/squeasel.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/18346/1 -- To view, visit http://gerrit.cloudera.org:8080/18346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1afbd6dfcad6b8fbc2e82763222996fabba207cf Gerrit-Change-Number: 18346 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 3: (1 comment) One more thing to check. Sorry I did not mention it yesterday. http://gerrit.cloudera.org:8080/#/c/18327/3/testdata/workloads/functional-planner/queries/PlannerTest/orc-stats-agg.test File testdata/workloads/functional-planner/queries/PlannerTest/orc-stats-agg.test: http://gerrit.cloudera.org:8080/#/c/18327/3/testdata/workloads/functional-planner/queries/PlannerTest/orc-stats-agg.test@82 PS3, Line 82: cardinality=4.39K We may need to compute the cardinality differently for count star optimization since the actual value should be # of files. Please refer to HfdsScanNode.computeCardinalities(). With the modified cardinality, a serial plan should be sufficient even for a very large table. -- To view, visit http://gerrit.cloudera.org:8080/18327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fafa1182f97323aeb9ee39dd4e8ecd418fa6091 Gerrit-Change-Number: 18327 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Wed, 23 Mar 2022 18:32:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 ) Change subject: IMPALA-11145: Block reads on JSON table until we support it .. Patch Set 7: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7958/ -- To view, visit http://gerrit.cloudera.org:8080/18323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa Gerrit-Change-Number: 18323 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Mar 2022 17:21:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 ) Change subject: IMPALA-11038: Zipping unnest from view .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10327/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68f649dda9e41f257e7f6596193d07b24049f92a Gerrit-Change-Number: 18094 Gerrit-PatchSet: 7 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 23 Mar 2022 15:58:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view
Gabor Kaszab has posted comments on this change. (
http://gerrit.cloudera.org:8080/18094 )
Change subject: IMPALA-11038: Zipping unnest from view
..
Patch Set 7:
(4 comments)
Thanks for the comments and the effort to understand the code changes, Csaba!
As you suggested, I managed to get rid of some over-complicated or duplicated
part of the code.
http://gerrit.cloudera.org:8080/#/c/18094/6/common/thrift/PlanNodes.thrift
File common/thrift/PlanNodes.thrift:
http://gerrit.cloudera.org:8080/#/c/18094/6/common/thrift/PlanNodes.thrift@657
PS6, Line 657: struct TCardinalityCheckNode {
> Do I understand correctly that until now we were using the id of the item t
Nevermind, it turned out that adding this extra field is not needed at all. I
also could revert the related changes from the UnnestNode both in FE and BE.
http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java
File fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java:
http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java@120
PS6, Line 120: if (!isRelative() && resolvedPath_.getRootTable() instanceof
FeView) {
> It is registered here, right? https://github.com/apache/impala/blob/d3da875
Indeed, "sourceView != null" kind of equals to "existingTableRef != null". But
anyway I managed to get rid of this part of the code and rely on the logic you
wrote below to substitute the exprs.
http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java@128
PS6, Line 128: // existing tuple desc created by the view. This is not
needed when
> Is this really different to
You're right. See comment above, I dropped this part of the code.
http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java:
http://gerrit.cloudera.org:8080/#/c/18094/6/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@521
PS6, Line 521: getBaseTableSMapFromTableR
> The name is a bit misleading, as it returns the baseTblSmap.
Renamed it.
--
To view, visit http://gerrit.cloudera.org:8080/18094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68f649dda9e41f257e7f6596193d07b24049f92a
Gerrit-Change-Number: 18094
Gerrit-PatchSet: 7
Gerrit-Owner: Gabor Kaszab
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Daniel Becker
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Wed, 23 Mar 2022 15:45:28 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18094 to look at the new patch set (#7). Change subject: IMPALA-11038: Zipping unnest from view .. IMPALA-11038: Zipping unnest from view IMPALA-10920 introduced zipping unnest functionality for arrays that are in a table. This patch improves that support further by accepting inputs from views as well. Testing: - Added planner tests to verify which execution node handles the predicates on unnested items. - E2E tests for both unnesting syntaxes (select list and from clause) to cover when the source of the unnested arrays is not a table but a view. Also tested multi-level views and filtering the unnested items on different levels. Change-Id: I68f649dda9e41f257e7f6596193d07b24049f92a --- M be/src/exec/subplan-node.cc M be/src/exec/unnest-node.cc M be/src/exec/unnest-node.h M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java M fe/src/main/java/org/apache/impala/analysis/FromClause.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/SlotRef.java M fe/src/main/java/org/apache/impala/analysis/TableRef.java M fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/PlanNode.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/main/java/org/apache/impala/planner/SingularRowSrcNode.java M fe/src/main/java/org/apache/impala/planner/UnnestNode.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test M testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-from-view.test M testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-select-list.test 19 files changed, 943 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/18094/7 -- To view, visit http://gerrit.cloudera.org:8080/18094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I68f649dda9e41f257e7f6596193d07b24049f92a Gerrit-Change-Number: 18094 Gerrit-PatchSet: 7 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/18327 )
Change subject: IMPALA-11123: Optimize count(star) for ORC scans
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18327/3/be/src/exec/hdfs-orc-scanner.cc
File be/src/exec/hdfs-orc-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/18327/3/be/src/exec/hdfs-orc-scanner.cc@780
PS3, Line 780: int64_t num_rows =
static_cast(reader_->getNumberOfRows());
Can you unify this with the Parquet implementation? If I didn't miss something
then the only difference is in getting the number of rows - there could be a
virtual function like HdfsColumnarScanner::GetNumberOfRowsInFile()
http://gerrit.cloudera.org:8080/#/c/18327/3/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/18327/3/be/src/exec/hdfs-scanner.cc@846
PS3, Line 846: !(scan_node->IsZeroSlotTableScan() ||
scan_node->optimize_count_star())
Having a function like "readsOnlyMetadata()" could be more descriptive.
http://gerrit.cloudera.org:8080/#/c/18327/3/be/src/exec/hdfs-scanner.cc@847
PS3, Line 847: || footer_split == split) {
Shouldn't we also check row_batches_need_validation_ like in
HdfsOrcScanner::GetNextInternal?
--
To view, visit http://gerrit.cloudera.org:8080/18327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fafa1182f97323aeb9ee39dd4e8ecd418fa6091
Gerrit-Change-Number: 18327
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Qifan Chen
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Riza Suminto
Gerrit-Comment-Date: Wed, 23 Mar 2022 15:01:07 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10723: Treat materialized view as a table instead of a view
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17595 ) Change subject: IMPALA-10723: Treat materialized view as a table instead of a view .. Patch Set 11: (7 comments) Looks great and many thanks for the rework! http://gerrit.cloudera.org:8080/#/c/17595/11/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/17595/11/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@225 PS11, Line 225: mvAuthException nit. missing suffix _ for these two new fields? http://gerrit.cloudera.org:8080/#/c/17595/7/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: http://gerrit.cloudera.org:8080/#/c/17595/7/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@464 PS7, Line 464: table_ instanceof MaterializedViewHdfsTable > Impala only allows updates/deletes on Kudu tables, so if you do an UPDATE o Done http://gerrit.cloudera.org:8080/#/c/17595/11/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java: http://gerrit.cloudera.org:8080/#/c/17595/11/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@625 PS11, Line 625: table MV keyword instead? http://gerrit.cloudera.org:8080/#/c/17595/11/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@635 PS11, Line 635: drop table functional.materialized_view Should we replace table with keyword MV here? Please refer to my other comment on making a distinction between a table and a MV at SQL level. In this doc, https://docs.cloudera.com/runtime/7.2.6/materialized-view-commands/topics/hive_drop_materialized_view.html, drop MV is used. http://gerrit.cloudera.org:8080/#/c/17595/11/testdata/workloads/functional-planner/queries/PlannerTest/views.test File testdata/workloads/functional-planner/queries/PlannerTest/views.test: http://gerrit.cloudera.org:8080/#/c/17595/11/testdata/workloads/functional-planner/queries/PlannerTest/views.test@589 PS11, Line 589: May add a test to generate a distributed plan for the above query to exercise the distributed planner code. http://gerrit.cloudera.org:8080/#/c/17595/7/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/compute-stats.test: http://gerrit.cloudera.org:8080/#/c/17595/7/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test@1841 PS7, Line 1841: table > You mean 'show materialized view stats .. ' ? Since this is now treated a Yeah, I am considering this too, as what it means to treat MVs as tables. It seems to me the idea of this patch is to exploit the benefits of MVs being physically stored as tables. But logically, MVs are still MVs and not tables, at the SQL interface level. Therefore one should be able to create table 'foo' and mv 'foo'. If we follow this idea, then we need to make the distinction for certain SQL statements, such as SHOW TABLE STATS and SHOW MV STATS , or SHOW CREATE TABLE and SHOW CREATE MV . http://gerrit.cloudera.org:8080/#/c/17595/11/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/compute-stats.test: http://gerrit.cloudera.org:8080/#/c/17595/11/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test@1841 PS11, Line 1841: table See my comment on the distinction between table and MV at SQL level. -- To view, visit http://gerrit.cloudera.org:8080/17595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3108996124c6544a97fb0c34b6aff5e324a6cff Gerrit-Change-Number: 17595 Gerrit-PatchSet: 11 Gerrit-Owner: Aman Sinha Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Mar 2022 13:11:15 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 ) Change subject: IMPALA-11145: Block reads on JSON table until we support it .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7958/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa Gerrit-Change-Number: 18323 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Mar 2022 12:58:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 ) Change subject: IMPALA-11145: Block reads on JSON table until we support it .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa Gerrit-Change-Number: 18323 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Mar 2022 12:58:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11145: Block reads on JSON table until we support it
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 ) Change subject: IMPALA-11145: Block reads on JSON table until we support it .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa Gerrit-Change-Number: 18323 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Mar 2022 12:58:20 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add 3.4.1 change log
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18345 ) Change subject: Add 3.4.1 change log .. Patch Set 1: > Patch Set 1: Verified-1 > > Build Failed > > https://jenkins.impala.io/job/gerrit-docs-auto-test/652/ : Doc tests failed. > See linked job for details on the failure. The job only verifies normal doc patch. Removing the -1. -- To view, visit http://gerrit.cloudera.org:8080/18345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I7d91d97fed8ea496ff2a24f51b7328c58214292e Gerrit-Change-Number: 18345 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 23 Mar 2022 12:17:27 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add 3.4.1 change log
Quanlong Huang has removed a vote on this change. Change subject: Add 3.4.1 change log .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/18345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: deleteVote Gerrit-Change-Id: I7d91d97fed8ea496ff2a24f51b7328c58214292e Gerrit-Change-Number: 18345 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR](asf-site) Add 3.4.1 change log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18345 ) Change subject: Add 3.4.1 change log .. Patch Set 1: Verified-1 Build Failed https://jenkins.impala.io/job/gerrit-docs-auto-test/652/ : Doc tests failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I7d91d97fed8ea496ff2a24f51b7328c58214292e Gerrit-Change-Number: 18345 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 23 Mar 2022 07:16:52 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add 3.4.1 change log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18345 ) Change subject: Add 3.4.1 change log .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/652/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/18345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I7d91d97fed8ea496ff2a24f51b7328c58214292e Gerrit-Change-Number: 18345 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 23 Mar 2022 07:11:37 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add 3.4.1 change log
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18345 Change subject: Add 3.4.1 change log .. Add 3.4.1 change log Previously we didn't mention the patch version, e.g. the last number of "3.4.1". This changes the web page to distinguish 3.4.1 vs 3.4.0. Also change 4.0 to 4.0.0. Added change log of 3.4.1 and mentioning that IMPALA-9242 is reverted. Change-Id: I7d91d97fed8ea496ff2a24f51b7328c58214292e --- A docs/changelog-3.4.1.html M impala-docs.html 2 files changed, 80 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/18345/1 -- To view, visit http://gerrit.cloudera.org:8080/18345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: newchange Gerrit-Change-Id: I7d91d97fed8ea496ff2a24f51b7328c58214292e Gerrit-Change-Number: 18345 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
