[Impala-ASF-CR](3.x) IMPALA-11444: Fix wrong results when reading wide rows from ORC

2022-07-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18745 )

Change subject: IMPALA-11444: Fix wrong results when reading wide rows from ORC
..


Patch Set 1: Code-Review+2

Nice catch and thanks for taking care of this!


--
To view, visit http://gerrit.cloudera.org:8080/18745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 3.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f1c23c817ad012587355c16f37f42d5fb41bff
Gerrit-Change-Number: 18745
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 19 Jul 2022 08:04:32 +
Gerrit-HasComments: No


[Impala-ASF-CR](3.x) IMPALA-11444: Fix wrong results when reading wide rows from ORC

2022-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18745 )

Change subject: IMPALA-11444: Fix wrong results when reading wide rows from ORC
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/18745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 3.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f1c23c817ad012587355c16f37f42d5fb41bff
Gerrit-Change-Number: 18745
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 19 Jul 2022 08:05:47 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality

2022-07-19 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18744 )

Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
..


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java
File fe/src/main/java/org/apache/impala/planner/SortNode.java:

http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java@465
PS1, Line 465: getChild(0).cardinality_ * avgRowSize_
Maybe not quite in the scope of this patch but is it possible that we have 
cardinality == -1 AND avgRowSize_ < 0 because of corrupt stats? This way the 
product would be incorrect but positive so we don't recognise it as incorrect 
on the next line.



--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 19 Jul 2022 08:40:56 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-11424: Support pushdown non-equi join predicate from OUTER/INNER JOIN to SCANNODE

2022-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18731 )

Change subject: IMPALA-11424: Support pushdown non-equi join predicate from 
OUTER/INNER JOIN to SCANNODE
..


Patch Set 6: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/18731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ce23cbd7522a209c830504f329b972d67bc263
Gerrit-Change-Number: 18731
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 19 Jul 2022 09:06:57 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10871 (part 2): Apache Hive 3: fixes for dataset loading

2022-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/18028 )

Change subject: IMPALA-10871 (part 2): Apache Hive 3: fixes for dataset loading
..

IMPALA-10871 (part 2): Apache Hive 3: fixes for dataset loading

This patch fixes the data loading problem of integrating Apache Hive 3
and switches to the tez engine.

Add HIVE-21569, HIVE-20038 patches and recompile the hive-exec module.

Testing:
- Manually perform data loading steps.

Change-Id: I86a1fdffc70b8d9a3bc97a72b5b939021dc496f1
Reviewed-on: http://gerrit.cloudera.org:8080/18028
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M testdata/cluster/hive/README
A testdata/cluster/hive/patch1-HIVE-21569.diff
A testdata/cluster/hive/patch2-HIVE-20038.diff
M tests/util/test_file_parser.py
11 files changed, 381 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/18028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I86a1fdffc70b8d9a3bc97a72b5b939021dc496f1
Gerrit-Change-Number: 18028
Gerrit-PatchSet: 11
Gerrit-Owner: Fucun Chu 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Fucun Chu 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-10871 (part 2): Apache Hive 3: fixes for dataset loading

2022-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18028 )

Change subject: IMPALA-10871 (part 2): Apache Hive 3: fixes for dataset loading
..


Patch Set 10: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/18028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86a1fdffc70b8d9a3bc97a72b5b939021dc496f1
Gerrit-Change-Number: 18028
Gerrit-PatchSet: 10
Gerrit-Owner: Fucun Chu 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Fucun Chu 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 19 Jul 2022 10:12:58 +
Gerrit-HasComments: No


[Impala-ASF-CR](3.x) IMPALA-11444: Fix wrong results when reading wide rows from ORC

2022-07-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/18745 )

Change subject: IMPALA-11444: Fix wrong results when reading wide rows from ORC
..

IMPALA-11444: Fix wrong results when reading wide rows from ORC

After IMPALA-9228, ORC scanner reads rows into scratch batch where we
perform conjuncts and runtime filters. The survived rows will be picked
by the output row batch. We loop this until the output row batch is
filled (1024 rows by default) or we finish reading the ORC batch (1024
rows by default).

Usually the loop will have only 1 iteration since the scratch batch
capacity is also 1024. All rows of the current ORC batch can be
materialized into the scratch batch. However, when reading wide rows
that have tuple size larger than 4096 bytes, the scratch batch capacity
will be reduced to be lower 1024, i.e. the scratch batch can store less
than 1024 rows. In this case, we need more iterations in the loop.

The bug is that we didn't commit rows to the output row batch after each
iteration. The suvived rows will be ovewritten in the second iteration.

This is fixed in a later optimization (IMPALA-9469) which is missing in
the 3.x branch. This patch only pick the fix of it.

Tests:
 - Add test on wide tables with 2K columns

Change-Id: I09f1c23c817ad012587355c16f37f42d5fb41bff
Reviewed-on: http://gerrit.cloudera.org:8080/18745
Reviewed-by: Gabor Kaszab 
Tested-by: Impala Public Jenkins 
---
M be/src/exec/hdfs-orc-scanner.cc
M tests/query_test/test_scanners.py
2 files changed, 56 insertions(+), 5 deletions(-)

Approvals:
  Gabor Kaszab: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/18745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 3.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I09f1c23c817ad012587355c16f37f42d5fb41bff
Gerrit-Change-Number: 18745
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR](3.x) IMPALA-11444: Fix wrong results when reading wide rows from ORC

2022-07-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18745 )

Change subject: IMPALA-11444: Fix wrong results when reading wide rows from ORC
..


Patch Set 1:

Thank Gabor's review!


--
To view, visit http://gerrit.cloudera.org:8080/18745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 3.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f1c23c817ad012587355c16f37f42d5fb41bff
Gerrit-Change-Number: 18745
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 19 Jul 2022 11:00:01 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18616 )

Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs
..


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8340/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/18616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60761faa2710f4795f1f3eaf66da866b5553f609
Gerrit-Change-Number: 18616
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 19 Jul 2022 16:45:59 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10791 Add batch reading for remote temporary files

2022-07-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17979 )

Change subject: IMPALA-10791 Add batch reading for remote temporary files
..


Patch Set 14: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/17979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dcc5d0881ffaeff09c5c514306cd668373ad31b
Gerrit-Change-Number: 17979
Gerrit-PatchSet: 14
Gerrit-Owner: Yida Wu 
Gerrit-Reviewer: Abhishek Rawat 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Qifan Chen 
Gerrit-Reviewer: Yida Wu 
Gerrit-Comment-Date: Tue, 19 Jul 2022 16:56:31 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18616 )

Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs
..


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8340/


--
To view, visit http://gerrit.cloudera.org:8080/18616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60761faa2710f4795f1f3eaf66da866b5553f609
Gerrit-Change-Number: 18616
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 19 Jul 2022 21:46:04 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9442: Add Ozone to minicluster

2022-07-19 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/18738

to look at the new patch set (#5).

Change subject: IMPALA-9442: Add Ozone to minicluster
..

IMPALA-9442: Add Ozone to minicluster

Adds Ozone as an alternative to hdfs in the minicluster. Select by
setting `export TARGET_FILESYSTEM=ozone`. With that flag,
run-mini-dfs.sh will start Ozone instead of HDFS. Requires a snapshot
because Ozone does not support HBase (HDDS-3589); snapshot loading
doesn't work yet primarily due to HDDS-5502.

Uses the o3fs interface because Ozone puts specific restrictions on
bucket names (no underscores, for instance), and it was a lot easier to
use an interface where everything is written to a single bucket than to
update all Impala's use of HDFS-style paths to make `test-warehouse` a
bucket inside a volume.

Specifies reduced Ozone client retries during shutdown where Ozone may
not be available.

Change-Id: Ibf8b0f7b2d685d8b011df1926e12bf5434b5a2be
---
M bin/bootstrap_toolchain.py
M bin/clean.sh
M bin/create-test-configuration.sh
M bin/impala-config.sh
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/resources/.gitignore
M testdata/bin/kill-hbase.sh
M testdata/bin/run-all.sh
M testdata/cluster/admin
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
A testdata/cluster/node_templates/common/etc/hadoop/conf/ozone-site.xml.tmpl
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
A testdata/cluster/node_templates/common/etc/init.d/ozone-common
A testdata/cluster/node_templates/common/etc/init.d/ozone-datanode
A testdata/cluster/node_templates/common/etc/init.d/ozone-manager
A testdata/cluster/node_templates/common/etc/init.d/ozone-scm
M tests/util/filesystem_utils.py
17 files changed, 237 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/18738/5
--
To view, visit http://gerrit.cloudera.org:8080/18738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf8b0f7b2d685d8b011df1926e12bf5434b5a2be
Gerrit-Change-Number: 18738
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 


[Impala-ASF-CR] IMPALA-9442: Add Ozone to minicluster

2022-07-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18738 )

Change subject: IMPALA-9442: Add Ozone to minicluster
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18738/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18738/5//COMMIT_MSG@13
PS5, Line 13: doesn't work yet primarily due to HDDS-5502.
HDDS-5502 is fixed in some CDP builds of Ozone, but not the 7.2 builds we use. 
We can address this once that fix is merged up to 7.2 builds by pulling in a 
new GBN and Ozone release.



--
To view, visit http://gerrit.cloudera.org:8080/18738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8b0f7b2d685d8b011df1926e12bf5434b5a2be
Gerrit-Change-Number: 18738
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 19 Jul 2022 22:13:11 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-9442: Add Ozone to minicluster

2022-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18738 )

Change subject: IMPALA-9442: Add Ozone to minicluster
..


Patch Set 5:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/10992/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/18738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8b0f7b2d685d8b011df1926e12bf5434b5a2be
Gerrit-Change-Number: 18738
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 19 Jul 2022 22:31:34 +
Gerrit-HasComments: No


[native-toolchain-CR] IMPALA-11441: Revert KUDU-1644 to avoid upsert test failure

2022-07-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/18752


Change subject: IMPALA-11441: Revert KUDU-1644 to avoid upsert test failure
..

IMPALA-11441: Revert KUDU-1644 to avoid upsert test failure

The test failure seen in IMPALA-11441 was tracked down
to the fix for KUDU-1644 (936d7edc4e4b69d2e1f1dffc96760cb3fd57a934).
This takes the latest Kudu upstream master commit
dc4031f693 and reverts KUDU-1644. This is posted to
my public Kudu fork (https://github.com/joemcdonnell/kudu.git)
for simplicity. This is a temporary fix until the underlying
issue is fixed in upstream Kudu.

Change-Id: I112211b6c32ddc86bc6402af84e7fce06c2be024
---
M buildall.sh
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/52/18752/1
--
To view, visit http://gerrit.cloudera.org:8080/18752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I112211b6c32ddc86bc6402af84e7fce06c2be024
Gerrit-Change-Number: 18752
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 


[native-toolchain-CR] IMPALA-11441: Revert KUDU-1644 to avoid upsert test failure

2022-07-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/18752 )

Change subject: IMPALA-11441: Revert KUDU-1644 to avoid upsert test failure
..

IMPALA-11441: Revert KUDU-1644 to avoid upsert test failure

The test failure seen in IMPALA-11441 was tracked down
to the fix for KUDU-1644 (936d7edc4e4b69d2e1f1dffc96760cb3fd57a934).
This takes the latest Kudu upstream master commit
dc4031f693 and reverts KUDU-1644. This is posted to
my public Kudu fork (https://github.com/joemcdonnell/kudu/tree/impala11441)
for simplicity. This is a temporary fix until the underlying
issue is fixed in upstream Kudu.

Change-Id: I112211b6c32ddc86bc6402af84e7fce06c2be024
---
M buildall.sh
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/52/18752/2
--
To view, visit http://gerrit.cloudera.org:8080/18752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I112211b6c32ddc86bc6402af84e7fce06c2be024
Gerrit-Change-Number: 18752
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 


[Impala-ASF-CR] IMPALA-11445: Allow partitions located in different file systems

2022-07-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/18759


Change subject: IMPALA-11445: Allow partitions located in different file systems
..

IMPALA-11445: Allow partitions located in different file systems

When adding a partition with location in a file system which is
different from the file system of the table location, Impala accept
it. But when insert values to the table, catalogd throw exception.

This patch fix the issue by using the right FileSystem object.

Testing:
 - Added new test cases with partitions on different file systems.
 - Did manual tests in cluster with partitions on HDFS and Ozone.
 - Passed core test.

Change-Id: I0491ee1bf40c3d5240f9124cef3f3169c44a8267
---
M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A testdata/workloads/functional-query/queries/QueryTest/partition-location.test
M tests/query_test/test_partitioning.py
4 files changed, 117 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/18759/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0491ee1bf40c3d5240f9124cef3f3169c44a8267
Gerrit-Change-Number: 18759
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou 
Gerrit-Reviewer: Quanlong Huang 


[Impala-ASF-CR] IMPALA-11445: Allow partitions located in different file systems

2022-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18759 )

Change subject: IMPALA-11445: Allow partitions located in different file systems
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/10993/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/18759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0491ee1bf40c3d5240f9124cef3f3169c44a8267
Gerrit-Change-Number: 18759
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Wed, 20 Jul 2022 06:13:05 +
Gerrit-HasComments: No