[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Xiang Yang has posted comments on this change. (
http://gerrit.cloudera.org:8080/18812 )
Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns
for kudu table
..
Patch Set 4:
(2 comments)
> Patch Set 2:
>
> (2 comments)
http://gerrit.cloudera.org:8080/#/c/18812/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/18812/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@519
PS2, Line 519: if (!oldColumns.contains(column.getColumnName())) {
> should we raise an error when oldColumns.contains(column.getColumnName()) a
Hi jian, impala already have check here:
https://github.com/apache/impala/blob/4.1.0/fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java#L84.
http://gerrit.cloudera.org:8080/#/c/18812/2/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test:
http://gerrit.cloudera.org:8080/#/c/18812/2/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test@352
PS2, Line 352: CATCH
> could you add another test without the `if not exists` clause:
Done
--
To view, visit http://gerrit.cloudera.org:8080/18812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6
Gerrit-Change-Number: 18812
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jian Zhang
Gerrit-Reviewer: Xiang Yang
Gerrit-Comment-Date: Tue, 13 Sep 2022 06:40:40 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 ) Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Comment-Date: Tue, 13 Sep 2022 06:32:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/11343/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 13 Sep 2022 04:07:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/18977 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@519
PS1, Line 519: o
flake8: E501 line too long (140 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@524
PS1, Line 524: s
flake8: E501 line too long (171 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@539
PS1, Line 539: m
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@544
PS1, Line 544: b
flake8: E501 line too long (132 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@605
PS1, Line 605: _
flake8: E501 line too long (123 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18977/1/buildall.sh@415
PS1, Line 415: if [[ "${DOWNLOAD_CDH_COMPONENTS}" = true ]] || [[
"${DOWNLOAD_APACHE_COMPONENTS}" = true ]]; then
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/18977/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
File
fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/18977/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@324
PS1, Line 324: req.setResource(new
RangerAccessResourceImpl(Collections.unmodifiableMap(resource)));
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399
Gerrit-Change-Number: 18977
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 13 Sep 2022 04:04:10 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18977 Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml 8 files changed, 142 insertions(+), 51 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/1 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18976 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18976 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/11342/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 13 Sep 2022 03:56:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18975 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782 Gerrit-Change-Number: 18975 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/18976 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@519
PS1, Line 519: o
flake8: E501 line too long (140 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@524
PS1, Line 524: s
flake8: E501 line too long (171 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@539
PS1, Line 539: m
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@544
PS1, Line 544: b
flake8: E501 line too long (132 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@605
PS1, Line 605: _
flake8: E501 line too long (123 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18976/1/buildall.sh@415
PS1, Line 415: if [[ "${DOWNLOAD_CDH_COMPONENTS}" = true ]] || [[
"${DOWNLOAD_APACHE_COMPONENTS}" = true ]]; then
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/18976/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
File
fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/18976/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@324
PS1, Line 324: req.setResource(new
RangerAccessResourceImpl(Collections.unmodifiableMap(resource)));
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb
Gerrit-Change-Number: 18976
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 13 Sep 2022 03:53:05 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has restored this change. ( http://gerrit.cloudera.org:8080/18976 ) Change subject: IMPALA-10408: Support build using Apache components .. Restored -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18976 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18976 Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml 8 files changed, 142 insertions(+), 51 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/18976/1 -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 ) Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18960/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18960/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue > nit: add space Done http://gerrit.cloudera.org:8080/#/c/18960/1/be/src/runtime/blocking-row-batch-queue.h File be/src/runtime/blocking-row-batch-queue.h: http://gerrit.cloudera.org:8080/#/c/18960/1/be/src/runtime/blocking-row-batch-queue.h@112 PS1, Line 112: std::unique_ptr > optional: Can't we use BlockingQueue directly as member without ptr/unique_ Yes, I think we can. But that requires more changes, we should change '->' to '.' -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 2 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Tue, 13 Sep 2022 03:35:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18975 Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/executor-deps/pom.xml 9 files changed, 167 insertions(+), 52 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/18975/1 -- To view, visit http://gerrit.cloudera.org:8080/18975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782 Gerrit-Change-Number: 18975 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18975 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/11341/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782 Gerrit-Change-Number: 18975 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 13 Sep 2022 03:38:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18966 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e Gerrit-Change-Number: 18966 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has restored this change. ( http://gerrit.cloudera.org:8080/18966 ) Change subject: IMPALA-10408: Support build using Apache components .. Restored -- To view, visit http://gerrit.cloudera.org:8080/18966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e Gerrit-Change-Number: 18966 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/18975 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@519
PS1, Line 519: o
flake8: E501 line too long (140 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@524
PS1, Line 524: s
flake8: E501 line too long (171 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@539
PS1, Line 539: m
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@544
PS1, Line 544: b
flake8: E501 line too long (132 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@605
PS1, Line 605: _
flake8: E501 line too long (123 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18975/1/buildall.sh@415
PS1, Line 415: if [[ "${DOWNLOAD_CDH_COMPONENTS}" = true ]] || [[
"${DOWNLOAD_APACHE_COMPONENTS}" = true ]]; then
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/18975/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
File
fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/18975/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@324
PS1, Line 324: req.setResource(new
RangerAccessResourceImpl(Collections.unmodifiableMap(resource)));
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782
Gerrit-Change-Number: 18975
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 13 Sep 2022 03:35:05 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 ) Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11340/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 2 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 13 Sep 2022 03:28:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11418: A statement that returns at most one row need not to spool results
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 ) Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11339/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 9 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Tue, 13 Sep 2022 03:23:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18966 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned fix bug -- To view, visit http://gerrit.cloudera.org:8080/18966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e Gerrit-Change-Number: 18966 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11418: A statement that returns at most one row need not to spool results
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 ) Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results .. Patch Set 9: Code-Review+1 Looks good to me. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 9 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Tue, 13 Sep 2022 03:07:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Xianqing He has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18960 ) Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. IMPALA-11557: Fix memory leak in BlockingRowBatchQueue 'batch_queue_' is a pointer to store the RowBatches. It's initialized in the constructor but not deleted in the destructor. The way to fix in the patch is to use std::unique_ptr. Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 --- M be/src/runtime/blocking-row-batch-queue.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/18960/2 -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 2 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-11418: A statement that returns at most one row need not to spool results
Xianqing He has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18711 ) Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results .. IMPALA-11418: A statement that returns at most one row need not to spool results A query that returns at most one row can run more efficiently without result spooling. If result spooling is enabled, it will set the minimum memory reservation in PlanRootSink, e.g. 'select 1' minimum memory reservation is 4MB. This optimization can reduce the statement's resource reservation and the exception 'Failed to get minimum memory reservation' when the host memory limit not available. Testing: - Add tests in result-spooling.test Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test 2 files changed, 113 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/18711/9 -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 9 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Xianqing He
[Impala-ASF-CR] IMPALA-11485: Pushdown LIMIT through UNION and LEFT/RIGHT OUTER JOIN
Jian Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/18862 )
Change subject: IMPALA-11485: Pushdown LIMIT through UNION and LEFT/RIGHT OUTER
JOIN
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18862/4/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java:
http://gerrit.cloudera.org:8080/#/c/18862/4/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@396
PS4, Line 396: private static PlanNode findNodeCanLimitPushdown(PlanNode
root) {
This function can only find the first `union all` or `join` node in the plan
tree and push the `limit` down.
However, I think we should find all the descendant `union all` or `join` nodes
and push the `limit` down. For example:
limit 10
-> left outer join
-> left outer join
-> table scan t1
-> table scan t2
-> table scan t3
can be optimized to the following plan after applying limit pushdown:
limit 10
-> left outer join
-> limit 10
-> left outer join
-> limit 10
-> table scan t1
-> table scan t2
-> table scan t3
http://gerrit.cloudera.org:8080/#/c/18862/4/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@397
PS4, Line 397: if (root == null || root instanceof UnionNode || root
instanceof HashJoinNode) {
Should we check whether it's `JoinNode` instead of `HashJoinNode` since this
happens in the single-node planning phase, in which the physical plan is not
determined?
I noticed there is another join implementation called `NestedLoopJoin`, it
should also be covered by this optimization
--
To view, visit http://gerrit.cloudera.org:8080/18862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5d040c0a98e60639d7ce4b25ecf07a859c8a32c
Gerrit-Change-Number: 18862
Gerrit-PatchSet: 4
Gerrit-Owner: Baike Xia
Gerrit-Reviewer: Aman Sinha
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jian Zhang
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Tue, 13 Sep 2022 02:33:31 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 ) Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11338/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Comment-Date: Tue, 13 Sep 2022 01:47:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 ) Change subject: IMPALA-11573: Certain methods used by the replanning feature can be improved .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99 Gerrit-Change-Number: 18968 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 13 Sep 2022 01:35:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Hello Jian Zhang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18812 to look at the new patch set (#4). Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table Impala already supports IF NOT EXISTS in alter table add columns for general hive table in IMPALA-7832, but not for kudu table. This patch try to add such semantics for kudu table. Testing: - Updated E2E DDL tests Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 --- M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test 2 files changed, 47 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/18812/4 -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 ) Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8563/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Comment-Date: Tue, 13 Sep 2022 01:27:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11511: Add build options for reducing binary sizes
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18962 ) Change subject: IMPALA-11511: Add build options for reducing binary sizes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18962/1/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: http://gerrit.cloudera.org:8080/#/c/18962/1/bin/dump_breakpad_symbols.py@297 PS1, Line 297: args = [dump_syms, decompressed_binary] : if objcopy_retcode != 0: Should we check objcopy_retcode before calling dump_syms -- To view, visit http://gerrit.cloudera.org:8080/18962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04a20258a86053d8f3972b9c7c81cd5bec1bbb66 Gerrit-Change-Number: 18962 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 13 Sep 2022 00:54:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 ) Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. Patch Set 3: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8561/ -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Comment-Date: Mon, 12 Sep 2022 18:11:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10791 Add batch reading for remote temporary files
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17979 ) Change subject: IMPALA-10791 Add batch reading for remote temporary files .. Patch Set 20: Rebased and refined the limits for the read buffer based on Abhishek's comments. -- To view, visit http://gerrit.cloudera.org:8080/17979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dcc5d0881ffaeff09c5c514306cd668373ad31b Gerrit-Change-Number: 17979 Gerrit-PatchSet: 20 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 12 Sep 2022 17:17:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10791 Add batch reading for remote temporary files
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17979 ) Change subject: IMPALA-10791 Add batch reading for remote temporary files .. Patch Set 20: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11337/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dcc5d0881ffaeff09c5c514306cd668373ad31b Gerrit-Change-Number: 17979 Gerrit-PatchSet: 20 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 12 Sep 2022 17:12:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10791 Add batch reading for remote temporary files
Yida Wu has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/17979 ) Change subject: IMPALA-10791 Add batch reading for remote temporary files .. IMPALA-10791 Add batch reading for remote temporary files The patch adds a feature to batch read from a remote temporary file in order to improve the reading performance for the spilled remote data. Originally, the design is to use the local disk file as the buffer for batch read from the remote file. But in practice, it doesn't help to improve the performance. Therefore, the design is changed to use the memory as the read buffer. Currently, each TmpFileRemote has two DiskFile, one is for the remote, and one is for the local buffer. The patch adds MemBlocks to the local buffer file. Each local buffer file is divided into several MemBlocks evenly. Moreover, in order to guarantee a single page not being cut into two parts in different blocks, the block size could be a little different to each other in practice. The default block size is the minimum value between the default file size and MAX_REMOTE_READ_MEM_BLOCK_THRESHOLD_BYTES, which is 16MB. When pinning a page, the system will detect if there is enough memory for the block that holds the page, if not, we will go reading the page directly and disable this block, because it may be good to avoid duplicated reads from the remote fs for the same content. If the system decides to fetch a block, the block will be stored in the memory until all of the pages in the block are read or the query ends. One challenge of the read buffer is where to get the extra memory for it, because when impala starts to spill data, it means the process lacks of memory to use. By default, impala process will reserve 20% of the total system memory as unused memory, and here we will use this unused memory for the read buffer because it is reasonable to use it for the emergency case like spilling. The maximum bytes of the read buffer memory are no more than 10% of the total system memory and 50% of the unused memory. Also, if the unused memory is less than 5% of the total system memory, the read buffer will be disabled. Two start options have been added for the new feature. 1. remote_batch_read. Default is false. If set true, the batch read is enabled. 2. remote_read_memory_buffer_size. Default is 1G. The maximum memory that can be used by the read buffer. The number is also restricted by the process memory limit, which can not exceed 10% of the process memory limit. Added metrics ScratchReadsUseMem/ScratchBytesReadUseMem/ ScratchBytesReadUseLocalDisk to the query profile. The patch also increases the MAX_REMOTE_TMPFILE_SIZE_THRESHOLD_MB from 256 to 512. Tests: Ran core and exhaustive tests. Added and ran TmpFileMgrTest::TestBatchReadingFromRemote. Added e2e test test_scratch_dirs_batch_reading. Change-Id: I1dcc5d0881ffaeff09c5c514306cd668373ad31b --- M be/src/runtime/io/CMakeLists.txt A be/src/runtime/io/disk-file-test.cc M be/src/runtime/io/disk-file.cc M be/src/runtime/io/disk-file.h M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/request-context.cc M be/src/runtime/io/request-context.h M be/src/runtime/io/request-ranges.h M be/src/runtime/io/scan-range.cc M be/src/runtime/tmp-file-mgr-internal.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M be/src/runtime/tmp-file-mgr.h M be/src/util/mem-info.cc M be/src/util/mem-info.h M be/src/util/metrics.h M common/thrift/metrics.json M tests/custom_cluster/test_scratch_disk.py 19 files changed, 1,648 insertions(+), 156 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/17979/20 -- To view, visit http://gerrit.cloudera.org:8080/17979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1dcc5d0881ffaeff09c5c514306cd668373ad31b Gerrit-Change-Number: 17979 Gerrit-PatchSet: 20 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18968 ) Change subject: IMPALA-11573: Certain methods used by the replanning feature can be improved .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11336/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99 Gerrit-Change-Number: 18968 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 12 Sep 2022 16:34:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11573: Certain methods used by the replanning feature can be improved
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18968 Change subject: IMPALA-11573: Certain methods used by the replanning feature can be improved .. IMPALA-11573: Certain methods used by the replanning feature can be improved This patch improves certain methods used by the replan feature (IMPALA-10992) so that they can be called by the FENG compiler component in Hive. Specifically, the declaration of these methods becomes public static. Testing: 1. Run unit tests; 2. Run "core" tests. Change-Id: I334523f86e4292e9591306179eb1ab43be316c99 --- M fe/src/main/java/org/apache/impala/service/Frontend.java 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/18968/3 -- To view, visit http://gerrit.cloudera.org:8080/18968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I334523f86e4292e9591306179eb1ab43be316c99 Gerrit-Change-Number: 18968 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18970 ) Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11335/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I823542c21fe8f10f43a501fe4175da883eaf2f99 Gerrit-Change-Number: 18970 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 12 Sep 2022 14:15:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18970 ) Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18970/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/18970/1/tests/query_test/test_scanners.py@378 PS1, Line 378: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/18970/1/tests/query_test/test_scanners.py@405 PS1, Line 405: + flake8: E226 missing whitespace around arithmetic operator -- To view, visit http://gerrit.cloudera.org:8080/18970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I823542c21fe8f10f43a501fe4175da883eaf2f99 Gerrit-Change-Number: 18970 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 12 Sep 2022 13:55:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18970 Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt .. IMPALA-11572: deflake test_mt_dop_skew_lpt test_mt_dop_skew_lpt was flaky. Also, it calculated the min(bytes_read) / max(bytes_read) globally across all fragment insteances, not just among the intra-node fragment instances. To deflake the test, this test: * calculate intra-node min(bytes_read) / max(bytes_read) ratios instead of global ones * print out the ratios so we'll know the numbers when the test fails * eliminate compression codec test dimension which is not used anyway Change-Id: I823542c21fe8f10f43a501fe4175da883eaf2f99 --- M tests/query_test/test_scanners.py 1 file changed, 22 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/18970/1 -- To view, visit http://gerrit.cloudera.org:8080/18970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I823542c21fe8f10f43a501fe4175da883eaf2f99 Gerrit-Change-Number: 18970 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18969 ) Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11334/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0 Gerrit-Change-Number: 18969 Gerrit-PatchSet: 2 Gerrit-Owner: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 12 Sep 2022 13:20:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 ) Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8561/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Comment-Date: Mon, 12 Sep 2022 13:09:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG
Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18969 Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG .. IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG Impala already supports said statement, added query tests for it. Testing: - Generated parquet table with complex type by hive - Created hive and iceberg table from said file, provides same output for describe statement Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0 --- M testdata/data/README A testdata/data/create_table_like_parquet_test.parquet M tests/query_test/test_iceberg.py 3 files changed, 62 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/18969/2 -- To view, visit http://gerrit.cloudera.org:8080/18969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0 Gerrit-Change-Number: 18969 Gerrit-PatchSet: 2 Gerrit-Owner: Gergely Fürnstáhl
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 ) Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8560/ -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Comment-Date: Mon, 12 Sep 2022 12:52:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 ) Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11333/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Comment-Date: Mon, 12 Sep 2022 08:02:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Hello Jian Zhang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18812 to look at the new patch set (#3). Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table Impala already supports IF NOT EXISTS in alter table add columns for general hive table in IMPALA-7832, but not for kudu table. This patch try to add such semantics for kudu table. Testing: - Updated E2E DDL tests Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 --- M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test 2 files changed, 45 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/18812/3 -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 ) Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8560/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Comment-Date: Mon, 12 Sep 2022 07:41:49 + Gerrit-HasComments: No
