[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11357/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68f37303aee4b6a28e560f27548c31472b82048b Gerrit-Change-Number: 18987 Gerrit-PatchSet: 2 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Sep 2022 03:46:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11356/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68f37303aee4b6a28e560f27548c31472b82048b Gerrit-Change-Number: 18987 Gerrit-PatchSet: 1 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Sep 2022 03:37:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18987/2/be/src/exprs/like-predicate.cc File be/src/exprs/like-predicate.cc: http://gerrit.cloudera.org:8080/#/c/18987/2/be/src/exprs/like-predicate.cc@186 PS2, Line 186: string cache_key = line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/18987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68f37303aee4b6a28e560f27548c31472b82048b Gerrit-Change-Number: 18987 Gerrit-PatchSet: 2 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Sep 2022 03:25:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up
Baike Xia has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up Each time the RE matches, the query from the cache will speed up the computation. Change-Id: I68f37303aee4b6a28e560f27548c31472b82048b --- M be/src/exec/aggregator.cc M be/src/exec/aggregator.h A be/src/exec/exec-node-thread-cache.h M be/src/exec/grouping-aggregator-ir.cc M be/src/exec/hdfs-columnar-scanner-ir.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-scanner.h M be/src/exec/kudu/kudu-scanner.cc M be/src/exec/kudu/kudu-scanner.h M be/src/exec/parquet/hdfs-parquet-scanner.cc M be/src/exprs/agg-fn-evaluator.h M be/src/exprs/like-predicate-ir.cc M be/src/exprs/like-predicate.cc M be/src/exprs/like-predicate.h M be/src/exprs/scalar-expr-evaluator.cc M be/src/exprs/scalar-expr-evaluator.h M be/src/udf/udf-internal.h M be/src/udf/udf-ir.cc M be/src/udf/udf.cc M be/src/udf/udf.h A testdata/workloads/functional-query/queries/QueryTest/thread-cache.test M tests/query_test/test_queries.py 22 files changed, 219 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/18987/2 -- To view, visit http://gerrit.cloudera.org:8080/18987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I68f37303aee4b6a28e560f27548c31472b82048b Gerrit-Change-Number: 18987 Gerrit-PatchSet: 2 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up
Baike Xia has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18987 Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up Each time the RE matches, the query from the cache will speed up the computation. Change-Id: I68f37303aee4b6a28e560f27548c31472b82048b --- M be/src/exec/aggregator.cc M be/src/exec/aggregator.h A be/src/exec/exec-node-thread-cache.h M be/src/exec/grouping-aggregator-ir.cc M be/src/exec/hdfs-columnar-scanner-ir.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-scanner.h M be/src/exec/kudu/kudu-scanner.cc M be/src/exec/kudu/kudu-scanner.h M be/src/exec/parquet/hdfs-parquet-scanner.cc M be/src/exprs/agg-fn-evaluator.h M be/src/exprs/like-predicate-ir.cc M be/src/exprs/like-predicate.cc M be/src/exprs/like-predicate.h M be/src/exprs/scalar-expr-evaluator.cc M be/src/exprs/scalar-expr-evaluator.h M be/src/udf/udf-internal.h M be/src/udf/udf-ir.cc M be/src/udf/udf.cc M be/src/udf/udf.h A testdata/workloads/functional-query/queries/QueryTest/thread-cache.test M tests/query_test/test_queries.py 22 files changed, 218 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/18987/1 -- To view, visit http://gerrit.cloudera.org:8080/18987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I68f37303aee4b6a28e560f27548c31472b82048b Gerrit-Change-Number: 18987 Gerrit-PatchSet: 1 Gerrit-Owner: Baike Xia
[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18987/1/be/src/exprs/like-predicate.cc File be/src/exprs/like-predicate.cc: http://gerrit.cloudera.org:8080/#/c/18987/1/be/src/exprs/like-predicate.cc@186 PS1, Line 186: string cache_key = non_constant_args[0].first->DebugString() + "###" + pattern_str; line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68f37303aee4b6a28e560f27548c31472b82048b Gerrit-Change-Number: 18987 Gerrit-PatchSet: 1 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Sep 2022 03:17:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8573/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68f37303aee4b6a28e560f27548c31472b82048b Gerrit-Change-Number: 18987 Gerrit-PatchSet: 1 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Sep 2022 03:17:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 ) Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18940/6/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/18940/6/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java@73 PS6, Line 73: "ALTER VIEW not allowed on a table: %s", tableName_)); This will confuse the user if the view is a materialized view. From the user's perspective, MV is not a table although we treat it as a table internally. We can check whether 'tableRef' is a MaterializedViewHdfsTable and use another error message, e.g. ALTER VIEW SET TBLPROPERTIES not supported on materialized view. -- To view, visit http://gerrit.cloudera.org:8080/18940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18 Gerrit-Change-Number: 18940 Gerrit-PatchSet: 6 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Baike Xia Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 15 Sep 2022 02:36:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10262: RPM/DEB Packaging Support
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 ) Change subject: IMPALA-10262: RPM/DEB Packaging Support .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11355/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82 Gerrit-Change-Number: 18939 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiang Yang Gerrit-Comment-Date: Thu, 15 Sep 2022 01:45:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10262: RPM/DEB Packaging Support
Hello Impala Public Jenkins, Xiang Yang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18939 to look at the new patch set (#4). Change subject: IMPALA-10262: RPM/DEB Packaging Support .. IMPALA-10262: RPM/DEB Packaging Support This patch bases on a previous patch contributed by Shant Hovsepian: https://gerrit.cloudera.org/c/16612/ It adds a new option, -package, to buildall.sh for building a package for the current OS type (e.g. CentOS/Ubuntu). You can also use "make/ninja package" to build the package. Scripts for launching the services and the required configuration files are also added. Tests: - Built on Ubuntu 16.04 and CentOS 7.5 using ./buildall.sh -noclean -skiptests -ninja -release -package - Deployed the RPM package on a CDP cluster. Verifed the scripts. Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82 --- M CMakeLists.txt M be/CMakeLists.txt M be/src/service/CMakeLists.txt M bin/bootstrap_system.sh M bin/impala-config.sh M bin/jenkins/build-all-flag-combinations.sh M bin/rat_exclude_files.txt M buildall.sh A package/bin/impala-env.sh A package/bin/start-catalogd.sh A package/bin/start-impalad.sh A package/bin/start-statestore.sh A package/conf/catalogd_flags A package/conf/core-site.xml A package/conf/fair-scheduler.xml A package/conf/hdfs-site.xml A package/conf/hive-site.xml A package/conf/impalad_flags A package/conf/llama-site.xml A package/conf/statestore_flags 20 files changed, 354 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/18939/4 -- To view, visit http://gerrit.cloudera.org:8080/18939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82 Gerrit-Change-Number: 18939 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiang Yang
[Impala-ASF-CR] IMPALA-11422: Bump Apache Hive to 3.1.3
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18716 ) Change subject: IMPALA-11422: Bump Apache Hive to 3.1.3 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I395a99cccf0a8902b3fd47235c32b69c5494f291 Gerrit-Change-Number: 18716 Gerrit-PatchSet: 1 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 15 Sep 2022 01:11:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11422: Bump Apache Hive to 3.1.3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18716 ) Change subject: IMPALA-11422: Bump Apache Hive to 3.1.3 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8572/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I395a99cccf0a8902b3fd47235c32b69c5494f291 Gerrit-Change-Number: 18716 Gerrit-PatchSet: 2 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 15 Sep 2022 01:11:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11422: Bump Apache Hive to 3.1.3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18716 ) Change subject: IMPALA-11422: Bump Apache Hive to 3.1.3 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I395a99cccf0a8902b3fd47235c32b69c5494f291 Gerrit-Change-Number: 18716 Gerrit-PatchSet: 2 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 15 Sep 2022 01:11:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11418: A statement that returns at most one row need not to spool results
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 ) Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results .. Patch Set 10: > Patch Set 10: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8566/ There are test failures that need to be addressed: https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6308/ https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17545/ https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17546/ Most of them are due to the plans changed. -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 10 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Thu, 15 Sep 2022 00:13:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18960 ) Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. IMPALA-11557: Fix memory leak in BlockingRowBatchQueue 'batch_queue_' is a pointer to store the RowBatches. It's initialized in the constructor but not deleted in the destructor. The way to fix in the patch is to use std::unique_ptr. Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Reviewed-on: http://gerrit.cloudera.org:8080/18960 Reviewed-by: Impala Public Jenkins Tested-by: Quanlong Huang --- M be/src/runtime/blocking-row-batch-queue.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved Quanlong Huang: Verified -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 4 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Xianqing He
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 ) Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. Patch Set 3: Verified+1 > Patch Set 3: > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8570/ Hit another two flaky tests: https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6313/ (IMPALA-11160) https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17556/ (IMPALA-11572) Merging this. -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 3 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Thu, 15 Sep 2022 00:10:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Quanlong Huang has removed a vote on this change. Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 3 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Xianqing He
[Impala-ASF-CR] IMPALA-11580: Fix memory leak in legacy catalog mode when applying incremental partition updates
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18978 ) Change subject: IMPALA-11580: Fix memory leak in legacy catalog mode when applying incremental partition updates .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18978/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18978/1//COMMIT_MSG@13 PS1, Line 13: reference to the old table object remains unchanged > Can't this also cause bugs? Or while the new / old table are different obje It should cause bugs in theory. But we are lucky that for unpartitioned tables, we don't have this issue. For partitioned tables, the usages in impalad side don't depend on any changable fields, e.g. most of the usages are on getting the partition columns which can't change. https://github.com/apache/impala/blob/3e06d600c2dcb2c9bcdc4f52cd27cd5d180a900b/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java#L118-L120 -- To view, visit http://gerrit.cloudera.org:8080/18978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie04ff243c6b82c1a06c489da74353f2d8afe423a Gerrit-Change-Number: 18978 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 15 Sep 2022 00:07:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18984 ) Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11354/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4 Gerrit-Change-Number: 18984 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 14 Sep 2022 23:59:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 ) Change subject: IMPALA-: Switch to GCC 10.4 .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11353/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe6857b822925226d39fd4d6413457ef6bbaabec Gerrit-Change-Number: 18134 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 14 Sep 2022 23:58:06 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 ) Change subject: IMPALA-: Build the toolchain with GCC 10 .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa Gerrit-Change-Number: 18806 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 14 Sep 2022 23:40:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 ) Change subject: IMPALA-: Switch to GCC 10.4 .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe6857b822925226d39fd4d6413457ef6bbaabec Gerrit-Change-Number: 18134 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 14 Sep 2022 23:39:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18984 Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20 .. IMPALA-11585: Build quickstart_client with Ubuntu 20 Ubuntu 20.04 only provides the python3-pip package. Update building quickstart_client to use python3-pip on Ubuntu 20.04. Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4 --- M docker/CMakeLists.txt M docker/publish_images_to_apache.sh M docker/quickstart_client/Dockerfile 3 files changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/18984/1 -- To view, visit http://gerrit.cloudera.org:8080/18984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4 Gerrit-Change-Number: 18984 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith
[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4
Hello Andrew Sherman, Abhishek Rawat, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18134 to look at the new patch set (#13). Change subject: IMPALA-: Switch to GCC 10.4 .. IMPALA-: Switch to GCC 10.4 This upgrades GCC and libstdc++ to version 10.4. This required patching or upgrading several dependencies so they could compile with GCC 10. The toolchain companion change has details on what items needed to be upgraded and why. The toolchain companion change switches GCC to build with toolchain binutils rather than host binutils. This means that the python virtualenv initialization needs to include binutils on the path. This disables two warnings introduced in the new GCC versions (Wclass-memaccess and Winit-list-lifetime). These two warnings occur in our code and also in dependencies like LLVM and rapidjson. These are not critical warnings, so they can be addressed independently and reenabled later. Binary sizes increase, particulary when including debug symbols: | GCC 7.5 | GCC 10.4 impalad RELEASE stripped | 83204768 | 88702824 impalad RELEASE | 707278904 | 971711456 impalad DEBUG stripped | 106677672 | 97391944 impalad DEBUG| 725864760 | 867647512 Testing: - Multiple test jobs (core, release exhaustive, ASAN) - Performance testing for TPC-H and TPC-DS shows a modest improvement (2-4%). - Code compiles without warnings on debug and release Change-Id: Ibe6857b822925226d39fd4d6413457ef6bbaabec --- M be/CMakeLists.txt M be/src/codegen/llvm-codegen-test.cc M be/src/runtime/string-value.inline.h M be/src/udf/udf.cc M be/src/util/parquet-reader.cc M bin/impala-config.sh M fe/pom.xml M infra/python/bootstrap_virtualenv.py 8 files changed, 51 insertions(+), 20 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/18134/13 -- To view, visit http://gerrit.cloudera.org:8080/18134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibe6857b822925226d39fd4d6413457ef6bbaabec Gerrit-Change-Number: 18134 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18824 ) Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. Patch Set 4: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/11352/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic35c7460bdbd54b8ec5872a83680e2f41ceae9fd Gerrit-Change-Number: 18824 Gerrit-PatchSet: 4 Gerrit-Owner: Noemi Pap-Takacs Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Comment-Date: Wed, 14 Sep 2022 16:55:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18980 ) Change subject: IMPALA-11578: Exclude locality test for remote FS .. Patch Set 2: Ran into ~20 failures I don't have the time to parse at the moment, so I've reverted this to a more limited change. -- To view, visit http://gerrit.cloudera.org:8080/18980 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43 Gerrit-Change-Number: 18980 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 14 Sep 2022 16:49:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18824 ) Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18824/4/be/src/runtime/sorted-run-merger.cc File be/src/runtime/sorted-run-merger.cc: http://gerrit.cloudera.org:8080/#/c/18824/4/be/src/runtime/sorted-run-merger.cc@30 PS4, Line 30: SortedRunMerger::SortedRunWrapper::SortedRunWrapper(SortedRunMerger* parent, const RunBatchSupplierFn& sorted_run) line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/18824/4/be/src/runtime/sorted-run-merger.cc@169 PS4, Line 169: llvm::Function* fn = codegen->GetFunction(IRFunction::SORTED_RUN_MERGER_HEAPIFY_HELPER, true); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic35c7460bdbd54b8ec5872a83680e2f41ceae9fd Gerrit-Change-Number: 18824 Gerrit-PatchSet: 4 Gerrit-Owner: Noemi Pap-Takacs Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Comment-Date: Wed, 14 Sep 2022 16:45:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18824 Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. IMPALA-11477: Adding Codegen to sorted-run-merger SortedRunMerger is used to merge multiple, already sorted runs. It is used for external merge in the sorter (SortNode, PartialSortNode and TopNNode), and in KRPC data stream receiver (ExchangeNode). SortedRunMerger builds and maintains a min heap of the sorted input runs. Re-writed SortedRunMerger::Heapify from recursive to iterative and moved to a separate new source file: sorted-run-merger-ir.cc. Added a static Codegen() to SortedRunMerger and call it from the corresponding ExecNodes: SortNode, PartialSortNode, TopNPNode and ExchangeNode. This change lets the merger use the codegened version of TupleRowComparator instead of the interpreted one, which can increase the speed especially in case of complex comparison expressions. This change also serves as a base for further codegen-related optimizations in the merger. Change-Id: Ic35c7460bdbd54b8ec5872a83680e2f41ceae9fd --- M be/src/codegen/gen_ir_descriptions.py M be/src/codegen/impala-ir.cc M be/src/exec/exchange-node.cc M be/src/exec/exchange-node.h M be/src/exec/partial-sort-node.cc M be/src/exec/partial-sort-node.h M be/src/exec/sort-node.cc M be/src/exec/sort-node.h M be/src/exec/topn-node.cc M be/src/exec/topn-node.h M be/src/runtime/CMakeLists.txt M be/src/runtime/krpc-data-stream-recvr.cc M be/src/runtime/krpc-data-stream-recvr.h A be/src/runtime/sorted-run-merger-ir.cc M be/src/runtime/sorted-run-merger.cc M be/src/runtime/sorted-run-merger.h M be/src/runtime/sorter.cc M be/src/runtime/sorter.h 18 files changed, 227 insertions(+), 69 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/18824/4 -- To view, visit http://gerrit.cloudera.org:8080/18824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic35c7460bdbd54b8ec5872a83680e2f41ceae9fd Gerrit-Change-Number: 18824 Gerrit-PatchSet: 4 Gerrit-Owner: Noemi Pap-Takacs Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Noemi Pap-Takacs
[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
Baike Xia has posted comments on this change. (
http://gerrit.cloudera.org:8080/18940 )
Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
..
Patch Set 6:
(7 comments)
Hi all,
I have repaired it, and it is ready for review.
Thanks.
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/cup/sql-parser.cup@2347
PS5, Line 2347: tbl_properties:tbl_props
> nit: can we simplify these to "tbl_properties"?
Yes, this is right.
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java:
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java@71
PS5, Line 71: if (!(tableRef instanceof InlineViewRef)) {
> Does this work for materialized view (MV)? I think we represent MV as table
Yeah, not supposed to work. In the new submission, I added a judgment, and
throw exception if it was not InlineViewRef. Like you said, we represent MV as
tables, so, will also throw exception.
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java:
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@20
PS5, Line 20: import java.util.ArrayList;
> nit: we avoid using * in imports
Got
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@22
PS5, Line 22: import java.util.List;
> nit: move this to line 33
Got
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@341
PS5, Line 341: viewName
> nit: viewName
Got
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1501
PS5, Line 1501: AnalyzesOk("ALTER VIEW functional.alltypes_view SET
TBLPROPERTIES " +
> nit: don't need this trivial comment
Got
http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1511
PS5, Line 1511: AnalysisError("alter view
functional_orc_def.mv1_alltypes_jointbl " +
> Could you add analyze test for CreateView with tblproperties as well?
Got
--
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia
Gerrit-Reviewer: Aman Sinha
Gerrit-Reviewer: Baike Xia
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Wed, 14 Sep 2022 15:29:56 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18970 ) Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18970/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/18970/2/tests/query_test/test_scanners.py@437 PS2, Line 437: assert cnt_fail <= 5 > Restarted my impala cluster and ran it again, and this time it passes. Thanks Michael for looking into this. I suspect you had only one impalad running when 'assert 3 == 7' was observed. -- To view, visit http://gerrit.cloudera.org:8080/18970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I823542c21fe8f10f43a501fe4175da883eaf2f99 Gerrit-Change-Number: 18970 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 14 Sep 2022 13:19:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10791 Add batch reading for remote temporary files
Qifan Chen has posted comments on this change. (
http://gerrit.cloudera.org:8080/17979 )
Change subject: IMPALA-10791 Add batch reading for remote temporary files
..
Patch Set 21: Code-Review+1
(1 comment)
Looks great! Thanks Yida for the careful rework.
http://gerrit.cloudera.org:8080/#/c/17979/13/be/src/runtime/tmp-file-mgr.cc
File be/src/runtime/tmp-file-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/17979/13/be/src/runtime/tmp-file-mgr.cc@1078
PS13, Line 1078: [read_buffer_block, tmp_file = this](const Status&
fetch_status) {
> The function firstly check whether the local buffer exists (even batch read
Done
--
To view, visit http://gerrit.cloudera.org:8080/17979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dcc5d0881ffaeff09c5c514306cd668373ad31b
Gerrit-Change-Number: 17979
Gerrit-PatchSet: 21
Gerrit-Owner: Yida Wu
Gerrit-Reviewer: Abhishek Rawat
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Smith
Gerrit-Reviewer: Qifan Chen
Gerrit-Reviewer: Yida Wu
Gerrit-Comment-Date: Wed, 14 Sep 2022 13:13:48 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 ) Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18 Gerrit-Change-Number: 18940 Gerrit-PatchSet: 6 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 14 Sep 2022 13:00:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 ) Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. Patch Set 3: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8570/ -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 3 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Wed, 14 Sep 2022 12:51:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11580: Fix memory leak in legacy catalog mode when applying incremental partition updates
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18978 ) Change subject: IMPALA-11580: Fix memory leak in legacy catalog mode when applying incremental partition updates .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18978/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18978/1//COMMIT_MSG@13 PS1, Line 13: reference to the old table object remains unchanged Can't this also cause bugs? Or while the new / old table are different objects, they are functionally equivalent? -- To view, visit http://gerrit.cloudera.org:8080/18978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie04ff243c6b82c1a06c489da74353f2d8afe423a Gerrit-Change-Number: 18978 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 14 Sep 2022 12:43:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 ) Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8571/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18 Gerrit-Change-Number: 18940 Gerrit-PatchSet: 6 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 14 Sep 2022 08:14:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 ) Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8569/ -- To view, visit http://gerrit.cloudera.org:8080/18940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18 Gerrit-Change-Number: 18940 Gerrit-PatchSet: 6 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 14 Sep 2022 07:49:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 ) Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8570/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 3 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Wed, 14 Sep 2022 07:33:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 ) Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. Patch Set 3: > Patch Set 3: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8568/ The failure is a flaky test tracked in IMPALA-11508 https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6311 -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 3 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Wed, 14 Sep 2022 07:33:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 ) Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8568/ -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 3 Gerrit-Owner: Xianqing He Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Xianqing He Gerrit-Comment-Date: Wed, 14 Sep 2022 07:11:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table
Xiang Yang has abandoned this change. ( http://gerrit.cloudera.org:8080/18812 ) Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table .. Abandoned duplicated with IMPALA-11565 -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Xiang Yang
