[Impala-ASF-CR] WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module.
Xiang Yang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20929 Change subject: WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module. .. WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module. Add admissiond service and impala-profile-tool to packaging module. Testing: - Manually deploy packages on Ubuntu22.04 and verify it. Change-Id: I594742037a05d4d74d6a2bc011619713f7ca12e4 --- M be/src/service/CMakeLists.txt M be/src/util/CMakeLists.txt A package/conf/admissiond_flags 3 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/20929/2 -- To view, visit http://gerrit.cloudera.org:8080/20929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I594742037a05d4d74d6a2bc011619713f7ca12e4 Gerrit-Change-Number: 20929 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Yang
[Impala-ASF-CR] WIP IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.
Xiang Yang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20928 Change subject: WIP IMPALA-12362: (part-2/4) Optimize default configurations for packaging module. .. WIP IMPALA-12362: (part-2/4) Optimize default configurations for packaging module. To avoid absolutely paths and keep it simple, optimize the default configurations for packaging module by remove or change some entries. At the same time, add license header to 'package/conf/*-site.xml' and rename them to '*-site.xml.template' to force administrator making configurations appropriate for their cluster. Testing: - Manually deploy packages on Ubuntu22.04 and verify it. Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66 --- M package/bin/start-catalogd.sh M package/bin/start-impalad.sh M package/bin/start-statestored.sh M package/conf/catalogd_flags D package/conf/core-site.xml A package/conf/core-site.xml.template D package/conf/fair-scheduler.xml A package/conf/fair-scheduler.xml.template D package/conf/hdfs-site.xml A package/conf/hdfs-site.xml.template D package/conf/hive-site.xml A package/conf/hive-site.xml.template M package/conf/impalad_flags D package/conf/llama-site.xml A package/conf/llama-site.xml.template M package/conf/statestore_flags 16 files changed, 266 insertions(+), 117 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/20928/4 -- To view, visit http://gerrit.cloudera.org:8080/20928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66 Gerrit-Change-Number: 20928 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20929 ) Change subject: WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15006/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I594742037a05d4d74d6a2bc011619713f7ca12e4 Gerrit-Change-Number: 20929 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 20 Jan 2024 12:18:46 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module.
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20929 to look at the new patch set (#3). Change subject: WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module. .. WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module. Add admissiond service and impala-profile-tool to packaging module. Testing: - Manually deploy packages on Ubuntu22.04 and verify it. Change-Id: I594742037a05d4d74d6a2bc011619713f7ca12e4 --- M be/src/service/CMakeLists.txt M be/src/util/CMakeLists.txt A package/conf/admissiond_flags 3 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/20929/3 -- To view, visit http://gerrit.cloudera.org:8080/20929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I594742037a05d4d74d6a2bc011619713f7ca12e4 Gerrit-Change-Number: 20929 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] WIP IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20928 ) Change subject: WIP IMPALA-12362: (part-2/4) Optimize default configurations for packaging module. .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15007/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66 Gerrit-Change-Number: 20928 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 20 Jan 2024 12:19:28 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20929 ) Change subject: WIP IMPALA-12362: (part-3/4) Add more binaries to packaging module. .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15008/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I594742037a05d4d74d6a2bc011619713f7ca12e4 Gerrit-Change-Number: 20929 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 20 Jan 2024 12:42:54 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files.
Hello Quanlong Huang, Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20263 to look at the new patch set (#7). Change subject: WIP IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. .. WIP IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. independent linux packaging related content to package/CMakeLists.txt. Testing: - Manually deploy package on Ubuntu22.04 and verify it. Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b --- M .gitignore M CMakeLists.txt A package/CMakeLists.txt 3 files changed, 133 insertions(+), 106 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/20263/7 -- To view, visit http://gerrit.cloudera.org:8080/20263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 20263 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] WIP IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files.
Xiang Yang has posted comments on this change. (
http://gerrit.cloudera.org:8080/20263 )
Change subject: WIP IMPALA-12362: (part-4/4) Refactor linux packaging related
cmake files.
..
Patch Set 7:
(8 comments)
> Patch Set 6:
>
> (8 comments)
>
> Thanks for improving the packaging support! There are several independent
> topics in this patch, e.g. CMake files refactoring, scripts refactoring,
> default configuration changes, adding more binaries, etc. To be easier for
> review, It'd be nice to split this into several smaller patches.
Hi quanlong, thanks for your review! I've splitted the original patch into 4
smaller patches:
https://gerrit.cloudera.org/c/20921/
https://gerrit.cloudera.org/c/20928/
https://gerrit.cloudera.org/c/20929/
https://gerrit.cloudera.org/c/20263/ (self)
There are dependencies between them, so you can review them one by one.
http://gerrit.cloudera.org:8080/#/c/20263/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20263/6//COMMIT_MSG@18
PS6, Line 18:
> It'd be nice to also add impala-profile-tool so users can parse the thrift
Done in https://gerrit.cloudera.org/c/20929/
http://gerrit.cloudera.org:8080/#/c/20263/6/package/CMakeLists.txt
File package/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/20263/6/package/CMakeLists.txt@28
PS6, Line 28: install(TARGETS impalad DESTINATION ${IMPALA_INSTALLDIR}/sbin)
:
: install(FILES ${CMAKE_SOURCE_DIR}/LICENSE.txt DESTINATION
${IMPALA_INSTALLDIR})
: install(DIRECTORY "${CMAKE_SOURCE_DIR}/www/" DESTINATION ${IMP
> We already have these in be/src/service/CMakeLists.txt. Do we need to dupli
Done
http://gerrit.cloudera.org:8080/#/c/20263/6/package/bin/impala.sh
File package/bin/impala.sh:
http://gerrit.cloudera.org:8080/#/c/20263/6/package/bin/impala.sh@21
PS6, Line 21:
> nit: customize
Done in https://gerrit.cloudera.org/c/20921/
http://gerrit.cloudera.org:8080/#/c/20263/6/package/bin/impala.sh@22
PS6, Line 22:
> nit: customize
same as above
http://gerrit.cloudera.org:8080/#/c/20263/6/package/bin/impala.sh@49
PS6, Line 49:
> nit: don't need "else"
what do you mean? remove the else branch, or keep the content out of the if
logical block?
http://gerrit.cloudera.org:8080/#/c/20263/6/package/bin/impala.sh@109
PS6, Line 109:
> Any reason for removing the logic of wait_for_ready? I think it's helpful w
Generally service startup tools (such as systemd, or the startup script for
apache doris) won't block until the service is available, but split the health
check function into separate commands, so I add a 'status' subcommand to check
the service health.
The reason for only checking if the process is alive is that the webserver may
be disabled, thus checking the '/healthz' interface is not a precise way to do
it.
http://gerrit.cloudera.org:8080/#/c/20263/6/package/conf/catalogd_flags
File package/conf/catalogd_flags:
http://gerrit.cloudera.org:8080/#/c/20263/6/package/conf/catalogd_flags@a9
PS6, Line 9:
> Why do we remove this? Without the correct doc root, the webUI might not be
I don't want to write dead a path in default configurations, I found that
'webserver_doc_root' default to $IMPALA_HOME:
https://github.com/apache/impala/blob/4.3.0/be/src/util/webserver.cc#L187, so I
export IMPALA_HOME variable in https://gerrit.cloudera.org/c/20928.
http://gerrit.cloudera.org:8080/#/c/20263/6/package/conf/catalogd_flags@20
PS6, Line 20:
> We should set -v=1 explicitly. Otherwise, no INFO logs will be shown. The d
Done in https://gerrit.cloudera.org/c/20928/
--
To view, visit http://gerrit.cloudera.org:8080/20263
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b
Gerrit-Change-Number: 20263
Gerrit-PatchSet: 7
Gerrit-Owner: Xiang Yang
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Laszlo Gaal
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Xiang Yang
Gerrit-Comment-Date: Sat, 20 Jan 2024 12:59:06 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12362: (part-1/4) Refactor service management scripts.
Xiang Yang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/20921 ) Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. .. IMPALA-12362: (part-1/4) Refactor service management scripts. Uniform all service management scripts to 'bin/impala.sh', administrator can customize environment variables based on their cluster at 'conf/impala-env.sh', as well as set flags at 'conf/impalad_flags...'. Usually administrator can override the environment variables in 'conf/impala-env.sh' with commandline arguments. The same is true for flags in 'conf/impalad_flags...'. This flexibility can be used in scenarios such as supporting multi-instance deployments. The directory structure has been adjusted as follows: - put java libs to 'lib/jars' directory. - put native libs to 'lib/native' directory. - put impalad binary to 'sbin' directory. Testing: - Manually deploy packages on Ubuntu22.04 and verify it. Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 --- M CMakeLists.txt M be/src/service/CMakeLists.txt D package/bin/impala-env.sh A package/bin/impala.sh D package/bin/start-catalogd.sh D package/bin/start-impalad.sh D package/bin/start-statestored.sh D package/bin/stop-catalogd.sh D package/bin/stop-impalad.sh D package/bin/stop-statestored.sh A package/conf/impala-env.sh R package/conf/statestored_flags 12 files changed, 217 insertions(+), 287 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/20921/7 -- To view, visit http://gerrit.cloudera.org:8080/20921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 Gerrit-Change-Number: 20921 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] WIP IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20263 ) Change subject: WIP IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15009/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 20263 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiang Yang Gerrit-Comment-Date: Sat, 20 Jan 2024 13:21:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12362: (part-1/4) Refactor service management scripts.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20921 ) Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15010/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 Gerrit-Change-Number: 20921 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 20 Jan 2024 13:27:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12362: (part-1/4) Refactor service management scripts.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20921 ) Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10181/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 Gerrit-Change-Number: 20921 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 20 Jan 2024 13:32:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 ) Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5 Gerrit-Change-Number: 20763 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Sat, 20 Jan 2024 13:48:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 ) Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10182/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5 Gerrit-Change-Number: 20763 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Sat, 20 Jan 2024 13:48:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12362: (part-1/4) Refactor service management scripts.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20921 ) Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 Gerrit-Change-Number: 20921 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 20 Jan 2024 17:52:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 ) Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5 Gerrit-Change-Number: 20763 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Tamas Mate Gerrit-Comment-Date: Sat, 20 Jan 2024 18:17:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20763 ) Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04 .. IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04 Ubuntu 20.04 locked down access to the kernel messages, so a call to 'dmesg' can succeed only when executed with elevated privileges. This could be a problem during Impala precommit runs, as the finalizer script uses 'dmesg' to detect potential OOM-kills during the run. This patch adds an "escalation" step to the dmesg call: if the regular call fails, it issues a second call via 'sudo'. Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5 Reviewed-on: http://gerrit.cloudera.org:8080/20763 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/jenkins/finalize.sh 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic20193740c6e5cb9e8e155c03bede55184875de5 Gerrit-Change-Number: 20763 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Tamas Mate
