[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys
Wenzhe Zhou has posted comments on this change. (
http://gerrit.cloudera.org:8080/21382 )
Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys
..
Patch Set 21:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java
File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java:
http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@573
PS21, Line 573: "", statestoreWebserverArgs, 0
If read jwks from local file, then don't need these three parameters, and don't
need variable statestoreWebserverArgs
http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@585
PS21, Line 585: impala
Should be 'jwt-cpp.example.localhost'
http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@598
PS21, Line 598: // Authenticate fails due JWT verification failure since the
RS256 public key cannot
: // be found in the JWKS.
: transport.setCustomHeaders(headers);
: try {
: openResp = client.OpenSession(openReq);
: } catch (Exception e) {
: verifyJwtAuthMetrics(3, 1);
: assertEquals(e.getMessage(), "HTTP Response code: 401");
: }
This negative test is dependent on the JWKS change in running time. It should
be removed since you read JWKS from local file now, and jwks will not be
changed in running time.
--
To view, visit http://gerrit.cloudera.org:8080/21382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74
Gerrit-Change-Number: 21382
Gerrit-PatchSet: 21
Gerrit-Owner: gaurav singh
Gerrit-Reviewer: Abhishek Rawat
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jason Fehr
Gerrit-Reviewer: Wenzhe Zhou
Gerrit-Reviewer: gaurav singh
Gerrit-Comment-Date: Tue, 14 May 2024 00:44:00 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. IMPALA-13051: Speed up, refactor query log tests Sets faster default shutdown_grace_period_s and shutdown_deadline_s when impalad_graceful_shutdown=True in tests. Impala waits until grace period has passed and all queries are stopped (or deadline is exceeded) before flushing the query log, so grace period of 0 is sufficient. Adds them in setup_method to reduce duplication in test declarations. Re-uses TQueryTableColumn Thrift definitions for testing. Moves waiting for query log table to exist to setup_method rather than as a side-effect of get_client. Refactors workload management code to reduce if-clause nesting. Adds functional query workload tests for both the sys.impala_query_log and the sys.impala_query_live tables to assert the names and order of the individual columns within each table. Renames the python tests for the sys.impala_query_log table removing the unnecessary "_query_log_table_" string from the name of each test. Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Reviewed-on: http://gerrit.cloudera.org:8080/21358 Tested-by: Impala Public Jenkins Reviewed-by: Riza Suminto --- M be/src/service/workload-management.cc A testdata/workloads/functional-query/queries/QueryTest/workload-management-live.test A testdata/workloads/functional-query/queries/QueryTest/workload-management-log.test M tests/common/custom_cluster_test_suite.py M tests/custom_cluster/test_query_live.py M tests/custom_cluster/test_query_log.py M tests/util/workload_management.py 7 files changed, 492 insertions(+), 515 deletions(-) Approvals: Impala Public Jenkins: Verified Riza Suminto: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 13 May 2024 22:46:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys
gaurav singh has posted comments on this change. (
http://gerrit.cloudera.org:8080/21382 )
Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys
..
Patch Set 21:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/21382/20/be/src/util/jwt-util-test.cc
File be/src/util/jwt-util-test.cc:
http://gerrit.cloudera.org:8080/#/c/21382/20/be/src/util/jwt-util-test.cc@460
PS20, Line 460: kid_x5c)
> This code is using the string "kid_x5c" but should be using the variable ki
Done
http://gerrit.cloudera.org:8080/#/c/21382/20/be/src/util/jwt-util.cc
File be/src/util/jwt-util.cc:
http://gerrit.cloudera.org:8080/#/c/21382/20/be/src/util/jwt-util.cc@157
PS20, Line 157: if (!values[0].empty()) {
> This statement needs an "else" clause.
Added. Thanks.
http://gerrit.cloudera.org:8080/#/c/21382/20/be/src/util/jwt-util.cc@158
PS20, Line 158: = values[0];
> enclose this line with { } to follow coding style.
Done
http://gerrit.cloudera.org:8080/#/c/21382/20/be/src/util/jwt-util.cc@258
PS20, Line 258:
> Line 251 allow different json type, here assume it's string. Please keep co
In Line 251, we assert that the json_value is of type array. and here we are
extracting a string since value is of type cpp_type which is *string or
[]string.
http://gerrit.cloudera.org:8080/#/c/21382/20/be/src/util/jwt-util.cc@395
PS20, Line 395: algorithm = "rs384";
> If the certificate algorithm is not supported, then the users will get an e
Added. Thanks.
http://gerrit.cloudera.org:8080/#/c/21382/20/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java
File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java:
http://gerrit.cloudera.org:8080/#/c/21382/20/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@110
PS20, Line 110:
> This function currently use fixed json file. You may add new input paramete
Reading the jwks directly from the local file instead of jwks url now.
http://gerrit.cloudera.org:8080/#/c/21382/20/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@575
PS20, Line 575: lient transport = new THttpClient("http://local
> add a new parameter to pass jwks_x5c_rs256.json
Reading the jwks from local file instead of the jwks url now.
http://gerrit.cloudera.org:8080/#/c/21382/20/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@600
PS20, Line 600: transport.setCustomHeaders(headers);
: try {
: openResp = client.OpenSession(openReq);
: } catch (Exception e) {
: verifyJwtAuthMetrics(3, 1);
: assertEquals(e.getMessage(), "HTTP Response code: 401");
: }
: }
:
: /**
:* Asserts that the specified string is present in the
impalad.ERROR file within the
:* specified log directory.
:*
> This function block seems copying from testJwtAuthWithJwksHttpUrl(). In tha
Removed. Now loading the jwks from local file directly.
--
To view, visit http://gerrit.cloudera.org:8080/21382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74
Gerrit-Change-Number: 21382
Gerrit-PatchSet: 21
Gerrit-Owner: gaurav singh
Gerrit-Reviewer: Abhishek Rawat
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jason Fehr
Gerrit-Reviewer: Wenzhe Zhou
Gerrit-Reviewer: gaurav singh
Gerrit-Comment-Date: Mon, 13 May 2024 22:23:15 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#21). Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys This enables the jwt verification using the x5c certificate(s) in the RSA jwks keys. The x5c claim can be part of the jwks either as a string or an array. This patch only supports a single x5c certificate per jwk. If the "x5c" is present and "alg" is not present, then "alg" is extracted from the "x5c" certificate using the signature algorithm. However, if "x5c" is not preseent, then "alg" is a mandatory field on jwk. Current mapping of signature algorithm string => algorithm: sha256WithRSAEncryption => rs256 sha384WithRSAEncryption => rs384 sha512WithRSAEncryption => rs512 If "x5c" is present, then it is given priority over other mandatory fields like "n", "e" to construct the public key. Testing: * added unit test VerifyJwtTokenWithx5cCertificate to verify jwt with x5c certificate. * added unit test VerifyJwtTokenWithx5cCertificateWithoutAlg to verify jwt with x5c certificate without "alg". * added e2e test testJwtAuthWithJwksX5cHttpUrl to verify jwt with x5c certificate. Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74 --- M be/src/util/jwt-util-test.cc M be/src/util/jwt-util.cc M fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java A testdata/jwt/jwks_x5c_rs256.json 4 files changed, 356 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/21382/21 -- To view, visit http://gerrit.cloudera.org:8080/21382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74 Gerrit-Change-Number: 21382 Gerrit-PatchSet: 21 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 13 May 2024 21:23:35 + Gerrit-HasComments: No
[Impala-ASF-CR](branch-3.4.2) IMPALA-9577: [test] Use `system unsync` time for Kudu test clusters
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21422 ) Change subject: IMPALA-9577: [test] Use `system_unsync` time for Kudu test clusters .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-3.4.2 Gerrit-MessageType: comment Gerrit-Change-Id: Id99e5cb58ab988c3ad4f98484be8db193d5eaf99 Gerrit-Change-Number: 21422 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Mon, 13 May 2024 17:25:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/21382/20/testdata/jwt/jwks_x5c_rs256.json File testdata/jwt/jwks_x5c_rs256.json: http://gerrit.cloudera.org:8080/#/c/21382/20/testdata/jwt/jwks_x5c_rs256.json@10 PS20, Line 10: "MIIE2jCCAsICAQ > I'm not seeing where the double quote is missing. The end of the line has The double quote is not shown in the UI of gerrit. I just downloaded the patch and checked this json file on local machine. There is double quote in the end of line. False alarm. -- To view, visit http://gerrit.cloudera.org:8080/21382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74 Gerrit-Change-Number: 21382 Gerrit-PatchSet: 20 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Mon, 13 May 2024 16:22:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 10: Code-Review+1 Looks good to me. I will give my +2 if no one else has any new comment and DRY_RUN pass. -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 13 May 2024 16:19:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10638/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 13 May 2024 16:19:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/21358/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21358/9//COMMIT_MSG@19 PS9, Line 19: : Refactors workload management code to reduce if-clause nesting. > nit: Mention new tests added since patch set 6. Done -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 13 May 2024 16:01:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests
Jason Fehr has uploaded a new patch set (#10) to the change originally created by Michael Smith. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. IMPALA-13051: Speed up, refactor query log tests Sets faster default shutdown_grace_period_s and shutdown_deadline_s when impalad_graceful_shutdown=True in tests. Impala waits until grace period has passed and all queries are stopped (or deadline is exceeded) before flushing the query log, so grace period of 0 is sufficient. Adds them in setup_method to reduce duplication in test declarations. Re-uses TQueryTableColumn Thrift definitions for testing. Moves waiting for query log table to exist to setup_method rather than as a side-effect of get_client. Refactors workload management code to reduce if-clause nesting. Adds functional query workload tests for both the sys.impala_query_log and the sys.impala_query_live tables to assert the names and order of the individual columns within each table. Renames the python tests for the sys.impala_query_log table removing the unnecessary "_query_log_table_" string from the name of each test. Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 --- M be/src/service/workload-management.cc A testdata/workloads/functional-query/queries/QueryTest/workload-management-live.test A testdata/workloads/functional-query/queries/QueryTest/workload-management-log.test M tests/common/custom_cluster_test_suite.py M tests/custom_cluster/test_query_live.py M tests/custom_cluster/test_query_log.py M tests/util/workload_management.py 7 files changed, 492 insertions(+), 515 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/21358/10 -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/21382/20/testdata/jwt/jwks_x5c_rs256.json File testdata/jwt/jwks_x5c_rs256.json: http://gerrit.cloudera.org:8080/#/c/21382/20/testdata/jwt/jwks_x5c_rs256.json@10 PS20, Line 10: "MIIE2jCCAsICAQ > missing double quote in the end of line I'm not seeing where the double quote is missing. The end of the line has a double quotes: X8yJuz4gA==" I copied this file and ran its contents through jq to look for parsing errors. It did not show any issues with this file. -- To view, visit http://gerrit.cloudera.org:8080/21382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74 Gerrit-Change-Number: 21382 Gerrit-PatchSet: 20 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jason Fehr Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Mon, 13 May 2024 15:53:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] xxxx HA
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21418 to look at the new patch set (#5). Change subject: HA .. HA Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3 --- M be/src/statestore/statestore-catalogd-mgr.cc M be/src/statestore/statestore-catalogd-mgr.h M be/src/statestore/statestore.cc M be/src/statestore/statestore.h M common/thrift/StatestoreService.thrift A www/catalog-ha-info.tmpl 6 files changed, 249 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/21418/5 -- To view, visit http://gerrit.cloudera.org:8080/21418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3 Gerrit-Change-Number: 21418 Gerrit-PatchSet: 5 Gerrit-Owner: ttz <2433038...@qq.com> Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] xxxx HA
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21418 to look at the new patch set (#4). Change subject: HA .. HA Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3 --- M be/src/statestore/statestore-catalogd-mgr.cc M be/src/statestore/statestore-catalogd-mgr.h M be/src/statestore/statestore.cc M be/src/statestore/statestore.h M common/thrift/StatestoreService.thrift A www/catalog-ha-info.tmpl 6 files changed, 249 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/21418/4 -- To view, visit http://gerrit.cloudera.org:8080/21418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3 Gerrit-Change-Number: 21418 Gerrit-PatchSet: 4 Gerrit-Owner: ttz <2433038...@qq.com> Gerrit-Reviewer: Impala Public Jenkins
