[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..

IMPALA-6479: Update DESCRIBE to respect column privileges

Modified the Frontend to filter columns from the DESCRIBE
statement.  Additionally, if a user has select on at least
one column, they can run DESCRIBE and see most metadata.
If they do not have full table access, they will not see
location or view query metadata.

Testing:
Added tests to validate users that have one or more column
access can run describe and that the output is filtered
accordingly.

Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Reviewed-on: http://gerrit.cloudera.org:8080/9276
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/12292
Reviewed-by: Fredy Wijaya 
Tested-by: Impala Public Jenkins 
---
M be/src/service/client-request-state.cc
M be/src/service/frontend.cc
M be/src/service/frontend.h
M common/thrift/Frontend.thrift
M fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/catalog/Column.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
13 files changed, 331 insertions(+), 69 deletions(-)

Approvals:
  Fredy Wijaya: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Fri, 01 Feb 2019 08:26:11 +
Gerrit-HasComments: No


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3696/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Fri, 01 Feb 2019 04:35:02 +
Gerrit-HasComments: No


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 2:

> Patch Set 2: Code-Review+2
>
> I spoke to Bharath offline and he no longer has any concern. Feel free to 
> merge this CR.

Sure. Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Fri, 01 Feb 2019 04:31:28 +
Gerrit-HasComments: No


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-31 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 2: Code-Review+2

I spoke to Bharath offline and he no longer has any concern. Feel free to merge 
this CR.


--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Fri, 01 Feb 2019 03:09:14 +
Gerrit-HasComments: No


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/1928/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Wed, 30 Jan 2019 02:15:06 +
Gerrit-HasComments: No


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-29 Thread Quanlong Huang (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Alex Behm, Impala Public Jenkins, 
Adam Holley,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12292

to look at the new patch set (#2).

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..

IMPALA-6479: Update DESCRIBE to respect column privileges

Modified the Frontend to filter columns from the DESCRIBE
statement.  Additionally, if a user has select on at least
one column, they can run DESCRIBE and see most metadata.
If they do not have full table access, they will not see
location or view query metadata.

Testing:
Added tests to validate users that have one or more column
access can run describe and that the output is filtered
accordingly.

Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Reviewed-on: http://gerrit.cloudera.org:8080/9276
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins
---
M be/src/service/client-request-state.cc
M be/src/service/frontend.cc
M be/src/service/frontend.h
M common/thrift/Frontend.thrift
M fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/catalog/Column.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
13 files changed, 331 insertions(+), 69 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12292/2
--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-29 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 1:

(2 comments)

> Patch Set 1: Code-Review-1
>
> This is a compatibility breaking fix for 2.x. Unless there is a strong case, 
> I'd prefer not to merge this as is. Thoughts?

This is picked in CDH branch too: 
https://github.com/cloudera/Impala/commit/f8a318d4f75e22a963b9cf4786ef07d2cd6bd93c

Is it really a compatibility breaking fix for 2.x? I'm going to pick 
https://gerrit.cloudera.org/c/10643/ right after this. Then we may be able to 
let the cherrypick-2.x-and-test job move forward for several commits.

http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
File fe/src/test/java/org/apache/impala/analysis/AuditingTest.java:

http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java@316
PS1, Line 316: ANY
> This is actually a bug that got fixed here: https://gerrit.cloudera.org/c/1
Sure!


http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1804
PS1, Line 1804: // Insufficient privileges on column that is not a complex 
type, trying to access member.
> line too long (93 > 90)
Done



--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 29 Jan 2019 23:13:59 +
Gerrit-HasComments: Yes


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/1914/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 29 Jan 2019 22:47:45 +
Gerrit-HasComments: No


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 1: Code-Review-1

This is a compatibility breaking fix for 2.x. Unless there is a strong case, 
I'd prefer not to merge this as is. Thoughts?


--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 29 Jan 2019 22:40:20 +
Gerrit-HasComments: No


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1804
PS1, Line 1804: // Insufficient privileges on column that is not a complex 
type, trying to access member.
line too long (93 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 29 Jan 2019 21:29:17 +
Gerrit-HasComments: Yes


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
File fe/src/test/java/org/apache/impala/analysis/AuditingTest.java:

http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java@316
PS1, Line 316: ANY
This is actually a bug that got fixed here: 
https://gerrit.cloudera.org/c/11617/. Make sure we don't forget to cherry pick 
the fix as well.



-- 
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 29 Jan 2019 16:56:49 +
Gerrit-HasComments: Yes


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..


Patch Set 1:

I'm currently working on moving forward branch-2.x. For the first patch, 
"0b540b025 IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, 
Partition", the cherry-pick conflicts is due to the revert of IMPALA-6479 in 
2.x. So here we backport IMPALA-6479 again.

It's a clean cherry-pick but fail some tests. Applied following changes to fix 
the tests.

diff --git a/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java 
b/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
index 5a953ad..933ead7 100644
--- a/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
+++ b/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
@@ -1860,6 +1860,7 @@ public class AuthorizationTest extends FrontendTestBase {
   "","NULL","NULL",
   "# Detailed Table Information","NULL","NULL",
   "Database:","functional","NULL",
+  "OwnerType:","USER","NULL",
   "Owner:","*","NULL",
   "CreateTime:","*","NULL",
   "LastAccessTime:","UNKNOWN","NULL",
@@ -1871,6 +1872,7 @@ public class AuthorizationTest extends FrontendTestBase {
   "","DO_NOT_UPDATE_STATS","true",
   "","EXTERNAL","TRUE",
   "","STATS_GENERATED_VIA_STATS_TASK","true",
+  "","impala.lastComputeStatsTime","*",
   "","numRows","11000",
   "","totalSize","834279",
   "","transient_lastDdlTime","*",
@@ -1905,6 +1907,7 @@ public class AuthorizationTest extends FrontendTestBase {
   "","NULL","NULL",
   "# Detailed Table Information","NULL","NULL",
   "Database:","functional","NULL",
+  "OwnerType:","USER","NULL",
   "Owner:","*","NULL",
   "CreateTime:","*","NULL",
   "LastAccessTime:","UNKNOWN","NULL",
@@ -1915,6 +1918,7 @@ public class AuthorizationTest extends FrontendTestBase {
   "","DO_NOT_UPDATE_STATS","true",
   "","EXTERNAL","TRUE",
   "","STATS_GENERATED_VIA_STATS_TASK","true",
+  "","impala.lastComputeStatsTime","*",
   "","numRows","100",
   "","totalSize","6472",
   "","transient_lastDdlTime","*",


--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Tue, 29 Jan 2019 07:21:36 +
Gerrit-HasComments: No


[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-28 Thread Quanlong Huang (Code Review)
Hello Alex Behm, Impala Public Jenkins,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/12292

to review the following change.


Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
..

IMPALA-6479: Update DESCRIBE to respect column privileges

Modified the Frontend to filter columns from the DESCRIBE
statement.  Additionally, if a user has select on at least
one column, they can run DESCRIBE and see most metadata.
If they do not have full table access, they will not see
location or view query metadata.

Testing:
Added tests to validate users that have one or more column
access can run describe and that the output is filtered
accordingly.

Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Reviewed-on: http://gerrit.cloudera.org:8080/9276
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins
---
M be/src/service/client-request-state.cc
M be/src/service/frontend.cc
M be/src/service/frontend.h
M common/thrift/Frontend.thrift
M fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/catalog/Column.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
13 files changed, 330 insertions(+), 69 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12292/1
--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins