[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10497 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Trimming build-all-flag-combinations and adding minicluster profile. [For the 2.x branch cherrypick, this change removes the "profile" stuff.] build-all-flag-combinations.sh is the long pole in pre-commit testing. It takes about 2.5 hours and runs about 40 builds per the following. $ curl --silent https://jenkins.impala.io/job/all-build-options-ub1604/1707/consoleText | grep 'Building with OPTIONS' | wc -l 40 This commit changes this to run only 7 builds, exercising every path, but not every combination of paths. The paths exercised are: Options -skiptests -noclean and profile 3 Options -skiptests -noclean -so and profile 2 Options -skiptests -noclean -release and profile 3 Options -skiptests -noclean -release -so -ninja and profile 3 Options -skiptests -noclean -asan and profile 3 Options -skiptests -noclean -ubsan -so -ninja and profile 2 Options -skiptests -noclean -tsan and profile 3 I've also added explicitly building with both minicluster profiles and a trivial dryrun option to print the above. The options are simply hard-coded rather than being clever and generating them. We decided this was easier to deal with. Change-Id: I258732a3d963958f76d99f9d7b51450ed67bec21 Reviewed-on: http://gerrit.cloudera.org:8080/10489 Reviewed-by: Joe McDonnell Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/10497 --- M bin/jenkins/build-all-flag-combinations.sh 1 file changed, 41 insertions(+), 30 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: I258732a3d963958f76d99f9d7b51450ed67bec21 Gerrit-Change-Number: 10497 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10497 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I258732a3d963958f76d99f9d7b51450ed67bec21 Gerrit-Change-Number: 10497 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 24 May 2018 16:14:11 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10497 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I258732a3d963958f76d99f9d7b51450ed67bec21 Gerrit-Change-Number: 10497 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 24 May 2018 07:40:47 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.
Hello Joe McDonnell, Tim Armstrong, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10497 to review the following change. Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Trimming build-all-flag-combinations and adding minicluster profile. [For the 2.x branch cherrypick, this change removes the "profile" stuff.] build-all-flag-combinations.sh is the long pole in pre-commit testing. It takes about 2.5 hours and runs about 40 builds per the following. $ curl --silent https://jenkins.impala.io/job/all-build-options-ub1604/1707/consoleText | grep 'Building with OPTIONS' | wc -l 40 This commit changes this to run only 7 builds, exercising every path, but not every combination of paths. The paths exercised are: Options -skiptests -noclean and profile 3 Options -skiptests -noclean -so and profile 2 Options -skiptests -noclean -release and profile 3 Options -skiptests -noclean -release -so -ninja and profile 3 Options -skiptests -noclean -asan and profile 3 Options -skiptests -noclean -ubsan -so -ninja and profile 2 Options -skiptests -noclean -tsan and profile 3 I've also added explicitly building with both minicluster profiles and a trivial dryrun option to print the above. The options are simply hard-coded rather than being clever and generating them. We decided this was easier to deal with. Change-Id: I258732a3d963958f76d99f9d7b51450ed67bec21 Reviewed-on: http://gerrit.cloudera.org:8080/10489 Reviewed-by: Joe McDonnell Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M bin/jenkins/build-all-flag-combinations.sh 1 file changed, 41 insertions(+), 30 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/10497/1 -- To view, visit http://gerrit.cloudera.org:8080/10497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newchange Gerrit-Change-Id: I258732a3d963958f76d99f9d7b51450ed67bec21 Gerrit-Change-Number: 10497 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10497 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2542/ -- To view, visit http://gerrit.cloudera.org:8080/10497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I258732a3d963958f76d99f9d7b51450ed67bec21 Gerrit-Change-Number: 10497 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 24 May 2018 04:06:30 + Gerrit-HasComments: No
