[Impala-ASF-CR](asf-site) IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo

2023-09-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20403 )

Change subject: IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/20403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I93083b999ec404ca3f407977b8e930b85a53b695
Gerrit-Change-Number: 20403
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Mon, 11 Sep 2023 22:33:54 +
Gerrit-HasComments: No


[Impala-ASF-CR](asf-site) IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo

2023-09-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/20403 )

Change subject: IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo
..

IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo

https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/js/bootstrap.min.js
is also slow to download in China and it usually fails at last.

This adds the file to the asf-site branch so the website can use a local
copy of it.

Tests:
 - Verified the pages locally.

Change-Id: I93083b999ec404ca3f407977b8e930b85a53b695
Reviewed-on: http://gerrit.cloudera.org:8080/20403
Reviewed-by: Daniel Becker 
Tested-by: Quanlong Huang 
---
M bylaws.html
M community.html
M downloads.html
M impala-docs.html
M index.html
A js/bootstrap-3.3.5.min.js
D js/bootstrap.js
D js/bootstrap.min.js
M overview.html
9 files changed, 13 insertions(+), 2,296 deletions(-)

Approvals:
  Daniel Becker: Looks good to me, approved
  Quanlong Huang: Verified

--
To view, visit http://gerrit.cloudera.org:8080/20403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: merged
Gerrit-Change-Id: I93083b999ec404ca3f407977b8e930b85a53b695
Gerrit-Change-Number: 20403
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 


[Impala-ASF-CR](asf-site) IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo

2023-09-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20403 )

Change subject: IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/20403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I93083b999ec404ca3f407977b8e930b85a53b695
Gerrit-Change-Number: 20403
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Mon, 11 Sep 2023 13:01:34 +
Gerrit-HasComments: No


[Impala-ASF-CR](asf-site) IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo

2023-09-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20403 )

Change subject: IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo
..


Patch Set 1:

> Patch Set 1: Code-Review+1
>
> Thanks Quanlong!
> Did we use the deleted files at all before?

Thank Daniel! I can only see they are added in 
https://github.com/apache/impala/commit/5661bfcc6c037a273584828c6ae91c3b072a284d
I can't find any usage on them.


--
To view, visit http://gerrit.cloudera.org:8080/20403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I93083b999ec404ca3f407977b8e930b85a53b695
Gerrit-Change-Number: 20403
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Mon, 11 Sep 2023 12:57:38 +
Gerrit-HasComments: No


[Impala-ASF-CR](asf-site) IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo

2023-09-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20403 )

Change subject: IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo
..


Patch Set 1: Code-Review+1

Thanks Quanlong!
Did we use the deleted files at all before?


--
To view, visit http://gerrit.cloudera.org:8080/20403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I93083b999ec404ca3f407977b8e930b85a53b695
Gerrit-Change-Number: 20403
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Mon, 11 Sep 2023 12:12:35 +
Gerrit-HasComments: No


[Impala-ASF-CR](asf-site) IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo

2023-08-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/20403


Change subject: IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo
..

IMPALA-12055: (Addendum) Use bootstrap.min.js from local repo

https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/js/bootstrap.min.js
is also slow to download in China and it usually fails at last.

This adds the file to the asf-site branch so the website can use a local
copy of it.

Tests:
 - Verified the pages locally.

Change-Id: I93083b999ec404ca3f407977b8e930b85a53b695
---
M bylaws.html
M community.html
M downloads.html
M impala-docs.html
M index.html
A js/bootstrap-3.3.5.min.js
D js/bootstrap.js
D js/bootstrap.min.js
M overview.html
9 files changed, 13 insertions(+), 2,296 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/20403/1
--
To view, visit http://gerrit.cloudera.org:8080/20403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93083b999ec404ca3f407977b8e930b85a53b695
Gerrit-Change-Number: 20403
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang