[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21410 ) Change subject: IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. .. IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. Independent linux packaging related content to package/CMakeLists.txt to make it more clearly. This patch also add LICENSE and NOTICE file in the final package. Testing: - Manually deploy package on Ubuntu22.04 and verify it. Backport note for 3.4.x: - Resolved conflicts in CMakeLists.txt and modified package/CMakeLists.txt accordingly. Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Reviewed-on: http://gerrit.cloudera.org:8080/20263 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/21410 Reviewed-by: Xiang Yang Reviewed-by: Zihao Ye Tested-by: Quanlong Huang --- M .gitignore M CMakeLists.txt M NOTICE.txt A package/CMakeLists.txt 4 files changed, 136 insertions(+), 101 deletions(-) Approvals: Xiang Yang: Looks good to me, but someone else must approve Zihao Ye: Looks good to me, approved Quanlong Huang: Verified -- To view, visit http://gerrit.cloudera.org:8080/21410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-3.4.2 Gerrit-MessageType: merged Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 21410 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiang Yang Gerrit-Reviewer: Zihao Ye
[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21410 ) Change subject: IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-3.4.2 Gerrit-MessageType: comment Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 21410 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiang Yang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Tue, 21 May 2024 11:11:23 + Gerrit-HasComments: No
[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21410 ) Change subject: IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-3.4.2 Gerrit-MessageType: comment Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 21410 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiang Yang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Tue, 21 May 2024 06:12:45 + Gerrit-HasComments: No
[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files.
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21410 ) Change subject: IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-3.4.2 Gerrit-MessageType: comment Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 21410 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiang Yang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sun, 19 May 2024 04:42:29 + Gerrit-HasComments: No
[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files.
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21410 to review the following change. Change subject: IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. .. IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. Independent linux packaging related content to package/CMakeLists.txt to make it more clearly. This patch also add LICENSE and NOTICE file in the final package. Testing: - Manually deploy package on Ubuntu22.04 and verify it. Backport note for 3.4.x: - Resolved conflicts in CMakeLists.txt and modified package/CMakeLists.txt accordingly. Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Reviewed-on: http://gerrit.cloudera.org:8080/20263 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M .gitignore M CMakeLists.txt M NOTICE.txt A package/CMakeLists.txt 4 files changed, 136 insertions(+), 101 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/21410/1 -- To view, visit http://gerrit.cloudera.org:8080/21410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-3.4.2 Gerrit-MessageType: newchange Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 21410 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Xiang Yang