[Impala-ASF-CR] (WIP) IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13400 )

Change subject: (WIP) IMPALA-8507: Support DROP TABLE statement with Kudu/HMS 
integration
..


Patch Set 1:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/3323/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/13400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d3b93957cc66009ad7a67fc513be2068f156abc
Gerrit-Change-Number: 13400
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 07:18:07 +
Gerrit-HasComments: No


[Impala-ASF-CR] (WIP) IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13400 )

Change subject: (WIP) IMPALA-8507: Support DROP TABLE statement with Kudu/HMS 
integration
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13400/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/13400/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1616
PS1, Line 1616:   tableName.getDb(), tableName.getTbl(), true, 
params.if_exists, params.purge);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/13400/1/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/13400/1/tests/custom_cluster/test_kudu.py@169
PS1, Line 169:
flake8: W391 blank line at end of file



--
To view, visit http://gerrit.cloudera.org:8080/13400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d3b93957cc66009ad7a67fc513be2068f156abc
Gerrit-Change-Number: 13400
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 06:30:27 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] (WIP) IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-05-21 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13400


Change subject: (WIP) IMPALA-8507: Support DROP TABLE statement with Kudu/HMS 
integration
..

(WIP) IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

This commit supports the actual handling of DROP TABLE DDL for managed
Kudu tables with Kudu's integration with the Hive Metastore. When
Kudu/HMS integration is enabled, after the table is dropped in the
Kudu, relies on Kudu to drop the table in the HMS.

Change-Id: I6d3b93957cc66009ad7a67fc513be2068f156abc
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_kudu.py
2 files changed, 78 insertions(+), 25 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13400/1
--
To view, visit http://gerrit.cloudera.org:8080/13400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d3b93957cc66009ad7a67fc513be2068f156abc
Gerrit-Change-Number: 13400
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao