[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Abandoned Rerun shows very marginal change (only significant improvement is 5% for TPCH-Q13). -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Patch Set 4: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/13214/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 06 Jun 2023 23:50:23 + Gerrit-HasComments: No
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Patch Set 4: (1 comment) Trying a run that should include more of k http://gerrit.cloudera.org:8080/#/c/18131/4/be/src/gutil/CMakeLists.txt File be/src/gutil/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18131/4/be/src/gutil/CMakeLists.txt@80 PS4, Line 80: set_target_properties(gutil PROPERTIES INTERPROCEDURAL_OPTIMIZATION OFF) Trying out this change, which should allow more of the kudu source code to be included in LTO. -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 06 Jun 2023 23:35:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has uploaded a new patch set (#4) to the change originally created by Joe McDonnell. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. [DO-NOT-MERGE] Experimental link time optimization This enables CMake's flag that turns on interprocedural optimization (i.e. link-time optimization). This is purely experimental for the purposes of benchmarking and testing. Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 --- M be/CMakeLists.txt M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/gutil/CMakeLists.txt M be/src/udf/CMakeLists.txt M cmake_modules/kudu_cmake_fns.txt 5 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/18131/4 -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has restored this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Restored -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18131/3/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18131/3/be/CMakeLists.txt@28 PS3, Line 28: SET(CMAKE_INTERPROCEDURAL_OPTIMIZATION ON) > We probably want to be more targeted about this. We don't want to bother fo Trying to be more targeted about it doesn't seem to work. Best case is only enable it for release builds (and have a way to enable it for debug builds if we need to debug an LTO-specific issue). -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 06 Jun 2023 23:09:00 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18131/3/cmake_modules/kudu_cmake_fns.txt File cmake_modules/kudu_cmake_fns.txt: http://gerrit.cloudera.org:8080/#/c/18131/3/cmake_modules/kudu_cmake_fns.txt@23 PS3, Line 23: cmake_minimum_required(VERSION 3.8) This prevents -flto on gutil. We compile gutil headers with both unsigned-char and signed-char, which violate the C++ One Definition Rule across the module. Can also be accomplished by disabling INTERPROCEDURAL_OPTIMIZATION for just the gutil library. -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 06 Jun 2023 23:01:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Abandoned Testing a more targeted change. -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18131/3/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18131/3/be/CMakeLists.txt@28 PS3, Line 28: SET(CMAKE_INTERPROCEDURAL_OPTIMIZATION ON) We probably want to be more targeted about this. We don't want to bother for all the unit tests; probably only care about impalad itself. -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 06 Jun 2023 20:33:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/13213/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 06 Jun 2023 19:15:53 + Gerrit-HasComments: No
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has uploaded a new patch set (#3) to the change originally created by Joe McDonnell. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. [DO-NOT-MERGE] Experimental link time optimization This enables CMake's flag that turns on interprocedural optimization (i.e. link-time optimization). This is purely experimental for the purposes of benchmarking and testing. Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 --- M be/CMakeLists.txt M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/udf/CMakeLists.txt M cmake_modules/kudu_cmake_fns.txt 4 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/18131/3 -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Michael Smith has restored this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Restored -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Patch Set 2: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/9985/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 07 Jan 2022 18:43:15 + Gerrit-HasComments: No
[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18131 to look at the new patch set (#2). Change subject: [DO-NOT-MERGE] Experimental link time optimization .. [DO-NOT-MERGE] Experimental link time optimization This enables CMake's flag that turns on interprocedural optimization (i.e. link-time optimization). This is purely experimental for the purposes of benchmarking and testing. Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 --- M CMakeLists.txt M be/CMakeLists.txt M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/exec/CMakeLists.txt M be/src/exec/parquet/CMakeLists.txt M be/src/testutil/CMakeLists.txt M be/src/udf/CMakeLists.txt M cmake_modules/kudu_cmake_fns.txt M common/fbs/CMakeLists.txt M common/function-registry/CMakeLists.txt M common/protobuf/CMakeLists.txt M common/thrift/CMakeLists.txt 12 files changed, 16 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/18131/2 -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins
