[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..

[DOCS] Event based HMS sync works for Metadata V1 and V2

- Move the Metadata V2 note so that it does not apply to event based
sync.

Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Reviewed-on: http://gerrit.cloudera.org:8080/12745
Tested-by: Impala Public Jenkins 
Reviewed-by: Vihang Karajgaonkar 
Reviewed-by: Bharath Vissapragada 
---
M docs/topics/impala_metadata.xml
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Vihang Karajgaonkar: Looks good to me, but someone else must approve
  Bharath Vissapragada: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12745/3/docs/topics/impala_metadata.xml
File docs/topics/impala_metadata.xml:

http://gerrit.cloudera.org:8080/#/c/12745/3/docs/topics/impala_metadata.xml@38
PS3, Line 38: improve overall performance and scalability.
> May be Bharath can confirm this but I think the other two features on this
They are not V2 specific. pull_incremental_statistics and memory based  
invalidation on the catalog server should work in v1 too.



--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 14 Mar 2019 20:14:43 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..


Patch Set 3: Code-Review+1

> (1 comment)

Followed up with Alex offline. Looks like the features don't need v2 as a 
requirement. So the change looks good to me.


--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 14 Mar 2019 18:41:52 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12745/3/docs/topics/impala_metadata.xml
File docs/topics/impala_metadata.xml:

http://gerrit.cloudera.org:8080/#/c/12745/3/docs/topics/impala_metadata.xml@38
PS3, Line 38: improve overall performance and scalability.
May be Bharath can confirm this but I think the other two features on this page 
(auto_invalidate_metadata and pull_incremental_statistics) need metadata v2 
enabled. But the event based polling feature doesn't need metadata v2.

So we want to keep the line " you need to turn on metadata v2 in your 
cluster" at-least for the two features while for event processing doesn't need 
to say it explicitly. Thoughts?



--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 14 Mar 2019 17:51:39 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..


Patch Set 3: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/276/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 14 Mar 2019 02:34:57 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-13 Thread Alex Rodoni (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Todd Lipcon, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12745

to look at the new patch set (#3).

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..

[DOCS] Event based HMS sync works for Metadata V1 and V2

- Move the Metadata V2 note so that it does not apply to event based
sync.

Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
---
M docs/topics/impala_metadata.xml
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/12745/3
--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/276/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 14 Mar 2019 02:32:06 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..


Patch Set 2: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/274/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 14 Mar 2019 02:07:34 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/274/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 14 Mar 2019 02:02:06 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-13 Thread Alex Rodoni (Code Review)
Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12745

to look at the new patch set (#2).

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..

[DOCS] Event based HMS sync works for Metadata V1 and V2

- Move the Metadata V2 note so that it does not apply to event based
sync.

Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
---
M docs/topics/impala_metadata.xml
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/12745/2
--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..


Patch Set 1: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/273/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 13 Mar 2019 21:56:33 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12745 )

Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/273/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 13 Mar 2019 21:34:53 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12745


Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2
..

[DOCS] Event based HMS sync works for Metadata V1 and V2

- Move the Metadata V2 note so that it does not apply to event based
sync.

Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
---
M docs/topics/impala_metadata.xml
1 file changed, 8 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/12745/1
--
To view, visit http://gerrit.cloudera.org:8080/12745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I366add1016d8dad876f100a0b27ba3051e2cafbb
Gerrit-Change-Number: 12745
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni