[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13273 )

Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..

[DOCS] Fixed more typos for SHOW SQL statements

Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Reviewed-on: http://gerrit.cloudera.org:8080/13273
Reviewed-by: Fredy Wijaya 
Tested-by: Impala Public Jenkins 
---
M docs/topics/impala_show.xml
1 file changed, 6 insertions(+), 12 deletions(-)

Approvals:
  Fredy Wijaya: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13273 )

Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..


Patch Set 2: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/322/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 09 May 2019 19:18:31 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13273 )

Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 09 May 2019 18:49:34 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13273 )

Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/322/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 09 May 2019 18:47:22 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13273 )

Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13273/1/docs/topics/impala_show.xml
File docs/topics/impala_show.xml:

http://gerrit.cloudera.org:8080/#/c/13273/1/docs/topics/impala_show.xml@429
PS1, Line 429: SHOW GRANT ROLE Statement
> Sorry, I may actually make a mistake here, but this doc is also confusing.
Done


http://gerrit.cloudera.org:8080/#/c/13273/1/docs/topics/impala_show.xml@442
PS1, Line 442: SHOW GRANT ROLE
> fix this to "SHOW ROLE GRANT GROUP"
Done



--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 09 May 2019 18:47:30 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-09 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13273

to look at the new patch set (#2).

Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..

[DOCS] Fixed more typos for SHOW SQL statements

Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
---
M docs/topics/impala_show.xml
1 file changed, 6 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/13273/2
--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13273 )

Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13273/1/docs/topics/impala_show.xml
File docs/topics/impala_show.xml:

http://gerrit.cloudera.org:8080/#/c/13273/1/docs/topics/impala_show.xml@429
PS1, Line 429: SHOW GRANT ROLE Statement
Sorry, I may actually make a mistake here, but this doc is also confusing. It 
looks like "SHOW GRANT ROLE" has already been documented in L467. I think this 
statement was meant to be "SHOW ROLE GRANT GROUP". Without "GROUP" I thought it 
was a typo :)


http://gerrit.cloudera.org:8080/#/c/13273/1/docs/topics/impala_show.xml@442
PS1, Line 442: SHOW GRANT ROLE
fix this to "SHOW ROLE GRANT GROUP"



--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 08 May 2019 21:35:44 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13273 )

Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..


Patch Set 1: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/319/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 07 May 2019 20:31:33 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13273 )

Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/319/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 07 May 2019 20:25:47 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] Fixed more typos for SHOW SQL statements

2019-05-07 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13273


Change subject: [DOCS] Fixed more typos for SHOW SQL statements
..

[DOCS] Fixed more typos for SHOW SQL statements

Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
---
M docs/topics/impala_show.xml
1 file changed, 2 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/13273/1
--
To view, visit http://gerrit.cloudera.org:8080/13273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2a903e229ba1875fdc23feab33ee69e9cd0142d
Gerrit-Change-Number: 13273
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni