[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17295 ) Change subject: [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early .. [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early This change set addresses the weakness in population min/max filters in the hash join builder by periodically measuring the usefulness of each such filter and set the AlwaysTrue flag to true. For each insert into a not useful filter, this reduces the amount of work from at least two comparisons and two conditional assignments to one Boolean test. Change-Id: I193646e7acfdd3023f7c947d8107da58a1f41183 --- M be/src/exec/filter-context.cc M be/src/exec/filter-context.h M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h M be/src/util/min-max-filter-ir.cc M be/src/util/min-max-filter.cc 6 files changed, 60 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/17295/3 -- To view, visit http://gerrit.cloudera.org:8080/17295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I193646e7acfdd3023f7c947d8107da58a1f41183 Gerrit-Change-Number: 17295 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 ) Change subject: [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8527/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I193646e7acfdd3023f7c947d8107da58a1f41183 Gerrit-Change-Number: 17295 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 09 Apr 2021 03:53:38 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17295 Change subject: [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early .. [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early Change-Id: I193646e7acfdd3023f7c947d8107da58a1f41183 --- M be/src/exec/filter-context.cc M be/src/exec/filter-context.h M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h 4 files changed, 71 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/17295/1 -- To view, visit http://gerrit.cloudera.org:8080/17295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I193646e7acfdd3023f7c947d8107da58a1f41183 Gerrit-Change-Number: 17295 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen
