[Impala-ASF-CR] Add --impalad args to single node perf run.py
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14923 ) Change subject: Add --impalad_args to single_node_perf_run.py .. Add --impalad_args to single_node_perf_run.py This is useful for benchmarking non-standard configurations, e.g. with mt_dop enabled. Testing: Ran the script, confirmed manually that the arguments took effect. single_node_perf_run.py \ --impalad_args=--default_query_options=mt_dop=4 \ --impalad_args=--unlock_mt_dop=true Change-Id: Ib903f0eabb06a7e8981c874c8fe1cec0936b1a64 Reviewed-on: http://gerrit.cloudera.org:8080/14923 Tested-by: Impala Public Jenkins Reviewed-by: Jim Apple --- M bin/single_node_perf_run.py 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Verified Jim Apple: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib903f0eabb06a7e8981c874c8fe1cec0936b1a64 Gerrit-Change-Number: 14923 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Add --impalad args to single node perf run.py
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/14923 ) Change subject: Add --impalad_args to single_node_perf_run.py .. Patch Set 1: Code-Review+2 (1 comment) Fine as-is, but one question you might want to clarify in the help text. http://gerrit.cloudera.org:8080/#/c/14923/1/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/14923/1/bin/single_node_perf_run.py@286 PS1, Line 286: help="Additional arguments to pass to each Impalad during startup") Does it only work like --impalad_args=--foo --impalad_args=--bar or will the following also work: --impalad_args="--foo --bar" -- To view, visit http://gerrit.cloudera.org:8080/14923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib903f0eabb06a7e8981c874c8fe1cec0936b1a64 Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Thu, 19 Dec 2019 03:42:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Add --impalad args to single node perf run.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14923 ) Change subject: Add --impalad_args to single_node_perf_run.py .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib903f0eabb06a7e8981c874c8fe1cec0936b1a64 Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Wed, 18 Dec 2019 22:51:42 + Gerrit-HasComments: No
[Impala-ASF-CR] Add --impalad args to single node perf run.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14923 ) Change subject: Add --impalad_args to single_node_perf_run.py .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5357/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib903f0eabb06a7e8981c874c8fe1cec0936b1a64 Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Wed, 18 Dec 2019 18:21:59 + Gerrit-HasComments: No
[Impala-ASF-CR] Add --impalad args to single node perf run.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14923 ) Change subject: Add --impalad_args to single_node_perf_run.py .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5307/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib903f0eabb06a7e8981c874c8fe1cec0936b1a64 Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Wed, 18 Dec 2019 17:34:26 + Gerrit-HasComments: No
[Impala-ASF-CR] Add --impalad args to single node perf run.py
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14923 Change subject: Add --impalad_args to single_node_perf_run.py .. Add --impalad_args to single_node_perf_run.py This is useful for benchmarking non-standard configurations, e.g. with mt_dop enabled. Testing: Ran the script, confirmed manually that the arguments took effect. single_node_perf_run.py \ --impalad_args=--default_query_options=mt_dop=4 \ --impalad_args=--unlock_mt_dop=true Change-Id: Ib903f0eabb06a7e8981c874c8fe1cec0936b1a64 --- M bin/single_node_perf_run.py 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/14923/1 -- To view, visit http://gerrit.cloudera.org:8080/14923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib903f0eabb06a7e8981c874c8fe1cec0936b1a64 Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
