[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Add a README for data-loading file format, remove LOAD_LOCAL The LOAD_LOCAL support appears to be unused, so removed it for cleanlines. Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Reviewed-on: http://gerrit.cloudera.org:8080/13370 Tested-by: Impala Public Jenkins Reviewed-by: Todd Lipcon --- M testdata/bin/generate-schema-statements.py M testdata/datasets/README 2 files changed, 54 insertions(+), 22 deletions(-) Approvals: Impala Public Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 3: Code-Review+2 Forwarding +2 -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 21 May 2019 16:44:05 + Gerrit-HasComments: No
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 21 May 2019 00:13:15 + Gerrit-HasComments: No
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3295/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 20 May 2019 19:29:51 + Gerrit-HasComments: No
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13370/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13370/1/testdata/bin/generate-schema-statements.py@632 PS1, Line 632: > flake8: E502 the backslash is redundant between brackets Done -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 20 May 2019 18:44:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13370 to look at the new patch set (#2). Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Add a README for data-loading file format, remove LOAD_LOCAL The LOAD_LOCAL support appears to be unused, so removed it for cleanlines. Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb --- M testdata/bin/generate-schema-statements.py M testdata/datasets/README 2 files changed, 54 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/13370/2 -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4280/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 20 May 2019 18:44:26 + Gerrit-HasComments: No
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3282/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sat, 18 May 2019 00:50:25 + Gerrit-HasComments: No
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 1: Code-Review+2 Thanks for cleaning this up. -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sat, 18 May 2019 00:20:12 + Gerrit-HasComments: No
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Hello Joe McDonnell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13370 to review the following change. Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Add a README for data-loading file format, remove LOAD_LOCAL The LOAD_LOCAL support appears to be unused, so removed it for cleanlines. Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb --- M testdata/bin/generate-schema-statements.py M testdata/datasets/README 2 files changed, 54 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/13370/1 -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13370/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13370/1/testdata/bin/generate-schema-statements.py@632 PS1, Line 632: \ flake8: E502 the backslash is redundant between brackets -- To view, visit http://gerrit.cloudera.org:8080/13370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7938d293e144c95ad3752ebc0238ee0e8cf11eb Gerrit-Change-Number: 13370 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sat, 18 May 2019 00:00:40 + Gerrit-HasComments: Yes
