[Impala-ASF-CR] Add logging when query unregisters

2020-08-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16285 )

Change subject: Add logging when query unregisters
..

Add logging when query unregisters

This adds a log line which is printed when a query is successfully
unregistered by the async unregister thread pool. Added only for
additional observability.

Change-Id: I09be63afbee6b338a952a9b12321e028be9d7cb0
Reviewed-on: http://gerrit.cloudera.org:8080/16285
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M be/src/service/impala-server.cc
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/16285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I09be63afbee6b338a952a9b12321e028be9d7cb0
Gerrit-Change-Number: 16285
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] Add logging when query unregisters

2020-08-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16285 )

Change subject: Add logging when query unregisters
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09be63afbee6b338a952a9b12321e028be9d7cb0
Gerrit-Change-Number: 16285
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 05 Aug 2020 06:13:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] Add logging when query unregisters

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16285 )

Change subject: Add logging when query unregisters
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6228/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09be63afbee6b338a952a9b12321e028be9d7cb0
Gerrit-Change-Number: 16285
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 05 Aug 2020 01:03:23 +
Gerrit-HasComments: No


[Impala-ASF-CR] Add logging when query unregisters

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16285 )

Change subject: Add logging when query unregisters
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09be63afbee6b338a952a9b12321e028be9d7cb0
Gerrit-Change-Number: 16285
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 05 Aug 2020 01:03:22 +
Gerrit-HasComments: No


[Impala-ASF-CR] Add logging when query unregisters

2020-08-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16285 )

Change subject: Add logging when query unregisters
..


Patch Set 2: Code-Review+2

Carrying forward Tim's +2


--
To view, visit http://gerrit.cloudera.org:8080/16285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09be63afbee6b338a952a9b12321e028be9d7cb0
Gerrit-Change-Number: 16285
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 05 Aug 2020 01:02:17 +
Gerrit-HasComments: No


[Impala-ASF-CR] Add logging when query unregisters

2020-08-04 Thread Bikramjeet Vig (Code Review)
Hello Sahil Takiar, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16285

to look at the new patch set (#2).

Change subject: Add logging when query unregisters
..

Add logging when query unregisters

This adds a log line which is printed when a query is successfully
unregistered by the async unregister thread pool. Added only for
additional observability.

Change-Id: I09be63afbee6b338a952a9b12321e028be9d7cb0
---
M be/src/service/impala-server.cc
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/16285/2
--
To view, visit http://gerrit.cloudera.org:8080/16285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09be63afbee6b338a952a9b12321e028be9d7cb0
Gerrit-Change-Number: 16285
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong