[Impala-ASF-CR] Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

2019-05-17 Thread Tim Armstrong (Code Review) 
Tim Armstrong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13355 )

Change subject: Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3
..

Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

Fixes in the new CMake version include:
- improved rule generation for ninja
- forbidding the use of select() during CMake runs, which caused hangs
  in the past.

Private builds have passed in the following configurations:
- on Ubuntu 14.04 using ninja
- on CentOS 7.4 and CnetOS 6.4 using GNU make
- in a Docker container (using docker/test-with-docker.py) using
  GNU make on Ubuntu 16.04 and Ubuntu 18.04

Change-Id: I251f1cd5e0f02abf5275f2f5aa37fac32532315e
Reviewed-on: http://gerrit.cloudera.org:8080/13355
Reviewed-by: Tim Armstrong 
Reviewed-by: Todd Lipcon 
Tested-by: Impala Public Jenkins 
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Todd Lipcon: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/13355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I251f1cd5e0f02abf5275f2f5aa37fac32532315e
Gerrit-Change-Number: 13355
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Todd Lipcon

[Impala-ASF-CR] Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

2019-05-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13355 )

Change subject: Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I251f1cd5e0f02abf5275f2f5aa37fac32532315e
Gerrit-Change-Number: 13355
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 17 May 2019 10:12:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

2019-05-16 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13355 )

Change subject: Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4274/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I251f1cd5e0f02abf5275f2f5aa37fac32532315e
Gerrit-Change-Number: 13355
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 17 May 2019 04:46:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

2019-05-16 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13355 )

Change subject: Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I251f1cd5e0f02abf5275f2f5aa37fac32532315e
Gerrit-Change-Number: 13355
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 17 May 2019 03:36:01 +
Gerrit-HasComments: No

[Impala-ASF-CR] Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

2019-05-16 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13355 )

Change subject: Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3256/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I251f1cd5e0f02abf5275f2f5aa37fac32532315e
Gerrit-Change-Number: 13355
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 16 May 2019 21:42:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

2019-05-16 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13355 )

Change subject: Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I251f1cd5e0f02abf5275f2f5aa37fac32532315e
Gerrit-Change-Number: 13355
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 16 May 2019 20:59:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

2019-05-16 Thread Laszlo Gaal (Code Review) 
Hello Todd Lipcon, Tim Armstrong, Joe McDonnell,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/13355

to review the following change.


Change subject: Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3
..

Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

Fixes in the new CMake version include:
- improved rule generation for ninja
- forbidding the use of select() during CMake runs, which caused hangs
  in the past.

Private builds have passed in the following configurations:
- on Ubuntu 14.04 using ninja
- on CentOS 7.4 and CnetOS 6.4 using GNU make
- in a Docker container (using docker/test-with-docker.py) using
  GNU make on Ubuntu 16.04 and Ubuntu 18.04

Change-Id: I251f1cd5e0f02abf5275f2f5aa37fac32532315e
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/13355/1
--
To view, visit http://gerrit.cloudera.org:8080/13355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I251f1cd5e0f02abf5275f2f5aa37fac32532315e
Gerrit-Change-Number: 13355
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Todd Lipcon