[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 May 2019 07:25:00 +
Gerrit-HasComments: No


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..

Exclude kafka dependency from ranger-plugins-audit

This patch excludes kafka dependency from ranger-plugins-audit to avoid
jax-rs version conflict due to kafka transitively pulling pulling an
incompatible version of jax-rs dependency used in Impala. See
RANGER-2426.

I was able to find an issue by manually modifying the CLASSPATH to force
jax-rs 2.1 (from Kafka) to be loaded first and saw a
java.lang.NoClassDefFoundError: javax/ws/rs/core/Link$Builder.

Testing:
- After removing kafka dependency, I did not see any jersey-server 2.27
  in the CLASSPATH and was able to start Impala with Ranger without any
  error.

Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Reviewed-on: http://gerrit.cloudera.org:8080/13322
Reviewed-by: Fredy Wijaya 
Tested-by: Impala Public Jenkins 
---
M fe/pom.xml
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Fredy Wijaya: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3210/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 May 2019 02:47:01 +
Gerrit-HasComments: No


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4247/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 May 2019 00:51:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..


Patch Set 2: Code-Review+2

Rebased and carry Todd's +2.


--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 14 May 2019 00:50:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..

Exclude kafka dependency from ranger-plugins-audit

This patch excludes kafka dependency from ranger-plugins-audit to avoid
jax-rs version conflict due to kafka transitively pulling pulling an
incompatible version of jax-rs dependency used in Impala. See
RANGER-2426.

I was able to find an issue by manually modifying the CLASSPATH to force
jax-rs 2.1 (from Kafka) to be loaded first and saw a
java.lang.NoClassDefFoundError: javax/ws/rs/core/Link$Builder.

Testing:
- After removing kafka dependency, I did not see any jersey-server 2.27
  in the CLASSPATH and was able to start Impala with Ranger without any
  error.

Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
---
M fe/pom.xml
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13322/2
--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..


Patch Set 1:

Merged that one, guess we can rebase this one and run GVM


--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 13 May 2019 22:46:10 +
Gerrit-HasComments: No


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3204/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 13 May 2019 22:41:41 +
Gerrit-HasComments: No


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 13 May 2019 22:13:57 +
Gerrit-HasComments: No


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13322 )

Change subject: Exclude kafka dependency from ranger-plugins-audit
..


Patch Set 1:

Will run a GVO until this is merged: https://gerrit.cloudera.org/c/13276. Looks 
like there'll be a merge conflict.


--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 13 May 2019 22:18:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13322


Change subject: Exclude kafka dependency from ranger-plugins-audit
..

Exclude kafka dependency from ranger-plugins-audit

This patch excludes kafka dependency from ranger-plugins-audit to avoid
jax-rs version conflict due to kafka transitively pulling pulling an
incompatible version of jax-rs dependency used in Impala. See
RANGER-2426.

I was able to find an issue by manually modifying the CLASSPATH to force
jax-rs 2.1 (from Kafka) to be loaded first and saw a
java.lang.NoClassDefFoundError: javax/ws/rs/core/Link$Builder.

Testing:
- After removing kafka dependency, I did not see any jersey-server 2.27
  in the CLASSPATH and was able to start Impala with Ranger without any
  error.

Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
---
M fe/pom.xml
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13322/1
--
To view, visit http://gerrit.cloudera.org:8080/13322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a01f34d078c50bc22fc67a67415a1e6e9c87151
Gerrit-Change-Number: 13322
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya