[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Fix the stale comment on ImpalaServer::RegisterQuery header Prior to this change, the comment from ImpalaServer::RegisterQuery asserts: "Registers the query exec state with client_request_state_map_ using the globally unique query_id and add the query id to session state's open query list." This comment is partially inaccurate about the current designs of this function since it does not add the query_id to the session state's open query list. Change-Id: If743e718f7322929acb710b36f85978dfbe981bf Reviewed-on: http://gerrit.cloudera.org:8080/13001 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/service/impala-server.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If743e718f7322929acb710b36f85978dfbe981bf Gerrit-Change-Number: 13001 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If743e718f7322929acb710b36f85978dfbe981bf Gerrit-Change-Number: 13001 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 13 Apr 2019 02:30:43 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If743e718f7322929acb710b36f85978dfbe981bf Gerrit-Change-Number: 13001 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 12 Apr 2019 21:23:34 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4015/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If743e718f7322929acb710b36f85978dfbe981bf Gerrit-Change-Number: 13001 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 12 Apr 2019 21:23:49 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13001 ) Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2756/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If743e718f7322929acb710b36f85978dfbe981bf Gerrit-Change-Number: 13001 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Apr 2019 18:14:15 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix the stale comment on ImpalaServer::RegisterQuery header
Vincent Tran has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13001 Change subject: Fix the stale comment on ImpalaServer::RegisterQuery header .. Fix the stale comment on ImpalaServer::RegisterQuery header Prior to this change, the comment from ImpalaServer::RegisterQuery asserts: "Registers the query exec state with client_request_state_map_ using the globally unique query_id and add the query id to session state's open query list." This comment is partially inaccurate about the current designs of this function since it does not add the query_id to the session state's open query list. Change-Id: If743e718f7322929acb710b36f85978dfbe981bf --- M be/src/service/impala-server.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/13001/2 -- To view, visit http://gerrit.cloudera.org:8080/13001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If743e718f7322929acb710b36f85978dfbe981bf Gerrit-Change-Number: 13001 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran
