[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-03 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/12900 )

Change subject: Give each config change in bootstrap_system.sh its own line
..

Give each config change in bootstrap_system.sh its own line

If a config file like ~/.ssh/config does not end in a newline
character, than the change to that file in bootstrap_system.sh would
get appended to the last line, causeing parsing of that line to fail.

Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Reviewed-on: http://gerrit.cloudera.org:8080/12900
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M bin/bootstrap_system.sh
1 file changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 6
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-03 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12900 )

Change subject: Give each config change in bootstrap_system.sh its own line
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 5
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Wed, 03 Apr 2019 06:22:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12900 )

Change subject: Give each config change in bootstrap_system.sh its own line
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3973/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 5
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Wed, 03 Apr 2019 01:39:54 +
Gerrit-HasComments: No

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12900 )

Change subject: Give each config change in bootstrap_system.sh its own line
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 5
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Wed, 03 Apr 2019 01:39:53 +
Gerrit-HasComments: No

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12900 )

Change subject: Give each config change in bootstrap_system.sh its own line
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Tue, 02 Apr 2019 18:50:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-01 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12900 )

Change subject: Give each config change in bootstrap_system.sh its own line
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/2608/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Tue, 02 Apr 2019 03:13:17 +
Gerrit-HasComments: No

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-01 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12900 )

Change subject: Give each config change in bootstrap_system.sh its own line
..


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12900/4/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/12900/4/bin/bootstrap_system.sh@303
PS4, Line 303: { echo "" | cat - ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys; } 
&& chmod 0600 ~/.ssh/authorized_keys
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/12900/4/bin/bootstrap_system.sh@304
PS4, Line 304: echo -e "\nNoHostAuthenticationForLocalhost yes" >> 
~/.ssh/config && chmod 0600 ~/.ssh/config
line too long (93 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Tue, 02 Apr 2019 02:28:30 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-01 Thread Jim Apple (Code Review) 
Hello Lars Volker, Joe McDonnell, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12900

to look at the new patch set (#4).

Change subject: Give each config change in bootstrap_system.sh its own line
..

Give each config change in bootstrap_system.sh its own line

If a config file like ~/.ssh/config does not end in a newline
character, than the change to that file in bootstrap_system.sh would
get appended to the last line, causeing parsing of that line to fail.

Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
---
M bin/bootstrap_system.sh
1 file changed, 8 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/4
--
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-01 Thread Jim Apple (Code Review) 
Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12900 )

Change subject: Give each config change in bootstrap_system.sh its own line
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh@303
PS3, Line 303: cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys && chmod 0600 
~/.ssh/authorized_keys
> Is this file affected by the same issue?
Good point. Updated here and elsewhere.



--
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Tue, 02 Apr 2019 02:28:16 +
Gerrit-HasComments: Yes