[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. IMPALA-10197: Add KUDU_REPLICA_SELECTION query option Sometimes it is useful to target queries at the leader only replica instead of the default closest replica. This patch added new query option KUDU_REPLICA_SELECTION with which to choose replicas for Kudu amongst multiple Kudu replicas. Removed variable FLAGS_pick_only_leaders_for_tests since its usage can be replaced by the new query option. Added new planner and end-to-end tests for the new query option. Testings: - Passed exhaustive tests. Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Reviewed-on: http://gerrit.cloudera.org:8080/17396 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exec/kudu-scanner.cc M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M be/src/util/debug-util.cc M be/src/util/debug-util.h M common/thrift/ImpalaService.thrift M common/thrift/Query.thrift M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-closest-replica.test A testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test M tests/query_test/test_kudu.py 13 files changed, 368 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 24 May 2021 11:38:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 24 May 2021 05:30:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7169/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 24 May 2021 05:30:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 3: Code-Review+2 LGTM, this is a useful query option! -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 24 May 2021 05:29:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 23 May 2021 17:00:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8759/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 20 May 2021 15:19:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. IMPALA-10197: Add KUDU_REPLICA_SELECTION query option Sometimes it is useful to target queries at the leader only replica instead of the default closest replica. This patch added new query option KUDU_REPLICA_SELECTION with which to choose replicas for Kudu amongst multiple Kudu replicas. Removed variable FLAGS_pick_only_leaders_for_tests since its usage can be replaced by the new query option. Added new planner and end-to-end tests for the new query option. Testings: - Passed exhaustive tests. Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 --- M be/src/exec/kudu-scanner.cc M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M be/src/util/debug-util.cc M be/src/util/debug-util.h M common/thrift/ImpalaService.thrift M common/thrift/Query.thrift M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-closest-replica.test A testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test M tests/query_test/test_kudu.py 13 files changed, 368 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/17396/3 -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17396/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test: http://gerrit.cloudera.org:8080/#/c/17396/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test@9 PS2, Line 9: 00:SCAN KUDU [functional_kudu.zipcode_incomes, LEADER-only] : kudu predicates: id = '860US00601' : mem-estimate=3.75MB mem-reservation=0B thread-reservation=1 : tuple-ids=0 row-size=124B cardinality=1 : in pipelines: 00(GETNEXT) > Maybe we just annotate the kudu scan for LEADER-only, something like the fo Fixed as suggested. -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 20 May 2021 14:57:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 2: (2 comments) Thanks Wenzhe for the reply. http://gerrit.cloudera.org:8080/#/c/17396/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: http://gerrit.cloudera.org:8080/#/c/17396/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@237 PS2, Line 237: if (leadOnly && !replica.getRole().equals(Role.LEADER.toString())) continue; > The code tablet.getReplicas() and replica.getRole() are calling Kudu client Done http://gerrit.cloudera.org:8080/#/c/17396/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test: http://gerrit.cloudera.org:8080/#/c/17396/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test@9 PS2, Line 9: 00:SCAN KUDU [functional_kudu.zipcode_incomes] : kudu predicates: id = '860US00601' : mem-estimate=3.75MB mem-reservation=0B thread-reservation=1 : tuple-ids=0 row-size=124B cardinality=1 : in pipelines: 00(GETNEXT) > The role of Kudu replica is not shown in the explain output. The difference Maybe we just annotate the kudu scan for LEADER-only, something like the following? 00:SCAN KUDU [functional_kudu.zipcode_incomes, LEADER-only] kudu predicates: id = '860US00601' mem-estimate=3.75MB mem-reservation=0B thread-reservation=1 tuple-ids=0 row-size=124B cardinality=1 in pipelines: 00(GETNEXT) Knowing the scan target is very useful info for performance tuning. For one thing, restricting to LEADER(s) may cause contention in a heavy concurrency situation. -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 19 May 2021 18:22:00 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 2: (2 comments) Thanks Qifan for your comments. http://gerrit.cloudera.org:8080/#/c/17396/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: http://gerrit.cloudera.org:8080/#/c/17396/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@237 PS2, Line 237: if (leadOnly && !replica.getRole().equals(Role.LEADER.toString())) continue; > nit. If there is only one leader, maybe we can break after the only leader The code tablet.getReplicas() and replica.getRole() are calling Kudu client APIs. Kudu don't provide API to get number of leader for the tablet so we don't know the number of leader until the loop ending. http://gerrit.cloudera.org:8080/#/c/17396/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test: http://gerrit.cloudera.org:8080/#/c/17396/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test@9 PS2, Line 9: 00:SCAN KUDU [functional_kudu.zipcode_incomes] : kudu predicates: id = '860US00601' : mem-estimate=3.75MB mem-reservation=0B thread-reservation=1 : tuple-ids=0 row-size=124B cardinality=1 : in pipelines: 00(GETNEXT) > nit. Just wonder if leader only scan or replica scan can be observed in the The role of Kudu replica is not shown in the explain output. The difference with or without setting the query option is the number of hosts and instances. Add new field in the explain output will affect too many test cases. -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 19 May 2021 17:40:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 2: (2 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/17396/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: http://gerrit.cloudera.org:8080/#/c/17396/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@237 PS2, Line 237: if (leadOnly && !replica.getRole().equals(Role.LEADER.toString())) continue; nit. If there is only one leader, maybe we can break after the only leader is processed. http://gerrit.cloudera.org:8080/#/c/17396/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test: http://gerrit.cloudera.org:8080/#/c/17396/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test@9 PS2, Line 9: 00:SCAN KUDU [functional_kudu.zipcode_incomes] : kudu predicates: id = '860US00601' : mem-estimate=3.75MB mem-reservation=0B thread-reservation=1 : tuple-ids=0 row-size=124B cardinality=1 : in pipelines: 00(GETNEXT) nit. Just wonder if leader only scan or replica scan can be observed in the explain output. -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Wed, 19 May 2021 15:22:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8753/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 19 May 2021 06:49:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. IMPALA-10197: Add KUDU_REPLICA_SELECTION query option Sometimes it is useful to target queries at the leader only replica instead of the default closest replica. This patch added new query option KUDU_REPLICA_SELECTION with which to choose replicas for Kudu amongst multiple Kudu replicas. Removed variable FLAGS_pick_only_leaders_for_tests since its usage can be replaced by the new query option. Added new planner and end-to-end tests for the new query option. Testings: - Passed exhaustive tests. Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 --- M be/src/exec/kudu-scanner.cc M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M be/src/util/debug-util.cc M be/src/util/debug-util.h M common/thrift/ImpalaService.thrift M common/thrift/Query.thrift M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-closest-replica.test A testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test M tests/query_test/test_kudu.py 13 files changed, 359 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/17396/2 -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 09 May 2021 23:43:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8683/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 04 May 2021 16:00:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17396 Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. IMPALA-10197: Add KUDU_REPLICA_SELECTION query option Sometimes it is useful to target queries at the leader only replica instead of the default closest replica. This patch added new query option KUDU_REPLICA_SELECTION with which to choose replicas for Kudu amongst multiple Kudu replicas. Removed variable FLAGS_pick_only_leaders_for_tests since its usage can be replaced by the new query option. Added new planner and end-to-end tests for the new query option. Testings: - Passed exhaustive tests. Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 --- M be/src/exec/kudu-scanner.cc M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M be/src/util/debug-util.cc M be/src/util/debug-util.h M common/thrift/ImpalaService.thrift M common/thrift/Query.thrift M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-closest-replica.test A testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-leader-only.test M tests/query_test/test_kudu.py 13 files changed, 359 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/17396/1 -- To view, visit http://gerrit.cloudera.org:8080/17396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I613e6d9be8680c05880f7cf962a31aa38931f3d9 Gerrit-Change-Number: 17396 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Grant Henke
