[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 22 Oct 2020 23:44:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. IMPALA-10216: add logging to help debug flaky test This commit adds additional info to the assertions to help debug it if it reoccurs. Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Reviewed-on: http://gerrit.cloudera.org:8080/16620 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/runtime/bufferpool/buffer-pool-test.cc 1 file changed, 43 insertions(+), 10 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6598/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 22 Oct 2020 18:17:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 22 Oct 2020 18:17:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7509/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Oct 2020 19:27:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. Patch Set 2: Code-Review+2 Looks good to me -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Oct 2020 19:17:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. Patch Set 2: Changes weren't totally trivial, so it would be good if you could take another look. -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Oct 2020 19:07:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16620/1/be/src/runtime/bufferpool/buffer-pool-test.cc File be/src/runtime/bufferpool/buffer-pool-test.cc: http://gerrit.cloudera.org:8080/#/c/16620/1/be/src/runtime/bufferpool/buffer-pool-test.cc@1767 PS1, Line 1767: > For some of these "not in" conditions, would it also be useful to dump the I changed it to dump something like this: be/src/runtime/bufferpool/buffer-pool-test.cc:1819: Failure Value of: FindPageInDir(pages[NEW_QUERY], error_dir) != NULL Actual: true Expected: false /tmp/buffer-pool-test.1/impala-scratch/:_17ceb8eb-fd31-46e3-8894-d2c34280eea9,/tmp/bu ffer-pool-test.0/impala-scratch/:_007406e7-1d2a-470c-95ce-58afb84bcb4c not in Directo ry /tmp/buffer-pool-test.0/impala-scratch: :_007406e7-1d2a-470c-95ce-58afb84bcb4c,000 0:_d1c376f3-30e7-4c5d-933e-4500d368bb0d,:_6c264d45-f808-4 ee6-9f45-74dabbcf6067 -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Oct 2020 19:07:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Hello Quanlong Huang, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16620 to look at the new patch set (#2). Change subject: IMPALA-10216: add logging to help debug flaky test .. IMPALA-10216: add logging to help debug flaky test This commit adds additional info to the assertions to help debug it if it reoccurs. Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 --- M be/src/runtime/bufferpool/buffer-pool-test.cc 1 file changed, 43 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/16620/2 -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. Patch Set 1: Code-Review+2 (1 comment) Always good to add diagnostics to track these things down http://gerrit.cloudera.org:8080/#/c/16620/1/be/src/runtime/bufferpool/buffer-pool-test.cc File be/src/runtime/bufferpool/buffer-pool-test.cc: http://gerrit.cloudera.org:8080/#/c/16620/1/be/src/runtime/bufferpool/buffer-pool-test.cc@1767 PS1, Line 1767: << TmpFilePaths(error_new_pages) << " not in " << good_dir; For some of these "not in" conditions, would it also be useful to dump the contents of the directory? -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 21 Oct 2020 16:47:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16620 ) Change subject: IMPALA-10216: add logging to help debug flaky test .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7505/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 21 Oct 2020 16:41:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10216: add logging to help debug flaky test
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16620 Change subject: IMPALA-10216: add logging to help debug flaky test .. IMPALA-10216: add logging to help debug flaky test This commit adds additional info to the assertions to help debug it if it reoccurs. Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 --- M be/src/runtime/bufferpool/buffer-pool-test.cc 1 file changed, 33 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/16620/1 -- To view, visit http://gerrit.cloudera.org:8080/16620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I09984dd3cea686808115ca4cb8c88d24271d8cc1 Gerrit-Change-Number: 16620 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Quanlong Huang
