[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 30 Oct 2020 05:34:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile This fix improved the skew reporting test by lowering the threshold to 0 and by taking care of the extreme case of no skews. Testing: 1. Unit testing. Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Reviewed-on: http://gerrit.cloudera.org:8080/16662 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/query_test/test_observability.py 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 30 Oct 2020 00:07:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6623/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 30 Oct 2020 00:07:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 30 Oct 2020 00:07:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7580/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 29 Oct 2020 17:42:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Qifan Chen has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile This fix improved the skew reporting test by lowering the threshold to 0 and by taking care of the extreme case of no skews. Testing: 1. Unit testing. Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b --- M tests/query_test/test_observability.py 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/16662/2 -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7566/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 27 Oct 2020 16:59:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16662/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/16662/1/tests/query_test/test_observability.py@753 PS1, Line 753: flake8: E203 whitespace before ':' -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 27 Oct 2020 16:39:33 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16662 Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile This fix improved the skew reporting test by lowering the threshold to 0 and by taking care of the extreme case of no skews. Together, they made the test more robust. Testing: 1. Unit testing. Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b --- M tests/query_test/test_observability.py 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/16662/1 -- To view, visit http://gerrit.cloudera.org:8080/16662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b Gerrit-Change-Number: 16662 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen
