[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 25 Nov 2020 03:14:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default This allows setting mt_dop for any query with any configuration. Before this patch it was not supported for DML. --unlock_mt_dop and --mt_dop_auto_fallback are now ignored. Testing: * Updated tests to reflect new behaviour. * Removed irrelevant tests for fallback/validation. * Ran exhaustive tests. Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Reviewed-on: http://gerrit.cloudera.org:8080/16775 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M bin/run-all-tests.sh M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/common/RuntimeEnv.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test D testdata/workloads/functional-query/queries/QueryTest/mt-dop-auto-fallback.test M tests/custom_cluster/test_mt_dop.py 11 files changed, 69 insertions(+), 132 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6710/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 24 Nov 2020 21:34:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 24 Nov 2020 21:34:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 24 Nov 2020 21:34:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7724/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 24 Nov 2020 17:48:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7726/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 24 Nov 2020 17:48:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7725/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 24 Nov 2020 17:48:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Tim Armstrong has uploaded a new patch set (#1). ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default This allows setting mt_dop for any query with any configuration. Before this patch it was not supported for DML. TODO: * exhaustive tests * precommit tests Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade --- M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M bin/run-all-tests.sh M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/common/RuntimeEnv.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test D testdata/workloads/functional-query/queries/QueryTest/mt-dop-auto-fallback.test M tests/custom_cluster/test_mt_dop.py 11 files changed, 69 insertions(+), 132 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/16775/1 -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16775 to look at the new patch set (#3). Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default This allows setting mt_dop for any query with any configuration. Before this patch it was not supported for DML. --unlock_mt_dop and --mt_dop_auto_fallback are now ignored. Testing: * Updated tests to reflect new behaviour. * Removed irrelevant tests for fallback/validation. * Ran exhaustive tests. Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade --- M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M bin/run-all-tests.sh M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/common/RuntimeEnv.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test D testdata/workloads/functional-query/queries/QueryTest/mt-dop-auto-fallback.test M tests/custom_cluster/test_mt_dop.py 11 files changed, 69 insertions(+), 132 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/16775/3 -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default This allows setting mt_dop for any query with any configuration. Before this patch it was not supported for DML. TODO: * exhaustive tests * precommit tests Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade --- M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M bin/run-all-tests.sh M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/common/RuntimeEnv.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test D testdata/workloads/functional-query/queries/QueryTest/mt-dop-auto-fallback.test M tests/custom_cluster/test_mt_dop.py 11 files changed, 69 insertions(+), 132 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/16775/2 -- To view, visit http://gerrit.cloudera.org:8080/16775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I66331481260fe4b69d9e95b0200029b14d230ade Gerrit-Change-Number: 16775 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
